Commit Graph

19121 Commits

Author SHA1 Message Date
Alex
1be746c1d0
fix: add max length to js run function name (#38363)
## Description
Fixes issue where JS run function name can take up too much space in
toolbar.

Fixes #38150 

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12491948782>
> Commit: c11b60d53e8c89e944abd2457c4d31c74ce74ce6
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12491948782&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Wed, 25 Dec 2024 10:35:52 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a character limit for function names in the `JSFunctionRun`
component, ensuring names are truncated to a maximum of 30 characters
for improved UI consistency.

- **Bug Fixes**
- Added a test case to verify that function names exceeding the
character limit are correctly truncated.

- **Documentation**
	- Updated constants to define the maximum length for function names.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-25 15:17:41 +03:00
shadabbuchh
199233be47
test: new test case for renaming JS Object (#38361)
## Description

This PR adds a test case for the bug:
https://github.com/appsmithorg/appsmith/issues/38207

This PR tests the issue where renaming a JS Object via the context menu
caused the focus to shift to another tab in the editor.

Changes:

- Added test cases to validate that focus remains on the current tab
while renaming JS Objects.
- Verified the functionality by renaming multiple JS Objects and
ensuring the changes are reflected without altering tab focus.


## Automation

/ok-to-test tags="@tag.JS"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12492186342>
> Commit: 5611d13c3a8d6fd26598a463b25e370e381323f5
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12492186342&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JS`
> Spec:
> <hr>Wed, 25 Dec 2024 11:16:53 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a method to rename JavaScript objects via the context menu
in the JSEditor.
	- Added a property for referencing the list of JavaScript objects.

- **Tests**
- Implemented a new test suite to validate the renaming functionality
and ensure focus remains on the correct tab during the process.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-25 16:53:44 +05:30
Alex
0c1a1d8ee4
fix: query tab scrollbar padding gap fix (#38317)
## Description
Remove scrollbar gap in request config.


Fixes [#38135](https://github.com/appsmithorg/appsmith/issues/38135)

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/12491071853>
> Commit: 85399dbbd44aef19ce3da06a8d6f190eed210de5
> Workflow: `PR Automation test suite`
> Tags: `@tag.IDE`
> Spec: ``
> <hr>Wed, 25 Dec 2024 08:14:00 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a tabbed interface in the `CommonEditorForm` for better
content organization.
- Enhanced usability of the `PluginActionForm` with scrollable content
areas.
  
- **Bug Fixes**
- Adjusted tooltip positioning to improve visibility in the
`EmbeddedDatasourcePathField`.

- **Style**
- Added new styled components for tabs and headers to enhance layout and
design.

- **Chores**
- Deprecated the `RequestTabs` component in preparation for its removal.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-25 16:39:07 +05:30
Trisha Anand
f078ec0b32
chore: Minor code refactor for seat based pricing (#38359)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/test sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12490386991>
> Commit: a06c91677563b3b78d50f3a439ebb9b83196d130
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12490386991&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 25 Dec 2024 07:41:48 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced methods for user retrieval and signup conditions, enhancing
user management capabilities.
	- Added functionality to retrieve system-generated user emails.

- **Bug Fixes**
- Improved user lookup process by centralizing logic into dedicated
methods.

- **Documentation**
- Updated method visibility for better accessibility of user-related
functionalities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-25 13:12:45 +05:30
Aman Agarwal
65391ab2e0
fix: calendly link on schedule a call click, jira and slack integration premium tag (#38331) 2024-12-25 11:58:07 +05:30
Nidhi
2dfa24ee91
chore: Added capability of running ITs on maven (#38354) 2024-12-25 02:08:49 +05:30
Manish Kumar
a8cb8aac44
chore: added interface changes to the server (#38258)
## Description
- interface layer changes for Git executor


Fixes #
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12481281011>
> Commit: e510ca6c5f34e5dd201d040d4fc866ca4c0628d8
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12481281011&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Tue, 24 Dec 2024 16:05:39 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced methods for creating and checking out branches and tags in
Git.
- Added functionality for validating reference creation based on
artifact status.
- Enhanced artifact publishing with new methods related to reference
creation.
  - Added a method for checking out artifacts based on provided details.

- **Bug Fixes**
- Improved error handling for Git operations, providing more specific
error messages.

- **Documentation**
- Updated method signatures to reflect new parameters and
functionalities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-25 01:11:47 +05:30
Alex
c0d393a8f7
fix: kebab menu rename jumps to wrong tab (#38346)
## Description
Fixes an issue when renaming from context menu in JS objects, cursor
always jumps to the first tab.

Fixes #38207 

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12480124658>
> Commit: 221119c1487842f0e58340eb3ce2b1ecd740d56d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12480124658&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Tue, 24 Dec 2024 10:31:34 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Improved context menu options with enhanced performance and clarity.
- **Bug Fixes**
- Added checks for the availability of the CodeMirror instance to
prevent errors.
- **Refactor**
- Simplified state management by replacing `useState` with `useBoolean`.
	- Optimized context menu option generation using `useMemo`.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-24 17:53:30 +05:30
Pawan Kumar
ecf9934859
chore: fix wds select widget bugs + refactor (#38304)
Fixes #38197 

/ok-to-test tags="@tag.Anvil"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced styling for select input components, improving visual
consistency.
- Introduced new validation functions for widget properties, ensuring
better data integrity.
- Added properties for improved configuration of select widgets,
including dynamic data binding.
- New utility functions for handling options in select widgets,
enhancing functionality.
- Introduced a constant for sample data to facilitate testing and
development.

- **Bug Fixes**
- Resolved issues with widget rendering and responsiveness to property
changes.

- **Refactor**
- Streamlined widget implementation by leveraging inherited
functionalities and simplifying methods.
- Updated methods to improve handling of derived properties and options.
- Removed obsolete configuration files and validation functions to clean
up the codebase.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12480977859>
> Commit: d669e05ed5b7ce07a54259b7e301eb65341c1b02
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12480977859&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Tue, 24 Dec 2024 11:43:59 UTC
<!-- end of auto-generated comment: Cypress test results  -->
2024-12-24 17:28:57 +05:30
Nidhi
d9a3253e92
chore: Moved git auth creation and updation to generified artifactservice (#38312) 2024-12-24 15:47:25 +05:30
Nidhi
f2733c67e9
test: Git integration tests (#38337) 2024-12-24 15:20:07 +05:30
Alex
52a394f362
fix: prevent menu content to be rendered when there are no options (#38329)
## Description
Fixes an issue where JS run menu is being shown with no items in it.

Fixes #38151 

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12468478974>
> Commit: f032137f9b4d9eeda85dfe1bb8d26e2e19f64c3b
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12468478974&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Mon, 23 Dec 2024 15:12:31 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved dropdown menu rendering logic to prevent displaying an empty
menu when no options are available.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-24 14:19:00 +05:30
Alex
16953b8159
fix: cannot see move to page option when there are exactly two pages in the app (#38328)
## Description
Fixes an issue where move between pages in query context menu was not
possible.

Fixes [#38117](https://github.com/appsmithorg/appsmith/issues/38117)

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12468165994>
> Commit: 1ef7d576fc5d8c9261279cdc77c69c9688826262
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12468165994&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Mon, 23 Dec 2024 14:47:50 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2024-12-24 10:12:00 +03:00
Jacques Ikot
cda656bab3
feat: add alignment property in style pane for table button cell (#38223)
## Description
**Problem**
When a user uses the button column type in a table widget, the button is
automatically aligned to the left, and the style tab of the button
property pane does not allow the user change the vertical or horizontal
alignment of the button column.

**Solution**
We have added the Alignment property to the button column type for the
table widget, and added tests.


Fixes #38032 

## Automation

/ok-to-test tags="@tag.Table, @tag.Widget, @tag.Binding"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12417408061>
> Commit: 07f2eb0795e04e37ed077a850bc9b87166ea549d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12417408061&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Table, @tag.Widget, @tag.Binding`
> Spec:
> <hr>Thu, 19 Dec 2024 18:44:06 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Added a test suite for validating button cell functionality in the
Table Widget V2.
- Introduced a method to generate CSS selectors for specific table
cells.
  
- **Bug Fixes**
- Enhanced visibility controls for alignment properties based on column
types, particularly for button cells.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-24 07:18:56 +01:00
albinAppsmith
7a6358eee1
feat: Updated ads-old table to accept custom row component (#38334)
## Description

This PR adds the support to pass custom row component to ads-old/table.
This change is required for the new changes in admin settings page.

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12476614610>
> Commit: db2b017ffc6bff5baf2f232550c11d2500e9cb1f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12476614610&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 24 Dec 2024 05:57:40 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a customizable row component for the Table, allowing users
to define how rows are rendered.
  
- **Enhancements**
- Improved type safety for row components, enhancing overall component
reliability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-24 11:38:07 +05:30
Hetu Nandu
ddb83c0094
chore: Move smaller Entity Explorer components into ADS (#38321) 2024-12-24 06:00:58 +00:00
subratadeypappu
d3ea54d6a2
chore: Add code-split for injecting JIT pull in app CI/CD (#38270)
## Description
EE counterpart PR: https://github.com/appsmithorg/appsmith-ee/pull/5780


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12471975301>
> Commit: f0a7b1e6c49b647d9530d74f7275b862d2deef5c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12471975301&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 23 Dec 2024 20:06:14 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced a method for validating and publishing artifacts before
discarding changes.
- Added functionality to commit artifacts to a Git repository with
customizable commit messages.
- Expanded interface capabilities with a new method for validating
artifacts.

- **Bug Fixes**
- Enhanced error handling in the discard changes process to improve
resource management during failures.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-24 11:57:21 +06:00
Nidhi
bc38ee739e
chore: Revert "test: Git integration tests (#38237)" (#38333) 2024-12-24 01:50:45 +05:30
Ankita Kinger
5855115abb
chore: Adding no access state for Datasource tab based on permissions given via GAC (#38268)
## Description

- Today, when a user gives only View/Edit access to a Datasource, the
schema tables are still being seen on the Datasource tabs while it
doesn't show on the Datasource Editor page. This has been fixed with
this PR. It should only be seen when Datasource has create action
permissions, hence we show the "We can’t show the schema for this
datasource" screen in this case.
- When the user has not given View access to a Datasource, the UI is
broken in Datasource tab. This has been fixed with this PR. We now show
the No access state in this case.

**BEFORE**:

When view access is not given:
<img width="1147" alt="Screenshot 2024-12-20 at 5 52 58 PM"
src="https://github.com/user-attachments/assets/c1d1fd39-d6d3-4fd8-99bf-895698f61490"
/>

When create action permission is not given but view access is given:
<img width="1138" alt="Screenshot 2024-12-20 at 5 54 10 PM"
src="https://github.com/user-attachments/assets/abf0aa86-e541-4453-b7e4-071d123f7a60"
/>


**AFTER**:

When view access is not given:
<img width="1136" alt="Screenshot 2024-12-20 at 5 58 22 PM"
src="https://github.com/user-attachments/assets/e160250b-963c-457e-81b1-380aef1332a1"
/>


When create action permission is not given but view access is given:
<img width="1139" alt="Screenshot 2024-12-20 at 5 57 53 PM"
src="https://github.com/user-attachments/assets/1967a657-622c-46f7-b6d4-78451b6106f0"
/>


Fixes [#38093](https://github.com/appsmithorg/appsmith/issues/38093)

## Automation

/ok-to-test tags="@tag.Sanity, @tag.Datasource, @tag.IDE, @tag.JS,
@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12452839374>
> Commit: ee5bc1774c02b4b29a702c8baefbad35390708c3
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12452839374&attempt=3"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Datasource, @tag.IDE, @tag.JS, @tag.Git`
> Spec:
> <hr>Mon, 23 Dec 2024 08:29:06 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced new icons and improved conditional rendering for datasource
components.
  - Added a "not found" message for empty datasource options.
  - Enhanced user feedback with clearer messaging for missing resources.

- **Bug Fixes**
- Adjusted rendering logic to ensure edit buttons only appear when both
conditions are met.

- **Enhancements**
- Improved permission checks and logic for managing datasource
visibility.
- Streamlined component logic for better readability and
maintainability.
  - Enhanced error handling practices in saga functions.

- **Tests**
  - Simplified test structure by removing unnecessary context providers.

- **Chores**
  - Updated import statements and component names for consistency.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-23 20:27:36 +05:30
Nidhi
e45cbdfa83
test: Git integration tests (#38237) 2024-12-23 19:49:58 +05:30
Sagar Khalasi
c5238ffd03
test: added new case (#38308)
## Description
Added new test case for the template module.


Fixes [Issue
URL](https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38309)

## Automation

/ok-to-test tags="@tag.Templates"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12463337741>
> Commit: d7d11f85cb88224c18c270e17398f5b1a405b219
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12463337741&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Templates`
> Spec:
> <hr>Mon, 23 Dec 2024 08:19:52 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new test suite for validating template functionality in
the client-side application.
- Added comprehensive test cases to verify data bindings and button
actions within templates.

- **Tests**
- Enhanced the testing framework with checks for data source connections
and user interactions.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-23 18:51:16 +05:30
Sagar Khalasi
2eac19379b
fix: Fix for locator for AddWidgetTableAndBind_spec test case (#38313)
## Description
Found minor locator failure


Fixes #
https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38314

## Automation

/ok-to-test tags="@tag.Datasource,@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12465389478>
> Commit: 9cf2fbe2bbda6abdb9547bbb8f38d578fe343f04
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12465389478&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource,@tag.Sanity`
> Spec:
> <hr>Mon, 23 Dec 2024 13:19:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Updated the locator for the query response to ensure accurate
referencing of the second row in the table, improving the application's
interaction with query results.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-23 18:50:44 +05:30
Sagar Khalasi
4a63176b0c
test: Admin setting test cases (#38172)
## Description
Admin setting cases for CE.


Fixes #
https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38320

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12466577616>
> Commit: fabd248b9631e80676036798cd12587ff031600e
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12466577616&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Settings`
> Spec:
> <hr>Mon, 23 Dec 2024 12:36:13 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced comprehensive end-to-end tests for the Admin Settings page,
covering various user scenarios and settings functionality.
- Added a new property `adminEmailsData` for improved element selection
in tests.

- **Chores**
- Enhanced the readability and maintainability of end-to-end tests for
the Admin Settings page by replacing direct commands with helper
functions.
	- Streamlined element interactions and assertions for improved clarity.
- Expanded test coverage with additional cases for default instance name
and admin setting sections.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-23 18:37:43 +05:30
Rishabh Rathod
8a16903f31
feat: Add currentPage, workspace, application name to appsmith context (#38114)
## Description

Add currentPageName, AppName and workspace name to appsmith context
object

Fixes https://github.com/appsmithorg/appsmith/issues/38046

## Automation

/ok-to-test tags="@tag.JS"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12462985063>
> Commit: eec4292d3bc1db86bdcf089061a6d2c7d8fa2205
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12462985063&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JS`
> Spec:
> <hr>Mon, 23 Dec 2024 09:14:06 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced `AppsmithEntity` interface with new properties:
`currentPageName`, `workspaceName`, and `appName`.
- Updated `getUnevaluatedDataTree` selector to accept additional
parameters, providing more contextual information about the current
application state.
- Introduced a new internal selector to retrieve the current page's
name.

- **Bug Fixes**
- Adjusted expected hint text in autocomplete tests for JavaScript
objects to align with updated behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2024-12-23 16:33:50 +05:30
Rahul Barwal
dcb27d2c87
feat: optimize HTML text extraction in TableWidgetV2 (#38153) 2024-12-23 15:49:46 +05:30
Subhrashis Das
d52490cabb
feat: Standardize log patterns across all services for consistency. (#38285)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12463955629>
> Commit: 1c48cae7a0d980d487a9387aa96e8b5aaaedeadb
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12463955629&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 23 Dec 2024 09:18:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced logging capabilities for various services, including distinct
log file paths incorporating hostnames.
	- Introduced event logging for standard output and error streams.

- **Bug Fixes**
	- Improved error handling through updated logging configurations.

- **Chores**
- Reorganized configuration parameters for better clarity and management
across multiple services.
- Increased maximum log file sizes from 10MB to 30MB and set backups to
zero for all services.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-23 15:15:53 +05:30
Ashit Rath
398f63112a
chore: Changes for introducing disabled states for package pull in application (#38222)
## Description
This PR introduces certain changes to facilitate disabled states when
package pull is in progress.

EE PR -> https://github.com/appsmithorg/appsmith/issues/37841


## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12425304652>
> Commit: 3c3aed7ca67559005f0ac6b6684e89b04c04f9d1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12425304652&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Fri, 20 Dec 2024 04:56:17 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a `GitActionsWrapper` component for wrapping child
elements.
- Added a new function for improved error messaging during package
upgrades.
	- Implemented a selector to check package upgrading status.
- Enhanced the `Header` component to manage deployment state based on
package upgrades.
- Updated the `Disabler` component to visually indicate a disabled
state.

- **Bug Fixes**
	- Improved tooltip functionality for the deploy button when disabled.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-23 14:13:19 +05:30
Rudraprasad Das
e9ac154a57
chore: git mod - connect modal and branches (#38171)
## Description
- Connects connect modal to store
- Adds component for branch list

Fixes #37814
Fixes #37802 

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12376713895>
> Commit: 34d96b492e20118aa5d82bfa10b9f09315b2bc60
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12376713895&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Tue, 17 Dec 2024 16:59:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a `ConnectInitialize` component for Git provider
connections.
	- Added `ConnectSuccess` modal to display successful Git connections.
	- Implemented `ImportModal` for Git import functionality.
	- Added `LocalProfileView` for managing user profile settings.
- Introduced `BranchList` component for displaying and managing
branches.

- **Bug Fixes**
	- Enhanced error handling and state management in various components.

- **Refactor**
- Streamlined prop handling and state management in multiple components.
	- Updated action and selector names for clarity and consistency.

- **Tests**
- Expanded test coverage for new and modified components, ensuring
accurate behavior under various conditions.

- **Chores**
- Updated import paths and removed unused files to improve project
structure.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-23 16:33:17 +08:00
Nilesh Sarupriya
8559d29b30
chore: refactor the appsmith-ai plugin trigger (#38303)
## Description
> [!IMPORTANT]  
> Refactor the Appsmith AI Plugin trigger method.


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12462586013>
> Commit: 5dc9f81dfc39a8f5357f2202615ebdb92ac59d15
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12462586013&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 23 Dec 2024 07:30:58 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced a new service for managing file upload and listing
operations.
	- Added structured handling of triggers for file-related actions.
- **Bug Fixes**
- Enhanced error management for file operations to improve logging and
response handling.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
2024-12-23 02:29:33 -06:00
Hetu Nandu
0785c556a3
chore: Update selectors for Table Response (#38302) 2024-12-23 12:57:27 +05:30
Sagar Khalasi
c69d7a2f38
chore: reverted changes (#38300)
## Description
Revert change for test case


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12460536656>
> Commit: ed65452d2a4430ceb4225ca084b8615e60b63c15
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12460536656&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Mon, 23 Dec 2024 03:40:01 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- The test suite for the Anvil Table Widget has been temporarily
suspended and will be skipped during test execution.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-23 09:12:27 +05:30
Sagar Khalasi
79ff1051c7
ci: Minor update for edge case (#38295)
## Description
Handle one minor edge case.


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12431317027>
> Commit: 2095f54cc940d1bc5f0201985ff8d5b8959336b1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12431317027&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 20 Dec 2024 14:00:30 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a `run_count` parameter for enhanced control over Cypress
test execution.
  
- **Bug Fixes**
- Improved robustness in checking for null or empty values in the
`specs_to_run` input.

- **Chores**
- Refined logic for rerunning tests based on previous run results and
clarified handling of snapshot updates.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-20 19:31:56 +05:30
Sagar Khalasi
3e9102c0a4
fix: Uncommented anvil cases (#38218)
## Description
Uncommenting test cases as chrome browser version has been hardcoded
now.

Fixes [`Issue
URL`](https://github.com/appsmithorg/appsmith/issues/36419)

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12429832882>
> Commit: 6b601b18c9a1000d3aa28e7954be89eefb748842
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12429832882&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Fri, 20 Dec 2024 10:59:51 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enabled execution of previously skipped test suites for various Anvil
widgets, including Checkbox, Button, Input, and others across different
modes (Canvas, Preview, Deploy).
- Enhanced visual testing capabilities by ensuring all theming
configurations (light and dark modes) are validated for each widget.

- **Bug Fixes**
- Resolved issues causing test suites to be skipped, allowing
comprehensive testing of widget functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-20 19:26:49 +05:30
Hetu Nandu
6a4ee2b9ed
chore: Masking user data in mixpanel session recordings (#38267) 2024-12-20 16:32:02 +03:00
Nilesh Sarupriya
3ff89d766e
chore: set workspaceId to triggerRequestDto (#38244)
## Description
> Set workspace ID to the TriggerRequestDTO.

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12426442788>
> Commit: 8a4bd2e9675dcb534691dd6101e4e054f637cf16
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12426442788&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 20 Dec 2024 06:38:48 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced trigger functionality to directly access and utilize the
`Datasource` object.
	- Updated method to incorporate workspace ID in trigger requests.

- **Bug Fixes**
- Improved error handling for null `requestType` or `parameters` in
trigger requests.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
2024-12-20 06:09:43 -06:00
Alex
3c872eb9ab
fix: property pane in preview mode (#38274)
## Description
Fixes an issue where property pane appeared in preview mode under
certain conditions.

Fixes [#37278](https://github.com/appsmithorg/appsmith/issues/37278)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12428449390>
> Commit: b61d77a9e614b0170c795fee9bb58cfb9ee37e25
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12428449390&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 20 Dec 2024 10:28:59 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new `StaticLayout` component for improved layout
management.
  
- **Bug Fixes**
- Enhanced readability and consistency in defining column widths for
various editor states.

- **Chores**
- Updated imports and exports to replace the deprecated
`UnanimatedLayout` with `StaticLayout`.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-20 14:57:53 +03:00
Pawan Kumar
3d44f4c607
chore: fix text area ui bug (#38282)
This PR fixes UI bugs in text area that got introduced during
refactoring of inputs.

/ok-to-test tags="@tag.Anvil"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced layout and visual feedback for input components with refined
styles for focus, hover, and invalid states.
- Improved handling of read-only inputs and conditional styling based on
data attributes.

- **Bug Fixes**
- Adjusted height calculation logic for the TextArea component to ensure
accurate sizing across browsers.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12429446430>
> Commit: 28022c47d7937e468eed1633c26d757b5b2335a2
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12429446430&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Fri, 20 Dec 2024 10:28:51 UTC
<!-- end of auto-generated comment: Cypress test results  -->
2024-12-20 16:33:47 +05:30
Hetu Nandu
3d0de4fcef
fix: Tab navigation issue in multi page apps (#38272) 2024-12-20 16:26:54 +05:30
Sagar Khalasi
d1cff32d2b
ci: Added ci option for snapshot (#38261)
## Description
Adding workflow for updating snapshot with github CI.


Fixes #[`36419`  ](https://github.com/appsmithorg/appsmith/issues/36419)


## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12426577557>
> Commit: 2660c07257f3d78f64371cedc2ee82f247f9d76d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12426577557&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 20 Dec 2024 07:02:16 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced CI workflow with new input parameters for snapshot updates
and spec execution.
- Added steps for uploading existing and new snapshot data during
Cypress tests.

- **Bug Fixes**
	- Improved artifact management and error handling in the CI process.

- **Documentation**
- Added comments for better understanding of workflow logic and input
parameters.

- **Refactor**
- Streamlined job execution logic and conditional checks for test
reruns.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-20 12:37:42 +05:30
Vemparala Surya Vamsi
71c51712da
chore: converted isNewEntity lookup to use a set (#38264)
## Description
Converted the lookup the in isNewEntity to use a Set, this has reduced
the cost of webworker scripting by about 5%.

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12415891373>
> Commit: 5dfc7a06a7ff2beabb41e005f1c83892896ef6fe
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12415891373&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 19 Dec 2024 16:55:57 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced evaluation logic for newly created entities.
	- Improved error handling for dynamic bindings during evaluations.

- **Bug Fixes**
	- Refined error tracking for property evaluations.

- **Documentation**
	- Minor updates to comments and formatting for clarity.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-20 10:37:39 +05:30
Aman Agarwal
e22dbd188b
chore: added premium tags datasources for knowing users request to add new integrations (#38110) 2024-12-19 20:00:09 +05:30
Hetu Nandu
1ade47d31a
chore: Visual changes for core navigation elements on IDE (#37880)
## Description

Updates a few visual elements for better Navigational experience using
the Segmented Controls

Fixes #37881

## Automation

/ok-to-test tags="@tag.IDE, @tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12409098657>
> Commit: a94e072ab76b5a1146f25dd822576c6b01e57c1e
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12409098657&attempt=3"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE, @tag.Sanity`
> Spec:
> <hr>Thu, 19 Dec 2024 12:51:29 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
- Added `testId` property to sidebar buttons for enhanced testing
capabilities.
	- Updated button titles from "Data" to "Datasources" for clarity.
- Introduced `BottomButtons` configuration for sidebar buttons based on
data source availability.

- **Bug Fixes**
- Improved visual distinction of selected segments in the Segmented
Control.

- **Style**
- Enhanced styling for sidebar buttons and segments, including hover
effects and separators.

- **Tests**
- Added tests to verify rendering of sidebar buttons with the correct
test IDs.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-19 18:57:44 +05:30
Hetu Nandu
4a91204e4d
chore: Analytics util refactor (#38089) 2024-12-19 17:46:22 +05:30
Rahul Barwal
97050485c7
fix: Enhance SelectWidget label and value handling logic (#38254) 2024-12-19 16:08:20 +05:30
Anagh Hegde
d9b1729ce3
chore: refactor crud methods (#38158)
## Description
As part of transaction support in PG, we are moving from using the jpa
methods for database operations. This PR is refactoring the code to use
custom repository class for DatasourceStorageRepository from the default
CrudRepository.

## Automation

/ok-to-test tags="@tag.ImportExport"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12406578294>
> Commit: c7efa6354d2cc1982121eeeab84ac15f1d400e9a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12406578294&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.ImportExport`
> Spec:
> <hr>Thu, 19 Dec 2024 05:27:22 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced new methods for retrieving and counting `NewAction`
entities based on application ID and IDs collection.

- **Bug Fixes**
- Removed outdated methods from the `NewActionRepositoryCE` interface to
streamline functionality.

- **Refactor**
- Enhanced repository capabilities for managing `NewAction` entities
while maintaining backward compatibility.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-19 15:24:23 +05:30
Alex
68264f1e2e
chore: extract search and add to ads (#38192)
## Description
Extract search and add to ADS.


Fixes [#37888](https://github.com/appsmithorg/appsmith/issues/37888)

## Automation

/ok-to-test tags="@tag.IDE, @tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12407865393>
> Commit: dce12fbeebae3ef23d9bd251a8096b09306a06d5
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12407865393&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE, @tag.Sanity`
> Spec:
> <hr>Thu, 19 Dec 2024 07:44:13 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced the `SearchAndAdd` component for enhanced search and add
functionality.
- Added a new Storybook story for the `SearchAndAdd` component,
providing visual documentation and interaction examples.

- **Bug Fixes**
- Replaced the deprecated `AddAndSearchbar` component with
`SearchAndAdd` in relevant areas of the application.

- **Documentation**
- Enhanced documentation for the `SearchAndAdd` component through
Storybook.

- **Chores**
- Updated import statements to reflect the new component structure and
removed obsolete components.
- Modified locators to use data attributes for improved element
identification in tests.
- Added specific identifiers for testing frameworks to enhance
testability of components.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-19 13:43:13 +05:30
Valera Melnikov
ad810c0811
chore: add custom consistent-storybook-title rule (#38241)
## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12396717822>
> Commit: c556bda0ecbae89388821185ab86d340c553bc1e
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12396717822&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 18 Dec 2024 16:46:31 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Updated titles for various components in Storybook for improved
readability (e.g., "NumberInput" to "Number Input").
- Introduced a new ESLint rule to enforce Title Case formatting for
Storybook titles.

- **Bug Fixes**
- Enhanced error handling and validation for Storybook titles through
the new ESLint rule.

- **Documentation**
- Added test cases for the new ESLint rule to validate title formats in
Storybook configurations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-19 10:22:39 +03:00
Hetu Nandu
8ec314f233
fix: Wrong pageId used for segment navigation (#38247)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #38216

## Automation

/ok-to-test tags="@tag.Git, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12406790663>
> Commit: 194f2ec70ff59c89f80410ee0088f16372decaa7
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12406790663&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git, @tag.IDE`
> Spec:
> <hr>Thu, 19 Dec 2024 06:19:57 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced navigation management in the editor for improved user
experience.
	- Streamlined retrieval of the base entity ID for navigation purposes.

- **Bug Fixes**
- Improved consistency in widget selection behavior based on current
focus entity and keyboard events.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-12-19 12:18:48 +05:30
Pawan Kumar
65b98c65b5
chore: Allow currency and phone dial code change (#38141)
![CleanShot 2024-12-16 at 16 42
37](https://github.com/user-attachments/assets/1b59a2f9-d8d1-4fa9-8827-493622088e56)

![CleanShot 2024-12-16 at 16 43
12](https://github.com/user-attachments/assets/b8d29bba-55c5-42ec-8352-fb8b374ef8d2)

Fixes #38091 

/ok-to-test tags="@tag.Anvil"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Added new props for enhanced styling and functionality in various
components, including `className` and `maxHeight`.
- Introduced dropdown menus for currency and ISD code selection in the
CurrencyInput and PhoneInput components.
- New story added for the `TextField` component showcasing prefix and
suffix usage.
- Added a custom hook `useRootContainer` for better theme provider
management.

- **Bug Fixes**
- Improved conditional rendering for input elements based on prop
values.

- **Style**
- Significant updates to CSS for input and select components, enhancing
layout and visual feedback.
- New CSS classes added for ComboBox and styling adjustments for
existing classes.
	- Enhanced styling for the ComboBox popover and other components.
- New CSS rules for currency and dial code options in respective
widgets.

- **Documentation**
- Updated property configurations for widgets to include new toggle
options for currency and dial code changes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12391730072>
> Commit: b8bb73890940ea57a708ffe31b1b61f02fbe7417
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12391730072&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Wed, 18 Dec 2024 11:33:31 UTC
<!-- end of auto-generated comment: Cypress test results  -->
2024-12-19 11:12:23 +05:30
Pawan Kumar
7a7f37cd48
chore: fix menu widget bugs (#38226)
Fixes #38202 

/ok-to-test tags="@tag.Anvil"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
	- Introduced a new configuration for widget sizing and characteristics.
- Enhanced menu functionality with clearer item rendering and
interaction.

- **Bug Fixes**
	- Improved type safety and compatibility in menu item processing.

- **Refactor**
- Updated configuration handling for menu items, transitioning to a more
generic structure.
	- Rearranged export statements for better organization.

- **Documentation**
- Updated method signatures and interface definitions for better clarity
and usability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12392606404>
> Commit: ade8c87e56c003a3d5c733f9c66a2ac4345f7158
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12392606404&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Wed, 18 Dec 2024 12:33:31 UTC
<!-- end of auto-generated comment: Cypress test results  -->
2024-12-19 11:12:09 +05:30