Commit Graph

467 Commits

Author SHA1 Message Date
vicky-primathon.in
c42839180e Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-image-cell-align 2021-04-21 21:25:19 +05:30
Satish Gandham
f7794495d7
Fix Map Widget crash #3843 (#4031)
* Fix map method being called on undefined varaible in MapComponent #3843
Sentry Issue: APPSMITH-N5

* Add type to marker property #3843

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-04-21 14:55:35 +05:30
Vicky Bansal
318cb78464
Escape line break characters when exporting table data to CSV (#3757) 2021-04-20 16:17:06 +05:30
vicky-primathon.in
faaf2e3345 Scroll should not be required for header in default table 2021-04-19 17:02:31 +05:30
vicky-primathon.in
934563a154 Removed background from selected dropdown item in table widget filters 2021-04-19 13:32:23 +05:30
vicky-primathon.in
2b8ab8dc8f Align page number text in table pagination 2021-04-19 11:12:18 +05:30
vicky-primathon.in
7a9dfb2066 Fixed table image cell alignment
Added cypress test to validate image cell alingment
2021-04-19 10:31:17 +05:30
vicky-primathon.in
15521fef06 Fix horizontal scrollbar 2021-04-19 09:02:47 +05:30
vicky-primathon.in
89af3501aa Removed vertical scroll bar from table header 2021-04-15 16:37:54 +05:30
vicky-primathon.in
f46beeb4c6 Reverted changes to ScrollIndicator file name 2021-04-15 11:03:09 +05:30
vicky-primathon.in
99ea7db01b Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-15 10:44:46 +05:30
vicky-primathon.in
d224f2921d Fix scrollbars 2021-04-15 10:31:06 +05:30
Vicky Bansal
d6399c2e48
Disable pagination controls when the table has a single page (#3895)
* Disable input number field when there are no pages to navigate to

* Added cypress test to validate table pagination is disabled
2021-04-09 16:06:50 +05:30
Vicky Bansal
791e8195b1
Align column headers when aligning columns (#3885)
* Align table column header title with table columns

* Added cypress test to validate column header text alignment
2021-04-09 16:04:01 +05:30
Vicky Bansal
43720123d8
Fix: Select Table Widget when a row is selected (#3871) 2021-04-09 16:03:22 +05:30
vicky-primathon.in
1db50eb527 Custom scrollbar changes 2021-04-09 12:34:31 +05:30
Abhinav Jha
f5b97e3863
Fix column ordering in table widget (#3755) 2021-04-07 06:33:30 +05:30
vicky-primathon.in
a24f8ae6ae Added react-custom-scrollbars 2021-04-05 14:52:55 +05:30
Vicky Bansal
6b26e400a8
Bug fix for table crash #3645 (#3849) 2021-04-04 01:10:12 +05:30
Vicky Bansal
bdf31dbf37
Text Widget new styling properties (#3167) 2021-04-01 14:00:33 +05:30
Arpit Mohan
91a7acea49
Adding table plugin in the Rich text editor (#3799)
* Add Table button in RTE Toolbar

Co-authored-by: Aswath K <aswath.sana@gmail.com>
2021-04-01 13:54:42 +05:30
vicky-primathon.in
b30ced453f Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-31 11:03:34 +05:30
Aswath K
b447aa8345 Allow removing filter on Dropdown Widget 2021-03-31 00:35:17 +05:30
Hetu Nandu
363bee8ec9
Fix action field evaluation for editor (#3701) 2021-03-30 10:59:03 +05:30
Ashok Kumar M
bf21c15ba9
Feature: Property pane enhancements(Bug fixes + Draggable popper) (#3748)
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
2021-03-29 21:17:22 +05:30
hetunandu
b0580e9ee0 Revert "Feature: Property Pane improvements (#3561)"
This reverts commit 3437c16ef0.
2021-03-29 16:58:22 +05:30
Ashok Kumar M
3437c16ef0
Feature: Property Pane improvements (#3561)
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
2021-03-29 15:28:52 +05:30
vicky-primathon.in
b153a0e78a Show header scrollbar always if needed 2021-03-27 11:36:42 +05:30
Rishabh Saxena
973a70a624
Fix editor help menu background color and icon size (#3686) 2021-03-26 12:18:15 +05:30
vicky-primathon.in
b6d47a078d Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-25 23:20:35 +05:30
vicky-primathon.in
e79f6c8806 Fix horizontal and vertical table scrollbars
Hide scrollbars during resize
2021-03-25 21:46:22 +05:30
NandanAnantharamu
424a1cbf69
SwitchWidget within FormWidget tests (#3501)
* added test with switch widget within farm widget

* Added another usecase with Switch

* added wait

* updated locators

* minor update

* add locators for switch widget spec

* removed waits and replaced with suitable assertions

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-03-25 21:38:16 +05:30
Abhinav Jha
1ccece69e1
Custom FusionCharts Config (#2670)
* Property pane enhancements

- Property pane sections are collapsible
- Property pane controls can be hidden conditionally
- Property pane configurations now come from the widget instead of a global config file
- Property pane property updates can be hooked with other related updates
- Property pane control and section ids are generated dynamically now.

* Add chart type: "Custom FusionChart" (#2996)

Co-authored-by: Zeger Hoogeboom <zegerhoogeboom@users.noreply.github.com>
Co-authored-by: zeger <zeger@equinoxai.com>
2021-03-25 03:35:04 +05:30
Abhinav Jha
4a05b5d320
Fix #3335 - New method of computing table data to display (#3607) 2021-03-25 00:55:38 +05:30
Vicky Bansal
97b9a32b32
Feature: Table Widget: URL column type (#3569) 2021-03-24 16:54:10 +05:30
vicky-primathon.in
f4d25f6b2e Renamed ScrollIndicator to VerticalScrollIndicator
Common css moved to DefaultTheme
2021-03-23 20:51:13 +05:30
vicky-primathon.in
bb77794125 handle scrollbar changes 2021-03-19 00:39:13 +05:30
vicky-primathon.in
fb7cea6ec6 Resolved conflicts 2021-03-18 11:07:16 +05:30
vicky-primathon.in
5f2d994fda Fix double imports 2021-03-17 18:00:16 +05:30
vicky-primathon.in
f92a8d7fa6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-17 17:22:26 +05:30
vicky-primathon.in
9e65136a75 Merge branch 'fix/table-scrollbar' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-17 17:21:37 +05:30
vicky-primathon.in
212cd423b5 Added horizontal scrollbar component
Add horizontal and vertical scrollbars in table widget
2021-03-17 17:15:49 +05:30
ram-primathon
3b0fb539d5
Property Pane re design (#3057)
Co-authored-by: devrk96 <rohit.kumawat@primathon.in>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-15 17:47:56 +05:30
Vicky Bansal
5acf2c3238
Fully display Table Widget filter conditionals (AND|OR) (#3521) 2021-03-15 14:39:10 +05:30
Arpit Mohan
660c194009
Moving all toast messages to messages.ts file (#2798)
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-03-13 19:54:45 +05:30
vicky-primathon.in
c952e9b10d Remove unnecessary scrollbar from inside table widget 2021-03-13 12:06:02 +05:30
vicky-primathon.in
3da86b33fe Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-03-12 15:24:51 +05:30
Rishabh Saxena
08ebbe410b
Fix chat with us button at the editor help menu (#3465) 2021-03-10 11:27:17 +05:30
Ashok Kumar M
4781f1096c
Fix: Modal Size gets cut in smaller screens. (#3441) 2021-03-09 11:27:44 +05:30
Rishabh Saxena
99b3fa6bb8
Omnibar global search (#2903) 2021-03-08 13:54:12 +05:30
Dwayne Forde
2dfc8ebf8a
Adds support for base64 image strings to image cells (#2769) 2021-03-06 01:07:49 +05:30
Hetu Nandu
3237950d97
End to cyclical dependency woes (#3380)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-03-04 10:54:47 +05:30
Rishabh Saxena
7204e87ea5
fix help modal overlapping with close button (#3289) 2021-03-02 11:26:02 +05:30
Pawan Kumar
d2a0980ec7
Fix: Table Actions button border radius and green shade color (#3222)
* update green shade and set border-radius 0 for table buttons

* updated color code for assertion

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-02 08:43:43 +05:30
vicky-primathon.in
950c7b93bb Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-26 16:35:12 +05:30
Piyush
21a2a2bdf4
Redirect URL for oAuth Auth code flow (#3232) 2021-02-26 12:28:47 +05:30
Vicky Bansal
118467c5bb
Feature: Show/Hide Tabs in Tabs Widget (#3192)
* Added functionality to show/hide a tab from tab property pane controls

* Added isVisible property in tabs widget default value

* Passing visible tabs to component from widget. Added missing widgetId
2021-02-26 11:47:21 +05:30
Pawan Kumar
7185536c67
Fix: Cannot read property 'length' of undefined (#3207)
* update

* fix chart component on empty dataset

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-26 10:58:31 +05:30
Abhinav Jha
647151e527
Internal Fix: Migration issues with Table widget (#3212)
* Fix hidden columns migration

Fix issue where column ids have spaces in them leading to a crash

* Quick fix unit tests

* Remove tableData dependencies from selectedRow and selectedRows
2021-02-25 17:21:54 +05:30
Abhinav Jha
868f29eaeb
Fix selected row issue in view mode (#3186)
* Fix selected row issue in view mode

* Remove un-select feature
2021-02-24 15:59:19 +05:30
vicky-primathon.in
b474442ec7 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-23 18:11:14 +05:30
NandanAnantharamu
6c80f23201
Feature: DatePicker V2 (#2889)
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-23 18:05:09 +05:30
vicky-primathon.in
8b334c3064 Removed passing formatType to component as html is default output 2021-02-23 12:10:19 +05:30
Young Yoo
e5e5af204d
Fix #2342 Un-select row feature (#3074)
Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
2021-02-23 10:19:14 +05:30
vicky-primathon.in
3d5d51fbde Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-22 22:20:36 +05:30
Vicky Bansal
0eab1993f8
Feature: onDataPointClick trigger in Chart Widget (#2953) 2021-02-22 22:01:13 +05:30
Abhinav Jha
4b01e7b3d6 Fix RTE text input parsing.
Fix default input type
2021-02-19 11:19:30 +05:30
Abhinav Jha
4ae81bb74e Fix text newline and html parsing 2021-02-19 11:18:16 +05:30
vicky-primathon.in
517fe592f1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-18 15:42:45 +05:30
Pawan Kumar
503a8ae3fe
remove negative margin (#3037)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-17 10:54:56 +05:30
Ashok Kumar M
a55c10a8ed
Feature Switch Widget (#2999)
* Feature Switch Widget

* Center switch widget

* Adding Cypress tests and changing some nomenclature.

* Adding doc reference

* Swap label for checkbox widget.

* Addressing code review comments.

* remove swap label as exposed property

* Align widget even when label isn't present.

* Changing swapLabel property to Alignment property.

* Fixing test cases.

* Adding default alignment for checkbox.

* Switch documentation link correction

* Removing Ids and adding bind and trigger properties as per new config.

* Changing  default state to bindable property.

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-16 17:45:17 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816)
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-16 15:59:08 +05:30
vicky-primathon.in
6ca247219c Added defaultText and defaultHTML properties in RTE to change newline only in case of default text value
Added migrations to handle the same
2021-02-15 17:19:33 +05:30
Pawan Kumar
5b23cbf6f1
fix margin/padding issue in container in publish view (#2446)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-12 10:37:03 +05:30
devrk96
ac23629647
Feature: API Pane Redesign (#2218)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-11 18:24:00 +05:30
Pawan Kumar
234b6983e9
Fix: border-radius of modal and bug where children of modal were not resetting on close of modal. (#2963)
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

* update border radius of modal

* reset modal children on close

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
2021-02-11 11:55:11 +05:30
Pawan Kumar
3b28653395
update rich text editor version + add check for string in editor value (#2966)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-11 11:55:00 +05:30
Vicky Bansal
e2349c53ab
Fix - Table column resize and reorder interaction (#2580) 2021-02-11 11:30:36 +05:30
Shubhendra Singh Chauhan
ac49a5aa87
Remove true from boolean attribute (#2892)
Added .deepsource.toml file
2021-02-09 11:38:54 +05:30
Pawan Kumar
3e53df8b64
Update Default styles of Widgets (#2823)
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
2021-02-08 13:00:01 +05:30
Rishabh Saxena
32b641c118
Implement new designs for the editor and viewer's navbar (#2750) 2021-02-04 12:32:36 +05:30
Vicky Bansal
42289173b1
Fix: Date widget crash due to invalid date in date picker (#2845)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-03 17:00:19 +05:30
Vicky Bansal
11f5687b38
Date picker validation fixed (#2789)
* Date picker validation fixed

* Added date value check to remove unncessary validations

Commented defaultDate validation test as invalid date cannot be saved in date control

* Fixed date selection on user change

Fixed min and max date parsing for date picker control default date

* Added validation for min and max date in validations to handle validations when field is converted to JS
2021-02-02 20:12:49 +05:30
Rishabh Saxena
b8bcac8544
add support for an onSubmit action for the input widget (#2749) 2021-01-28 16:45:14 +05:30
Pawan Kumar
35e66360e2
Fix: Hover highlight in entity explorer should be edge-to-edge (#2478)
* fix merge conflicts of sumanthyedoti:fix/entity-items-hover

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-27 17:08:21 +05:30
vicky-primathon
63e286a469
Show row cursor as pointer when onRowSelected property is set in table widget (#2604) 2021-01-22 15:42:34 +05:30
vicky-primathon
c9cee45f51
Fix - Wrap contents of the table cell tooltip (#2629) 2021-01-22 15:19:02 +05:30
vicky-primathon
a309107623
Fix - Remove delete icon when there are no filters in table widget (#2605) 2021-01-22 15:17:14 +05:30
vicky-primathon
ae276a93f8
Fix - Boolean values comparison in Table widget filters(#2586)
- Display filter label instead of value
2021-01-22 15:14:03 +05:30
vicky-primathon
64a0a44446
Remove table row alternating colors (#2552) 2021-01-22 15:07:43 +05:30
Rishabh Saxena
64a90a6767
enable immer autofreeze only in development (#2669) 2021-01-22 10:50:55 +05:30
Rishabh Saxena
d2dfd75a0c
use editor init event intead of setup to check if initialised (#2622) 2021-01-20 11:00:53 +05:30
Shrikant Sharat Kandula
d4990683c6
Fix UI for documentation modal (#2631) 2021-01-19 22:01:35 +05:30
Rishabh Saxena
3aa268174d
use script loader for tinymce (#2620) 2021-01-19 14:24:50 +05:30
Rishabh Saxena
969b6fd0d2
Product updates modal (#2453) 2021-01-19 11:47:15 +05:30
Piyush Mishra
1521f7445c
Fix eslint warnings (#2510) 2021-01-12 06:52:31 +05:30
Rishabh Saxena
c36b6b640f
auto focus create org input field (#2493) 2021-01-11 11:14:54 +05:30
Hetu Nandu
cb2dd3c9da
Handle for scenarios scrollTo is not available in browser (#2456) 2021-01-07 10:36:25 +05:30
Pawan Kumar
9d0c6d5359
fix datetimepicker max date issue (#2407)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-31 17:54:50 +05:30
Rishabh Saxena
6dd97a6f09
fix stacking order of popover and app header (#2338) 2020-12-30 14:36:24 +05:30