PromucFlow_constructor

Author	SHA1	Message	Date
Sagar Khalasi	177636d43a	chore: Updated doc urls (#36634 ) ## Description Updated third party URLs. Fixes #`36437` ## Automation /ok-to-test tags="@tag.DocumentViewer" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11125143689> > Commit: 7d19fcce57eb2183d6e261feaa772d20d6fafa10 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11125143689&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.DocumentViewer` > Spec: > <hr>Tue, 01 Oct 2024 12:45:03 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Updated document link URLs for testing to ensure accurate functionality in the DocumentViewer widget. - Tests - Maintained and validated tests for various document types, ensuring correct rendering and handling of different file formats. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-10-03 11:51:25 +05:30
albinAppsmith	4f501419cd	fix: Revert "feat: allow multiple lines in alert component" (#36643 ) Reverts appsmithorg/appsmith#36629 Reverts appsmithorg/appsmith#36126 Reverting this PR since it is causing multiple issues in toast and we are reverting the original PR caused this issue. ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11138591480> > Commit: 598a1d3c6e94fc817c1bc75293b60936a422f77c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11138591480&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 02 Oct 2024 07:27:39 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new styled button component for enhanced toast notifications. - Updated toast styling with customizable properties for better visual presentation. - Bug Fixes - Simplified toast body structure by removing unnecessary components, ensuring content displays correctly. - Chores - Removed outdated end-to-end test file for button widget alert functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-10-02 12:58:16 +05:30
NandanAnantharamu	241dfa8f33	test: replaced 3rd party apit in treeSelect (#36598 ) Replaced 3rd Party API with TED /ok-to-test tags="@tag.Select" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11102740010> > Commit: 692dd2810fb4520bac6fe8aec3658a0cb70525ba > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11102740010&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Select` > Spec: > <hr>Mon, 30 Sep 2024 09:21:05 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>	2024-10-01 16:05:40 +05:30
saiprabhu-dandanayak	a6c109b3ba	feat: allow multiple lines in alert component (#36126 ) ### Description ### Fixes : [#30851](https://github.com/appsmithorg/appsmith/issues/30851) I have raised this pr in-order to allow multiple lines in alert message ### Screenshots ### passing `\n` in the message ![Screenshot from 2024-09-05 13-51-43](https://github.com/user-attachments/assets/02f5fe58-44a6-40e1-a366-c909018e4417) ### unable to parse `\n` ![Screenshot from 2024-09-05 13-50-06](https://github.com/user-attachments/assets/e5fe1d14-4c80-4c5d-8f67-350788d8d84c) ### After issue is resolved ![Screenshot from 2024-09-05 13-55-01](https://github.com/user-attachments/assets/05c8477c-d593-4b5e-9de0-9b6867234c3f) ### Cypress Testing video https://github.com/user-attachments/assets/ec826cef-664f-4392-b81e-9974178e65ec <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new styled component `StyledPre` for enhanced formatting in toast notifications. - Enhanced the Toast component to better render content, improving readability by preserving whitespace and formatting. - Added automated tests for the button widget's alert functionality, ensuring correct display of messages with newline characters. - Bug Fixes - Improved the display of alert messages in toast notifications, ensuring they respect original formatting. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-30 11:15:51 +01:00
Jacques Ikot	6f27959bce	fix: Invalid Date Display in Table Widget's Date Column When Using Unix Timestamp (ms) (#36455 ) ## Description Problem When populating a table widget with data that includes dates in Unix timestamp (milliseconds) format, setting the column type to "Date," the input format to "Unix timestamp (ms)," and selecting a display format leads to an issue during inline editing. While the date picker behaves correctly, selecting a new date results in the table cell showing an "Invalid Date" error. Root Cause The platform currently uses DateInputFormat.MILLISECONDS for Unix timestamp (ms) formatting. However, this value is not a valid option for the moment.format() function, which expects the input format to be 'x' for Unix timestamps in milliseconds. This mismatch leads to the "Invalid Date" error. Solution Modify the logic to map DateInputFormat.MILLISECONDS to the correct moment format string 'x'. Adjust the table's transformDataPureFn to correctly process and display dates in Unix timestamp (ms) format after inline edits, ensuring the moment library can handle the input properly. Outcome This fix ensures that when a user selects a date via the date picker in inline editing mode, the selected date is displayed correctly in the table without any errors. Fixes #35631, #25081 ## Automation /ok-to-test tags="@tag.Sanity, @tag.Binding, @tag.Table, @tag.Datepicker" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11101758400> > Commit: 6a3cae774f3824bd2ee126b501bfa4b6d71ae0c8 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11101758400&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity, @tag.Binding, @tag.Table, @tag.Datepicker` > Spec: > <hr>Mon, 30 Sep 2024 08:54:58 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Enhanced date column editing in table widgets to accept Unix timestamps in milliseconds without errors. - Introduced a new enumeration for improved date formatting options. - Added mock data structures for testing various date formats and transformations in the table widget. - New method for generating formatted date strings for tomorrow in both verbose and ISO formats. - Bug Fixes - Improved validation logic for date inputs in the table, ensuring proper handling of different date formats. - Tests - Added new test cases to validate date handling and input formats in the table widget. - Introduced a new test suite for transforming table data based on specified column metadata. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-30 10:02:42 +01:00
Sagar Khalasi	73169d13b0	chore: Replacing ted api call for resources (#36472 ) ## Description Remove third party url. Fixes `https://github.com/appsmithorg/appsmith/issues/36535` ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11031926377> > Commit: bf5f2950598b16f4eadda81c1076d0c504e90be1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11031926377&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 25 Sep 2024 12:37:04 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Updated various image and URL references in test configurations to point to local resources instead of external links, improving consistency and performance during testing. - Bug Fixes - Corrected image source URLs in multiple test files to ensure proper loading of images in the application. - Chores - Replaced outdated URLs with local Docker host URLs across numerous test files and configurations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-25 19:41:00 +05:30
Jacques Ikot	8fe96c9c20	fix: isRequired validation property for table select column (#36375 ) ## Description Problem The select column of the table widget does not have a validation property within its property pane to allow users add an isRequired validation to the table select column. Solution Added a Validation section to the table select column's property pane, which includes an isRequired toggle. When enabled, this feature will trigger a visual indication (error border colour) around the select widget if a required field is left unselected during "Add new row" or inline editing. Fixes #30091 ## Automation /ok-to-test tags="@tag.Widget, @tag.Table, @tag.Binding, @tag.Sanity, @tag.Select" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10957896180> > Commit: d2597e6a26938f2b99f2f997fca7bc110e5c2091 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10957896180&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget, @tag.Table, @tag.Binding, @tag.Sanity, @tag.Select` > Spec: > <hr>Fri, 20 Sep 2024 12:23:29 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced end-to-end tests for Select column validation in Table widgets. - Enhanced validation logic to support Select column types in the Table widget. - Added visual feedback for required Select fields during row addition and inline editing. - Improved locator for single-select widget button control to enhance UI interaction. - Bug Fixes - Improved error handling and visual representation for invalid editable Select cells. - Documentation - Updated validation configuration to include Select column types for better usability. - Refactor - Enhanced code clarity for styled components related to Select fields. - Modified method to improve versatility in handling table interactions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Sai Charan <saicharan.chetpelly@zemosolabs.com> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-09-23 08:44:46 +01:00
Sagar Khalasi	1cf043c40a	fix: Inline editing flaky test fix (#36366 ) ## Description EE PR: [Appsmith EE Pull Request #5158](https://github.com/appsmithorg/appsmith-ee/pull/5158) Root Cause Analysis (RCA): The `updateCodeInput` function was identified as a source of flakiness due to improper execution. Additionally, the `SaveLocalStorageCache` caused issues by retaining the reset button after the 6th test case, resulting in a duplicate button in the 7th test case, which led to test failures. Solution: Replaced `updateCodeInput` with `EnterJSContext` from `agHelper` for more reliable execution. For the second flaky step, a new page was created, and a table with relevant data was added. This resolved the issue without requiring significant changes to the test case or workflow. Fixes #`36365` ## Automation /ok-to-test tags="@tag.ImportExport" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10940196158> > Commit: 32d1be4c3dfe54bf8a0f8e9f54b20d2845c86407 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10940196158&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.ImportExport` > Spec: > <hr>Thu, 19 Sep 2024 12:01:32 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Bug Fixes - Adjusted the inline editing test suite for the table widget to improve state management between tests. - New Features - Updated the limited tests to focus on inline editing functionality, enhancing testing priorities for the Table V2 widget. - Introduced new properties in the widget locators to enhance UI interactions, including selectors for various controls and elements within the property pane and cell editing functionalities. - Added a new JavaScript toggle selector to facilitate interactions in tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-20 12:44:14 +05:30
Rahul Barwal	6507f90e05	fix: Incorrect updation of selctedRowIndex when primary column is set. (#36393 ) ## Description <ins> Problem statement </ins> 1. Table should have a primary column set. 2. The table should be filtered(via search or client side filters) 3. there should be a selectedRow in table a. One way to ensure is add a text widget and bind it to table's `selectedRowIndex` property. If you now run a query that updates the data behind the table: the `selectedRow` is updated to (seemingly) random row and selectedRowIndex is updated as well <ins> Rootcause </ins> We have a mechanism of preserving `selectedRow` when data updates happen. Underlying logic gets the previous selected row and tries to find it in the new data using the primary key. * If it finds it, it updates the selectedRowIndex to the `__original_index__` of the found row i.e. its position in the original data before any filters were applied. <ins> Solution </ins> We update the selectedRowIndex to the index in the new filtered data. <ins> How to test </ins> 1. Create a table with a primary key 2. Add a text widget and bind it to table's `selectedRowIndex` property 3. Filter the table 4. Click on a row to select it 5. Run a query that updates the data behind the table 6. Assert that the selected row is the same and that the selectedRowIndex is updated to the new index Fixes #36080 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table, @tag.Binding, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10953679202> > Commit: 1a2d64467e453229940b67b29da1ce9d0e9ac24d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10953679202&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Binding, @tag.Sanity` > Spec: > <hr>Fri, 20 Sep 2024 06:30:08 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Improvements - Enhanced the efficiency of the TableWidgetV2 by streamlining the method for retrieving the index of selected rows. - Improved code readability and maintainability without altering the overall functionality. - New Features - Introduced new test cases to validate filtering and searching functionalities within the Table Widget V2. - Added a JSON configuration for a data-driven table interface, supporting sorting, filtering, and dynamic data binding. - Introduced fixture data for testing, allowing for comprehensive validation of table behavior under various conditions. - Added a JavaScript object containing employee data to facilitate filtering and display in the table. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-20 12:25:23 +05:30
Sagar Khalasi	9e7fa1d725	chore: Added sanity and tags for blank tag specs (#36421 ) ## Description Added relevant tags with sanity tags. Fixes `https://github.com/appsmithorg/appsmith/issues/36415` ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10938122144> > Commit: 8383cf735da821760853af77f232b5c992904a19 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10938122144&attempt=4" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 19 Sep 2024 11:41:23 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced test suites with additional `@tag.Sanity` tags for improved categorization and organization. - Bug Fixes - Updated various test suite tags to include `@tag.Sanity`, ensuring comprehensive coverage of functionalities. - Documentation - Improved tagging structure across multiple test suites for better clarity and maintainability. - Chores - General modifications to existing test suite descriptors to include new tags without altering core functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-19 18:21:58 +05:30
Pawan Kumar	27aeb4dc18	chore: fix map chart spec (#36370 ) /ok-to-test tags="@tag.Maps" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10916335124> > Commit: 6e88177f19e0b2deff3eed2d2531a8f88ec06a68 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10916335124&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Maps` > Spec: > <hr>Wed, 18 Sep 2024 06:11:15 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-09-18 11:53:42 +05:30
albinAppsmith	66c815f1cb	feat: Migrate DBform to UQI config (#36168 ) ## Description This PR migrates the plugins which were old DBForm config to UQI config. Plugins that got affected, 1. Snowflake 2. ArangoDB 3. Oracle 4. PostgreSQL 5. MySQL 6. Elasticsearch 7. DynamoDB 8. Redis 9. MSSQL 10. Redshift Fixes #35496 Fixes #35497 Fixes #35500 Fixes #35487 Fixes #35490 Fixes #35491 Fixes #35499 Fixes #35501 Fixes #35502 Fixes #35506 Fixes #35890 ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10897087023> > Commit: e8fe475a48aac1e2e1f3184181ae0bed154313ba > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10897087023&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource` > Spec: > <hr>Tue, 17 Sep 2024 06:07:27 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced rendering logic in the Query Editor to support additional UI component types. - Improved handling of form evaluations and query configurations across various plugins, including ArangoDB, DynamoDB, Elasticsearch, and others. - Introduced structured layouts for editor configurations, enhancing clarity and usability in multiple database plugins. - Bug Fixes - Adjusted control flow in sagas to ensure proper handling of UI component types, improving user interactions. - Chores - Refined JSON configurations across multiple plugins for better organization and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-17 14:22:32 +05:30
Sagar Khalasi	996e26b537	fix: Fix datepicker issue with aghelper (#36325 ) ## Description Root Cause Analysis (RCA): In the local environment, the minDate field was consistently cleared as expected, but this behavior was not replicated in the CI pipeline. Updating the existing flow to address this issue could introduce other problems. The minDate text area having js date function in the CI pipeline, leading to repeated test failures. Multiple function attempts to resolve this issue were unsuccessful. Solution: I tried using the `agHelper` utility and updated the test flow with adding a new test case. EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5139 Fixes #`36329` ## Automation /ok-to-test tags="@tag.ImportExport" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10878662752> > Commit: 0985fc573bbbc678850985babcbc027897c9d59f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10878662752&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.ImportExport` > Spec: > <hr>Mon, 16 Sep 2024 06:53:39 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced Datepicker widget functionality with new locators for improved user interaction. - Bug Fixes - Improved test cases for the Datepicker widget, ensuring accurate validation of display data and date formats. - Documentation - Updated test specifications to reflect a shift in focus towards the Datepicker widget. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-16 13:33:53 +05:30
Rahul Barwal	5996f74b73	test: fix failing table filter spec by rearranging steps. (#36303 ) ## Description In the spec, feature flag intercept is interfering with navigating back to editor flow. Since we need FF in the editor, this PR rearranges these steps. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/10845920958> > Commit: c7de064cd6c262f969270be226a135371985646e > Workflow: `PR Automation test suite` > Tags: `@tag.Table` > Spec: `` > <hr>Fri, 13 Sep 2024 08:40:08 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Improved test flow for the Table V2 component by repositioning navigation actions, enhancing clarity and context. - Chores - Updated the configuration for limited tests to focus on the Table V2 widget's filtering functionality instead of template-related tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-13 14:43:23 +05:30
Valera Melnikov	7ba06c829d	chore: change snapshot package (#35867 ) /ok-to-test tags="@tag.All" ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10815637874> > Commit: 54937a7a64e755959e3420a0a20abcc30ee10d78 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10815637874&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 11 Sep 2024 17:30:00 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Added support for visual regression testing through new tagging in various test suites. - Integrated a new image snapshot plugin to enhance testing capabilities. - Bug Fixes - Removed outdated image snapshot assertions to streamline testing processes. - Documentation - Updated tags in multiple test suites to improve organization and clarity regarding visual testing. - Chores - Upgraded Node.js version in the Cypress Dockerfile for improved performance and compatibility. - Simplified Cypress plugin configuration by removing unnecessary functions and enhancing browser compatibility. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-09-12 11:09:42 +03:00
Jacques Ikot	8a9af791e4	feat: Allow table search to include label and value for tables with select column type (#36061 )	2024-09-12 08:28:46 +01:00
Pawan Kumar	b5f4c65719	chore: fix select1 spec (#36228 ) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Enhanced test functionality by adding a check for page save errors in the "Select1" test, improving error handling before executing further actions. - Chores - Updated testing priorities by commenting out the "Fork Template" test and activating the "Select1" test in the limited tests configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!WARNING] > Tests have not run on the HEAD d248530e0b95d34947fef3ffc2ba08e71e81dad7 yet > <hr>Tue, 10 Sep 2024 11:37:57 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-09-11 11:28:44 +05:30
Sagar Khalasi	188e9f0643	fix: Video2 spec flaky fix (#36166 ) ## Description RCA: We are using youtube url for `Verify Basic Functionality of Video Widget - muted`. Which leads to flakiness. Also this case needs a human intervention to fulfilled the actual user case. Solution: Deleted this test as it can be part of manual testing. Fixes #`36164` ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10766784105> > Commit: 11d8d952f5e24cc49056532b15da190eefe8ba41 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10766784105&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 09 Sep 2024 05:41:15 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Removed a test case for the muted functionality of the Video Widget, streamlining the test suite. - Chores - Updated the test path in the limited-tests file to prioritize video widget testing over template testing. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-09-09 11:55:00 +05:30
Hetu Nandu	65eb8546f4	fix: Fall of the error toasts wall (#35839 )	2024-09-05 11:06:43 +05:30
NandanAnantharamu	bdeeea5c77	test: fix inline editing spec (#35986 ) RCA: Toggle state of the property was going to wrong state, hence with retry test was passing as it would bring back the application to required statee. Solution: Updated toggle state in the flaky test to avoid this issue EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4997 /ok-to-test tags="@tag.Sanity" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10633979760> > Commit: b63e5716203e0865ad493b1bc0ab8e952aaa7301 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10633979760&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Fri, 30 Aug 2024 14:27:24 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced inline editing functionality for table widgets, improving interaction and validation in tests. - Bug Fixes - Updated limited tests configuration to prioritize inline editing tests over previous specifications. - Tests - Improved test coverage for inline editing by adding interactions with dropdowns and property state toggling. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-30 20:05:41 +05:30
Jacques Ikot	826a33aa9c	fix: Prevent Errors in Debugger When Deleting List Widget (#35820 ) ## Description Problem When deleting a List widget in the EE environment, the widget is successfully removed, but errors are displayed in the in-app debugger. These errors disappear upon refreshing the page, leaving users confused as to why the errors appeared in the first place, despite the widget being deleted correctly. Root Cause - The issue arises from the sequence in which widgets and their associated meta widgets are deleted. - When deleting a widget with meta widgets (e.g., a List widget): - The main widget is removed first via the deleteWidget saga. - Meta widgets are then deleted later during the componentWillUnmount lifecycle method. - The lint evaluation runs between these two processes, detecting meta widgets still present in the state without a parent widget. - This mismatch triggers errors in the in-app debugger, which disappear once the page is refreshed, as the meta widgets have already been deleted by then. Solution - We have modified the deletion process to ensure that both the main widget and its associated meta widgets are removed within the same action. - Instead of handling meta widget deletion in the general deleteSaga: - We now check for widgets with the hasMetaWidgets flag within the deleteWidget saga. - If such widgets are found, their meta widgets are deleted before the main widget is removed from the layout. - This adjustment ensures that the lint evaluation occurs after both the main widget and its meta widgets have been removed, preventing errors in the debugger. Fixes #35628 ## Automation /ok-to-test tags="@tag.Widget, @tag.List, @tag.IDE, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10629216245> > Commit: 56a4c85076d574cc2ebfef12d3b9f998ee1a4ece > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10629216245&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget, @tag.List, @tag.IDE, @tag.Sanity` > Spec: > <hr>Fri, 30 Aug 2024 09:25:02 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Enhanced testing for the list widget to include verification of the drag, drop, and delete functionalities. - Improved widget deletion process by ensuring related meta widgets are also addressed during deletion. - Updated test descriptions for better clarity and scope, specifically focusing on deletion functionality. - Introduced a factory for creating instances of version 2 list widgets, streamlining widget generation. - Bug Fixes - Expanded test coverage for potential issues in widget behavior, particularly concerning deletion. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-30 10:38:19 +01:00
NandanAnantharamu	67de8c1a19	test: updated tests for checkboxgroup (#35945 ) RCA: Test was failing after removing retry, the issue was it was clicking on a checkbox which was not required. the retry actually was bringing back the system to right state by clicking again. Solution: We removed the step that was unnecessary in this case which resolved the issue EE: https://github.com/appsmithorg/appsmith-ee/pull/4992 /ok-to-test tags="@tag.Sanity" <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10616697878> > Commit: e599c6d0149814c38049aaba7828465361d8f43b > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10616697878&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 29 Aug 2024 14:33:59 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: karthik <thinkify@karthiks-MacBook-Pro.local>	2024-08-29 22:55:33 +05:30
Anna Hariprasad	5ddf6e6977	feat: remove-clear-option-for-required-select-widget (#35060 ) Hi @rohan-arthur, @somangshu , @contributor-support Fixes #34262 What's in this pr : - Added isRequired prop for select widget components to control the logic for the remove button. - Added two test cases to verify clear button rendering when isRequired is set to true and false. Screenshots : ![image](https://github.com/user-attachments/assets/4c276add-f28e-4060-8f44-a957dc48f673) ![image](https://github.com/user-attachments/assets/02138d93-e4c1-4e67-97df-0703398c440b) ![image](https://github.com/user-attachments/assets/8eb8ec6f-9124-4a61-9df4-448338086714) Please let me know if any changes are required. Thank you. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Introduced an `isRequired` property to the `SelectButton`, `SelectComponent`, and `SelectWidget`, allowing users to indicate whether a selection is mandatory. - Enhanced rendering logic in the `SelectButton` to conditionally display the cancel button based on the `isRequired` state. - Improved styling and behavior options in `SelectComponent` for better integration into forms. - Tests - Added new test cases for the `SelectButton` to ensure correct rendering behavior of the cancel button based on the `isRequired` prop. - Streamlined Cypress tests to focus on the non-existence of the clear button, reflecting updated component behavior. - Updated locator configurations to improve test coverage for user interactions involving clearing selections. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-28 16:03:16 +05:30
Jacques Ikot	9f387d5763	fix: Correct Select Widget Mapping for Dynamic Label and Value Keys (#35862 ) ## Description Problem When the Select widget's labelKey or valueKey properties are switched to JS mode, passing a function that returns a string as the key causes the dropdown options to break. Instead of correctly mapping the labels and values, the options are incorrectly returned as an array of the key itself. Root Cause The issue lies in the `getOptions` function in derived.js. The logic that computes the select options based on the labelKey and valueKey was not handling cases where these properties are functions that return arrays. Instead of mapping through the source data and returning the corresponding values for each key, the function was mistakenly returning the entire array. Solution The `getOptions` function in derived.js has been updated to correctly handle cases where labelKey or valueKey are arrays. The function now maps through the sourceData and computes the correct labels and values based on the provided properties, ensuring that the dropdown options are displayed as expected. Fixes #35269 ## Automation /ok-to-test tags="@tag.Sanity, @tag.Select, @tag.Widget, @tag.Binding" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10560970428> > Commit: 118badee07c47fe72f727f8ab248c29685f6f7a1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10560970428&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity, @tag.Select, @tag.Widget, @tag.Binding` > Spec: > <hr>Mon, 26 Aug 2024 15:24:26 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced test coverage for the Select widget by adding new test cases to validate the correct functioning of JavaScript functions in the label and value keys. - Improved processing of `optionLabel` and `optionValue` properties for the Select widget, ensuring accurate mapping to `sourceData`. - Introduced a new helper function to streamline the validation of label and value keys in the Select widget tests. - Bug Fixes - Corrected the handling of multiple options in the Select widget to enhance data mapping accuracy and functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-27 07:54:44 +01:00
Jacques Ikot	28ac53bf6e	fix: Ensure Select Column Displays Data When Options Are Not Set (#35817 ) ## Description Problem When using a table widget, changing a column to the "Select" type causes the data in that column to disappear unless the options property is explicitly set. This creates a poor user experience, as it appears that the data has been lost or the widget is malfunctioning. Solution We have implemented a fallback mechanism to ensure a smoother user experience. If no options are set in the property pane, the label inside the select cell will now default to displaying the existing value. This ensures that the data remains visible, even in the absence of predefined options. Fixes #35807 ## Automation /ok-to-test tags="@tag.Widget, @tag.Select, @tag.Binding, @tag.Table, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10513374411> > Commit: 1e89468e8345f2fc351c100428dca76a7a455dbc > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10513374411&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget, @tag.Select, @tag.Binding, @tag.Table, @tag.Sanity` > Spec: > <hr>Thu, 22 Aug 2024 19:43:53 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the select column in the table widget to return a default value when no options are available. - Bug Fixes - Improved robustness of the select cell component to prevent errors when the options array is empty. - Tests - Updated and reorganized test cases for the select column to improve clarity and specificity. - Introduced a new test case to validate default value behavior when no options are provided. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-23 10:10:27 +01:00
Rahul Barwal	6c8d4a9a66	fix: Fixes currentRow calculation logic in table(property pane) (#35390 ) ## Description <ins>Problem</ins> `currentRow` variable which is availabe in property pane of col settings - is not getting correct value during runtime if the table is sorted or filtered. <ins>Root cause</ins> * We are considering `processedTableData` to get the `currentRow`. * This property is not updated during filtering and sorting, another property `filteredTableData` is updated instead. * We CANNOT use `filteredTableData` as it depends on `primaryColumns` property which we intend to update as well - this is leading to cyclic dependency during evaluations. <ins>Solution</ins> Since the problem is related to edit cases and given the constraints around using `filteredTableData` directly, we fixed the problem by adding a new property to `editableCellValue` object called `__originalIndex__`. * This property stores the index of the row being edited in `processedTableData` * On top of this change, the PR adds a migration for updating the current row binding in TableWidgetV2, ensuring accurate current row calculation and improving the functionality of the widget. * We also added unit test for migration changes. * Additionally, This pull request refactors the DSLs for TableWidgetV2 migration test cases to update the DSLs to separate folder, drastically reducing the file size to its core logic, improving the readability of the code. * We also updated relevant test cases to account for this change. [Testing plan](https://www.notion.so/appsmith/Issue-34346-currentRow-doesn-t-work-correctly-when-the-table-is-filtered-449225ae822c485493036599c2b19487) [Counter part EE pr](https://github.com/appsmithorg/appsmith-ee/pull/4879) Fixes #34346 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10451549845> > Commit: d1d65c6898c223bf3f6dfbfe93b8e8de214fcc7d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10451549845&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 19 Aug 2024 11:15:04 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [x] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Updated DSL migration process to support version 90, enhancing compatibility and robustness. - Introduced new migration logic for table widget data bindings, improving inline editing capabilities. - Enhanced validation logic for editable cells in table widgets, allowing for more dynamic data handling. - Added a method to discard edits in specific table cells, improving user interaction. - Introduced a new message constant for required fields, enhancing user feedback. - Bug Fixes - Improved validation checks for table cells based on updated indices and values. - Tests - Added comprehensive tests to validate migration functions related to Table Widget, ensuring all aspects function correctly post-update. - Enhanced test specifications for improved validation logic and coverage in table widget functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: sneha122 <sneha@appsmith.com>	2024-08-20 13:31:45 +05:30
Jacques Ikot	6628635cf4	fix: mandatory date column enforcement (#35613 ) ## Description Problem: When the `isRequired` property is set for date columns in the table widget, the validation doesn't work as expected. Users can add new rows without filling in the date field, even though it is marked as required. This results in rows being added with missing date values, which can lead to incomplete or invalid data entries. Root Cause: The validation logic for the date column is currently handled within the DateCell component. However, the isRequired validation functionality was not implemented within this component. Additionally, the general validation logic in the `getEditableCellValidity` function, located in the derived.js file, does not account date cells in its isRequired validation. Solution: To fix this issue: Enhance the `getEditableCellValidity` function: Extend the existing validation logic in getEditableCellValidity to include the date cell in its validation, specifically checking for the isRequired property. Integrate with DateCell validation: Ensure that the isRequired validation is properly executed in conjunction with the existing date validations inside the DateCell component. This will enforce the requirement and prevent new rows from being added if the date field is left empty. Test Plan https://www.notion.so/appsmith/Test-Plan-Date-Column-Marked-as-Required-Doesn-t-Enforce-Mandatory-Entry-When-Adding-New-Table-Row-c73b764af60842a188cba056bdda6d79?pvs=4 Fixes #34258 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10453174231> > Commit: 40fe2eaf7d45024bef00f8031e971a5bac2a4e3e > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10453174231&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 19 Aug 2024 13:17:23 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Introduced validation for "Date" column types, ensuring that required fields are correctly enforced. - Enhancements - Improved validation logic for more accurate user feedback in date cells. - Expanded support for validating "date" columns in the table widget. - Bug Fixes - Enhanced error handling to ensure proper indication of cell validity based on new validation criteria. - Updated visual feedback for cell editor state in the UI. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-20 07:09:51 +01:00
Sagar Khalasi	25349c1c66	test: Update case base duplicate file name (#35672 ) ## Description Remove the duplicate file name with different cases as well. Fixes #`34939` ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10370869517> > Commit: 242ca07a87991f5786bd8a33aeefaf046e2a29e0 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10370869517&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 13 Aug 2024 14:36:34 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No	2024-08-20 10:48:52 +05:30
Rahul Barwal	32f2986662	chore: fix flaky datepicker spec. (#35726 ) ## Description In the past we attempted to remove the `DatePickerV2_spec` from flaky list after successful `/ci-limit-test` runs ([EE PR with runs](https://github.com/appsmithorg/appsmith-ee/pull/4736)). But the very next day it had to be added back to the flaky list. There was certainly a problem which was not getting caught on local and `ci-limit-test` runs. Upon observing the [last known failure run of this spec](https://internal.appsmith.com/app/cypress-dashboard/run-details-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10096251875&attempt=5&selectiontype=test&testsstatus=failed&specsstatus=fail), this error got highlighted: > CypressError: Timed out retrying after 100000ms: `cy.wait()` timed out waiting `100000ms` for the 5th response to the route: `updateLayout`. No response ever occurred. Upon further debugging and a loooot of local runs I noticed that even though we were changing the `Max date` at the end of this spec does not do anything(on the product UI) and more importantly had no impact on the test run. So we removed it. The good thing is that in current [EE PR](https://github.com/appsmithorg/appsmith-ee/pull/4907) as well there are no failures. > PS: I would still be on alert after merging to notice any more failures and add it back to flaky, if it troubles other team members. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Datepicker, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10446454718> > Commit: b0348f4f13c6b36cb35b0a5fd596513d42ab7837 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10446454718&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datepicker, @tag.Sanity` > Spec: > <hr>Mon, 19 Aug 2024 03:36:10 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Adjusted the DatePicker component's test to remove the maximum date constraint, allowing for a broader range of valid dates during testing. - Revised conditions for tooltip assertions related to date range validation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-19 09:16:48 +05:30
Jacques Ikot	35839c6bb3	test: fix flaky inline editing 2 spec (#35426 ) ## Description Fix flaky test - `Inline_editing_2_spec.js` Related EE PR for fix - https://github.com/appsmithorg/appsmith-ee/pull/4819 Problems Previous change made to remove the editable checkbox from the columns list on the table property pane made the `table.EnableEditableOfColumn` obsolete as a method for enabling edit mode on specific columns. There is a newly introduced method `toggleColumnEditableViaColSettingsPane` was swapped only in some cases, not implemented correctly, and in some other cases, the `table.EnableEditableOfColumn` still existed, causing the test to fail. Solution 1. Fix the implementation of the `table.toggleColumnEditableViaColSettingsPane` in all instances in the test suit 2. Replace `table.EnableEditableOfColumn` with `table.toggleColumnEditableViaColSettingsPane` in tests 3. Move standalone values into consts for readability 4. Remove unused const Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10352974239> > Commit: 83116d9c64f95946ab0ba7399c7e1c491f2d2851 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10352974239&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 12 Aug 2024 14:08:51 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Bug Fixes - Improved reliability of inline editing tests for the table widget, ensuring consistent behavior when editing columns. - Improvements - Enhanced clarity of test case descriptions regarding cell column height behavior with text wrapping. - Updated height assertions to use constants for better readability and maintainability. - Chores - Changed focus of limited tests from template-related tests to inline editing functionality tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-12 17:48:25 +01:00
Rahul Barwal	b64d5c8338	fix: drag and drop issue in list widget (#35622 ) ## Description This pull request fixes an issue where the error count was not being properly checked when a list widget was dropped. * Reverts a previous commit(#35221). * Include changes to the test file and the widget creation functions to ensure that the error count is correctly checked when a list widget is dragged and dropped. Fixes #35578 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10350318730> > Commit: 07f3abcff845eb4d350fc9af235d6ed076257264 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10350318730&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 12 Aug 2024 11:35:20 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Improved drag-and-drop functionality for list widgets. - Bug Fixes - Enhanced clarity and organization of test cases for better logical flow. - Chores - Simplified widget ID generation across several components, improving consistency in the application. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-12 17:24:19 +05:30
Hetu Nandu	4bbbaecf20	chore: Upgrade TinyMCE (#35399 )	2024-08-08 20:08:09 +05:30
Aman Agarwal	f0059fe894	fix: table save row button onclick function (#35412 )	2024-08-08 18:46:40 +05:30
Jacques Ikot	3b1c14a9f0	feat: add sortBy property to table select cell type (#35187 ) ## Description Problem The table widget now supports the Select column type, which allows the column to contain both a label and a value. This could be useful for currency fields, foreign keys, or any other case where you want to display a different version of the column value. However, there is a problem with sorting. The table always sorts using the value, and does not give the user an option to sort using the label, where it makes sense in specific cases. Solution This PR adds a Sort By property to the table select cell, allowing the users to choose which value is used for sorting without affecting any functionality of the label or value of the select cell. [Additional Technical Documentation](https://www.notion.so/appsmith/Adding-sortBy-Property-to-Select-Columns-in-Table-Widget-V2-a5a41e6319a047378eb50a42be8c32ef?pvs=4) Tested Cases 1. Sort select column by default value Objective: Ensure that a newly added table with select column default sorts by the value Steps: - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., role) to select type. - Add selectOptions property - Verify that when sorted in ascending or descending order, the sorting is correct 2. Sort select column by label Objective: Ensure that a newly added table with select column and sortBy property set to label sorts correctly Steps: - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., role) to select type - Add selectOptions property - Set sortBy property to label - Verify that when sorted in ascending or descending order, the sorting is correct and based on the label value only 3. Verify that sorting of other table cells that are not select works as expected Objective: Ensure that every other cell type in the table sorts correctly Steps: - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., role) to select type - Add selectOptions property - Set sortBy property to label - Verify that when columns other that role are sorted, they are sorted correctly 4. Verify that sorting works as expected when table data is a binding Objective: Ensure that the sorting works for all columns while using data binding in table data Steps: - Drop a new table widget - Link a query binding to the table data property - Verify that all columns sort correctly 5. Verify that sorting works as expected when table data is a binding and select column sorting is set to label Objective: Ensure that the sorting works for all columns while using data binding in table data with a select column set to sort by the label Steps: - Drop a new table widget - Link a query binding to the table data property - Set a column (e.g., role) to select type - Add selectOptions property - Set sortBy property to label - Verify that all columns sort correctly 6. Verify that sortBy logic does not take effect or break user experience until the user adds selectOptions in select cell Steps: - Drop a new table widget - Link a query binding to the table data property or add raw data - Set a column (e.g., role) to select type - Do not add selectOptions - Set sortBy property to label - Verify that all other columns display and sort correctly 7. Verify that sorting by label and value works correctly in deployed mode Steps: - Drop a new table widget - Link a query binding to the table data property or add raw data - Set a column (e.g., role) to select type - Add selectOptions - Set sortBy property to label - Deploy application - Confirm that sorting works correctly for all columns Fixes #21993 ## Automation /ok-to-test tags="@tag.Table, @tag.Binding, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10165119164> > Commit: 8a4e8b238adc0d78726a811b54a209caa4990606 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10165119164&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Binding, @tag.Sanity` > Spec: > <hr>Tue, 30 Jul 2024 16:02:35 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [x] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a feature flag for dynamic table cell labeling. - Added a sorting option for select cells, allowing sort by value or label. - Enhanced user interface with new configuration options for select components. - Improved sorting functionality for select columns to sort by labels. - Bug Fixes - Improved sorting functionality in the table widget to ensure accurate data representation. - Tests - Expanded and clarified test cases for sorting functionality in the Table Widget V2. - Updated testing structure for better reliability and isolation of test scenarios. - Integrated dynamic testing capabilities based on feature flags. - Documentation - Added new locators for sorting controls to enhance UI interaction capabilities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-08-02 08:37:00 +01:00
Hetu Nandu	e0d0ee1046	chore: Reorganise IDE Panels (#35114 ) ## Description By re organising the panels in the IDE, we are creating a new Code Editor only panel which is separate from the main / canvas and the explorer panel. This ensures that the Code Editor is not remounted when switching between Split screen and Full screen. This PR is also improving the Preview mode by not changing urls when entering and exiting preview modes. EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4760 Fixes #31707 Fixes #31387 Fixes #34545 Fixes #34546 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10177085462> > Commit: 26688b0fde7e797d88996ef569d9fc06e3942958 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10177085462&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 31 Jul 2024 09:42:50 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Introduced `EditorPaneExplorer` and `QueryExplorer` components for enhanced navigation and query management within the IDE. - Added visual enhancements to `ListJSObjects` and `AddWidgets` components with new style properties. - Improvements - Implemented clamping in the `useDynamicAppLayout` hook to prevent negative width values, enhancing layout stability. - Updated layout management to ensure a responsive user experience based on IDE view modes. - Style - Enhanced visual clarity by adding borders to various components, improving UI separation and organization. - Bug Fixes - Streamlined test cases in the `Postgres2_Spec.ts` to maintain coherent sequencing after removing unnecessary tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-07-31 21:23:35 +05:30
Sagar Khalasi	b7629b3514	test: Updated duplicate file names (#34972 ) ## Description Updated name for duplicate file name with extensions as well in spec file. Fixes #`34965` ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9960943316> > Commit: 71dee8e1400f227a6183a760832dd703d7074d1f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9960943316&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 16 Jul 2024 17:46:48 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No	2024-07-31 10:27:33 +05:30
Jacques Ikot	2cded02983	feat: display label in table select cell (#35124 ) ## Description Issue In the table widget, the select column currently displays the value from the dropdown when a user makes a selection, rather than the label. This behaviour is inconsistent with the standalone select widget, which correctly renders the label upon selection. Fix This PR addresses the inconsistency by modifying the table widget's select column to display the label of the selected item, while maintaining the table cell value and ensuring alignment with the behaviour of the standalone select widget. Tested Cases Manual Test Cases for Table Select Widget Improvement 1. Default Value Display Objective: Ensure that a new table displays the correct default label key from the selectOptions in the cell. Steps: - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Verify that the table cell displays the value from the label key of the `selectOptions` by default. 2. Binding Check for Selected Row Objective: Ensure that the table binding for the selected row reflects the correct value key from the selectOptions. Steps: - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Select a row and verify that `Table1.selectedRow.gender` matches the value key from the `selectOptions`. 3. Updating Table Cell Content Objective: Verify that updating the table cell content via the dropdown updates the cell with the correct label key property. Steps: - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Change the content of the table cell using the dropdown. - Confirm that the cell content updates accordingly with the value key property. 4. Add New Row Functionality Objective: Ensure that adding a new row works as expected with the enhanced functionality. Steps: - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Add a new row to the table. - Verify that the new row uses the label key property from the `selectOptions` in the table display. 5. Deployed Mode Verification Objective: Verify that the display functionality works correctly in deployed mode. Steps: - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Change the displayAs property to both value and label. - Deploy the table. - Verify that the table displays correctly in both value and label modes in the deployed environment. Fixes #26188 ## Automation /ok-to-test tags="@tag.Table, @tag.Binding, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10080592979> > Commit: 78b268d2b566aa07ef23fec567ce05e8c5a6add4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10080592979&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Binding, @tag.Sanity` > Spec: > <hr>Wed, 24 Jul 2024 17:17:06 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Improved display of selected options in table widgets by showing the corresponding label instead of the raw value. - Introduced a feature flag to toggle the table cell label value functionality. - Bug Fixes - Enhanced test cases to ensure accurate validation of select options behavior within the table widget. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-07-25 12:39:24 +01:00
Shivam kumar	eff3c5969e	fix: Wrong evaluated value after binding checkbox group widget with… (#33906 ) ## Description - In this PR I have fixed wrong evaluated value after binding checkbox group widget with query Output: [Loom](https://www.loom.com/share/ddcc10c5ab8b4ead8ef5d10843671d95?sid=6346b4a9-9a89-4c7d-bdcd-73c428f17626) > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #24620 _or_ Fixes https://github.com/appsmithorg/appsmith/issues/24620 > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced comprehensive snapshot tests for Anvil Widgets in Canvas, Preview, and Deploy modes. - Added test cases for Anvil modals in the Anvil editor. - Enabled filtering functionality for TableV2 widgets by default. - Bug Fixes - Addressed issues with Git sync tests by updating selectors and function calls. - Fixed control flow in various Cypress tests by removing `cy.pause()`. - Chores - Updated Dockerfile to ensure custom command-scripts have executable permissions. - Added environment variable `DP_POSTGRES_URL` to Docker deployment configuration. - Refactor - Refined job configurations and script executions in GitHub Actions workflows for improved performance and clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-07-17 10:54:03 +05:30
Rahul Barwal	083cea19d3	feat: Remove editable checkbox from PrimaryColumnsControlV2 and update imports (#34586 ) ## Description One of the findings in usability tests is that editable fields in table tend to confuse our users. With this PR, we attempt to remove editable option in table cols. <ins>Summary of code changes</ins> This PR consists of code changes to `PrimaryColumnsControlV2.tsx` to hide the editable checkboxes in the table. All cypress changes just make sure that the we use the colSettings view to make the column editable(earlier we used checkbox there. * Removed unnecessary cypress command as well. Fixes #33888 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Widget, @tag.Table, @tag.Binding" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9904610336> > Commit: 890d9355b375e66e5e56a52464d8c0f19c759b9f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9904610336&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget, @tag.Table, @tag.Binding` > Spec: > <hr>Fri, 12 Jul 2024 09:16:41 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved inline editing functionality test by updating the method used to toggle column editability for better accuracy and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-07-12 15:29:01 +05:30
Sagar Khalasi	3078d81104	test: Updated file name for remove duplicate (#34821 ) ## Description Renamed the file name to remove duplicity for FileNames. Fixes #`34799` ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9891607703> > Commit: 0cf957b1737f7826a661676f400d965b8ebeb57e > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9891607703&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 11 Jul 2024 13:34:23 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated import paths in testing files to ensure compatibility with the latest data structure. - Enhanced test descriptions and scenarios for the Admin settings page in the Enterprise context, including redirection and button functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-07-12 10:07:17 +05:30
Jacques Ikot	34f6e32d6d	revert: change value to label in onItemSelect inside SelectCell of table widget (#34872 ) Reverts appsmithorg/appsmith#34743 ## Automation /ok-to-test tags="@tag.Table" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9888593641> > Commit: eec317589c3e8ec7fa68a85811f0fb4e7e632582 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9888593641&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table` > Spec: > <hr>Thu, 11 Jul 2024 09:38:04 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved test cases for select options in the table widget for better clarity and organization. - Updated `SelectCell` component to use option values instead of labels for item selection. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-07-11 15:08:53 +05:30
Jacques Ikot	b7853a99b2	feat: change value to label in onItemSelect inside SelectCell of table widget (#34743 ) ## Description Issue In the table widget, the select column currently displays the value from the dropdown when a user makes a selection, rather than the label. This behaviour is inconsistent with the standalone select widget, which correctly renders the label upon selection. Fix This PR addresses the inconsistency by modifying the table widget's select column to display the label of the selected item, ensuring alignment with the behaviour of the standalone select widget. Fixes #26188 ## Automation /ok-to-test tags="@tag.Table, @tag.Binding, @tag.Widget, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9843945454> > Commit: 330d0d3f82ea7a8769c350f7caa0714959838f12 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9843945454&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Binding, @tag.Widget, @tag.Sanity` > Spec: > <hr>Mon, 08 Jul 2024 18:21:02 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Updated the `SelectCell` component to use the `option.label` instead of `option.value` for item selection. - Tests - Revised test descriptions and assertions for select options in Table Widget to reflect the new functionality of using labels as values in select cells. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-07-09 09:00:00 +01:00
carinanfonseca	a2f2f795c8	chore: Turn off Allow filtering property on Table widget (#34593 ) https://github.com/appsmithorg/appsmith/issues/34591 ## Description Making _Allow filtering_ option false by default. <img width="798" alt="Allow filtering off" src="https://github.com/appsmithorg/appsmith/assets/121817440/8ac64773-2385-433d-96fa-0a90080e2462"> Fixes #34591 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table, @tag.Widget, @tag.Binding, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9795462304> > Commit: e0c1e8376b702f13b9640c880cf5606af070a420 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9795462304&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Widget, @tag.Binding, @tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Filtering is now disabled by default for the `TableWidgetV2`. - Tests - Updated test scripts to enable filtering for `TableWidgetV2` in multiple scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Jacques Ikot <jacquesikot@gmail.com>	2024-07-05 08:46:11 +01:00
Rahul Barwal	ce930598a1	feat: Refactor SelectWidget sourceData handling (#34619 ) ## Description This pull request refactors the sourceData handling in the SelectWidget component. It introduces a dynamic property path for the sourceData in the SelectWidget configuration, allowing it to be passed as a JSON string. This change ensures that the source data matches the sample data passed for the widget configuration, enabling the switching back of the JS toggle button. Additionally, it fixes cypress tests: opening of the prop pane in JS mode. Fixes #34568 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Widget, @tag.Select, @tag.Binding" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9758347627> > Commit: 01e5b4fba240667eaa0818330047489d94c01a46 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9758347627&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget, @tag.Select, @tag.Binding` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Improved stability of test scenarios by ensuring JavaScript mode is toggled appropriately. - Tests - Updated test cases to include JavaScript mode toggling for more accurate test outcomes. - Renamed and restructured test files to enhance clarity and maintainability. - New Features - Enhanced `SelectWidget` to initialize `sourceData` with a stringified array and made `sourceData` dynamically configurable. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-07-03 13:31:35 +05:30
Shrikant Sharat Kandula	b5c5fb2fb3	chore: Revert "Add dynamic property path for sourceData in SelectWidget (#34574 )" (#34618 ) /test binding <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9754334718> > Commit: 2c67d23abd75ce763c6e8eac2b1d9582bccca875 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9754334718&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Binding` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved the internal handling of `sourceData` within the Select widget for better performance and maintainability. - Tests - Updated test cases for the Select widget to reflect the new handling of `sourceData`. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-07-02 09:45:30 +05:30
Rahul Barwal	938e7b4dca	feat: Add dynamic property path for sourceData in SelectWidget (#34574 ) ## Description Add dynamic property path for sourceData in SelectWidget. Fixes #34568 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Widget" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9712372976> > Commit: c5521e46382d448715183862aededc142136db0a > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9712372976&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the Select Widget with a new property to support dynamic property paths. - Tests - Added new tests to validate the dynamic property paths functionality in the Select Widget. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-07-01 12:02:21 +05:30
Rahul Barwal	2f12030a9a	fix: Disable custom widgets for airgapped environments (#34540 ) ## Description Since custom widgets rely on react delievered from `https://cdn.jsdelivr.net`, it can't work in airgapped edition. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Widget" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9692258525> > Commit: bf3b40a5c3c51a2271347967516a53655721f7a2 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9692258525&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Custom widgets will now hide specific cards if the environment is air-gapped. - Tests - Updated test tags for custom widgets to exclude tests in air-gapped environments. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-06-27 13:47:32 +05:30
Shrikant Sharat Kandula	6f67dbd85e	test: Use `deep.eq` for comparing objects (#34513 ) The JSON string comparison is flaky because it depends on the order of keys in serialized objects. We actually don't care for the order the keys are serialized, just that the keys and values are as we want. This PR should fix that. [Slack conversation](https://theappsmith.slack.com/archives/C0134BAVDB4/p1719409620659339). /test table <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9681276909> > Commit: 3fa1746c580d700a3084d94166850acd18432d09 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9681276909&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table` <!-- end of auto-generated comment: Cypress test results -->	2024-06-26 21:16:29 +05:30
Shrikant Sharat Kandula	dc79ebb918	test: Remove unused data in DSL fixtures (#34405 ) Part of #33724. We have a lot of fixture files in our Cypress tests with DSLs of various kinds. They are used to update the DSL using the `/api/v1/layouts/{layoutId}/pages/{pageId}?applicationId={applicationId}`. This API, is [in this line in `LayoutControllerCE`](`c4e5d5e6c8/app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/LayoutControllerCE.java (L71)`), and the request body is parsed as [objects of `LayoutUpdateDTO` record](`71bc84fc76/app/server/appsmith-server/src/main/java/com/appsmith/server/dtos/LayoutUpdateDTO.java (L6)`). This `record`, accepts _only_ the `dsl` field, and nothing else. List of potential files that have this problem was identified with this command: ```sh cd app/client/cypress rg -Io 'AddDsl$".+?$' \ \| cut -d\" -f2 \ \| sort -u \ \| while read line; do if rg -q '"(layoutOnLoadActions\|layoutOnLoadActionErrors\|userPermissions\|new)":' fixtures/"$line".json; then echo $line fi done ``` (For reference, and to use on EE repo, after this is merged). /test all <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9633990737> > Commit: 9e848f1ed0c3332177d2e6c4a75e2483f045395f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9633990737&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: `` > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor3_spec.ts > <li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_1_spec.js > <li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_2_spec.js </ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Corrected the file path for loading DSL configuration in the nested list widget scenario. - Chores - Streamlined multiple JSON files by removing deprecated `layoutOnLoadActions` arrays and other obsolete fields, resulting in cleaner and more manageable configurations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-06-24 17:17:43 +05:30
Saicharan Chetpelly	092208a1c1	fix: checkbox column misalignment on table widget (#34222 ) Fixes #21790 _or_ Fixes [Issue URL](https://github.com/appsmithorg/appsmith/issues/21790) Introduced a new prop called isFullWidth for the CheckboxComponent and pass this prop to this styled component CheckboxContainer. The isFullWidth is an optional boolean property whole default value would be true. Added screenshot for reference. ![image](https://github.com/appsmithorg/appsmith/assets/119920490/1e5f3a9c-d98a-4525-85bc-8f6f471435ed) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a full-width option for checkboxes to enable better styling flexibility. - Tests - Added new test cases to verify checkbox styling properties in tables. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-06-20 11:50:37 +05:30

1 2 3 4 5 ...

315 Commits