Rishabh Rathod
d044155e23
chore: Revert "chore: delete redundant files" ( #35022 )
2024-07-18 16:18:10 +05:30
Valera Melnikov
c48aaaccd4
chore: delete redundant files ( #34858 )
...
## Description
Just small clean up.
## Automation
/ok-to-test tags="@tag.Sanity"
### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9875850734 >
> Commit: a51c05fa79d2e6b3c7e4f3cbb671e1b2a6e0b5c7
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9875850734&attempt=1 "
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 10 Jul 2024 14:34:24 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-07-11 11:49:10 +03:00
Trisha Anand
72504222e7
chore: Splitting JS Object body dump vs parsed JS Object update to remove race condition originated bad state ( #33124 )
...
## Description
> [!TIP]
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._
Fixes #`Issue Number`
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._
## Automation
/ok-to-test tags="@tag.All"
### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9029211697 >
> Commit: 190f7682cad3117e776d94f1502609026633369c
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9029211697&attempt=1 "
target="_blank">Click here!</a>
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
---------
Co-authored-by: Nidhi Nair <nidhi@appsmith.com>
Co-authored-by: Diljit VJ <diljit@appsmith.com>
2024-05-13 09:38:30 +05:30
Shrikant Sharat Kandula
97e3791d3a
chore: Add a lint step for field name constants ( #32769 )
...
We have a small linter NodeJS script that checks if any field name
constants are defined incorrectly. This PR adds this linter to the build
script, so it'll be run in CI.
2024-04-19 10:01:09 +05:30
Shrikant Sharat Kandula
41a66a1168
chore: Tiny NodeJS script as a linter for field name constants ( #31766 )
...
The point is to prevent unfortunate field name problems like this:
https://github.com/appsmithorg/appsmith/pull/31760/files .
This NodeJS script does a very rudimentary analysis on all Java files,
with a few regular expressions, and finds anomalies. As such, since it's
not very smart, it's quite strict. I intend to make it a little more
strict in the coming days, but it's a start.
It's not hooked into any processes/CI yet, but that will also come in
next. Since it's not very smart, it actually runs quite fast (.8s on
EE).
The script also doesn't exit with a non-zero exit code when it finds a
problem. Also will be solved as part of integrating it into CI.
2024-03-14 06:30:40 +05:30
Shrikant Sharat Kandula
1b6b4926e7
chore: Delete unused app/server/scripts/node
2023-08-08 06:00:48 +05:30
dependabot[bot]
e26ea6b8cb
chore(deps-dev): bump tough-cookie from 4.0.0 to 4.1.3 in /app/server/scripts/node ( #25220 )
...
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie ) from
4.0.0 to 4.1.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/salesforce/tough-cookie/releases ">tough-cookie's
releases</a>.</em></p>
<blockquote>
<h2>4.1.3</h2>
<p>Security fix for Prototype Pollution discovery in <a
href="https://redirect.github.com/salesforce/tough-cookie/issues/282 ">#282</a>.
This is a minor release, although output from the <code>inspect</code>
utility is affected by this change, we felt this change was important
enough to be pushed into the next patch.</p>
<h2>4.1.2 -- Patch and Bugfix Release</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: allow set cookies with localhost by <a
href="https://github.com/colincasey "><code>@colincasey</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/253 ">salesforce/tough-cookie#253</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/salesforce/tough-cookie/compare/v4.1.1...v4.1.2 ">https://github.com/salesforce/tough-cookie/compare/v4.1.1...v4.1.2 </a></p>
<h2>4.1.1</h2>
<h2>Patch Release</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: allow special use domains by default by <a
href="https://github.com/colincasey "><code>@colincasey</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/249 ">salesforce/tough-cookie#249</a></li>
<li>4.1.1 Patch -- allow special use domains by default by <a
href="https://github.com/awaterma "><code>@awaterma</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/250 ">salesforce/tough-cookie#250</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/salesforce/tough-cookie/compare/v4.1.0...v4.1.1 ">https://github.com/salesforce/tough-cookie/compare/v4.1.0...v4.1.1 </a></p>
<h2>4.1.0</h2>
<p>v4.1.0</p>
<p>Minor release, focused mainly on resolving reported issues and some
minor feature work.</p>
<h2>What's Changed</h2>
<ul>
<li>Create CHANGELOG.md by <a
href="https://github.com/ShivanKaul "><code>@ShivanKaul</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/189 ">salesforce/tough-cookie#189</a></li>
<li>Missing param validation issue145 by <a
href="https://github.com/medelibero-sfdc "><code>@medelibero-sfdc</code></a>
in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/193 ">salesforce/tough-cookie#193</a></li>
<li>Create SECURITY.md by <a
href="https://github.com/ShivanKaul "><code>@ShivanKaul</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/201 ">salesforce/tough-cookie#201</a></li>
<li>Create CODE_OF_CONDUCT.md by <a
href="https://github.com/ShivanKaul "><code>@ShivanKaul</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/200 ">salesforce/tough-cookie#200</a></li>
<li>Fix for issue <a
href="https://redirect.github.com/salesforce/tough-cookie/issues/195 ">#195</a>
by <a
href="https://github.com/medelibero-sfdc "><code>@medelibero-sfdc</code></a>
in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/202 ">salesforce/tough-cookie#202</a></li>
<li>Add explanation and more special-use domains by <a
href="https://github.com/ShivanKaul "><code>@ShivanKaul</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/203 ">salesforce/tough-cookie#203</a></li>
<li>Sync of constructor options for serialization by <a
href="https://github.com/medelibero-sfdc "><code>@medelibero-sfdc</code></a>
in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/204 ">salesforce/tough-cookie#204</a></li>
<li>Returned null in case of empty cookie value by <a
href="https://github.com/vsin12 "><code>@vsin12</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/196 ">salesforce/tough-cookie#196</a></li>
<li>132 str trim not a function by <a
href="https://github.com/awaterma "><code>@awaterma</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/209 ">salesforce/tough-cookie#209</a></li>
<li>Fix for issue <a
href="https://redirect.github.com/salesforce/tough-cookie/issues/153 ">#153</a>
by <a
href="https://github.com/medelibero-sfdc "><code>@medelibero-sfdc</code></a>
in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/210 ">salesforce/tough-cookie#210</a></li>
<li>Fix permuteDomain with trailing dot by <a
href="https://github.com/ruoho-sfdc "><code>@ruoho-sfdc</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/216 ">salesforce/tough-cookie#216</a></li>
<li>Issue <a
href="https://redirect.github.com/salesforce/tough-cookie/issues/213 ">#213</a>
-- added gh-actions flow for building and testing tough-co… by <a
href="https://github.com/awaterma "><code>@awaterma</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/218 ">salesforce/tough-cookie#218</a></li>
<li>Issue <a
href="https://redirect.github.com/salesforce/tough-cookie/issues/210 ">#210</a>
-- Updated workflow to use npm install. by <a
href="https://github.com/awaterma "><code>@awaterma</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/220 ">salesforce/tough-cookie#220</a></li>
<li>@<a
href="https://redirect.github.com/salesforce/tough-cookie/issues/215 ">GH-215</a>
-- Tests that document localhost behavior when set as domain. by <a
href="https://github.com/awaterma "><code>@awaterma</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/221 ">salesforce/tough-cookie#221</a></li>
<li>fix: MemoryCookieStore methods should exist on the prototype, not on
the class. by <a
href="https://github.com/wjhsf "><code>@wjhsf</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/226 ">salesforce/tough-cookie#226</a></li>
<li>Unit test cases for <code>allowSpecialUseDomain</code> option by <a
href="https://github.com/colincasey "><code>@colincasey</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/225 ">salesforce/tough-cookie#225</a></li>
<li>[Snyk] Upgrade universalify from 0.1.2 to 0.2.0 by <a
href="https://github.com/snyk-bot "><code>@snyk-bot</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/228 ">salesforce/tough-cookie#228</a></li>
<li>React Native Support by <a
href="https://github.com/colincasey "><code>@colincasey</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/227 ">salesforce/tough-cookie#227</a></li>
<li>Adding Updating CODEOWNERS with ECCN as per Export Control
Compliance by <a
href="https://github.com/svc-scm "><code>@svc-scm</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/223 ">salesforce/tough-cookie#223</a></li>
<li>fix: domain match routine by <a
href="https://github.com/colincasey "><code>@colincasey</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/236 ">salesforce/tough-cookie#236</a></li>
<li>Stop using the internal NodeJS punycode module by <a
href="https://github.com/gboer "><code>@gboer</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/238 ">salesforce/tough-cookie#238</a></li>
<li>Initial documentation review by <a
href="https://github.com/mcarey86 "><code>@mcarey86</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/234 ">salesforce/tough-cookie#234</a></li>
<li>fix: distinguish between no samesite and samesite=none by <a
href="https://github.com/colincasey "><code>@colincasey</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/240 ">salesforce/tough-cookie#240</a></li>
<li>Prepare tough-cookie 4.1 for publishing (updated GitHub actions,
move… by <a
href="https://github.com/awaterma "><code>@awaterma</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/242 ">salesforce/tough-cookie#242</a></li>
<li>4.1.0 release to NPM by <a
href="https://github.com/awaterma "><code>@awaterma</code></a> in <a
href="https://redirect.github.com/salesforce/tough-cookie/pull/245 ">salesforce/tough-cookie#245</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="4ff4d29f6chttps://redirect.github.com/salesforce/tough-cookie/issues/284 ">#284</a>)</li>
<li><a
href="12d474791bhttps://redirect.github.com/salesforce/tough-cookie/issues/283 ">#283</a>)</li>
<li><a
href="f06b72d1d4b1a8898ee3https://redirect.github.com/salesforce/tough-cookie/issues/253 ">#253</a>)</li>
<li><a
href="ec707966e6https://redirect.github.com/salesforce/tough-cookie/issues/250 ">#250</a>)</li>
<li><a
href="d4ac5801ddhttps://redirect.github.com/salesforce/tough-cookie/issues/249 ">#249</a>)</li>
<li><a
href="79c2f7d373https://redirect.github.com/salesforce/tough-cookie/issues/245 ">#245</a>)</li>
<li><a
href="4fafc179a7aa4396da7ahttps://redirect.github.com/salesforce/tough-cookie/issues/240 ">#240</a>)</li>
<li><a
href="b8d751188dhttps://redirect.github.com/salesforce/tough-cookie/issues/234 ">#234</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/salesforce/tough-cookie/compare/v4.0.0...v4.1.3 ">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/appsmithorg/appsmith/network/alerts ).
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-04 15:30:35 +05:30
Ankita Kinger
3933f5f4d1
feat: migrate from org to workspace under phase 3 ( #14158 )
...
* migration from organization to workspace on code level
* updated a few more files
* fixed runtime errors
* update org settings URL
* Renamed organizationId in domain objects
* changed field named from organization to workspace
* Reverted AppsmithRole changes
* fixed migrations
* recreating indexes
* migration update
* seed data runs before migration, undo changes
* mock commit
* seedmongo to populate upgraded data, datasource upgrade
* fixed two test cases
* updated migrations
* updated prop name
* Upgraded AclPermission
* comment
* migrated AppsmithRole
* more changes
* final set of changes
* variable name changes
* update cypress variable name
* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ApplicationControllerCE.java
* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/Datasource.java
Co-authored-by: Trisha Anand <trisha@appsmith.com>
* reverting encryption handler change
* refactor code to migrate from org to workspace
* migrated a few missed out org to workspace
* updated a few more
* migrated a few missed out org to workspace
* migration changes
* Removed Permission import
* reverted code change
* few more changes
* fixed failing cypress test
* fixed failing cypress test
Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Sidhant Goel <sidhant@hexcod.in>
2022-07-20 17:24:16 +05:30
dependabot[bot]
c3c54b01b0
chore: bump follow-redirects in /app/server/scripts/node ( #12038 )
...
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects ) from 1.14.7 to 1.14.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases )
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.9 )
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-24 15:47:11 +05:30
Bharat Patodi
743d6cb00d
chore: Replace equality and inequality operators with their strict versions ( #7585 )
...
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2022-02-03 09:42:38 +05:30
dependabot[bot]
d73b075aa2
chore: bump follow-redirects from 1.14.3 to 1.14.7 in /app/server/scripts/node ( #10413 )
...
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects ) from 1.14.3 to 1.14.7.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases )
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.3...v1.14.7 )
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-15 03:43:12 +05:30
Shrikant Sharat Kandula
9202c0bf67
Fix Docker buildx images
...
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-17 10:27:56 +05:30
Shrikant Sharat Kandula
31da3ea9ef
Load Docker buildx images for testing
...
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-17 10:26:30 +05:30
Sheetal Patel
f939ebbe8a
chore: Fixing yoda conditions in the code ( #8297 )
2021-10-08 22:21:24 +05:30
dependabot[bot]
02784d9b4e
chore(deps-dev): bump axios in /app/server/scripts/node ( #7318 )
...
Bumps [axios](https://github.com/axios/axios ) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/axios/axios/releases )
- [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md )
- [Commits](https://github.com/axios/axios/compare/v0.21.1...v0.21.2 )
---
updated-dependencies:
- dependency-name: axios
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-09-09 22:14:58 +05:30
Dwayne Forde
51ccd19081
Use IPv4 on WSL machines ( #2729 )
...
WSL has issues when handling IPv6 ips. In order to resolve this, on dev machines, we now check if it's a WSL environment. If yes, we default to using IPv4 instead of IPv6.
2021-01-28 12:08:44 +05:30
dependabot[bot]
0ab61079e2
Bump axios from 0.19.2 to 0.21.1 in /app/server/scripts/node ( #2462 )
...
Bumps [axios](https://github.com/axios/axios ) from 0.19.2 to 0.21.1.
- [Release notes](https://github.com/axios/axios/releases )
- [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md )
- [Commits](https://github.com/axios/axios/compare/v0.19.2...v0.21.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-07 17:38:24 +05:30
dependabot[bot]
41a51c2885
Bump bl from 2.2.0 to 2.2.1 in /app/server/scripts/node ( #496 )
...
Bumps [bl](https://github.com/rvagg/bl ) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/rvagg/bl/releases )
- [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:52:35 +05:30
Shrikant Sharat Kandula
54c75b26dd
Add a node.js script to dump examples organization ( #448 )
...
* Add a node.js script to dump examples organization
This dump file is used to setup initial examples organization
in a self-hosted setup.
* Remove unused variable
* Add npm run shortcut for dump script
2020-09-02 17:15:55 +05:30
nupur
d0e60a1890
Mysql plugin integration ( #53 )
...
This commit adds the Mysql plugin to the Appsmith server. We also add a migration to ensure that this plugin is installed by default for all existing organizations. The migration also adds the plugin details into the DB.
Also adding the test cases for mysql plugin.
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Hetu Nandu <hetu@appsmith.com>
Co-authored-by: Arpit Mohan <me@arpitmohan.com>
Co-authored-by: Nupur Singhal <nupursinghal@Nupurs-MacBook-Air.local>
2020-07-21 16:01:42 +05:30
Shrikant Sharat Kandula
56547ec02f
Move application configuration to be loaded from environment variables ( #23 )
...
* Move application configuration to be loaded from environment variables
* Remove unused sentry.properties
* Make missing value sentinel a constant and ignore all *.env files
* Removed now-used ACL properties
* Prefix RapidAPI environment variable with APPSMITH_
* Fix application properties not being loaded into static fields
* Remove application-test.properties file
* Add required env variables for test in GitHub
* Quote URLs for MongoDB and Redis in test config
* Change RAPIDAPI to RAPID_API in environment variable names
* Source .env file in the root of repo in start script
2020-07-06 14:35:56 +05:30
Shrikant Kandula
18476432ac
Don't invite users if they have any access in an org, not just admin.
2020-06-12 17:48:35 +05:30
Shrikant Kandula
b391f46e2c
ACL Migration Script
2020-06-12 11:54:21 +00:00
