Commit Graph

8642 Commits

Author SHA1 Message Date
Trisha Anand
122b5388ac
chore: use read permission to fetch pages in edit mode (#18944) 2022-12-14 13:02:17 +05:30
Aman Agarwal
cb1b0b5aa3
fix: removed old key_val_input, updated keyval_array, show ds info (#18626)
fix: removed old key_val_input, updated keyval_array, show ds info
2022-12-13 20:09:16 +05:30
Ayangade Adeoluwa
2cc64183c8
fix: Error handling for undefined datasource in API Authentication (#18881) 2022-12-13 17:16:56 +05:30
Ankit Srivastava
9f84298dcf
fix: Login password length upper limit changed from 48 to 256 characters (#18176)
* fix - login password length upper limit removed

* removed unused variables

* password max limit of 256 characters

Co-authored-by: Anubhav <anubhav@appsmith.com>
2022-12-13 16:40:47 +05:30
Rishabh Kashyap
26c01b35e9
feat: add tooltip property to select widgets (#18480) 2022-12-13 16:05:08 +05:30
Ankit Srivastava
236214f182
fix: treat empty valued env variables as false | FE (#18428)
* converting empty env values to boolean before storing in store

* triming and checking empty values

* Empty commit for test

Co-authored-by: Anubhav <anubhav@appsmith.com>
2022-12-13 15:38:37 +05:30
Hetu Nandu
c5ae0521ec
fix: Modal opening or closing type error (#18913)
fix for sometimes widget not available
2022-12-13 15:34:32 +05:30
Sangeeth Sivan
44c9a261f9
fix: datasource active tab options menu is not permission driven (#18863)
* fix: ds active tab menu

* fix: condition
2022-12-13 15:01:46 +05:30
Sangeeth Sivan
3d8650db4d
fix: publishing an app removes page permissions (#18865)
* fix: page permissions for deployed app

* fix: use the selector with select
2022-12-13 14:49:22 +05:30
Vaibhav Tanwar
770afde191
fix: Execute api pagination fix (#17886)
Query parameters encoding parameter added for paginated prev and next url.
2022-12-13 09:07:15 +00:00
Bhuvaneswari Pathsamatla
6e49dff020
chore: rename actions for REST and GraphQL in datasource pane (#18114) 2022-12-12 22:33:10 +05:30
Apeksha Bhosale
efa8b68a47
fix: Parse js actions for view mode changes (#18357)
* added new function inside parse js actions for view moe

* fixing test cases

* added evaluateSync with isTriggered false

* Add types
Add switch case for diff.event
Add function get back app mode

* Change foreach loops to for of

* Dont return jsUpdates from view mode save resolved since no operation is happening
Change viewModeSaveResolvedFunctionsAndJSUpdates -> viewModeSaveResolvedFunctions to reflect
what it's functionality is

* Refactor JSObject code

* Refactor code for JSobject
* remove any
* export parsed object's type from ast
* create function for deleteResolvedFunctionsAndCurrentJSCollectionState

* Code review changes

* Fix tests

* Change returns in for of loops to continue
Remove try for evaluate sync
Js updates return

* Fix bug

* Fix bug

Co-authored-by: Rimil Dey <rimil@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-12 19:45:40 +05:30
Shrikant Sharat Kandula
e4476e2893
chore: Fix more potential race condition in sending emails (#18884)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-12 16:12:39 +05:30
Ankita Kinger
35a9188111
fix: Updating the logic for getting tenant permissions to show new workspace button (#18874) 2022-12-12 16:09:42 +05:30
Shrikant Sharat Kandula
1bf842b525
chore: Fix potential race condition in sending email (#18882)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-12 15:34:46 +05:30
Anand Srinivasan
5627c3e8aa
chore: update import to fix compilation issue (#18875) 2022-12-12 13:33:51 +05:30
GitStart-Appsmith
618626f6a4
feat: [APPSMTH-22] Execute action on widget focus and blur (#18128)
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-12 12:39:22 +05:30
Nidhi
5329010415
fix: Refactor entities based on AST parsing logic (#18517)
* feat: Refactor entities based on AST parsing logic

* Deleted jmh file

* rts updates for the edge cases

* adding jest test cases

* update review comments

* Fixed issue with references outside of bindings and some other stuff

* Added tests for DSLUtils

* bug fix 18699

* Test fixes

* Test fixes

* Review comments

* Changed type to boxed

Co-authored-by: ChandanBalajiBP <chandan@appsmith.com>
Co-authored-by: ChandanBalajiBP <104058110+ChandanBalajiBP@users.noreply.github.com>
2022-12-12 08:12:21 +03:00
Anand Srinivasan
284571803b
fix: update settings pane validations (#18739)
* init fix

* button style update

* decode url in preview

* bring back custom slug validation

* custom slug validation on type

* remove imports

* handle special characters in url preview

* change label

* code clean up

* remove pageId from action name selector

* messages clean up

* tests for validations

* cypress cases update

* Renamed helper methods

* add index for test cases

* AppSettings specs script ts updates

* Added Bud id in title #18698

* GIt Import spec fix

* GItImport spec fix

* Git import unskip

* Skipping Git import

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-12 10:21:14 +05:30
ashit-rath
f67f8571ec
refactor: JSONForm eliminate the use of canvasWidgets and remove childStylesheet from dynamicBindingPathList (#18715)
* refactor: JSONForm eliminate the use of canvasWidgets and remove childStylesheet from dynamicBindingPathList

* review changes

* fixed field reset on deploy

* reverted prevSourceData changes
2022-12-12 10:13:18 +05:30
akash-codemonk
a6df3a6deb
chore: add analytics for page creation ctas (#18676) 2022-12-12 10:12:17 +05:30
ankurrsinghal
432e513678
fix: modal deselect issue auto height (#18750)
modal deselect issue fixed when dynamicHeight property is changed
2022-12-11 20:51:46 +05:30
Aswath K
ce2925cafc
feat: Property pane search (#18164) 2022-12-11 20:12:32 +05:30
Ankita Kinger
9899eaa0c3
fix: Left panel not scrollable on Admin settings page when the list is too long (#18845) 2022-12-11 18:21:52 +05:30
sidhantgoel
4501434ede
chore: Synchronize Page,Action and ActionCollection object from original corresponding object (#18846)
Synchronize Page,Action and ActionCollection object from original corresponding object
2022-12-11 12:23:45 +05:30
rahulramesha
a1973b81a3
Fix: Context switching UX issues (#18828)
* fix Property panel jitters on focus

* open widget entity on widget selection

* Remove retaining Datasources url on page change

* fix param string while restoring URLs

* add cypress test
2022-12-10 23:59:36 +05:30
f0c1s
2ce9665b61
chore: add some more audit logs analytics (#18738) 2022-12-10 14:56:29 +05:30
Ankita Kinger
d9f20e33ad
chore: splitting the role name to avoid showing workspace name next to it (#18830)
* splitting the role name to avoid showing workspace name next to it

* fixing cypress tests failures
2022-12-10 14:00:28 +05:30
Shrikant Sharat Kandula
e12b865bf2
Fix logos in email templates (#18835)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-10 08:02:37 +05:30
Parthvi
aafaa8abfa
test: fix flaky tests (#18603)
* Update GitImport_spec.js

* fix flaky tests

* skip git import tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-12-09 19:46:51 +00:00
Ayangade Adeoluwa
aec6296e2c
fix: query command value from being reset to an empty state (#18559)
* Fixes query command value from being reset to an empty state

* Fix merge issues
2022-12-09 16:58:36 +00:00
Pawan Kumar
d7e2c491e0
feat: Branding (#18717)
* add branding for ce

* add ce changes

* update colorpicker ux

* remove unsued flag

* Add new email templates

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* add local appsmith logo

* code review feedback fixes + qa fixes

* remove forward slash in url of favicon

* fix message

* Fix tests

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* update messages

* Fix tests (again)

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* update messages

* fix cypress tests

* skipping app layout test cases

* fix cypress tests

* remove it.only

* try moving test

* use stable DS version

* remove __diff

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-09 20:13:47 +05:30
Satish Gandham
03703ff044
ci: Ship source maps + fix perf test failures on EE (#18700)
* - Add missing env variables to fix perf tests failures in EE

* - Delete source maps on CI only for EE

* - Add the additional steps that might be required for running perf tests on EE

* Update if condition

* Update if condition

* Switch to bash from using sh in build.sh

* Check if the server started later

* Update the check to see if the server has started

Co-authored-by: Satish Gandham <hello@satishgandham.com>
2022-12-09 18:40:59 +05:30
Nirmal Sarswat
9f0b9ee94b
fix: Filtering out empty value env variables from /admin/env API response in backend (#18430)
* Filtering out empty value env variables from /admin/env API response in backend

* adding UT for getAllNonEmpty;
2022-12-09 17:17:26 +05:30
sneha122
c094a28c40
fix: gsheet multiline broken formatting fixed (#18552)
* gsheet multiline broken formatting fixed

* junit test added

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-12-09 15:53:55 +05:30
Sangeeth Sivan
ab00c3dda4
fix: hide workspace menu options trigger when there are no permissions (#18742)
* fix: variable mismatch fix

* fix: updated to use the right boolean flag

* fix: workspace menu order
2022-12-09 15:46:00 +05:30
sneha122
c460154c43
fix: datasource discard popup issue fixed (#18761)
* datasource discard popup issue fixed

* cypress code review changes

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-12-09 15:29:35 +05:30
Shrikant Sharat Kandula
cf81c14ec2
chore: Add multipart payload support for admin settings (#18434) 2022-12-09 13:46:14 +05:30
Souma Ghosh
0395457e51
feat: Add Series Colour property for default charts (#18229)
* Adds functionality for Series Color property

* fix an issue where chart was breaking when color property is not provided

* Changes Series Color field to Color Picker type input
Default color set as primary theme color

* Under development
- Some bug fixes to the series colour feature

* Fix issue with second series color not being applied correctly
New property placeholderText for ColorPickerComponentV2
Disable series color feature for Pie Chart
Code clean up
2022-12-09 12:47:21 +05:30
Anand Srinivasan
84426b9c41
chore: update smartlook client (#18784)
update smartlook client
2022-12-09 11:45:14 +05:30
Aishwarya-U-R
70f6cd1ab8
test: Automated tests for Bug18376 + few flaky fixes (#18769)
* ApiOnload spec fix

* Bug 18376 script added

* Bug 18376 script fix

* ValidateURL() added

* OnLoadTests/APIOnLoad_Spec.ts fix

* Moved Bug 16248 script

* JSOnload trial fix

* JsonLoad fix -disbaling not working hnce commented

* Skipping GitImport (merge issue-open bug 18776)

* Git imPort trial fix

* PassingParams spec update

* APIPage.ts wrong update corrected

* Removed added comments

* ApiPage.ts mistake corrected!
2022-12-09 10:36:52 +05:30
Ankita Kinger
df8add5e0c
chore: Updating the text from enterprise to business to maintain consistency (#18787)
* updating the text from enterprise to business to maintain consistency

* minor change

* Omnibar fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-09 00:08:42 +05:30
Aman Agarwal
1bcb321ec3
fix: gs quick wizard table header index (#18242)
* fix: gs quick wizard table header index

* fix: disable generate button if error

* Omni spex fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-08 22:20:51 +05:30
Vishnu Gp
a1702d9b2e
fix: Corrected action execution analytics event (#18783) 2022-12-08 21:05:34 +05:30
Hetu Nandu
3b98c8f7fe
feat: Command click navigation via code (#18326) 2022-12-08 17:46:41 +05:30
rahulramesha
3bb9e96e39
feat: [Context Switching] Complex widgets and other Phase 2 items (#17046)
This PR contains changes to retain context on the following items,
Leaving and then returning to a page should maintain what api/query was open
Entity explorer should stay as you left it when you left the page (collapse levels)
Widget/explorer tab
Width - Should be the same across all pages of an app
Property Pane width
Complex widgets, multi tier property panes

Co-authored-by: hetunandu <hetunandu@gmail.com>
Co-authored-by: Akash N <akash@codemonk.in>
Co-authored-by: Hetu Nandu <hetu@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-08 12:51:58 +05:30
Ankita Kinger
10bdbed0e3
refactor: Updating upgrade flows to start using upgrade hook for better code reusability (#18735)
* updated upgrade flow for authentication page to start using upgrade hook

* using the upgrade hook on upgrade pages as well

* adding RBAC feature flag
2022-12-08 10:48:03 +05:30
Ankita Kinger
a0211f5eed
fix: fetching the plugin form config for queries if datasource is not viewable (#18749)
fetching the plugin form config for queries if datasource is not viewable
2022-12-08 09:06:35 +05:30
Nilansh Bansal
669120b3a6
fix: fork template tracking (#18727)
fix: fork_APPLICATIONTEMPLATE event tracking added to merge template api (#18416)
2022-12-08 02:32:23 +00:00
Rishabh Kashyap
2213a61357
fix: resetting audio and video widget (#18126)
* bug for audio and video widget fixed

* cypress test for audio widget

* audio and video updated cypress tests

* cypress test cases updated

* writing logic for video widget

* working on video widget

* intermediate logic

* inbetween logic

* updateWidgetMetaProperty removed from onEnded event

* this.props.playing logic in onPlay & onPause events

* test code

* test code

* Add comment

* audio widget updated; comments for audio and video widget

* cypress changes

* removed cypress credentials

* comments updated

* change in comments and cypress test cases

* feedback incorporated

* comments added to audio and video spec files

* video spec updated

* video spec updated

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-12-07 20:40:28 +05:30