Commit Graph

8029 Commits

Author SHA1 Message Date
subratadeypappu
0e2637b1b2
chore: Modified action execution payload to support data types (#16106)
* POC: Datatype handling autogenerated naming params client

* added array and file datatype

* handles all primitive types

* paramproperties convetred to map instead of array

* parametermap inversion

* handled no bindings bug

* feat: Consume action execution payload changes w.r.t. data type mapping (#15555)

This commit does the following things
1. It consumes data type metadata from payload
2. It consumes the mapping between the pseudo binding name and original binding name
3. It doesn't apply any logic w.r.t. data type identification after consumption

* added comments and cleaned code with proper datatypes

* removed URLencoding for binding params names

* feat: Remove URL decoding on param keys from server-side codebase (#15555)

* Remove unused import (#15555)

Co-authored-by: ChandanBalajiBP <chandan@appsmith.com>
2022-08-19 01:01:47 +05:30
Aman Agarwal
14262e1601
fix: old column names exists even after renamed columns (#16076) 2022-08-18 21:53:24 +05:30
Aishwarya-U-R
1164b72db2
test: Fixing http-proxy version (#16138) 2022-08-18 18:57:45 +05:30
Bhavin K
d48976105d
fix: search functionality in tree select (#16073) 2022-08-18 16:00:37 +05:30
Nidhi
cdb70066b6
fix: Logging execute events again (#16125)
Execute action triggered events were not getting logged because of a lack of subscription. Fixed in place.

## Type of change
- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
- Locally connected to segment

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-08-18 13:40:29 +05:30
Tolulope Adetula
e36a28d7da
feat: Select default value control (#15856)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests

* Fix: default value issue

* Merge branch 'release' into fix/Select-default-Value-validation

* Fix: Default Value Control

* fix: updated Multiselect

* Fix: issues with curly braces

* fix: Serverside filtering issue

* fix: revert commit

* Fix: empty commit

* fix: copy-paste widgets

* fix: use WidgetOperationSaga to fix copy-paste

* fix: update comment

* feat: add test for copy-past Select and MultiSelect
2022-08-18 08:10:58 +01:00
Aishwarya-U-R
ba9e4458a2
Automated test for JSObj OnPageLoad + flaky fixes + fix for timeout runs (#16028) 2022-08-18 12:00:28 +05:30
Pawan Kumar
ea04404de9
fix: Reskinning Input Widgets (#15546)
* update checkbox

* fix margin in checkbox

* fix color bug

* fix border radius

* fixes

* remove unused imports

* bug fixes

* ui fixes

* code review feedback fixes

* css updates for toggle

* fix bg bug in checkbox

* fix disabled checkbox style

* update styles for radio and switch

* update label align

* add hover interaction for switch

* add wds css variables

* add error state

* add error state

* fix css variable

* fix css

* fix checkbox group column height

* move checkbox icons to assets

* update input

* fix input

* fix input

* fix input fix

* fix disalbed icon color

* empty commit to deploy again

* address review feedbacks

* fix font in dropdown

* fix colors

* fix search icon alignment

* fix space in right cross icon

* fix colors and label alignment

* fix margin top in tooltip

* replace red color with css variable

* Json form field spec fix

* fix css variable typo in checkbox

* fix css variable typo in checkbox

* fix label spec

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-18 11:56:07 +05:30
arslanhaiderbuttar
e9bc7063b6
Fix TED run command updated (#16089) 2022-08-18 10:09:12 +05:30
Aswath K
6645413dec
chore: Grouping & reorganisation of Table Widget (#15638) 2022-08-17 23:53:53 +05:30
Tolulope Adetula
7a3784e50e
fix: prevent children rerender in listwidget (#16015)
* fix: move to deepEqual

* fix: performance issue

* fix: improve code using klona import

* fix: refactor function
2022-08-17 22:26:19 +05:30
Favour Ohanekwu
b4875193c1
Fix set button type to prevent reload of page when clicked (#16090)
For most browsers the default type of button is submit, this could cause the page to reload when clicked. Setting button type to button, prevents this behavior.
2022-08-17 17:28:23 +05:30
Favour Ohanekwu
7c5f6c4bd4
Fix Show invalid page UI for invalid jsobject page (#16056) 2022-08-17 17:27:54 +05:30
Favour Ohanekwu
950e57aab7
Fix error with undefined triggerpath dependency (#16037)
Return early for undefined trigger field dependency
2022-08-17 13:57:59 +05:30
Sangeeth Sivan
3da13577f1
chore: integrate msw to browser to mock api requests (#15965)
* feat: msw browser integration to mock apis on dev

* chore: dynamic import to code split worker

* refactor: added new line at end of file
2022-08-17 12:01:55 +05:30
albinAppsmith
eeb94b3132
feat: updated design system package to 1.0.13 (#16033)
* feat: updated design system package to latest version

* added yarn lock
2022-08-17 11:37:03 +05:30
Ankita Kinger
dbbae79aec
feat: refactor invite modal UI (#15957)
* updated ads components required for invite modal refactoring

* removed unused code

* minor css changes

* implemented pr suggestions

* minor fix
2022-08-17 11:00:47 +05:30
Sangeeth Sivan
5e2e701220
feat: added support for loaders / spinners in table component. (#15683)
* feat: added loader/spinner support for table

* added empty data state in table

* updated no data UI for table

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-08-16 16:48:12 +05:30
Satish Gandham
3990162ca6
ci: Update the access token in ci script. (#16032)
* Clean up the perf folder and update integration commnds to use the new repo

* Use a different token for github auth

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-08-16 14:33:55 +05:30
akash-codemonk
583320bea6
fix: hide explorer menu on scroll (#15537) 2022-08-16 14:18:47 +05:30
Satish Gandham
a76fd48ddc
chore: Update integration script to use performance testing code from private repo (#15991)
Clean up the perf folder and update integration commnds to use the new repo

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-08-16 11:54:13 +05:30
Souma Ghosh
44d1885ae9
fix: Text getting clipped for Italic font in Table Widget V1 (#15549) 2022-08-16 11:12:31 +05:30
arslanhaiderbuttar
9277274b13
Removed the conflicting part with TED (#16022) 2022-08-16 11:01:25 +05:30
NandanAnantharamu
b6b762f623
Updated default-meta fix (#16003) 2022-08-16 10:31:12 +05:30
Aishwarya-U-R
820846ce8b
Cypress version upgrade for timeout issue resolution (#15917) 2022-08-16 09:31:16 +05:30
Bhavin K
0aafa388ec
fix: navigation issue in the Iframe widget due to src change (#15656)
* fix: navigation issue in the Iframe widget due to src change

* test: added test case for the iframe widget
2022-08-16 09:12:38 +05:30
Souma Ghosh
4acf5aa59c
fix: Cell background colour not applied to new columns in table widget (#15898) 2022-08-15 17:27:28 +05:30
Aman Agarwal
e6a6ceaebc
RTS Docker image build error (#16010) 2022-08-15 15:23:58 +05:30
Aswath K
b88564d96a
fix: unable to remove Icon on Input widget (#16007) 2022-08-15 09:44:58 +00:00
Aswath K
359d09d53e
chore: Grouping & reorganisation for Toggle widgets (#15706) 2022-08-15 13:35:46 +05:30
Aswath K
759ad4fda4
chore: Grouping & Reorganisation for Select Widgets (#15831) 2022-08-15 13:08:30 +05:30
Manish Kumar
fcfc3d97dc
feat: Making the error messages in amazon s3 plugin informative (#15861)
* feat: make AmazonS3 plugin error messages more readable. #8664

* added curly braces in if/else block

* modified according to PR review comments

* modified according to PR review comments

* This commit introduces readable errors for S3 Datasource: https://github.com/appsmithorg/appsmith/issues/8554
It changes three files:
	*AmazonS3ErrorUtils.java
	*AmazonS3PluginTest.java
	*AmazonS3ErrorUtilsTest.java

This commit has been tested:
	*manual testing
	*Junit testing

* This feature-commit introduces readable errors for S3 Datasource: https://github.com/appsmithorg/appsmith/issues/8554
It changes three files:
	*AmazonS3ErrorUtils.java
	*AmazonS3PluginTest.java
	*AmazonS3ErrorUtilsTest.java

This commit has been tested:
	*manual testing
	*Junit testing

* added new line in the AmazonS3ErrorUtilsTest.java

* * Ommited unused imports in following files:
	* AmazonS3ErrorUtils.java
	* AmazonS3PluginTest.java
	* AmazonS3ErrorUtilsTest.java

* Moved test functions
* combined instance checking for AmazonServiceException and its subclass

* removed unused imports from AmaxonS3UtilsTest.Java

Co-authored-by: somna <somnathdasadhikari@gmail.com>
2022-08-15 10:48:20 +05:30
Aman Agarwal
ba9281cf77
fix: rts version file moved to src (#15963) 2022-08-12 21:10:50 +05:30
Keyur Paralkar
d39cecbbb4
feat: chartwidget reskin feedback (#15621)
* style: added styles to chart configs

* style: adjusted axis names and legend position

* style:
* adjusting legend position
* removed background property at the widget level
* exposed current theme data at widget level

* fix: addressed feedback on chart widget reskin

* fix:
* style according to feedback
* styled custom charts

* fix:
* added migration for accentColor and fontFamily
* implemented reskinning feedback

* fix: changed the position of properties in custom chart config

* fix:
* added unit test for migration
* changed the caption color

* fix: spacing fix

* fix: added accentColor and fontFamily defaults

* test: added cypress test for chart reskinning

* test: fixed cypress test failure
2022-08-12 17:40:17 +05:30
Aswath K
b77a8cae81
feat: JS toggle for icon property of Inputs (#15947) 2022-08-12 14:35:37 +05:30
Ayangade Adeoluwa
0e36569b06
feat: Abort Query Execution (#15775)
* Snaps response view to certain height and adds abort query execution feature

* make raw string a constant

* Add cypress tests

* Remove theme variable

* move raw strings to constants in messages.ts file

* Fix test case description

* Comment out query abort action execution

* cy fix

* Fix abortion of parallel action execution like onPageLoad

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-12 12:49:17 +05:30
Pawan Kumar
a5733da363
fix: Cypress tests for admin settings's watermark setting (#15760) 2022-08-11 17:35:08 +02:00
Aman Agarwal
3b00508c1e
feat: ast mono repo poc (#15610)
* POC for Shared AST Logic using Yarn Symlinks

* fix: preinstall script for bundling shared packages

* Merge commit

* fix: updated the script to link, unlink the package as shared dep

* fix: updated dependencies

* Add a post-install script and fix yarn.lock file

* Remove commented code

* fix: added verification script, readme, moved scripts to shared

Co-authored-by: Ayangade Adeoluwa <adeoluayangade@yahoo.com>
2022-08-11 20:59:26 +05:30
Aswath K
ee32ffb76f
chore: Grouping & reorganisation for Input widgets (#15584) 2022-08-11 16:50:09 +05:30
Trisha Anand
48ab154cf1
chore: Removing debug feature flag logs from the server (#15931) 2022-08-11 12:50:37 +02:00
Nidhi
10c9f77359
fix: Make default DB compulsory in URI string format (#15881)
* fix: Use admin as default database when no Mongo DB is specified

* fix: Make default db compulsary instead

* Added back check during execution per review

* Json field spec fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-11 15:35:27 +05:30
Rishabh Rathod
e255593e28
fix: Improve Autocomplete for local vars, JSObject & ButtonGroup Widget
Add Autocomplete support for
- local variables 
- JSObjects
- ButtonGroupWidget
Remove Autocomplete suggestion for
- `eval`
-  undefined global values like `tabs`
2022-08-11 15:29:38 +05:30
albinAppsmith
1a6936435d
fix: design system package conflict with styled-component (#15914) 2022-08-11 15:13:15 +05:30
Aman Agarwal
fb752eaa9e
fix: revamped rts server architecture (#15870)
## Description

RTS node server was being used for Availability feature. Now we will be enhancing the server to utilise client side logic on the server side side like construction of AST, Evaluations logic etc. So, since our codebase was not structured for implementing such use case, so we had to revamp the structure of the codebase.
#### Architecture

- **Routes :** To define different paths to consume apis
- **Controllers :** To capture the routing and formulate the logic to provide response to a particular request
- **Middleware :** action functions that happen to be stitched in between the routes and controllers, or can be used as a part of logic that needs to be injected in between.
- **Constants :** To keep static variables as per the usage without declaring it in other parts of the codebase
- **Sockets :** Any socket apis exists inside this folder to properly structure every socket implementations
- **Utils :** Helper functions which can be used at any stage of the application

Fixes #15645

## Type of change

- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

> Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.

- Test A
- Test B

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-11 15:06:02 +05:30
Tolulope Adetula
c6ed1b7214
fix: select default value validation (#15846)
* feat: Multiselect default Check

* Fix: failing tests

* fix: review issues

* fix: build errors

* fix: review issues

* fix: unused vars

* fix: failing tests

* Fix: default value issue

* Merge branch 'release' into fix/Select-default-Value-validation

* fix: add jest test

* Empty Commit

* Fix: Empty commit to re-reun

* empty commit

* Empty Commit

* cy fix

* json field event fix

* TableFilter failure fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-11 10:02:55 +05:30
Aishwarya-U-R
d0dd080397
test: Script fix for Cypress Timeout - CI runs (#15878) 2022-08-10 21:36:30 +05:30
Nayan
8e38079a31
chore: Return custom slug in other api (#14854)
* -return custom slug in response to the get list of pages API

* -return custom slug for default page in home page API

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-10 21:52:24 +06:00
Dhruvik Neharia
ce2aafaee4
feat: Change default label position of RTE widget to top (#15769) 2022-08-10 14:00:24 +05:30
Rishabh Rathod
78379d4718
fix: update def on widget property name update (#15490) 2022-08-10 10:50:08 +05:30
rahulramesha
b4e9f648c3
fix: Multiple scrolls in view mode (#15679)
fix multiple scrollbars
2022-08-09 22:40:10 +05:30