Commit Graph

2672 Commits

Author SHA1 Message Date
Nikhil Nandagopal
0cb4d3733c
Fix/deploy script (#206)
* Added information to setup domain

* Fixed incorrect var reference

* Updated documentation message

* Updated env template

* updated template

* removed debug echo

* Updated Script

* Updated Text

* Removed option to connect to external mongo for fresh installs
Exit script of docker desktop is not installed

* Updated docker installation explanation

* added a question to skip custom domain if user is installing locally

* Inverted script question and

* Removed question to determine local installation

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-08-03 18:20:55 +05:30
Tejaaswini Narendra
00e53af4ed
Fix UI Bugs (#168)
* Fix UI Bugs

- Double search box width and change text to Search app name
- Half the space between the org icon and the org name on home page
- Make org name bold and increase font to 16px
- Remove manage users button from invite modal if modal is opened in organisation settings page

* fix: Review Comments and other minor changes

- Clear TagList on form submit
- Fix CSS for search widget width
- Fix table height
- Make org name text bold for admin access.

* fix: Test Cases
2020-08-03 17:14:18 +05:30
Trisha Anand
b5841e96d2
GET plugin form now returns json to render both datasource configuration form and the editor query pane (#199)
Keeping the function to read plugin resource generic for any type of resource. Now the parent function can also conditionally decide which plugin would require to read which resources from the filesystem.

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2020-08-03 16:37:28 +05:30
Tejaaswini Narendra
b65cdf68b0
feat: Add org share option to application share modal (#166)
* feat: Add org share option to application share modal

* fix: Update design and implement copy to clipboard

* fix: Show share based on permission and update modal UI

- Update modal style
-  show application share button only to admins.

* fix: refine code
2020-08-03 14:44:08 +05:30
dependabot[bot]
2b2a06e9e1
Bump elliptic from 6.5.2 to 6.5.3 in /app/client (#204)
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-08-03 09:16:56 +05:30
areyabhishek
3fa0beef9c
Update README.md (#188) 2020-08-03 07:47:10 +05:30
Shrikant Sharat Kandula
cef1241bcb
Return 200 when action could not be executed (#202) 2020-08-03 07:35:14 +05:30
Hetu Nandu
f8c2bd5d42
Update binding highlight styles (#136)
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-07-31 15:47:18 +05:30
Shrikant Sharat Kandula
43304ca146
Fix form data not showing up in the right place when importing from curl (#198) 2020-07-30 16:30:39 +05:30
Arpit Mohan
6bd994a9ba
Removing the option --nobest from the apt install command (#196) 2020-07-30 11:18:48 +05:30
Trisha Anand
c6a9fc2bb4
Organization getById should use custom repository get function (#195)
* Overwriting the base service's getById for OrganizationService to ensure that the response contains userPermissions (by using custom repository instead of default mongo repository classes)

* Fixed the failing test cases.

* Minor code formatting.
2020-07-29 16:57:46 +05:30
Arpit Mohan
4475bc2b1e
Configuring dynamic redirect post login (#194)
The client will have to send a query parameter redirectUrl or a header X-Redirect-Url in order for the server to redirect the client to the appropriate URL post login. If neither of these parameters are present, the client is redirected to /applications by default.

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2020-07-29 16:07:40 +05:30
dependabot[bot]
4b026d5acb
Bump lodash from 4.17.15 to 4.17.19 in /app/client (#132)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-07-29 15:43:38 +05:30
vicky-primathon
527bb5898a
Fix-The tabs should scroll with the increase in the number of tabs. (#131)
* Fixed tabs widget bugs and other updates:
1. Moved drag icon to the left of tab name field in the tabs widget property pane
2. Change drag icon
3. Add scroll when the tabs occupy more width than the width of tabs widget.
4. Add selected tab name validation.
5. Hide overflow tabs.
6. Avoid vertical scrollbars in tabs widget header
2020-07-29 14:31:17 +05:30
Trisha Anand
eba38ae1fa
During signup, if the user already exists, instead of throwing a generic duplicate key exception, request the user to sign in. (#192)
* During signup, if the user already exists, instead of throwing a generic duplicate key exception, request the user to sign in.

* Minor change in the error message.
2020-07-29 13:44:23 +05:30
Abhinav Jha
08d2a94768
Change derivedpropertiesmap for selectedRow to use filtered table data (#173)
* Add a new meta property to tableWidget called filteredTableData which will be used by the table to filter

* Use derived properties to update filteredTableData

* Check if search is done via actions, if so, filteredTableData is the same as tableData
2020-07-29 11:45:06 +05:30
Arpit Mohan
9575abc602
Fixing minor typos in the README (#186) 2020-07-29 11:33:40 +05:30
NandanAnantharamu
3c5d93e699
Feature/validate request header (#189)
* validate request header

* Validate request header for API tests

Co-authored-by: Nandan Anantharamu <Nandan@thinkify.com>
2020-07-29 11:30:03 +05:30
Shrikant Sharat Kandula
60efdb998b
Fix: Datasource password gets double encrypted on cloning (#191)
* Decrypt sensitive fields before cloning a datasource

* Fix NPE in cloning datasource when configuration is missing
2020-07-29 11:12:04 +05:30
Trisha Anand
9c51ac3f8d
🔥 & forget asynchronous email sending (#187)
* Email sending is now an asynchronous function. It follows a 🔥 & forget strategy to make it run asynchronously.
2020-07-28 20:06:12 +05:30
vicky-primathon
e794c916e6
Fix-Row to be selected when button is clicked and row is not selected (#167)
* Row selection when button is clicked and row is not selected

* Added columnActions to useMemo for columns computation to support live action name updated and action change support
2020-07-28 19:56:27 +05:30
Arpit Mohan
ad41063944
Fixing bug for beta releases (#185) 2020-07-28 18:52:59 +05:30
Arpit Mohan
7eda0f0201
Making the pre-release tag configurable based on the tag (#184) 2020-07-28 18:21:40 +05:30
Shrikant Sharat Kandula
66bf23106d
Fix cloning fails in some cases for organizations (#159)
* Fix cloning fails in some cases for organizations

Cloning currently fails in cases like the following:
- Application with no pages
- Pages with no actions
- Pages with more than one action

* Remove debug naming of cloned datasources

* Add test for organization cloning

* Add more tests for organization cloning

* Fix potential race condition in adding pages to an application

* Move db update call to add page to application, into repository

* Use `getIdCriteria` to query for document's _id
2020-07-28 17:54:06 +05:30
Arpit Mohan
0bff7ca165
Adding nightly builds that will be generated on each push to master (#183)
The latest tag will only be generated when a non-beta Github release is created.
2020-07-28 17:33:05 +05:30
Hetu Nandu
01a3d4682f
Fix action batching issue (#181) 2020-07-28 16:11:51 +05:30
Arpit Mohan
f3d88bc8b8
Removing erroneous condition on master branch (#180) 2020-07-28 15:04:13 +05:30
Arpit Mohan
55bb744a3b
Adding condition to run only on master branch for specific tag push (#179) 2020-07-28 14:55:16 +05:30
Arpit Mohan
7b142ba8b8
Fixing the github yml (#178) 2020-07-28 14:26:51 +05:30
Arpit Mohan
5028a98d45
Correcting github release action yml file (#177) 2020-07-28 14:17:16 +05:30
akash-codemonk
502733315b
Fix key value array not being able to set initial value (#150)
* Fix key value array not being able to set initial value. Now we allow multiple values to initialise for array input
2020-07-28 10:45:26 +05:30
NandanAnantharamu
adee90aee9
assertion type changed (#174)
Co-authored-by: Nandan Anantharamu <Nandan@thinkify.com>
2020-07-27 16:44:06 +05:30
Nikhil Nandagopal
45163c5f99
Updated installation script (#172)
* Added information to setup domain

* Fixed incorrect var reference

* Updated documentation message

* Updated env template

* updated template

* removed debug echo

* Updated Script

* Updated Text

* Removed option to connect to external mongo for fresh installs
Exit script of docker desktop is not installed

* Updated docker installation explanation

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-07-27 12:52:53 +05:30
Arpit Mohan
f120fb1281
Fixing the yml file for Github Action (#171) 2020-07-27 12:31:00 +05:30
Nikhil Nandagopal
74756a25b1
Fix/deploy script (#170)
* Added information to setup domain

* Fixed incorrect var reference

* Updated documentation message

* Updated env template

* updated template

* removed debug echo

* Updated Script

* Updated Text

* Removed option to connect to external mongo for fresh installs
Exit script of docker desktop is not installed

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-07-27 12:25:45 +05:30
Arpit Mohan
015c56e1a6
Github action to push to Docker Hub and create Github release (#169)
* Adding a github action to push to Docker Hub and create Github release when a tag is created on master branch.

* Extracting the tag from the github ref and only tagging the Docker image with the relevant tag.
2020-07-27 11:52:18 +05:30
Shrikant Sharat Kandula
74da0f117e
Reuse layout that's automatically created with page (#163)
* Reuse layout that's automatically created with page

* Use correct API for updating a layout

* Commenting out organization cloning test.

* Removed organization cloning test

* Adding a dummy commit to run the pipeline.

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2020-07-25 18:13:29 +05:30
Shrikant Sharat Kandula
10ad639b28
Bug/layouts not updated on action change (#161)
* Fix layouts not be updated when an action is updated

* Add test for updating onLoadActions when action updated

* Split layout and action test to separate class

* Remove duplicated test in ActionServiceTest
2020-07-25 16:45:42 +05:30
Shrikant Sharat Kandula
5ee1c24224
Fix layouts not be updated when an action is updated (#160)
* Fix layouts not be updated when an action is updated

* Add test for updating onLoadActions when action updated
2020-07-25 15:43:22 +05:30
vicky-primathon
8fb0dc02ad
Fix-Search component in Table widget updated with support for clearing search data (#96)
* Added Button component in Table widget for actions

* Action button state loading added for Table widget

* Action button font-weight made as normal

* Created header for common functionalities in Table Widget

* Client side searching added in Table Widget. Action created for server side searching also.

* Columns visibility feature initial commit

* Column visibility list added in Table Widget

* Changed pagination designs in accordance with new layout. This enable user to jump page as well.

* Using colors values from constants

* Table widget pagination, numeric input page number clamped between 1 and total pages

* Adding tool tip to truncated values in table widget. Added AutoToolTipComponent that adds tooltip when text is truncated.

* Table data download changes. Added downlaod icon and button to table widget.

* Table data download changes

* Table button loading state fixed. Table code refactored, rendering from props instead of state in ReactTableComponent

* Table widget action button alignment fixed

* Handled actions column changes

* added proper keys to useMemo for react table widget

* Download table data as CSV implemented

* table data download, unused code removed

* Code refactors and added dependency map with meta props and table data for computing columns

* Table UI breakages on scroll and empty cells fixed

* Handled empty rows in table widget

* Fixed last row cut issue

* Code review changes

* Code review changes

* Added table widget component heights as enum

* code review changes

* Search component in Table widget updated with support for clearing data, renamed properties

* Opening image in new tab on clicking in table widget

* Fixed table craching due to empty data filtering

* Empty extra space on loading removed in table widget

* Removed stopping of event propagation on table widget action button click

* Fixing for test cases

* Table header UI overflow fixed

* Clearing selected row on searching data in table widget

* fix for cypress test

* Table crash issue fix

* searchKeyword renamed to searchText. searchText added to entity definitions

Co-authored-by: Arpit Mohan <me@arpitmohan.com>
2020-07-24 19:28:28 +05:30
akash-codemonk
126e0a7d04
Update Create query style (#157) 2020-07-24 18:35:37 +05:30
Shrikant Sharat Kandula
4a269efd4a
Reset default fields of User object before update (#158)
The policies of `User` objects is an empty set by default. So, when using a new `User` object to call `update`, it also updates existing policies to be an empty list.
2020-07-24 18:32:43 +05:30
Trisha Anand
9f8b5ca4d8
Adding execute action permissions policy to match read actions policy in existing actions. (#156)
* Fixing test cases failing due to non unique names.

* Adding execute action permissions policy to match read actions policy in existing actions.

* Only save the action if there are read actions permission present (and hence could have been updated)
2020-07-24 17:05:49 +05:30
vicky-primathon
a2673aaa87
Fix-Open image in new tab on clicking it in table widget. (#119)
* Added Button component in Table widget for actions

* Action button state loading added for Table widget

* Action button font-weight made as normal

* Created header for common functionalities in Table Widget

* Client side searching added in Table Widget. Action created for server side searching also.

* Columns visibility feature initial commit

* Column visibility list added in Table Widget

* Changed pagination designs in accordance with new layout. This enable user to jump page as well.

* Using colors values from constants

* Table widget pagination, numeric input page number clamped between 1 and total pages

* Adding tool tip to truncated values in table widget. Added AutoToolTipComponent that adds tooltip when text is truncated.

* Table data download changes. Added downlaod icon and button to table widget.

* Table data download changes

* Table button loading state fixed. Table code refactored, rendering from props instead of state in ReactTableComponent

* Table widget action button alignment fixed

* Handled actions column changes

* added proper keys to useMemo for react table widget

* Download table data as CSV implemented

* table data download, unused code removed

* Code refactors and added dependency map with meta props and table data for computing columns

* Table UI breakages on scroll and empty cells fixed

* Handled empty rows in table widget

* Fixed last row cut issue

* Code review changes

* Code review changes

* Added table widget component heights as enum

* code review changes

* Search component in Table widget updated with support for clearing data, renamed properties

* Opening image in new tab on clicking in table widget

* Fixed table craching due to empty data filtering

* Empty extra space on loading removed in table widget

* Removed stopping of event propagation on table widget action button click

* Table header UI overflow fixed

* Clearing selected row on searching data in table widget

* fix for cypress test

Co-authored-by: Arpit Mohan <me@arpitmohan.com>
2020-07-24 16:02:31 +05:30
Trisha Anand
61c62c9212
Datasource Test should test against the datasource object sent by the client (#155)
* Datasource test should always test the latest object given by the client (instead of fetching the same from the db). If it is a saved datasource, then we should decrypt and set the password in the datasource (unless the password is one of the changes that is being tested).

* Added function level comment to clarify that this function can no longer be used by just sending the datasource.id field set.
2020-07-24 15:53:40 +05:30
Shrikant Sharat Kandula
23dd84d9c8
Clear application pages list before cloning (#154) 2020-07-24 14:35:16 +05:30
Shrikant Sharat Kandula
dfcabab4cc
Handle stale database connection from datasources (#151)
* Handle stale database connection from datasources

* Fix potential secondary case of stale connection error

* Fix Postgres to MySQL

* Move validity check timeout to a constant field

* Add test for recovery when stale connection error is thrown
2020-07-24 12:18:25 +05:30
NandanAnantharamu
8e5fb14f70
updated test by removing blank header value (#153)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Hetu Nandu <hetu@appsmith.com>
Co-authored-by: Arpit Mohan <me@arpitmohan.com>
Co-authored-by: Nandan Anantharamu <Nandan@thinkify.com>
2020-07-24 11:17:54 +05:30
NandanAnantharamu
b73d049019
Api test fixes (#146)
Co-authored-by: Nandan Anantharamu <Nandan@thinkify.com>
2020-07-24 10:01:39 +05:30
Shrikant Sharat Kandula
ca73c3e625
Copy plugin dependencies to their target/lib to fix driver not found errors (#152)
The plugin class loader from Pf4J looks for jars under target/lib
to use to load any classes that are missing target/classes. This
PR adds the `maven-dependency-plugin` to copy the jars to this
folder automatically so the classes are available during
development.
2020-07-24 09:49:17 +05:30