Commit Graph

11657 Commits

Author SHA1 Message Date
Appsmith Bot
0b32e50cc8 Update top contributors 2022-12-15 06:58:39 +05:30
Sangeeth Sivan
c8d396fa32
fix: update delete workspace permission and condition case (#18930)
handles delete option edgecase: when user has the delete permission but workspace has applications, user should not be able to delete the workspace.

This commit hides the option.
2022-12-14 23:38:58 +05:30
dependabot[bot]
91f81484b4
chore: bump tinymce from 5.10.2 to 5.10.7 in /app/client (#18792) 2022-12-14 21:16:13 +05:30
Ankita Kinger
faffba78a6
fix: Updating page permissions in view mode to solve error message for updating the page (#18946) 2022-12-14 20:32:13 +05:30
Satish Gandham
519dd3a7a3
ci: Make perf tests a blocking check (#18955)
Make perf tests a blocking check

Co-authored-by: Satish Gandham <hello@satishgandham.com>
2022-12-14 18:39:53 +05:30
Trisha Anand
94e21d58df
chore: Adding variable to track admin settings visibility in user profile (#18956) 2022-12-14 18:28:20 +05:30
Ankita Kinger
9537c282ac
chore: Updating UI for the left panel on Admin settings page by adding separators (#18895) 2022-12-14 17:37:55 +05:30
akash-codemonk
11dba7b4f8
chore: use updated table widget in onboarding (#18705) 2022-12-14 16:02:34 +05:30
Manish Kumar
654f94a94c
chore: decomposing action execution flow methods into smaller methods (#18762) 2022-12-14 15:43:14 +05:30
Rishabh Kashyap
4877acf1eb
fix: show more modal of a truncated text widget is flickering (#18888)
class for updated z-index added
2022-12-14 13:43:43 +05:30
Trisha Anand
122b5388ac
chore: use read permission to fetch pages in edit mode (#18944) 2022-12-14 13:02:17 +05:30
Appsmith Bot
8aaebc6ae1 Update top contributors 2022-12-14 06:58:26 +05:30
Aman Agarwal
cb1b0b5aa3
fix: removed old key_val_input, updated keyval_array, show ds info (#18626)
fix: removed old key_val_input, updated keyval_array, show ds info
2022-12-13 20:09:16 +05:30
Satish Gandham
bc2b60974d
ci: Fix perf tests failure (#18926)
* Fix perf test failure due to a wrong step added earlier

* Remove all the steps added to make perf tests work on EE

Co-authored-by: Satish Gandham <hello@satishgandham.com>
2022-12-13 19:29:51 +05:30
Ayangade Adeoluwa
2cc64183c8
fix: Error handling for undefined datasource in API Authentication (#18881) 2022-12-13 17:16:56 +05:30
Ankit Srivastava
9f84298dcf
fix: Login password length upper limit changed from 48 to 256 characters (#18176)
* fix - login password length upper limit removed

* removed unused variables

* password max limit of 256 characters

Co-authored-by: Anubhav <anubhav@appsmith.com>
2022-12-13 16:40:47 +05:30
Rishabh Kashyap
26c01b35e9
feat: add tooltip property to select widgets (#18480) 2022-12-13 16:05:08 +05:30
Ankit Srivastava
236214f182
fix: treat empty valued env variables as false | FE (#18428)
* converting empty env values to boolean before storing in store

* triming and checking empty values

* Empty commit for test

Co-authored-by: Anubhav <anubhav@appsmith.com>
2022-12-13 15:38:37 +05:30
Hetu Nandu
c5ae0521ec
fix: Modal opening or closing type error (#18913)
fix for sometimes widget not available
2022-12-13 15:34:32 +05:30
Aishwarya-U-R
973d46aaef
test: Migration to FatContainer (new .yml faile) (#18917)
## Description

- This PR adds a new fat-migration.yml file which will run all cases in fat container instead of dev.app.appsmith
- This PR will not affect any existing Push/Workflow dispatches as its a separate action file
- Moving to fat container will not be put into action until RBAC is live - so as to not trigger any new challenge at last minute

## Type of change

- New .yml file

## How Has This Been Tested?
- Cypress CI runs

## Checklist:
### QA activity:
- [X] Test plan has been approved by relevant developers
- [X] Test plan has been peer reviewed by QA
- [X] Cypress test cases have been added and approved by either SDET or manual QA
- [X] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [X] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-13 15:24:56 +05:30
Satish Gandham
b5e8fc3be8
ci: Fix perf test failure due to a wrong step added earlier (#18918)
Fix perf test failure due to a wrong step added earlier

Co-authored-by: Satish Gandham <hello@satishgandham.com>
2022-12-13 15:06:09 +05:30
Sangeeth Sivan
44c9a261f9
fix: datasource active tab options menu is not permission driven (#18863)
* fix: ds active tab menu

* fix: condition
2022-12-13 15:01:46 +05:30
Sangeeth Sivan
3d8650db4d
fix: publishing an app removes page permissions (#18865)
* fix: page permissions for deployed app

* fix: use the selector with select
2022-12-13 14:49:22 +05:30
Vaibhav Tanwar
770afde191
fix: Execute api pagination fix (#17886)
Query parameters encoding parameter added for paginated prev and next url.
2022-12-13 09:07:15 +00:00
Parthvi
db19455e57
ci: Add three more runners for the fat container tests (#18915) 2022-12-13 14:36:33 +05:30
Appsmith Bot
32d1de9108 Update top contributors 2022-12-13 06:58:47 +05:30
Bhuvaneswari Pathsamatla
6e49dff020
chore: rename actions for REST and GraphQL in datasource pane (#18114) 2022-12-12 22:33:10 +05:30
Rooney30
4354251ccc
docs: Added a title to GlobalFunctions.md (#18617) 2022-12-12 22:26:25 +05:30
Apeksha Bhosale
efa8b68a47
fix: Parse js actions for view mode changes (#18357)
* added new function inside parse js actions for view moe

* fixing test cases

* added evaluateSync with isTriggered false

* Add types
Add switch case for diff.event
Add function get back app mode

* Change foreach loops to for of

* Dont return jsUpdates from view mode save resolved since no operation is happening
Change viewModeSaveResolvedFunctionsAndJSUpdates -> viewModeSaveResolvedFunctions to reflect
what it's functionality is

* Refactor JSObject code

* Refactor code for JSobject
* remove any
* export parsed object's type from ast
* create function for deleteResolvedFunctionsAndCurrentJSCollectionState

* Code review changes

* Fix tests

* Change returns in for of loops to continue
Remove try for evaluate sync
Js updates return

* Fix bug

* Fix bug

Co-authored-by: Rimil Dey <rimil@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-12 19:45:40 +05:30
Anagh Hegde
77a225f4dd
ci: revert Add replicate set to the mongodb url for transaction PR (#18890)
Revert "ci: Add replicate set to the mongodb url for transaction PR (#18873)"

This reverts commit bc8022caf2.
2022-12-12 18:57:20 +05:30
Anagh Hegde
bc8022caf2
ci: Add replicate set to the mongodb url for transaction PR (#18873) 2022-12-12 16:28:00 +05:30
Shrikant Sharat Kandula
e4476e2893
chore: Fix more potential race condition in sending emails (#18884)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-12 16:12:39 +05:30
Ankita Kinger
35a9188111
fix: Updating the logic for getting tenant permissions to show new workspace button (#18874) 2022-12-12 16:09:42 +05:30
Shrikant Sharat Kandula
1bf842b525
chore: Fix potential race condition in sending email (#18882)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-12 15:34:46 +05:30
Anand Srinivasan
5627c3e8aa
chore: update import to fix compilation issue (#18875) 2022-12-12 13:33:51 +05:30
GitStart-Appsmith
618626f6a4
feat: [APPSMTH-22] Execute action on widget focus and blur (#18128)
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-12 12:39:22 +05:30
Nidhi
5329010415
fix: Refactor entities based on AST parsing logic (#18517)
* feat: Refactor entities based on AST parsing logic

* Deleted jmh file

* rts updates for the edge cases

* adding jest test cases

* update review comments

* Fixed issue with references outside of bindings and some other stuff

* Added tests for DSLUtils

* bug fix 18699

* Test fixes

* Test fixes

* Review comments

* Changed type to boxed

Co-authored-by: ChandanBalajiBP <chandan@appsmith.com>
Co-authored-by: ChandanBalajiBP <104058110+ChandanBalajiBP@users.noreply.github.com>
2022-12-12 08:12:21 +03:00
Anand Srinivasan
284571803b
fix: update settings pane validations (#18739)
* init fix

* button style update

* decode url in preview

* bring back custom slug validation

* custom slug validation on type

* remove imports

* handle special characters in url preview

* change label

* code clean up

* remove pageId from action name selector

* messages clean up

* tests for validations

* cypress cases update

* Renamed helper methods

* add index for test cases

* AppSettings specs script ts updates

* Added Bud id in title #18698

* GIt Import spec fix

* GItImport spec fix

* Git import unskip

* Skipping Git import

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-12 10:21:14 +05:30
ashit-rath
f67f8571ec
refactor: JSONForm eliminate the use of canvasWidgets and remove childStylesheet from dynamicBindingPathList (#18715)
* refactor: JSONForm eliminate the use of canvasWidgets and remove childStylesheet from dynamicBindingPathList

* review changes

* fixed field reset on deploy

* reverted prevSourceData changes
2022-12-12 10:13:18 +05:30
akash-codemonk
a6df3a6deb
chore: add analytics for page creation ctas (#18676) 2022-12-12 10:12:17 +05:30
Nikhil Nandagopal
901b046751 Updated Label Config 2022-12-12 09:58:38 +05:30
Appsmith Bot
9adc1a2f2f Update top contributors 2022-12-12 06:58:27 +05:30
ankurrsinghal
432e513678
fix: modal deselect issue auto height (#18750)
modal deselect issue fixed when dynamicHeight property is changed
2022-12-11 20:51:46 +05:30
Aswath K
ce2925cafc
feat: Property pane search (#18164) 2022-12-11 20:12:32 +05:30
Ankita Kinger
9899eaa0c3
fix: Left panel not scrollable on Admin settings page when the list is too long (#18845) 2022-12-11 18:21:52 +05:30
sidhantgoel
4501434ede
chore: Synchronize Page,Action and ActionCollection object from original corresponding object (#18846)
Synchronize Page,Action and ActionCollection object from original corresponding object
2022-12-11 12:23:45 +05:30
Appsmith Bot
1dafb8776e Update top contributors 2022-12-11 06:58:36 +05:30
rahulramesha
a1973b81a3
Fix: Context switching UX issues (#18828)
* fix Property panel jitters on focus

* open widget entity on widget selection

* Remove retaining Datasources url on page change

* fix param string while restoring URLs

* add cypress test
2022-12-10 23:59:36 +05:30
f0c1s
2ce9665b61
chore: add some more audit logs analytics (#18738) 2022-12-10 14:56:29 +05:30
Ankita Kinger
d9f20e33ad
chore: splitting the role name to avoid showing workspace name next to it (#18830)
* splitting the role name to avoid showing workspace name next to it

* fixing cypress tests failures
2022-12-10 14:00:28 +05:30