Commit Graph

5771 Commits

Author SHA1 Message Date
Nikhil Nandagopal
122d897617
Updated S3 CRUD Template (#8722) 2021-10-22 11:33:27 +00:00
Pawan Kumar
b9d8105949
fix: TypeError: Cannot read properties of undefined (reading 'filter') (#8598)
* fadd null check

* fix validation of checkbox group

* add jest test for checkbox default selected option validation

* fix checkbox group failing

* sort order of imports

* update default selected value validation
2021-10-22 13:26:52 +05:30
albinAppsmith
9c8cdacd0f
Hover state of incoming connection fix (#8670) 2021-10-22 10:54:32 +05:30
haojin111
4dc8da3cbb
enable edit icon (#8613) 2021-10-21 11:06:33 +05:30
balajisoundar
b2c5779234
feat: Introduce a welcome banner and a form to fill in role, useCase for new user (#8312) 2021-10-21 11:06:17 +05:30
Rishabh Saxena
7fe75ba711
chore: fetch published page after fetching actions for viewer (#8635) 2021-10-21 10:53:34 +05:30
balajisoundar
e7de8bafd5
feat: option to download config files from admin settings page (#8631) 2021-10-21 10:27:10 +05:30
akash-codemonk
6347bd9c38
fix: show tooltips for entity names in explorer (#8501) 2021-10-21 10:07:34 +05:30
Trisha Anand
a5eb79b2e1
Fixing the substitution type for JSON fields (#8652) 2021-10-21 09:52:35 +05:30
akash-codemonk
5a80e9b014
fix: scroll bar shifting widget sidebar content on windows (#8524) 2021-10-20 20:05:12 +05:30
arunvjn
71b1ea0675
fix: autocomplete experience (#8539)
CodeEditor component refactor and fixes around autocomplete flicker
2021-10-20 17:51:07 +05:30
Bhavin K
4f5facbe7a
fix: Radio component keys are now unique (#8277) 2021-10-20 17:45:54 +05:30
Aanchal
e78ace8bc2
fix: Removed unused variables (#8122)
Fix: Removed unused variables
2021-10-20 18:09:50 +06:00
akash-codemonk
ea98e4e075
chore: add analytics event for debugger context menu click (#8628) 2021-10-20 17:10:29 +05:30
Nayan
98ca448f9f
feat: [Feature] Add API to download docker config (#8587)
Added API to download docker config for super admin users
2021-10-20 15:58:31 +06:00
Anagh Hegde
6faaa33936
feat: Git version control functionality with connect to remote, commit, push flows (#8403)
* core workflows of git - branch, clone, commit, pull, merge, status, log

* Rehydrate file system before merge operation

* Add logic to handle merge conflict for merge and pull flow

* Add defaultBranch to listBranch API

* Add Unit tests for git commands

* Upgrade JGit dependencies to fix the security issue

* Git command tests

* Revert unwanted changes and update delete application flow

* Disable git feature until the FE changes are merged

Co-authored-by: Abhijeet <ABHI.NAGARNAIK@GMAIL.COM>
2021-10-20 09:47:34 +00:00
albinAppsmith
b1367caf1f
fix: border radius of google sheet where clause removed (#8453)
* dynamic text field bg fixed

* removed | replaced color with constant

* * border radius of google sheet where clause removed

* * Error header BG color changed

* * where field alignment fix

* fixed hover state of dynamicinputtextcontrol

* border-radius fix

* css syntax fix

Co-authored-by: rashmi rai <rashmirai@rashmis-MacBook-Pro.local>
2021-10-20 15:03:04 +05:30
Rishabh Rathod
258189cc3f
fix: git sync ui fixes (#8133) 2021-10-20 07:38:17 +00:00
haojin111
bc5643db80
fix: 8239 - fixed issue of delete action truncatedd (#8604)
* fixed issue of delete action truncatedd

* matched option width

Co-authored-by: Albin <albin@appsmith.com>
2021-10-20 11:21:25 +05:30
haojin111
7a4e96fab9
fixed issue of api action query icon (#8555)
Co-authored-by: Albin <albin@appsmith.com>
2021-10-20 11:11:29 +05:30
kyteinsky
5676d6f652
fix: Added hover state to the black-colored Launch button on Applications Page. (#8279)
* Added hover state to the black Launch button on Applications Page.
The black button didn't exhibit hover changes while the orange Edit button did
because the Button base component made the buttons darker, and the launch button
was already dark.
Custom CSS was included in Applications.tsx for hover state background-color
change.

* Fix: Added hover state to Launch button on Applications page

default: black background, white text
hover: transparent background, black text and border

* replaced harcoded colors with src/constants/Colors.tsx properties
2021-10-20 10:52:17 +05:30
Rishabh Saxena
3ba3aed30f
fix: hide entity explorer search (#8610) 2021-10-20 04:45:23 +00:00
Bhavin Ag
c45de57ab8
fix(Dropdown): remove empty dropdown in case of no options (#8357)
* fix(dropdown): add check for empty option array

* test(Dropdown): add UT for empty option

* refactor(Dropdown): show no results found message on empty data

* refactor: update empty data message
2021-10-19 08:40:07 -07:00
Apeksha Bhosale
f7fa2aefe5
fix: refactor js action name flow change (#8302)
* refactor js action name flow chnage

* PR commnets fixeed

* refactor states missing
2021-10-19 17:23:15 +05:30
Ashok Kumar M
5233887890
fix: Dynamic canvas height escaping un-wanted migrations. (#8305) 2021-10-19 16:34:32 +05:30
Pranav Kanade
23078215df
fix: unread indicator behaviour (#8290)
* fix: unread indicator behaviour

* minor fixes

* no need to deep copy the state

* removed state update of show indicator

* refactor to handle delete & insert thread cases and getting rid of unnecessary state

* removing unnecessary updates to store

* with update event if the thread is not there we'll put it in

* fetching the comments when user starts to edit the app

* updated tests

* typo fixed

* using memo to get the unread comments flag

* removed dependency from global state

* storing last updated comment thread id for each application.

* updated a few test cases
2021-10-19 15:56:56 +05:30
haojin111
8f32a6dba3
updated style of multiple dropdown as v2 (#8433) 2021-10-19 11:03:30 +05:30
haojin111
4bc370c3d8
remove 3 dot for loading sketon app card (#8435) 2021-10-19 10:52:55 +05:30
albinAppsmith
f9f2808719
* Icon alignment in debugger fiox (#8581)
* Omnibar icon bg fix
* Highlight color for input box
2021-10-19 10:32:36 +05:30
albinAppsmith
1a1e550986
icon color on hover fix (#8486) 2021-10-19 10:29:50 +05:30
Rishabh Rathod
6693c62396
hotfix: Add check to confirm variable are string (#8358) 2021-10-18 17:38:34 +00:00
Rishabh Saxena
31476092cc
chore: refactors for supporting git branches (#7695) 2021-10-18 19:33:44 +05:30
balajisoundar
8ea9e0d31c
chore: Add helper tooltips for page properties icons (#8538) 2021-10-18 15:09:04 +05:30
balajisoundar
10de149240
feat: Introduce a setting page for a super user to tinker with Appsmith env variables (#8144) 2021-10-18 13:17:55 +05:30
Rishabh Saxena
6225aca046
chore: conditionally load plausible on Appsmith cloud (#8477) 2021-10-18 11:48:27 +05:30
Rishabh Saxena
2040dceed9
fix: remove redundant env var (#8544) 2021-10-18 05:51:55 +00:00
rashmi rai
4b722449eb
fix: Fixes different form field background in forms (#8373) 2021-10-16 11:47:38 +00:00
Sumit Kumar
c9172f8079
fix: data migration to set default value for permanent url toggle where none exists (#8507)
* Recently a change was introduced to modify the default value of s3 plugin's permanent URL toggle from NO to YES. This created an issue with the older actions where the toggle didn't exist and hence no value was saved against its property. Hence, since the default is now ON and the older actions don't have any value saved, the action editor shows the toggle value as ON but behaves like the value is OFF. To fix this issue, this method adds URL toggle as NO where no toggle value exists.
2021-10-15 11:24:04 +05:30
Yyee
870dadd777
fix: Refresh current user in edit profile (#8267) 2021-10-15 11:07:27 +05:30
Favour Ohanekwu
922ab5f008
fix: close hint when certain characters are pressed (#7662)
Don't show autocomplete hint when brackets is pressed
2021-10-14 17:23:46 +01:00
Pranav Kanade
82c033c785
fix: allow api error interceptor to handle api call failure (#8513)
* letting error interceptor take care of api call failure

* minor fix
2021-10-14 18:38:24 +05:30
Favour Ohanekwu
813af16dba
fix: Show readable error in query response pane if present (#8518) 2021-10-14 16:34:43 +05:30
Aswath K
ce4b984e27
fix: unable to change button color on table widget (#8521)
* fix: unable to change button color on table widget

* Adds test for Table button color validation

* removes commented out code
2021-10-14 16:25:03 +05:30
Tolulope Adetula
da49fabfdf
fix: add column order to default Config (#8386) 2021-10-14 00:06:46 -07:00
Nidhi
1cefa7e51b
fix: Expose actions with collections in view mode (#8509)
* fix: Expose actions with collections in view mode

* Dummy commit for tests to pass

* Test fixes
2021-10-14 06:53:46 +00:00
Samyak Jain
23dbc6c6d7
chore: Removing re-declared variables (#8050) 2021-10-14 09:47:26 +05:30
Noel Daniel Aguilera
c613195c9d
fix: remove append isCommentMode=false when hitting esc key outside of comment view (#8135)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-10-13 21:54:23 +05:30
Paul Li
c9c529646f
feat: RTE - option to hide the toolbar (#8271)
-- Add a new widget property, isToolbarHidden
-- Add new Cypress test cases for the newly added property
2021-10-13 18:10:52 +05:30
Paul Li
d3fc8d8d1d
feat: Change color picker icon for better UX (#8352)
-- Replace no color icon with new design
2021-10-13 18:10:25 +05:30
Paul Li
a9e2eac8c3
fix: After using an app with AudioRecorder widget, Appsmith always shows the mic symbol in the tab (#8424)
-- Upgrade underlying package, react-media-recorder to the latest one
2021-10-13 18:10:04 +05:30
Sumit Kumar
d7411be855
fix: show hint message on using duplicate header or query parameters in API (#8263)
* show hint message on using duplicate headers or query parameters in API.
2021-10-13 18:02:16 +05:30
Rishabh Rathod
a4c3c6ca9d
fix: Remove Success GIF and Add Tick Animation (#7925)
- Decreased the delay to 3 seconds and
- Added CSS animation instead of GIF which reduces the load time.
- Added Placeholder image for the information image to show while it is loading.
2021-10-13 09:43:57 +00:00
Ashok Kumar M
4807e58267
fix: Switching back from comment mode the selection canvas doesn't work. (#8328) 2021-10-13 15:13:16 +05:30
Satish Gandham
b580e55e83
fix: Check if event.target is defined before accessing the value (#8475)
This is a patch, should see what triggered this issue.

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-10-13 11:55:04 +05:30
Nidhi
a3e63758d8
fix: Added default cs url for netlify builds (#8471) 2021-10-12 20:17:17 +05:30
Favour Ohanekwu
d10bde59e9
Add support for optional chaining and null coalescing in Linting (#8448) 2021-10-12 15:39:43 +01:00
Apeksha Bhosale
c0e945f0a3
in case if empty eval tree (#8441) 2021-10-12 15:49:10 +05:30
Aswath K
24b9da6741
fix: change Button variant types constant (#7817)
* change Button variant types constant

* Add migration

* Adds cypress test to validate default button variant

* update the ButtonVariant for MenuButton inside table widget

* Remove only from Button_spec

* fix: Binding issue with Variant in table

* fix: cypress test for default variant validation

* Add validation to IconButton inside table
2021-10-12 08:04:51 +00:00
Apeksha Bhosale
7c55a903f9
clear history from code editor (#8422) 2021-10-12 12:06:15 +05:30
Rishabh Rathod
41758bcd4d
fix: icon path fillColor issue (#8347) 2021-10-12 11:14:47 +05:30
Apeksha Bhosale
7eeba049ba
fix: js collection static values as part of best match (#8351)
* no rules for js actions

* add edit option to explorer
2021-10-11 19:22:39 +05:30
Hetu Nandu
2c3a0991f7
feat: setInterval and clearInterval support (#8158) 2021-10-11 12:55:03 +00:00
Paul Li
8bf6f1379e
feat: Audio recorder widget - permission denied state (#8223)
-- Design a new UI for permission denied status
-- Add a new recorder status for getting permission
2021-10-11 18:21:34 +05:30
Nayan
c288df157b
Show profile picture from the uploaded photo id of the user (#8402)
Sends photoId in user profile response. Shows profile picture from the uploaded photo id instead of email address.
2021-10-11 18:28:08 +06:00
Vicky Bansal
1d9f1831ba
Reset table page on filters reset (#8257)
Date column to not show invalid date when column value is empty
2021-10-11 17:51:35 +05:30
Shrikant Sharat Kandula
09c2875e4f
Server restart API, and restart detection API (#7480) 2021-10-11 16:29:39 +05:30
Nayan
1fa4a175a3
feat: upgraded spring boot vesion from 2.2.4 to 2.2.13 (#8381) 2021-10-11 15:58:37 +06:00
Apeksha Bhosale
5eb292aaee
fix: recent entities and incoming entity change (#8342)
* recent entities and incoming entity change

* added icon for js objects
2021-10-11 14:14:26 +05:30
Alyssa Holland
b4b038d90e
fix: 🐛 Display tooltips for scroll content label (#8134) 2021-10-11 13:08:27 +05:30
albinAppsmith
71886c3b9e
feat: Property pane dropdown overflow issues (#8236)
* * hide subtext for date picker fix
* EE clicking on entity, unfolding/folding added

* * bug fixes in action dropdown

* bug fix for cursor

* fix: 8190 background api request and welcome helper button (#8281)

* chore: Move action/js debugger tabs related logic to a common component (#8199)

* removed background of api request textbox and added hover text on "no thanks" button

Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>

* fix: added scrolling in invited users more popup (#8226)

* added scrolling in invited users more popup

* always scrollbar displaying on invited users pan

* fixed issue related with 8190

* updated cursor of invited users more

* replace edit data source icon with remix icon (#8192)

* * active text color

* fix: dropdownlist props issue (#8322)

* Commented failing JS tests (#8276)

Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>

* docs: Update ServerSetup.md (#8255)

* Make port customizable from env variable (#8288)

* fix: issue with string templates (#7848)

* Remove bracket highlight on error

* fix string template issue

* using string template to join strings

* fix breaking tests

* fixed props pass issue

Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
Co-authored-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com>

* * bug fixes

* * bug fix

* * test cases fix

* - test case fix

* * test fixes

* * bug fix in test case

Co-authored-by: haojin111 <63215848+haojin111@users.noreply.github.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
Co-authored-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-10-11 11:31:05 +05:30
Jen Dunlap
bd1e196139
chore: removed duplicate else-if JS-0034 (#8356)
Co-authored-by: Jen Dunlap <jen@customer.io>
2021-10-11 10:49:03 +05:30
Arpit Mohan
57bdbdc0f9
test: Fixing some cypress tests that were asserting if the message texts are correct (#8369) 2021-10-11 10:38:08 +05:30
Vaishnavi Joshi
9818001c3d
fix: updated misleading title in datasource page (#8028) 2021-10-10 09:18:20 +05:30
Bhavin K
22acbe4474
feat: updated widget meta key reset logic (#7901)
* updated widget meta key reset logic

* changes as required
2021-10-09 10:13:19 +05:30
Chiradeep-Banik
7af22b96a7
Remove Square bracket notation when using object properties (#7954)
- Replaced with dot-notations
2021-10-09 02:13:43 +05:30
Sheetal Patel
addca3fdb4
fix: if-else-statements-converted to ternary operator (#8219) 2021-10-09 02:05:24 +05:30
abhishek nayak
daeaf44fac
chore: Improve product copy by removing improper character capitalization (#7911) 2021-10-08 23:04:04 +05:30
Shrikant Sharat Kandula
d9c7de28d4
feat: Handle extra Java arguments to server Docker image (#8244) 2021-10-08 22:47:25 +05:30
Rafael Baldasso Audibert
7da4941571
fix: Update message to check request body (#8272) 2021-10-08 22:30:38 +05:30
Sheetal Patel
f939ebbe8a
chore: Fixing yoda conditions in the code (#8297) 2021-10-08 22:21:24 +05:30
Bhavin K
59af26dd8e
fix: tooltip should hide for a disabled on button widget (#8209) 2021-10-08 19:58:59 +05:30
Nayan
72dd22d490
fix: added a check to address NPE in home page when user has no organization (#8259) 2021-10-08 19:27:16 +06:00
Vicky Bansal
fdac6428b4
fix: Icon button click should not de-select row in table widget (#8197) 2021-10-08 18:00:12 +05:30
Rishabh Rathod
4fde9d63be
Fix css issue due to new DS (#8181) 2021-10-08 16:56:39 +05:30
Vinod
1bf41ed413
feat: add authentication tab in api editor (#8245)
* Remove bracket highlight on error

* add authentication section

* move string to messages.ts

* move api editor tab titles to messages.ts

* use createMessage to create strings

* navigate edit datasource to data source edit mode
2021-10-08 07:52:30 +00:00
akash-codemonk
9f2c32b9de
fix: onboarding table widget is blank after adding binding (#8285) 2021-10-08 13:22:08 +05:30
Aswath K
b02240cc34
fix: Focus lost when typing on property pane (#8318)
* fix: Focus lost when typing on property pane

* resurrect tests for Radio & CheckboxGroup
2021-10-08 13:09:31 +05:30
balajisoundar
d1efe8405e
feat: Add tooltips for icons in editor (#7711)
fixes: #6759
2021-10-08 12:35:34 +05:30
Tolulope Adetula
0b1f6da7fa
fix: column reorder on data load (#8167)
* fix: column reorder

* fix: table reorder with derived column
2021-10-08 07:43:33 +01:00
rahulramesha
86c931e365
chore: add ctrl y for windows users to redo (#7856)
* Scaffolding for undo-redo

* undo redo working Poc commit

* memory performance improvements by diffing

* dont run update on undo/redo"

* merging widget postion update and canvas bottom row update into one dsl update.

* fix tabs widget

* Visible updates per undo redo action (#6838)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* resize atomic operation

* fix switch control state issue

* disallow undo/redo for snipping and comment mode

* disallow undo/redo for snipping and comment mode

* fix color picker issue in undo/redo

* add test for replayDSL

* option control fix, adding logs

* minor position change undo redo updates

* add test cases for replayHelpers

* property Upade visual change

* remove unused code

* global hot key jest test for undo redo

* Fixing batch updates on property change..

* add tests for toggle control in property pane

* unwanted utils.

* add tests for text control

* add tests for deletion

* add tests for dropping a new widget

* adding jest test for replayUtils

* add move widget tests

* add tests for color picker control

* add analytics for undo/redo

* add analytics for undo/redo

* tab addition atomic

* cypress tests for propertyPane, toasts and radiowidget optionControl

* replayDSL end of redo stack fix

* property update changes

* menu option control debounce input

* color picker empty undo fix

* fix cypress tests

* widget add/remove atomic

* revert alternative approach to handle atomic operations

* update replayDSL test

* add some comments

* addressing review comments

* flash color for property pane controls

* Fixing adding of tabs widget as well.

* code review comments.

* merging widget postion update and canvas bottom row update into one dsl update.

* fix ordering of tabs property control

* meta property update canvas min height.

* fixing failed specs.

* Fixing entity explorer update on deleting tab from entity explorer.

* address review comments and minor property update changes

* fixing failing tests

* merge conflicts

* changes to cater widget api.

* fix suggested widget table issue

* draggable list for undo redo

* fix widget name focus

* excluding canvas updates.

* fixing codeEditor update on propertySection collapse

* fixed failing test case

* ctrl y to redo for windows users

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-10-08 12:01:43 +05:30
Anand Jayaram
ad6c015826
Fixed Null comparisons without type-checking (#8293)
Fixed warning for Null comparisons without type-checking operators may not work as intended JS-0059 as found by https://deepsource.io/gh/appsmithorg/appsmith/issue/JS-0059/occurrences
2021-10-08 12:07:29 +06:00
Shrikant Sharat Kandula
a4975c5bff
Add API for updating role and goal for users (#8242) 2021-10-08 09:40:19 +05:30
NandanAnantharamu
470fab30f7
test: S3Crud test fix (#8323)
* added route for a validation

* removed calls which are not happening
2021-10-08 08:32:34 +05:30
Vinod
159e7f2062
fix: issue with string templates (#7848)
* Remove bracket highlight on error

* fix string template issue

* using string template to join strings

* fix breaking tests
2021-10-07 12:33:15 +00:00
Shrikant Sharat Kandula
a13f674752
Make port customizable from env variable (#8288) 2021-10-07 17:02:49 +05:30
yatinappsmith
9ff6c804dc
Commented failing JS tests (#8276)
Co-authored-by: Yatin Chaubal <yatin.chaubal@gmail.com>
2021-10-07 16:13:01 +05:30
akash-codemonk
30c859180e
chore: Move action/js debugger tabs related logic to a common component (#8199) 2021-10-07 12:23:58 +05:30
Aswath K
b2e3f5d022
fix: make property pane control example to be one of the allowed values (#7851) 2021-10-07 11:42:18 +05:30
yatinappsmith
f900cf9765
test: JSEditor Tests (#8068)
* Added basic support for JSEditor

* Added copy and delete test cases

* Basic changes for js editor

* Basic tests

* JSEditor Binding tests
2021-10-07 07:59:16 +05:30
Favour Ohanekwu
803e5e7cc6
fix: improve dropdown component (#8183)
Improved multipart form's dropdown component
2021-10-06 20:20:35 +01:00