Commit Graph

7415 Commits

Author SHA1 Message Date
Favour Ohanekwu
59710de95b
chore: highlight name input field for newly created js objects (#13212) 2022-05-04 10:47:41 +01:00
Pawan Kumar
809a633306
feat: App Theming (#9714)
* fix style bugs

* fix select styles

* test: fix font size issue for cypress tests

* incorporate ashit feedback

* test: addresed review comments for cypress tests

* add analytics events

* height issue in view mode

* incorporate code review feedbacks

* incorporate code review feedbacks

* refactor: addressed review comments; removed border radius and box shadow for text widget; Updated migrations

* feat: Makes shadow and radius controls keyboard accessible (#11547)

* makes shadow and radius controls keyboard accessible

* removes unused imports

* moves options out of render method

* fix: changed the misnomer background property name to the relevant property name

* fix: border radius issue for the map widget

* address qa bugs

* address qa bugs

* fix ux of theming pane when widget is selected

* fix:
* added backgroundColor to the video widget
* restricted pop-over border radius to 0.375rem
* added box shadow for the input group for select widget

* fix: added delete icon in the delete theme modal

* address qa bugs

* change checkbox column size in config

* add js convertible to button color

* remove unused imports

* test: fixed jest tests

* fix primary color typo

* fix: migrations for the theming

* fix:
* Removed background color from MultiTreeSelect and TreeSelect component.
* grouped button's menu button pop over border radius restricting to 0.375rem.

* test: updated Dsl migration UT

* address qa bugs

* address qa bugs

* fix: address qa comments

* address qa bugs

* fix:
* migration issue;
* unit test cases;

* fix rating widget scroll issue

* fix youtube video border radius bug

* fix select widget

* fix select widgets styles

* address qa bugs

* merge conflicts

* makes the reset button keyboard accessible (#12134)

* -resolved merge conflicts

* address qa bugs

* fix: labelTextSize migration fixes

* refactor:
* made changes to the fontSizeUtils function
* fixed the issue related to unit tests

* fix button group widget

* remove unused imports

* fix: fixed the text size migration for the table widget

* refactor: addressed review comments for the table widget theming migration

* fix button group widget

* add init calls for view mode

* json form init theme changes

* fix: added migration for boxShadow, borderRadius and textSizes for table widget

* fix broken fields

* test: fixed unit tests

* wip

* inconsistancy fixes and schemaItem update in updateHook/fieldConfiguration

* feat: init json form migration theming

* json form primaryColor -> accentColor

* update table widget

* update table widget

* object field label styling

* fix: migration related to the JSON form

* fix: fixed labelTextSize migration for JSON form nested widgets

* property control nested stylesheet lookup

* JSONForm label styles form array items

* show label for checkbox field array item

* fix button group widget

* wip

* refactor: addressed table widget review comments

* refactor: addressed ashit review comments;
* added childStylesheet for widgets

* feat: Keyboard navigable Color Picker control (#11797)

* Makes ColorPicker keyboard accessible

* seperate out keyboard and mouse interactions

* fix issue with not focusing back to input

* Adds test for Color picker

* chore: added comment for the boxShadow property

* fix:
* added unit test cases for the widget and property utils
* resolved warning messages

* wip

* theme config update

* fix merge conflicts

* refactor: moved theming migration inside the migrations folder

* fix qa bugs

* fix jest test

* fix: unit test cases

* fix table column creation logic

* refactor: addressed review comments for migrations

* fix: Overriding margin and padding for custom render in the dropdown component (#12875)

* * fix for custom render padding and margin in ADS dropdown

* * fix for removing padding from normal render options

* refactor: moved the boxShadow condition to the variable

* fix qa bugs

* fix: migration QA callouts for audio recorder widget

* refactor: added updated comments for boxShadow migration for table widget

* fix theme binfings for JSONForm fields under Object

* fix table widget theming bug

* fix: addressed code review comments

* fix: unit test cases

* fix: qa migration callouts

* fix table widget theming bug

* fix JSONForm currency input dropdown not submit form

* Added new tests - AppThemingSpec

* fix qa bugs

* fix unit test

* fix JSONForm cellBorderWidth to have default value post migration

* fix unit test

* fix qa bugs

* remove unused imports

* fix qa bugs

* fix JSONForm input height issue

* fix qa bugs

* Updating Theming spec

* * dropdown color fixes (#13249)

* fix caching issue
;

* Fixed Theming tests

* fix tests

* fix tab widget tests

* fix: json form children level migration issue

* fix table widget tests

* Updated test

* updated tests

* updated test

* updated tests

* updated tests

* updated pageload

* fix cypress tests

* remove cypress created files

* fix color picker issues

* Failure fixes

* Fixed some more tests

* fix: cypress test failures

* fix tests

* remove consoles

* fix table tests

* fix qa bugs

* updating snapshots for AppPageLayout_spec as per new UI

* fix rating widget bug

* fix qa bugs

* fix:
* cypress failing tests
* Migration QA callouts
* Removed unused imports

* update constract check algo

* fix color contrast issue

* fix: cypress failure test cases

* update font sizes labels

* fix regression bugs

* fix:
* JSON form labelTextSize issue fix
* Updated comment for the fontSizeUtility function
* migrations issues related to table widget borderRadius and boxShadow

* fix: default labelTextSize issue for the Input and Select families

* fix regression bugs

* fix regression bugs

* PassingParams spec - added wait time

* fix: font family default value issue on JS toggle

* fix js toggle issue in text widget

* fix tests

* fix tests

* fix tests

* fix cypress tests

* fix regression bugs

* fix regression bugs

* fix:
* refactored table widget migration function as per review comments,
* added default value to the widget

* fix: failing unit test cases

* fix theming spec

* fix cypress tests

* test: fixed failed cypress test

* incorporate ashit feedback

* fix cypress tests

* fix: addressed review comments

* comment out table cypress test

* fix merge conflicts

* comment out color picker tests

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aswath K <aswath@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Ashit Rath <ashit@appsmith.com>
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-04 15:15:57 +05:30
balajisoundar
8163becacc
fix: DisplayText in table url column should be processed properly for empty values (#13318)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-04 14:59:42 +05:30
Favour Ohanekwu
7261834fe5
fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521)
* prevent execution of onPageLoad actions before sucessful actions fetch

* Perform url update before fetching actions and jscollections
2022-05-04 09:43:26 +01:00
akash-codemonk
05fdfd540b
fix: welcome form shown for a while after signup (#13304) 2022-05-04 14:13:02 +05:30
rahulramesha
e128b2daf3
feat: new Widget Copy paste experience (#12906)
* copy paste commit

* class name generator changes

* modal widget fixes change

* addressing review comments

* bug fix for after deleting a widget by undoing action

* additional fix for modal widget

* additional tests for fixes
2022-05-04 13:28:57 +05:30
ashit-rath
7dbe9ccf26
fix: JSONForm placed in modal does not update default value from source data (#13453) 2022-05-04 12:53:48 +05:30
Abhijeet
9fc9f7a774
chore: Commit application files during the connect flow (#12288)
* Commit application files during the connect flow

* Refactor detach remote method name

* updating connectToGitRepo method

* fix git tests

* Update default dsl to remove uncommitted changes for bottomRow and pathlist

* updating git cypress tests

* fixed git bug spec cypress test

* enabled other test case

* with store test

* fixed comment

* closing git sync modal

* updated test logic

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
Co-authored-by: Parthvi12 <80334441+Parthvi12@users.noreply.github.com>
Co-authored-by: haojin111 <haojin828@outlook.com>
2022-05-04 12:27:07 +05:30
dependabot[bot]
356a3d646d
chore(deps): bump cross-fetch from 3.1.4 to 3.1.5 in /app/client (#13427)
Bumps [cross-fetch](https://github.com/lquixada/cross-fetch) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/lquixada/cross-fetch/releases)
- [Commits](https://github.com/lquixada/cross-fetch/compare/v3.1.4...v3.1.5)

---
updated-dependencies:
- dependency-name: cross-fetch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 10:57:01 +05:30
ashit-rath
06168ecb60
fix: submit button not disabled in invalid json form on first load (#13415)
* fix: submit button not disabled in invalid json form on first load

* reset fixes
2022-05-04 10:45:27 +05:30
Favour Ohanekwu
3efb3588d2
chore: Add JS editor test cases 2022-05-03 15:22:45 +01:00
Vishnu Gp
acca123872
Merge pull request #13462 from appsmithorg/feat/analytics-events-for-authentication-methods
Feat: Added analytics events for GitHub and Google Auth
2022-05-03 19:51:39 +05:30
haojin111
0414c8823d
fix: 12456 - oauth redirection issue (#13511)
* fixed issue of gsheet authorization
* hidden cloudhost ip info on reconnect modal
2022-05-03 14:22:48 +05:30
Anagh Hegde
75a326470c
fix: Add null check for createdAt field in analytics event (#13491)
* Add null check for createdAt field

* send empty value
2022-05-03 11:42:34 +05:30
Anagh Hegde
d274fa3974
fix: Optimize flow to maintain page order during export-import (#13401)
* Use map isntead of sorting list

* Refactor

Co-authored-by: Abhijeet <abhijeet@appsmith.com>
2022-05-03 11:42:22 +05:30
Rimil Dey
c55718f9f1
fix: don't run onClick event handler when button is disabled (#12333) 2022-05-03 07:25:31 +02:00
Favour Ohanekwu
395fd30335
add overflow to js editor settings (#13488) 2022-05-02 20:34:55 +02:00
Ankur Singhal
3b63f59a16 added the force true to single-select action selector 2022-05-02 15:47:25 +05:30
Ankur Singhal
0d0f5d4c2c Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/pp-datepicker 2022-05-02 13:23:59 +05:30
haojin111
c300bc9eeb
Merge pull request #13472 from appsmithorg/fix/12603-git-import-modal-message
fix: 12603 - git import modal message of remote url inputbox
2022-05-02 14:23:48 +08:00
haojin111
ca33d68532 fixed uppercase of url 2022-05-02 12:50:49 +08:00
Parthvi12
2f4ca6aa98
test: Add tests for git sync app and git bugs (#13394)
* Add tests for gitSync

* add test for git import bug#12749

* modified importAppfromGit method

* add test for bug #13385

* updated tests

* fixed test

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-02 09:59:03 +05:30
haojin111
ecffa88684 updated label text of remote url 2022-04-30 21:18:53 +08:00
rashmi rai
4596a12bfd
added fixActionPayloadForMongoQuery (#13465) 2022-04-30 08:27:15 +05:30
Nayan
e9b1108e47
fix: Set default theme when application is exported (#13321)
When application is exported and it does not have a theme set, a NullPointerException was raised in that case. This PR fixes that by returning the default theme when theme is missing.
2022-04-30 01:41:08 +06:00
Preet Sidhu
c6f3f356e6
Merge pull request #12964 from appsmithorg/fix-10379
fix: 10379 disable html parsing for long texts
2022-04-29 12:29:36 -04:00
Rishabh Rathod
3b1fbfa989
fix: replace klon/full with klona default (#13457)
- when manipulating props, react state (immutable values)
2022-04-29 15:14:17 +00:00
Vishnu Gp
a8fa0b7465 Added analytics events for GitHub and Google Auth 2022-04-29 19:18:24 +05:30
Anagh Hegde
3e3a32604a
fix: Git connected Application forking should use default branch application (#13255)
* Application forking use default branch application

* refactor changes

* Update the permission
2022-04-29 19:05:23 +05:30
Ankita Kinger
63479dbb3e
chore: update subtext copies for Google & Github (#13451)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
2022-04-29 17:52:27 +05:30
Preet
2ee727bd84 Merge branch 'release' into fix-10379 2022-04-29 06:34:47 -04:00
akash-codemonk
9b9048fdc4
chore: add analytics event for similar templates click (#13177) 2022-04-29 15:39:16 +05:30
Anagh Hegde
0653f657cf
Merge pull request #13262 from appsmithorg/bug/duplicate-app-git-connected
fix: For git connected apps duplicate should use default branch resources
2022-04-29 15:01:50 +05:30
Paul Li
297b6141c0
fix: feedbacks on label feature (#13123)
* fix: Fix on feedbacks on Label feature

-- Eliminate CSS restriction for horizontal scrolling

* fix: feedbacks on label feature

-- Eliminates CSS rules for overflow-x: hidden
2022-04-29 17:21:08 +08:00
Ankur Singhal
e29a879ff7 Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/pp-datepicker 2022-04-29 14:14:37 +05:30
Preet Sidhu
5726ed0919
chore: add perf test for select widget (#12409)
* wip

* add select widget perf test

* fudge cred

* Revert "fudge cred"

This reverts commit e2e78ed4c126c385b31ca03d9ea5834114849637.

* pr updates

* pr updates

* remove single test script

* remove coverage summary changes
2022-04-29 14:12:03 +05:30
Nayan
501fb1c1ed
feat: Delete theme when application is deleted (#13252)
This PR archives the related themes when an application is deleted aka archived.
2022-04-29 12:38:09 +06:00
Maulik
59e8ad12e1
fix: allow camera & mic access for page in iframe widget 2022-04-29 11:49:44 +05:30
Anagh Hegde
4a19f83a42 Merge branch 'release' into bug/duplicate-app-git-connected 2022-04-29 11:43:45 +05:30
Tolulope Adetula
fa48a026ad Merge branch 'release' into fix/disable-cancel-button-on-a-disabled-select-widget 2022-04-29 06:12:19 +01:00
Tolulope Adetula
16724bdc04
Merge pull request #13074 from appsmithorg/fix/table-mutiselect-checkbox-alignment
fix: table Widget Multiselect Row checkbox alignment
2022-04-28 21:51:38 -07:00
akash-codemonk
cc3de11bfa
fix: dropdown showing an empty row when the options list is empty (#13364) 2022-04-29 10:09:44 +05:30
Tolulope Adetula
14e1b20464
Merge pull request #12626 from appsmithorg/feat/show-page-count-when-total-records-exist
feat: show total records and pageCount in table header
2022-04-28 19:30:51 -07:00
Tolulope Adetula
5749a4461b Merge branch 'release' into feat/show-page-count-when-total-records-exist 2022-04-29 02:37:59 +01:00
Tolulope Adetula
302644473c
Merge pull request #13164 from appsmithorg/fix/Primary-column-control-visibility-icon-out-of-sync
fix: Primary column control visibility icon out of sync
2022-04-28 18:35:11 -07:00
Tolulope Adetula
76b2e219f6 fix: build issue 2022-04-29 02:22:28 +01:00
Favour Ohanekwu
942547287c
feat: js object v1 run and settings redesign (#11456) 2022-04-28 17:51:02 +01:00
Tolulope Adetula
70c475f049
Update Icon.tsx 2022-04-28 04:59:14 -07:00
Tolulope Adetula
359d3706fe Merge branch 'release' into fix/Primary-column-control-visibility-icon-out-of-sync 2022-04-28 12:42:04 +01:00
Tolulope Adetula
47398e20d9 fix: PR reviews 2022-04-28 12:25:14 +01:00
Ankur Singhal
f2cabb8eec Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/pp-datepicker 2022-04-28 16:51:19 +05:30
Anagh Hegde
2c484d5538
fix: Unable to see apps in home page after git connect fails (#13387) 2022-04-28 16:43:53 +05:30
Ankur Singhal
47d219cc90 removed day click and clear click which was crfeating the ambiguity 2022-04-28 16:36:18 +05:30
Pawan Kumar
0aec29d837 update theming config 2022-04-28 16:00:03 +05:30
Pawan Kumar
6052600d0b update theming config 2022-04-28 15:58:51 +05:30
Ankita Kinger
3835e81105
chore: Add analytic event for the Reset button click on the Admin settings page. (#13408) 2022-04-28 14:46:38 +05:30
Favour Ohanekwu
02d4af3ed7
prevent multiple execution of pageload actions when generating a template (#13361) 2022-04-27 19:28:52 +01:00
Ankita Kinger
251ad6097b
chore: Add analytic events on Authentication page (#13384)
* added analytic events for Authentication page on Admin settings

* updated event names
2022-04-27 23:16:24 +05:30
rahulramesha
727889434c
fix: calculating the canvas container height to be exact to not scroll on scrollIntoView() call (#13096)
* canvas container Fix

* add comments
2022-04-27 15:43:29 +00:00
Ayangade Adeoluwa
5a126bfda2
Add space to both sides of response run button (#13368) 2022-04-27 12:42:29 +01:00
Tolulope Adetula
2d57840938 fix: add new line 2022-04-27 12:30:43 +01:00
Tolulope Adetula
7f8bf5c4fe fix: PR reviews 2022-04-27 12:29:31 +01:00
ashit-rath
fc36a3af94
feat: Analytics to log source data limit exceed (#13339)
* feat: Analytics to log source data limit exceed

* minor change
2022-04-27 14:04:15 +05:30
Maulik
0eef3b0bfd
fix: code hidden issue for JS Enabled fields (#13241)
* fix code hidden issue for JS Enabled fields

* test for code hidden fix
2022-04-27 12:37:33 +05:30
Anagh Hegde
a768bb5eb7 Merge branch 'release' into bug/duplicate-app-git-connected 2022-04-27 12:31:23 +05:30
haojin111
7b09976f52
feat: 12457 - added application import success modal (#12739)
* added application import success modal

* updated logic and added cypress test

* fixed cypress test

* added local storage for refresh

* fixed issue - 11721 git import issue

* fixed cypress test with new designd modal

* fixed cypress test failed issue
2022-04-27 12:07:04 +05:30
Anagh Hegde
456b5b94ef
fix: Page order sequence for git import (#13126)
* Added page sequence to metadata

* Update test resources

* Add null check for the pageOrder List

* FIx NPE

* Add logic to handle page order for deployed version

* Add tests for the page order

* Add null check for published pages

* Fix unpublished page names getting added in the order list for published

* update the variable name

* Use published page order in tests for published view

* Fix NPE
2022-04-27 11:45:40 +05:30
Nidhi
e73fd0a269
fix: Parse nested structures as tables for action execution results (#13328)
* fix: Parse nested structures as tables

* Updated comments
2022-04-27 08:45:15 +05:30
Ayangade Adeoluwa
c264e1cd89
Add fallback for responseType, in case it does not exist (#13324) 2022-04-26 20:40:59 +05:30
Nidhi
10f83ef698
fix: Throw error on trying to access non-existent unpublished action (#13210)
* fix: Throw error on trying to access non-existent unpublished action

* Fixed NPE at copy policies from page to action
2022-04-26 20:04:14 +05:30
Nidhi
ea6debab20
fix: Added contains and not equals options to where clause in Google Sheets (#13208) 2022-04-26 20:03:17 +05:30
Arsalan Yaldram
4dabbd8f13
fix: onSucess & onError action selector () => {} (#12753) 2022-04-26 20:01:23 +05:30
Ankita Kinger
cd84b63373
added check for disconenct button clicked once (#13272) 2022-04-26 19:51:06 +05:30
albinAppsmith
1d019d1376
fix: Modal padding and color fixes (#12189)
* * share modal fixes

* * modal ui fixes
2022-04-26 19:26:07 +05:30
Sumit Kumar
7e9eb58f03
fix: fix action objects missing plugin id and plugin type info in database (#13263)
* add plugin id and type info to action object if found missing
* this fix is currently added to the read and update action flows
2022-04-26 16:51:30 +05:30
Abhijeet
b88cdacc7d
Fix npe and duplication for JSObject during clone application (#13297) 2022-04-26 13:13:58 +05:30
Tolulope Adetula
faea2712fe fix: disable cancel button on a disabled select widget 2022-04-25 13:36:36 +01:00
Anagh Hegde
838b45a8f5 Add branchName check for the clone 2022-04-25 14:24:04 +05:30
Anagh Hegde
94ba542606 use default branch app for clone operation 2022-04-25 14:18:17 +05:30
Bhavin K
20aa7196d2
fix: handle editor value update (#12726) 2022-04-25 12:32:55 +05:30
f0c1s
d428262bf9
fix: Azure SSH url was not accepted for git connection (#12896) 2022-04-23 18:01:43 +05:30
haojin111
08bbd55020
Merge pull request #13207 from appsmithorg/fix/13184-master-branch-issue
fix: 13183, 13184 - fixed issue of correct branch name on edit mode
2022-04-23 05:03:44 +08:00
Aishwarya-U-R
8c8a3b0695
Adding wait to fix flake failures (#13226) 2022-04-22 19:46:03 +05:30
ashit-rath
1acf242600
feat: JSONFrom add isValid form level property to represent overall form validity (#13083) 2022-04-22 17:20:51 +05:30
Ayangade Adeoluwa
a896467e69
fix: Change response tab name (#12930)
* Change response tab name

* Fix response tab name
2022-04-22 12:10:00 +01:00
Aman Agarwal
9a022a668f
fix: datasource ui style issues resolved (#13175) 2022-04-22 16:23:00 +05:30
Bhavin K
78600bd2ed
fix: handle dropdown flickers (#12979) 2022-04-22 15:56:48 +05:30
Abhinav Jha
60503bb9a6
feat: Dynamic Height widget config (#13143)
* Add platform feature which adds dynamic height property controls and default properties based on widget config

* Move features to the top, so that defaults can override them if necessary

* - Add unit tests to verify that the property controls show up for dynamic height
- Add unit test to verify that the hidden hook in the dynamic height controls work
- Fix console warning for react key unavailable in Generator.tsx
- Move constants and types to their respective files

* Remove dynamic height config from Container Widget

* Add comments in hard to understand areas

* Add function which converts fn validation params to fnString
2022-04-22 15:14:22 +05:30
ashit-rath
07757c7e7b
fix: Replace "klona/full" -> "klona" in JSONForm to avoid cloning of non-enumerable properties (#13193)
- non-enumerable like `writable`, `configurable`, `enumerable` were getting cloned with `klona/full` and it wasn't needed.
2022-04-22 14:15:45 +05:30
Nayan
0a038e714f
feat: added page names to the templates meta data (#12786)
Adds page names to templates meta data
2022-04-22 12:58:35 +06:00
haojin111
498b9a6f7e fixed issue of correct branch name on edit mode 2022-04-22 14:36:49 +08:00
Bhavin K
7e3d873d20
feat: added searched address into map center data (#12962) 2022-04-22 11:44:42 +05:30
Nayan
c4ee44de15
feat: log template app name to analytics service when template is forked (#12972)
Logs application template name to analytics service when template is forked.
2022-04-22 11:40:32 +06:00
Vishnu Gp
534bdd93b2
fix: Add validation for Git URLs on server (#13182)
This PR adds a backend validation for git URLs on the backend side. Plus added some more test cases for URLs
2022-04-22 07:23:13 +05:30
Nayan
6889882088
feat: updated download template App API to download from cloud services (#12311)
Update download json file API so that it downloads via cloud services
2022-04-22 00:19:46 +06:00
akash-codemonk
7d646bf11c
chore: redirect to home page at the end of onboarding (#12961) 2022-04-21 19:28:26 +05:30
Ankita Kinger
6f311944be
fix: add edition check on cypress to avoid merge conflicts on EE (#13188)
* added edition check on cypress to avoid merge conflicts on EE

* minor change
2022-04-21 19:04:03 +05:30
arunvjn
bdcc99b53b
chore: Hides update button when there are no pending updates. (#13152) 2022-04-21 18:44:10 +05:30
Bhavin K
958233f4f5
fix: added dataFormat into file data (#12807) 2022-04-21 16:09:24 +05:30
Satish Gandham
f6b29d3b71
Fix perf infra data collection (#13158)
Only last run data was being saved to supabase since we were changing the value in the same object.
2022-04-21 15:30:07 +05:30
Nayan
15394207a5
feat: Add API to get template filters (#12969)
Adds a new API to get available filters for application templates from Appsmith cloud services. It acts as a proxy to the API.
2022-04-21 15:52:27 +06:00
Nidhi
d14d8d356e
chore: Added jcmd to Appsmith server image (#13155) 2022-04-21 13:56:49 +05:30
albinAppsmith
978f1d3cd1
chore: Added margin bottom for sign posting checklist footer (#12884) 2022-04-21 11:44:34 +05:30
Ankita Kinger
9ed26a92b0
chore: update a cypress test (#13036) 2022-04-21 11:44:02 +05:30
Abhijeet
3a22cda148
Add index for git (#13133) 2022-04-21 11:10:41 +05:30
Preet
19172bf2b6 reduce line break limits to 1000 2022-04-20 13:22:45 -04:00
Preet
eb4eaf849a Merge remote-tracking branch 'origin/release' into fix-10379 2022-04-20 13:20:22 -04:00
Aishwarya-U-R
ade7b05adb
test: Automation script update to fix PromisesSpec failure (#13148)
* Promises spec fix for validating EitherOr

* Sipping LayoutValidationForLoginPage failure case
2022-04-20 22:00:22 +05:30
arunvjn
c925bf2efd
fix: scroll to active entity in explorer on route change (#13085)
* Scroll to active entity in explorer on route change

* Removes scroll animation

* Open modal via entity explorer

* Try tonavigate to canvas only in edit mode

* Added cypress to assert modals' presence when triggered from the API page.
2022-04-20 21:55:55 +05:30
Tolulope Adetula
04ac78ba15 fix: Primary column control visibility icon out of sync 2022-04-20 14:56:01 +01:00
rahulramesha
98f6a3fede
move reflow out of beta (#12746) 2022-04-20 18:33:30 +05:30
Aman Agarwal
356cdfffab
fix: changed prop drilled fn to class fn, avoided array prop (#12788) 2022-04-20 15:56:27 +05:30
Leo Thomas
c8f88ed977
fix: 11141-JDBC override parameter for resolving TZ Cast Errors (#12821) 2022-04-20 14:50:49 +05:30
ashit-rath
5b3f29a6bc
fix: onOptionChange event not triggering in JSON Form radio group field (#13073) 2022-04-20 14:47:34 +05:30
Vishnu Gp
cfb7fc4b94
fix: git remote SSH url for Azure | BE (#12933)
Users were not able to add Git SSH URLs from some providers. This fixes the BE aspects of this issue.
2022-04-20 14:47:02 +05:30
rahulramesha
27b54f22e8
Reflow overlapping fix on canvas edges (#12745) 2022-04-20 12:56:35 +05:30
Pawan Kumar
a5e32c8083
chore: Update theming default themes configs (#13117)
* theming config update

* add progress bar

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-04-20 12:08:35 +05:30
Aman Agarwal
4f4d1400c5
fix: updated the condition to show expiry key (#13092) 2022-04-20 11:32:01 +05:30
haojin111
923efa9696
fixed issue of deleting original default branch (#13062) 2022-04-20 05:50:54 +05:30
Anagh Hegde
ecb08a4918
Add logic to change default branch for git connected application (#11549)
We are opening the appsmith default application when the user clicks on edit. But when the app is connected to git we should always bring up the default application of the default branch.
2022-04-19 19:43:23 +05:30
Abhijeet
cebccc5401
Fix issues in git flows when pages don't have reference in application object (#13040)
As a part of git-directory update we have introduced a bug where if the entity names includes the - we were not able to filter the entities in the individual page directory. This commit introduces a new name-seperator to avoid such issues.
2022-04-19 17:25:11 +05:30
Tolulope Adetula
a892aa678d fix: Table Multiselect checkbox alignment 2022-04-19 09:40:42 +01:00
rashmi rai
bb5d7159c6
Always show advanced settings in rest api editor (#12927) 2022-04-19 12:03:27 +05:30
Ankita Kinger
5b4628a9d4
Add common code for SAML (#12976)
Added new form field component in ads. Also, updated copy URL form component.
2022-04-18 17:47:29 +05:30
Anagh Hegde
f9fee48c14
Remove feature flag for git import (#12909) 2022-04-18 16:36:59 +05:30
Anagh Hegde
4b8646dd05
Handle logic to delete the application during git delete branch flow (#12986) 2022-04-18 15:24:40 +05:30
Rishabh Rathod
8df17fd56c
chore: remove minifying in dev to ease debugging (#12940) 2022-04-18 13:51:36 +05:30
Bhavin K
3575a03005
fix: updated cursor style in actionWrapper (#12850) 2022-04-18 11:39:11 +05:30
Preet Sidhu
820a99e5d1 disable html parsing for long texts 2022-04-15 10:03:38 -04:00
Bhavin K
b6b253a636
fix: update custom chart data and type only (#12574) 2022-04-15 16:28:13 +05:30
akash-codemonk
71591ff75f
chore: remove frontend template feature flag (#12937) 2022-04-15 14:58:27 +05:30
arunvjn
b69b1191cf
fix: widgets from other apps shown in omnibar (#12890) 2022-04-15 11:10:56 +05:30
Abhijeet
a12750b536
feat: Update directory structure for git-sync to mimic UI (#11705)
* File migration for git

* Testcases added

* Comments added

* Update the action file names to keep unique constraints

* Separate out the theme from metadata

* Update server version to convey the file migration
2022-04-14 23:35:08 +05:30
Aswath K
25afe65cb7
Merge pull request #12923 from appsmithorg/fix/delete-button-kdb
feat: makes option control delete button keyboard accessible
2022-04-14 19:57:06 +05:30
Rishabh Rathod
846ba223ea
fix: replace rfdc with klona (#12568)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-14 14:19:13 +00:00
akash-codemonk
90fa2d7912
fix: onboarding deploy step getting redirected to edit view (#12830) 2022-04-14 16:58:51 +05:30
Aswath K
6a4b632338 Merge branch 'release' into fix/delete-button-kdb 2022-04-14 16:24:52 +05:30
Paul Li
eb37416a2a
feat: Controls for labels in widgets to align the widgets in forms and other places (#10600)
* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Create a new property control for a label position
-- Create a new property control for a label alignment
-- Prototype a label section for Input widget

* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Add a property, labelWidth in the property pane

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Input widget: Implement all the requirements in case its type is Text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adapt the functionalty on other types of the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into DropdownWidget
-- Clean up for the input widget and DRY

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectWidget
-- Eliminate unnecessary component prop, columns

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalties into Tree Select widget
-- Add styles for alignment between lable and input control over the widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectTreeWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Introduce label functionalities into DatePickerWidget2
-- Use width instead of columns prop in InputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RichTextEditorWidget
-- Eliminate compactMode from StyledLabel

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into CheckboxGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement switch group for the correct meaning of right alignment

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RadioGroupWidget
-- Add new properties, alignment and inline for consistency

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adjust cols and rows for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused StyledRadioProps

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete first MVP of enhanced SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete the first MVP of enhanced RadioGroupWidget
-- Eliminate unused StyledSwitch component for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add min-height, align-self rules for LabelContainer

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Use original label property for RadioGroupWidget
-- Add a migration for adding isInline and alignment properties for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Update version to latest one in DSLMigrationsUtils.test.ts

* fix failing jest test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement label functionalities on BaseInputWidget, InputWidgetV2, CurrencyInputWidget, PhoneInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DSLMigrationsUtils

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the label related test case which is failed in Input_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places
-- Fix on #10119: The label text truncates on resizing the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix scroll issue when shrink with MultiSelectWidget and MultiSelectTreeWidget

* fix: Widget Popup test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement width and alginment features on the level of label element
-- Prevent actual inputs from DropdownWidget, MultiSelectWidget, SingleSelectTreeWidget, MultiSelectTreeWidget from overflow when resizing
-- Enable label feature on a RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set label container's default width to 33% when width is not set

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix crash issue when labelWidth is filled by non-numeric value, eliminating passing NaN as its value

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set flex-grow to zero on input types other than TEXT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label features on newly created MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate LabelPositionTypes, directly using enum LabelPosition
-- Add a comment for a constant LABEL_MAX_WIDTH_RATE
-- Directly import React for LabelAlignmentOptionsControl
-- Remove unnecessary constructor for LabelAlignmentOptionsControl
-- Define handleAlign instance method as a higher-order function
-- Only migrate alignment property for RadioGroupWidget
-- Use Object.hasOwnProperty instead of in operator

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Migrate alignment property of RadioGroupWidget in case of currentDSL.version is 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Revert currentDSL.version to 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a Jest test case for RadioGroupWidget's alignment property migration

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Replace all nested ternary operators with if statements

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label feature on new version of SelectWidget
-- Add Cypress tests for widgets' label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor code for BaseInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change CSS selector for step buttons for Numeric BaseInputWidget
-- Directly use migrateRadioGroupAlignmentProperty migration function without using transformDSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on typo about migrateRadioGroupAlignmentProperty

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add data-testid attributes for Cypress selectors

* feat: Deprecate form button widget

-- Assert flex-direction to row in CheckboxGroup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a missing data-testid for SelectWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on failed test cases: CheckboxGroup_spec, DatePicker_2_spec, MultiSelectWidgetV2

* fix: Select popup DSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new property control, NumericInputControl
-- Replace all the label properties with the newly created controls

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new Cypress command, checkLabelWidth and apply to all related test cases
-- Increase width in checkboxgroupDsl.json
-- Rename className for label in MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement the tooltip feature for labels
-- Add missing props for labels in DateField, MultiSelectField, RadioGroupField, SelectField fields for JSONFormWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor property controls, including LabelPositionOptionsControl, LabelAlignmentOptionsControl, NumericInputControl to keep consistency
-- Apply default values into label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract the label related parts from the various widgets as an independent component

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate TypeScript any type from BaseInputComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change labelPosition property type to DROP_DOWN
-- Modify LabelAlignmentOptionsControl to use ButtonTabComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Define getLabelWidth method into BaseWidget
-- Extract the common CSS rules for the widget containers
-- Revert rows and columns for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed test case in DSLMigrationsUtils.test.ts

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on overflow issue on CheckboxGroupWidget
-- Create a distinctive spec file for label feature
-- Eliminate the redundant label specs with the relevant widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Delete unnecessary files, including Select_spec.js, LabelButton.tsx and LabelPositionOptionsControl.tsx
-- Revise wrong comment for checkLabelForWidget Cypress command

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Do not set the label width only if its value is 0
-- Clean up the component for DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Make RadioGroupWidget's layout flexible in all modes

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on Cypress test case for RadioGroupWidget in Widgets_Labels_spec
-- Change Cypress commands, including addAction, addSuccessMessage, enterActionValue to accept parentSelector

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change getLabelWidth method to not have any argument
-- Define some constants for label numbers
-- Extract the common styles for SwitchGroupWidget and RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor some constants

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused width prop from RadioGroupWidget
-- Get labelWidth from getLabelWidth

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate the min-height restriction on a label
-- Eliminate the scroll on the earlier InputWidgetV2 which was not in compact mode

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add one more condition checking if the current input type is text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract common code base for MultiSelectTreeWidget and MultiSelectWidgetV2
-- Apply a few CSS fixes on the scrollbar issue select related widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply some tweaks for earlier widgets with labels so as not to be broken UX

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed Cypress test case in Widget_Popup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add constants, LABEL_DEFAULT_WIDTH_RATE, SELECT_DEFAULT_HEIGHT, LABEL_MARGIN_OLD_SELECT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Increase the widths of CheckboxGroupWidget and SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set the font size to 14px for NumericInputControl

Co-authored-by: ohansFavour <fohanekwu@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-04-14 16:47:25 +08:00
Aswath K
1bf959d177 feat: makes option control delete button keyboard accessible 2022-04-14 13:23:41 +05:30
Ayangade Adeoluwa
a4d22b3d13
Handle stringified json response and fix alignment issue (#12886) 2022-04-14 12:53:07 +05:30
Rishabh Rathod
ee76cabb96
chore: fix Key missing error in Boxed component (#12912) 2022-04-14 06:31:50 +00:00
arunvjn
b7aff3c38b
chore: Parallellise fetch page call with actions, jsObject and plugins (#12537) 2022-04-14 10:16:17 +05:30
rahulramesha
cfba555fe8
chore: Should not persist DSL for mainContainer layout changes (#12351)
* Moving out non persistent state out of DSL

* replacing canvas width seector

* converting to immerReducer

* adding TODO and more immer reducer changes
2022-04-14 10:06:20 +05:30
Parthvi12
0766f83cf0
test: Add tests for git bugs and git import (#12751)
* add tests for git bugs and git import

* add dsl file

* added test for git bug and commented git sync test for apps

* updated tests

* removed wait

* updated messages.test.ts

* updated git import tests

* added fix for onboarding_spec
2022-04-14 08:32:57 +05:30
rahulramesha
faaf977728
feat: Container Jump Improvements and Code for tracking Container Jumps (#12686)
* conatiner Jump Optimization and tracking

* Round of mouse positions ans add negative jest test cases

* addressing review comments
2022-04-13 20:27:44 +05:30
Vishnu Gp
c7a4ac7353
fix: Organization name can be empty
fix: Organization name can be empty
2022-04-13 17:36:32 +05:30
Anagh Hegde
5c17422956
fix: Connection timeout for git connect when the git repo is behind a firewall (#12819)
* Use non blocking IO for checking the repo status

* Cache the results

* Update tests for the util class method
2022-04-13 10:33:28 +00:00
akash-codemonk
2abb7bb822
fix: welcome form getting submitted on pressing enter key (#12613) 2022-04-13 15:37:11 +05:30
f0c1s
736c2e024e
feat: git delete branch (#12681) 2022-04-13 15:33:23 +05:30
akash-codemonk
73482000a6
chore: search for templates with a given datasource or widgets (#12434) 2022-04-13 14:18:40 +05:30