Favour Ohanekwu
876d1a17e7
fix: prevent lint warnings from blocking execution in js objects ( #13700 )
2022-05-11 11:20:33 +01:00
rahulramesha
27d5ae8b77
fix: Avoid pasting list widget inside another list widget ( #13719 )
...
* fix for stopping list widget from copying onto itself
* remove duplicate comment
* verify selected widgets are not inside list widget if list widget is to be pasted
2022-05-11 14:46:22 +05:30
NandanAnantharamu
7199a329a9
test: Theme related tests ( #12740 )
...
* Removed unwanted waits
* Updated test for fonts
* Updated tests with Font and Theme usecases
* updated tests
* Added new tests and common locators
* Added default/update theme tests
* grouped tests
* Updated Theme tests
* updated multiwidget test
* updated theme tests
* Updated tests
* Reordered tests
2022-05-11 11:43:28 +05:30
Aishwarya-U-R
f5cc98644f
Automated tests to TableFilterSpec for Bug #13334 + failure fixes ( #13662 )
2022-05-10 10:40:46 +05:30
akash-codemonk
2b5d5dd89f
fix: triggering omnibar shortcuts toggles visibility when visible ( #11601 )
2022-05-09 19:43:57 +05:30
ashit-rath
47a31a8412
feature: JSONForm - disable add new and remove buttons when array is disabled ( #13520 )
2022-05-09 17:34:49 +05:30
Keyur Paralkar
1c1135d639
refactor: removed the duplicate style properties for the list widget ( #13605 )
...
* refactor: removed the duplicate style properties for the list widget
* test: fixed list_spec cypress failures
2022-05-09 15:41:36 +05:30
Favour Ohanekwu
3ab904d83d
fix:only show js successful execution toast message in edit mode ( #13590 )
...
* only show js successful execution toast message in edit mode
2022-05-07 17:03:03 +01:00
rashmi rai
c0f98ad4d7
fix:change default value in rest api json and placeholder ( #13261 )
2022-05-06 19:13:10 +01:00
haojin111
b6d2f971c0
feat: 12594 - added cypress test of form login on admin setting page ( #13178 )
...
* added cypress test of form login on admin setting page
* resotre setting after checked
* added a check if signup form is enabled for all users
* minor fix
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-05-06 20:21:08 +05:30
Arpit Mohan
4934fc9066
Merge pull request #13644 from appsmithorg/fix-12164
2022-05-06 16:17:37 +02:00
rahulramesha
7a501ecd9c
fix: stopping list widget from copying onto another list widget ( #13621 )
...
* fix for stopping list widget from copying onto itself
* remove duplicate comment
2022-05-06 19:41:09 +05:30
ashit-rath
ddc95fae53
fix: JSONForm fix events/actions controls JS mode produces additional binding strings ( #13509 )
...
* fix: JSONForm fix events controls js mode additional binding strings
* fixed globalContext value for fieldState update and fix FilterText spec
2022-05-06 15:29:56 +05:30
Anubhav
03684fce97
fix: disable revoke button after first click
2022-05-06 15:21:33 +05:30
ashit-rath
910427788e
fix: JSONForm currency and phone input dropdown not working in Array Field ( #13564 )
2022-05-06 15:19:36 +05:30
Aishwarya-U-R
e8c9d1da3e
test: Automated tests to improve coverage for JSObjects-onPageLoad + Flaky fixes ( #12904 )
...
* Adding theming spec
* Removed theming spec
* Reverted cypress.json changes
* Adding more JSOnPage load validations
* Added Theming - comment spec
* Theming - new cases
* JSOnload fix
* JSOnPage load cases update
* Bind_tabWidget fix
* Name update to CommunityIssues
* Flaky fixes
* Flaky fix
* Reverting postgress index addition
* Failure fixes
2022-05-06 11:10:10 +05:30
Aswath K
ca3f159f66
fix: set max-height for Dropdown component ( #13105 )
...
* fix: set max-height for Dropdown component
* changes style for date format dropdown
* Combines MultiSelectControl into DropdonwControl
* fix: max height set via props
* fix: popover double scrollbar issue
* fix: styles for chips
* Delete MultiSelectControl
* fix: error when pressing Enter twice
* add tests for multi select & fix some warnings
* removes unwanted test file
* fix: country filtering issue
* address review comments
* fix dropdown for primary columns dropdown
* fix: issue with position
* Adds scrollIntoView when using arrow key for navigation
* fixes issue with scrollbar
* fix: jest tests
* fix: jest test
* fix: flaky cypress test
* fix: height & align issue in Date format selection
* smoothens the scroll
2022-05-06 10:34:17 +05:30
f0c1s
7a3985f962
feat: git discard changes ( #11835 )
...
* feat: git discard changes
* fixed cypress test in git connection
* feat: add discardDocUrl and update casing
* chore: update tests
* chore: fix review comment
Co-authored-by: haojin111 <haojin828@outlook.com>
2022-05-06 10:14:24 +05:30
ashit-rath
f0952b8082
fix: JSONForm RadioGroupField - support numeric values in the options ( #13365 )
...
* fix: JSONForm RadioGroupField accept numeric values in the options
* cypress test - clear options before adding
* update code editor clear
2022-05-05 11:10:52 +05:30
Parthvi12
b84f827ef2
test: fix Tab widget related cypress tests ( #13571 )
...
* fix Bind_TabWidget_Input_spec and Tab_new_scenario_spec
2022-05-05 09:05:36 +05:30
ankurrsinghal
ef79f6450d
Merge pull request #12190 from appsmithorg/feature/pp-datepicker
...
feat: added keyboard interaction for datepicker
2022-05-04 18:10:27 +05:30
Favour Ohanekwu
59710de95b
chore: highlight name input field for newly created js objects ( #13212 )
2022-05-04 10:47:41 +01:00
Pawan Kumar
809a633306
feat: App Theming ( #9714 )
...
* fix style bugs
* fix select styles
* test: fix font size issue for cypress tests
* incorporate ashit feedback
* test: addresed review comments for cypress tests
* add analytics events
* height issue in view mode
* incorporate code review feedbacks
* incorporate code review feedbacks
* refactor: addressed review comments; removed border radius and box shadow for text widget; Updated migrations
* feat: Makes shadow and radius controls keyboard accessible (#11547 )
* makes shadow and radius controls keyboard accessible
* removes unused imports
* moves options out of render method
* fix: changed the misnomer background property name to the relevant property name
* fix: border radius issue for the map widget
* address qa bugs
* address qa bugs
* fix ux of theming pane when widget is selected
* fix:
* added backgroundColor to the video widget
* restricted pop-over border radius to 0.375rem
* added box shadow for the input group for select widget
* fix: added delete icon in the delete theme modal
* address qa bugs
* change checkbox column size in config
* add js convertible to button color
* remove unused imports
* test: fixed jest tests
* fix primary color typo
* fix: migrations for the theming
* fix:
* Removed background color from MultiTreeSelect and TreeSelect component.
* grouped button's menu button pop over border radius restricting to 0.375rem.
* test: updated Dsl migration UT
* address qa bugs
* address qa bugs
* fix: address qa comments
* address qa bugs
* fix:
* migration issue;
* unit test cases;
* fix rating widget scroll issue
* fix youtube video border radius bug
* fix select widget
* fix select widgets styles
* address qa bugs
* merge conflicts
* makes the reset button keyboard accessible (#12134 )
* -resolved merge conflicts
* address qa bugs
* fix: labelTextSize migration fixes
* refactor:
* made changes to the fontSizeUtils function
* fixed the issue related to unit tests
* fix button group widget
* remove unused imports
* fix: fixed the text size migration for the table widget
* refactor: addressed review comments for the table widget theming migration
* fix button group widget
* add init calls for view mode
* json form init theme changes
* fix: added migration for boxShadow, borderRadius and textSizes for table widget
* fix broken fields
* test: fixed unit tests
* wip
* inconsistancy fixes and schemaItem update in updateHook/fieldConfiguration
* feat: init json form migration theming
* json form primaryColor -> accentColor
* update table widget
* update table widget
* object field label styling
* fix: migration related to the JSON form
* fix: fixed labelTextSize migration for JSON form nested widgets
* property control nested stylesheet lookup
* JSONForm label styles form array items
* show label for checkbox field array item
* fix button group widget
* wip
* refactor: addressed table widget review comments
* refactor: addressed ashit review comments;
* added childStylesheet for widgets
* feat: Keyboard navigable Color Picker control (#11797 )
* Makes ColorPicker keyboard accessible
* seperate out keyboard and mouse interactions
* fix issue with not focusing back to input
* Adds test for Color picker
* chore: added comment for the boxShadow property
* fix:
* added unit test cases for the widget and property utils
* resolved warning messages
* wip
* theme config update
* fix merge conflicts
* refactor: moved theming migration inside the migrations folder
* fix qa bugs
* fix jest test
* fix: unit test cases
* fix table column creation logic
* refactor: addressed review comments for migrations
* fix: Overriding margin and padding for custom render in the dropdown component (#12875 )
* * fix for custom render padding and margin in ADS dropdown
* * fix for removing padding from normal render options
* refactor: moved the boxShadow condition to the variable
* fix qa bugs
* fix: migration QA callouts for audio recorder widget
* refactor: added updated comments for boxShadow migration for table widget
* fix theme binfings for JSONForm fields under Object
* fix table widget theming bug
* fix: addressed code review comments
* fix: unit test cases
* fix: qa migration callouts
* fix table widget theming bug
* fix JSONForm currency input dropdown not submit form
* Added new tests - AppThemingSpec
* fix qa bugs
* fix unit test
* fix JSONForm cellBorderWidth to have default value post migration
* fix unit test
* fix qa bugs
* remove unused imports
* fix qa bugs
* fix JSONForm input height issue
* fix qa bugs
* Updating Theming spec
* * dropdown color fixes (#13249 )
* fix caching issue
;
* Fixed Theming tests
* fix tests
* fix tab widget tests
* fix: json form children level migration issue
* fix table widget tests
* Updated test
* updated tests
* updated test
* updated tests
* updated tests
* updated pageload
* fix cypress tests
* remove cypress created files
* fix color picker issues
* Failure fixes
* Fixed some more tests
* fix: cypress test failures
* fix tests
* remove consoles
* fix table tests
* fix qa bugs
* updating snapshots for AppPageLayout_spec as per new UI
* fix rating widget bug
* fix qa bugs
* fix:
* cypress failing tests
* Migration QA callouts
* Removed unused imports
* update constract check algo
* fix color contrast issue
* fix: cypress failure test cases
* update font sizes labels
* fix regression bugs
* fix:
* JSON form labelTextSize issue fix
* Updated comment for the fontSizeUtility function
* migrations issues related to table widget borderRadius and boxShadow
* fix: default labelTextSize issue for the Input and Select families
* fix regression bugs
* fix regression bugs
* PassingParams spec - added wait time
* fix: font family default value issue on JS toggle
* fix js toggle issue in text widget
* fix tests
* fix tests
* fix tests
* fix cypress tests
* fix regression bugs
* fix regression bugs
* fix:
* refactored table widget migration function as per review comments,
* added default value to the widget
* fix: failing unit test cases
* fix theming spec
* fix cypress tests
* test: fixed failed cypress test
* incorporate ashit feedback
* fix cypress tests
* fix: addressed review comments
* comment out table cypress test
* fix merge conflicts
* comment out color picker tests
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aswath K <aswath@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Ashit Rath <ashit@appsmith.com>
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-04 15:15:57 +05:30
balajisoundar
8163becacc
fix: DisplayText in table url column should be processed properly for empty values ( #13318 )
...
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-04 14:59:42 +05:30
Favour Ohanekwu
7261834fe5
fix: only execute pageload actions after successfully fetching actions and jscollections in view mode ( #13521 )
...
* prevent execution of onPageLoad actions before sucessful actions fetch
* Perform url update before fetching actions and jscollections
2022-05-04 09:43:26 +01:00
rahulramesha
e128b2daf3
feat: new Widget Copy paste experience ( #12906 )
...
* copy paste commit
* class name generator changes
* modal widget fixes change
* addressing review comments
* bug fix for after deleting a widget by undoing action
* additional fix for modal widget
* additional tests for fixes
2022-05-04 13:28:57 +05:30
ashit-rath
7dbe9ccf26
fix: JSONForm placed in modal does not update default value from source data ( #13453 )
2022-05-04 12:53:48 +05:30
Abhijeet
9fc9f7a774
chore: Commit application files during the connect flow ( #12288 )
...
* Commit application files during the connect flow
* Refactor detach remote method name
* updating connectToGitRepo method
* fix git tests
* Update default dsl to remove uncommitted changes for bottomRow and pathlist
* updating git cypress tests
* fixed git bug spec cypress test
* enabled other test case
* with store test
* fixed comment
* closing git sync modal
* updated test logic
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
Co-authored-by: Parthvi12 <80334441+Parthvi12@users.noreply.github.com>
Co-authored-by: haojin111 <haojin828@outlook.com>
2022-05-04 12:27:07 +05:30
ashit-rath
06168ecb60
fix: submit button not disabled in invalid json form on first load ( #13415 )
...
* fix: submit button not disabled in invalid json form on first load
* reset fixes
2022-05-04 10:45:27 +05:30
Ankur Singhal
3b63f59a16
added the force true to single-select action selector
2022-05-02 15:47:25 +05:30
Parthvi12
2f4ca6aa98
test: Add tests for git sync app and git bugs ( #13394 )
...
* Add tests for gitSync
* add test for git import bug#12749
* modified importAppfromGit method
* add test for bug #13385
* updated tests
* fixed test
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-02 09:59:03 +05:30
akash-codemonk
9b9048fdc4
chore: add analytics event for similar templates click ( #13177 )
2022-04-29 15:39:16 +05:30
Tolulope Adetula
5749a4461b
Merge branch 'release' into feat/show-page-count-when-total-records-exist
2022-04-29 02:37:59 +01:00
Favour Ohanekwu
942547287c
feat: js object v1 run and settings redesign ( #11456 )
2022-04-28 17:51:02 +01:00
Favour Ohanekwu
02d4af3ed7
prevent multiple execution of pageload actions when generating a template ( #13361 )
2022-04-27 19:28:52 +01:00
Maulik
0eef3b0bfd
fix: code hidden issue for JS Enabled fields ( #13241 )
...
* fix code hidden issue for JS Enabled fields
* test for code hidden fix
2022-04-27 12:37:33 +05:30
haojin111
7b09976f52
feat: 12457 - added application import success modal ( #12739 )
...
* added application import success modal
* updated logic and added cypress test
* fixed cypress test
* added local storage for refresh
* fixed issue - 11721 git import issue
* fixed cypress test with new designd modal
* fixed cypress test failed issue
2022-04-27 12:07:04 +05:30
Ankita Kinger
cd84b63373
added check for disconenct button clicked once ( #13272 )
2022-04-26 19:51:06 +05:30
Aishwarya-U-R
8c8a3b0695
Adding wait to fix flake failures ( #13226 )
2022-04-22 19:46:03 +05:30
ashit-rath
1acf242600
feat: JSONFrom add isValid form level property to represent overall form validity ( #13083 )
2022-04-22 17:20:51 +05:30
Ayangade Adeoluwa
a896467e69
fix: Change response tab name ( #12930 )
...
* Change response tab name
* Fix response tab name
2022-04-22 12:10:00 +01:00
Ankita Kinger
6f311944be
fix: add edition check on cypress to avoid merge conflicts on EE ( #13188 )
...
* added edition check on cypress to avoid merge conflicts on EE
* minor change
2022-04-21 19:04:03 +05:30
Ankita Kinger
9ed26a92b0
chore: update a cypress test ( #13036 )
2022-04-21 11:44:02 +05:30
Aishwarya-U-R
ade7b05adb
test: Automation script update to fix PromisesSpec failure ( #13148 )
...
* Promises spec fix for validating EitherOr
* Sipping LayoutValidationForLoginPage failure case
2022-04-20 22:00:22 +05:30
arunvjn
c925bf2efd
fix: scroll to active entity in explorer on route change ( #13085 )
...
* Scroll to active entity in explorer on route change
* Removes scroll animation
* Open modal via entity explorer
* Try tonavigate to canvas only in edit mode
* Added cypress to assert modals' presence when triggered from the API page.
2022-04-20 21:55:55 +05:30
ashit-rath
5b3f29a6bc
fix: onOptionChange event not triggering in JSON Form radio group field ( #13073 )
2022-04-20 14:47:34 +05:30
Anagh Hegde
ecb08a4918
Add logic to change default branch for git connected application ( #11549 )
...
We are opening the appsmith default application when the user clicks on edit. But when the app is connected to git we should always bring up the default application of the default branch.
2022-04-19 19:43:23 +05:30
Bhavin K
b6b253a636
fix: update custom chart data and type only ( #12574 )
2022-04-15 16:28:13 +05:30
arunvjn
b69b1191cf
fix: widgets from other apps shown in omnibar ( #12890 )
2022-04-15 11:10:56 +05:30
akash-codemonk
90fa2d7912
fix: onboarding deploy step getting redirected to edit view ( #12830 )
2022-04-14 16:58:51 +05:30
