Commit Graph

13528 Commits

Author SHA1 Message Date
Anand Srinivasan
d62e1961d8
fix: Add collapse icon for bottom bar (#16939)
* add containerRef and explandedHeight to enable collapse icon

* change icon

* sizing

* alignment fixes

* consistent height

* remove unwanted padding

* debugger panel height

* remove extra divider line

* open panel on header click

* rename method

* cypress tests init

* jsobject navigate instead of create

* clean up

* remove variable

* undo changes

* final clean up

* logs spec clean up

* debugger locators clean up

* rename locator

* mock db spec fix

* logs spec fix

* clean up records count locator

* Rename dubugger locators and methods

* spec file change

* move methods

* rename debugger helper class

* build fix

* handle selectors

* merge clean up

* fix failing tests

* use single variable to set height

* undo cypress env changes
2022-10-20 17:38:48 +05:30
Aishwarya-U-R
694a7d342e test: Script updates for flaky tests (#17603)
* Skipping Bug16702 spec

* Bug 16702 fix

* timeout spec index update

* Bug 16702 spec fix

* Bug16702 fix

* BUg16702 spec fix

* Bug 16702 revert

* fix template spec

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-10-20 14:35:27 +05:30
Parthvi
1b9373e3b0 test: Add cypress tests for template phase 2 (#17036)
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-10-20 14:29:47 +05:30
Anagh Hegde
bd95ae4ef0
chore: Add action execution params to analytics (#17562) 2022-10-20 13:37:48 +05:30
Rimil Dey
42b913cef8
feat: Add postMessage as a global function (#14925)
## Description

**Revert Context -** 

Reverts appsmithorg/appsmith#14890 (We had to revert the PR as we got some suggestions on improving the feature - now reverting the revert so we can have this feature out with improvements)

**PR Context -** 
This pull request exposes window.postMessage() as a global function in the Appsmith platform.

Post message safely enables cross-origin communication between window objects.
Example use-case - Appsmith page embedded within an iframe which communicates with the container website

Diagram for all the different levels of communication - 
![Untitled-2022-09-12-1205](https://user-images.githubusercontent.com/10229595/189592030-98bc29ac-b94e-4c75-8567-965757cc0d18.png)



**More on post message here** - https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage

**References used for this PR:**

1. Geolocation APIs - https://github.com/appsmithorg/appsmith/pull/9295
2. setInterval and clearInterval support - https://github.com/appsmithorg/appsmith/pull/8158

**Fixes** https://github.com/appsmithorg/appsmith/issues/7241

## Type of change

- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

Test plan 
- **Manual**: Created an app with different buttons holding different types of data and embedded it in a code sandbox within an iframe. Also removed the target origin which throws an error (App link - https://dev.appsmith.com/app/post-msg-app/page1-624c1af4d8e632741017682e, Codesandbox link - https://codesandbox.io/s/compassionate-tdd-6dnzzd?file=/src/index.js)
- Added Jest tests
- https://github.com/appsmithorg/TestSmith/issues/1892
- https://github.com/appsmithorg/TestSmith/issues/2068
- https://github.com/appsmithorg/TestSmith/issues/2069

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-20 12:39:42 +05:30
Aishwarya-U-R
03fbcdd21c
test: Script updates for flaky tests (#17603)
* Skipping Bug16702 spec

* Bug 16702 fix

* timeout spec index update

* Bug 16702 spec fix

* Bug16702 fix

* BUg16702 spec fix

* Bug 16702 revert

* fix template spec

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-10-20 11:56:52 +05:30
Tanvi Bhakta
5a358ce0c3 chore: Correct the toast font on windows (#17671) 2022-10-20 11:52:47 +05:30
Sangeeth Sivan
62fb99929e
feat: code split permission helpers and added null check for some selectors (#17718) 2022-10-20 11:33:33 +05:30
Appsmith Bot
8b419a177c Update top contributors 2022-10-20 07:00:11 +05:30
Arpit Mohan
4e71432d74
chore: Adding base repository function to add user permissions to generic domain object (#17733)
## Description

Adding base function to set the user permissions for a user in any domain object. 

As part of this, we also add default permission group to the `SeedMongoData`. Without this fix, the JUnit tests go into an infinite loop. Also fixing the `ExampleWorkspaceClonerTest` file.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- JUnit

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-10-20 03:00:30 +05:30
Arpit Mohan
b2cc280009 chore: Fixing prettier formatting for AnalyticsUtil.tsx 2022-10-19 23:08:25 +05:30
Shrikant Sharat Kandula
39dd761cb0
Change Segment CDN to our proxy (#17714) 2022-10-19 20:29:35 +05:30
Parthvi
0ae012a90e
test: Add cypress tests for template phase 2 (#17036)
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-10-19 19:43:51 +05:30
Nikhil Nandagopal
aedde34ab2 Updated Label Config 2022-10-19 16:25:51 +05:30
Ayush Pahwa
0248f8e4a9
fix: replace time based action to event based (#17586)
* fix: replace time based action to event based

- The delete datasource button was getting reset to it's original state after a static time of 2200ms
- Replaced this to reset on completion of deletion instead

* fix: removed unused functions

* fix: updated the condition to show confirm delete icon
2022-10-19 16:04:12 +05:30
sanjus-robotic-studio
3a04e1abb1
fix: JS option missing for Label Font Style in Input widget (#17631) 2022-10-19 15:38:48 +05:30
Tanvi Bhakta
e0c8b5d22d
chore: Correct the toast font on windows (#17671) 2022-10-19 15:37:25 +05:30
Vishnu Gp
b470cb29c8
chore: Added workspace details to user invite analytic event (#17644)
## Description

This PR adds the workspace details to user invite analytics event

## Type of change

- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manually on local

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-10-19 15:32:41 +05:30
Shrikant Sharat Kandula
8bc97b086e
chore: Add recommended indexes (#17704)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-10-19 14:20:30 +05:30
Shrikant Sharat Kandula
bda994ba4e
Fix typo in cloud-hosting check and NPE from Segment (#17700)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
(cherry picked from commit 973997c606)
2022-10-19 12:12:55 +05:30
Anagh Hegde
f2012b6804 Merge branch 'release-frozen' of https://github.com/appsmithorg/appsmith into release-frozen 2022-10-19 12:11:53 +05:30
Keyur Paralkar
0e73906a19 fix: remove file references on click of cancel button (#17664) 2022-10-19 12:11:29 +05:30
sneha122
2139382928
fix: table does not show data issue fixed (#17459) 2022-10-19 11:30:04 +05:30
Keyur Paralkar
3a96547815
fix: remove file references on click of cancel button (#17664) 2022-10-19 11:09:01 +05:30
Shrikant Sharat Kandula
973997c606
Fix typo in cloud-hosting check and NPE from Segment (#17692)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-10-19 11:08:36 +05:30
Appsmith Bot
7995ca909d Update top contributors 2022-10-19 07:00:00 +05:30
Vishnu Gp
7a6d2ad314
chore: Corrected analytics event for instance setting events (#17622) 2022-10-19 01:11:05 +05:30
f0c1s
cb26edbb66
Merge branch 'master' into release-frozen 2022-10-18 19:08:12 +05:30
Nidhi
dcaa7af450
chore: Added feature flag for datasource environments (#17657)
chore: Added Feature flag for datasource environments
2022-10-18 15:51:31 +05:30
ChandanBalajiBP
e5cdfbe445
feat: AST based entity refactor (#17434)
* task: AST based entity refactor

* implemented refactor logic

* jest cases with string manipulation using AST logic

* comments and indentation

* added evalVersion to request
2022-10-18 12:07:06 +05:30
subratadeypappu
327b66775d Fix/16994 refactor common datatype handling (#17429)
* fix:Add array datatype to execute request

* feat: Consume and store type of array elements in Param class (#16994)

* Append param instead of clientDataType in varargs (#16994)

* Refactor common data type handling w.r.t newer structure (#16994)

This commit takes care of the following items:
- It minimizes the number of usage to the older stringToKnownDataTypeConverter method
- Modifies the existing test cases to conform to the newer structure
- Marks stringToKnownDataTypeConverter method as deprecated to discourage further use

* Remove comma delimited numbers from valid test cases (#16994)

* Fix extracting clientDataType from varargs in MySQL (#16994)

* Pass param as a dedicated parameter in json smart replacement (#16994)

* Remove varargs from json smart replacement method (#16994)

* Move BsonType to mongoplugin module (#16994)

* Introduce NullArrayType and refactor BsonType test cases (#16994)

* Add new test cases on numeric string with leading zero (#16994)

* Refactor test case name (#16994)

* Add comment on the ordering of Json and Bson types (#16994)

* Add comment on the ordering of Json and Bson types (#16994)

* Add NullArrayType in Postgres and introduce postgres-specific types (#16994)

* Add data type test cases for Postgres and change as per review comments (#16994)

Co-authored-by: ChandanBalajiBP <chandan@appsmith.com>
2022-10-18 11:55:51 +06:00
Ankita Kinger
a13301808d
feat: Update invite modal submit when we have tabs in modal (#17608)
## Description

> Update invite modal submit when we have tabs in modal.

Fixes [#16741](https://github.com/appsmithorg/appsmith/issues/16741)

## Type of change

- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

> Tested it locally.

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-10-18 11:07:35 +05:30
subratadeypappu
19e2e5785e
Fix/16994 refactor common datatype handling (#17429)
* fix:Add array datatype to execute request

* feat: Consume and store type of array elements in Param class (#16994)

* Append param instead of clientDataType in varargs (#16994)

* Refactor common data type handling w.r.t newer structure (#16994)

This commit takes care of the following items:
- It minimizes the number of usage to the older stringToKnownDataTypeConverter method
- Modifies the existing test cases to conform to the newer structure
- Marks stringToKnownDataTypeConverter method as deprecated to discourage further use

* Remove comma delimited numbers from valid test cases (#16994)

* Fix extracting clientDataType from varargs in MySQL (#16994)

* Pass param as a dedicated parameter in json smart replacement (#16994)

* Remove varargs from json smart replacement method (#16994)

* Move BsonType to mongoplugin module (#16994)

* Introduce NullArrayType and refactor BsonType test cases (#16994)

* Add new test cases on numeric string with leading zero (#16994)

* Refactor test case name (#16994)

* Add comment on the ordering of Json and Bson types (#16994)

* Add comment on the ordering of Json and Bson types (#16994)

* Add NullArrayType in Postgres and introduce postgres-specific types (#16994)

* Add data type test cases for Postgres and change as per review comments (#16994)

Co-authored-by: ChandanBalajiBP <chandan@appsmith.com>
2022-10-18 11:02:37 +05:30
f0c1s
421dfb9b64
chore: Fixing broken client build (#17634)
## Description

EE client build is broken due to not following proper code splitting strategy; one file in particularly didn't get split earlier and changes to that file broke the client build on EE.

This PR fixes the issues.
2022-10-18 10:53:18 +05:30
albinAppsmith
4b8e9806ef
fix: removed global style from design system dropdown component (#17392)
* bug: removed global style from design system dropdown component

* changed design system package version

* fix: Dropdown background fix - design system

* design-system - dropdown background color fix

* DS version updated
2022-10-18 09:45:41 +05:30
Vaibhav Tanwar
7defff9a7a
fix: ms sql default port updated to 1433 (#17342) 2022-10-18 09:08:39 +05:30
Appsmith Bot
b50aff93be Update top contributors 2022-10-18 07:00:41 +05:30
arunvjn
28138c18c8
feat: enabled setTimeout/clearTimeout APIs (#17445) 2022-10-17 22:40:17 +05:30
Anagh Hegde
06f1b23625
chore: Add properties to analytics event (#17621) 2022-10-17 22:21:07 +05:30
Nilesh Sarupriya
019072b4de
fix: update regex and test case for organisation website (#17612) 2022-10-17 21:43:07 +05:30
Hetu Nandu
3aff53187c
feat: Maintain Focus and Context Phase 1 (#16317) 2022-10-17 20:46:38 +05:30
Dhruvik Neharia
199f68fc74
feat: Text Widget Reskinning (#17298)
* feat: Use truncate button color from theme

* fix: Update Truncate Button Color validation regex
2022-10-17 18:54:23 +05:30
f0c1s
d2ba72306f
feat: upgrade hooks | audit logs (#17525) 2022-10-17 18:39:09 +05:30
Shrikant Sharat Kandula
71293dec82
Fix sandbox iframe default setting (#17618) 2022-10-17 16:12:56 +05:30
Arpit Mohan
70f79ae69a
chore: Updating the tenant API to return the complete object instead of just the configuration (#17615) 2022-10-17 14:21:28 +05:30
Trisha Anand
ad57c3533d
chore: BaseAppsmithRepo code split (#17614) 2022-10-17 14:14:52 +05:30
Sangeeth Sivan
5f34376e4d
chore: code split tenant API CE (#17596)
## Description

We shouldn't expose tenant config on CE , so on CE,  we should only return the necessary user permissions hard coded on the saga.

## Type of change

- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-10-17 14:14:33 +05:30
Nidhi
1cb59ab172
chore: Flapdoodle version upgrade to 3.5.0 (#17609) 2022-10-17 13:18:28 +05:30
Nikhil Nandagopal
160a00340e Updated Label Config 2022-10-17 13:13:33 +05:30
Nidhi
2af4fd136b
fix: Fixed check for duplicate JSObject names in an application page (#17536)
* fix: Fixed check for duplicate JSObject names in an application page

* Fixed merge conflicts

* Reverted file with unchanged tests

* Fixed test name
2022-10-17 10:31:42 +05:30