Commit Graph

13528 Commits

Author SHA1 Message Date
Appsmith Bot
5b73f8fe09 Update top contributors 2022-12-08 06:59:19 +05:30
Rishabh Kashyap
2213a61357
fix: resetting audio and video widget (#18126)
* bug for audio and video widget fixed

* cypress test for audio widget

* audio and video updated cypress tests

* cypress test cases updated

* writing logic for video widget

* working on video widget

* intermediate logic

* inbetween logic

* updateWidgetMetaProperty removed from onEnded event

* this.props.playing logic in onPlay & onPause events

* test code

* test code

* Add comment

* audio widget updated; comments for audio and video widget

* cypress changes

* removed cypress credentials

* comments updated

* change in comments and cypress test cases

* feedback incorporated

* comments added to audio and video spec files

* video spec updated

* video spec updated

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-12-07 20:40:28 +05:30
appsmithguru
b64df3e1c9
chore: rename_triggerUtils (#18405)
Refactored Renamed TriggerUtils.java to RestAPIActivateUtils.java and its usage
2022-12-07 15:03:50 +03:00
Tanvi Bhakta
9931d3cdc5
feat: update button states (#18335)
* fix: Form message component link issue

* removed the inverted flag for testing

* use updated design system

* category.tertiary -> category.secondary

* fix: Made changes to pass action link element to design system component - formMessage

* chore: update design-system version to access new tertiary button styles

* chore: update design-system version to use blacks instead of grays

* chore: bump design-system version to use buttons with explicit background color

* Remove rules that mess with border, background, text color on StyledPropertyPaneButton

* chore: update design-system version to use updated button categories across all ads components

Co-authored-by: Albin <albin@appsmith.com>
2022-12-07 11:44:30 +00:00
Souma Ghosh
b2f67e12bc
feat: update property name automatically when custom column name is changed (#18048) 2022-12-07 16:20:29 +05:30
Favour Ohanekwu
e37f7419b9
fix: Aggregate calls to add and remove Appsmith errors (#18285)
* Aggregate calls to add and remove Appsmith errors

* fix switch type

* Fix entity deletion errors

* Code clean up

* fix cypress tests

* Return early for empty errors in Appsmith debugger

* Remove redundant identifier

* Retain order of debugger logs

* Use push instead of unshift for perf reasons

* redundant commit to retrigger CI
2022-12-07 11:28:29 +01:00
Hetu Nandu
5542d12123
ci: Improve the test file check workflow (#18741) 2022-12-07 14:52:43 +05:30
dependabot[bot]
f3e37b9d1e
chore: bump express from 4.17.1 to 4.18.2 in /app/client (#18734)
Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.18.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.17.1...4.18.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-12-07 13:20:56 +05:30
dependabot[bot]
d93d7ff5ee
chore: bump qs from 6.5.2 to 6.5.3 in /app/client (#18733)
Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/ljharb/qs/releases)
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ljharb/qs/compare/v6.5.2...v6.5.3)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-12-07 13:19:57 +05:30
Hetu Nandu
652ec15f97
Update label-checker to add new bypass
Add skip-testPlan label bypass in the test plan approved label checker
2022-12-07 11:33:13 +05:30
Sangeeth Sivan
c0a7574772
fix: workspace context menu is not permission driven (#18642)
* fix: workspace context menu is now permission driven

* fix: remove action operation on global search if there are no file operations

* fix: hide more options when there are no options and refactor

* refactor: revert settings title changes in this PR

* fix: use manage permission for delete on CE

* fix: move delete workspace permission to EE

* fix: change in permissions

* Remove redundant share CTA from org menu

* fix: change of permissions for members and import/create new app

* Remove redundant invite users dialog

* Remove unused variables

Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-12-07 11:07:59 +05:30
dependabot[bot]
f3d4600d85
chore: bump decode-uri-component from 0.2.0 to 0.2.2 in /app/client (#18659)
* chore: bump decode-uri-component in /app/util/plugin-generation

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: bump decode-uri-component from 0.2.0 to 0.2.2 in /app/client

Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
2022-12-07 11:01:16 +05:30
dependabot[bot]
59fb886342
chore: bump decode-uri-component from 0.2.0 to 0.2.2 in /app/util/plugin-generation (#18658)
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/SamVerschueren/decode-uri-component/releases">decode-uri-component's releases</a>.</em></p>
<blockquote>
<h2>v0.2.2</h2>
<ul>
<li>Prevent overwriting previously decoded tokens  980e0bf</li>
</ul>
<p><a href="https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.1...v0.2.2">https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.1...v0.2.2</a></p>
<h2>v0.2.1</h2>
<ul>
<li>Switch to GitHub workflows  76abc93</li>
<li>Fix issue where decode throws - fixes <a href="https://github-redirect.dependabot.com/SamVerschueren/decode-uri-component/issues/6">#6</a>  746ca5d</li>
<li>Update license (<a href="https://github-redirect.dependabot.com/SamVerschueren/decode-uri-component/issues/1">#1</a>)  486d7e2</li>
<li>Tidelift tasks  a650457</li>
<li>Meta tweaks  66e1c28</li>
</ul>
<p><a href="https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.1">https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="a0eea469d2"><code>a0eea46</code></a> 0.2.2</li>
<li><a href="980e0bf09b"><code>980e0bf</code></a> Prevent overwriting previously decoded tokens</li>
<li><a href="3c8a373dd4"><code>3c8a373</code></a> 0.2.1</li>
<li><a href="76abc93978"><code>76abc93</code></a> Switch to GitHub workflows</li>
<li><a href="746ca5dcb6"><code>746ca5d</code></a> Fix issue where decode throws - fixes <a href="https://github-redirect.dependabot.com/SamVerschueren/decode-uri-component/issues/6">#6</a></li>
<li><a href="486d7e26d3"><code>486d7e2</code></a> Update license (<a href="https://github-redirect.dependabot.com/SamVerschueren/decode-uri-component/issues/1">#1</a>)</li>
<li><a href="a65045724e"><code>a650457</code></a> Tidelift tasks</li>
<li><a href="66e1c2834c"><code>66e1c28</code></a> Meta tweaks</li>
<li>See full diff in <a href="https://github.com/SamVerschueren/decode-uri-component/compare/v0.2.0...v0.2.2">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=decode-uri-component&package-manager=npm_and_yarn&previous-version=0.2.0&new-version=0.2.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/appsmithorg/appsmith/network/alerts).

</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-07 11:00:38 +05:30
balajisoundar
be997b240a
fix: show filter & show download properties should not control add new row link visibility in table widget (#18348) 2022-12-07 09:52:18 +05:30
balajisoundar
b8aa7b3a67
fix: table widget header links should have pointer cursor when hovered (#18262) 2022-12-07 09:50:18 +05:30
Appsmith Bot
f833e3533e Update top contributors 2022-12-07 06:59:31 +05:30
Rishabh Kashyap
2afc10387f
fix: add js for icon property in button group (#18524)
made icon js convertible
2022-12-06 23:02:43 +05:30
NandanAnantharamu
bbf896e389
test: Added test for bug fixed (#18135)
* Added test for bug fixed

* Commented a test
2022-12-06 21:59:05 +05:30
Trisha Anand
0cbb0e20c6
chore: Fetch pages in editor with READ permissions (#18722) 2022-12-06 21:06:04 +05:30
Hetu Nandu
473501c761
fix: Remove redundant share CTA from org menu (#18718) 2022-12-06 12:50:41 +00:00
Arpit Mohan
6d19abf6ac
chore: Release v1.8.12 (#18721)
> Pull Request Template
>
> Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

## Description
Release v1.8.12

> Add a TL;DR when description is extra long (helps content team)

Fixes # (issue)
> if no issue exists, please create an issue and ask the maintainers about this first


Media
> A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video


## Type of change

> Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update


## How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.
> Delete anything that is not important

- Manual
- Jest
- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-06 13:32:42 +01:00
“sneha122”
4529bd5896 merge conflict issue resolved 2022-12-06 15:08:16 +05:30
“sneha122”
0530214179 Merge branch 'master' into release-6dec-v1.8.12 2022-12-06 14:56:02 +05:30
Arsalan Yaldram
ad55928fc3
chore: Fix dropdown font family (#18693)
## Description

- Fix dropdown font family. 

Fixes  #18677 



## Type of change

> Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Manual

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-06 13:31:58 +05:30
Parthvi
bc7659d53a
test: Add dummy users in Cypress test suite (#18675) 2022-12-06 11:21:54 +05:30
Rhitottam
4231a905c0
ci: Update perf infra dashboard link inside github workflows yml (#18702) 2022-12-06 10:17:27 +05:30
Shrikant Sharat Kandula
e7b2e2392b
Fix NPE on reset password, and message formats (#18108)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-06 08:37:41 +05:30
Appsmith Bot
ef5ee9c504 Update top contributors 2022-12-06 06:58:09 +05:30
Nidhi
166414b6d6
chore: Improved metadata on logs when reading DSL fails (#18692)
* chore: Improved metadata on logs when reading DSL fails

* Fixed test

* Test fix

* Review comment
2022-12-05 22:35:44 +03:00
sneha122
93fe30674f
fix: datasource autosave git issue fixed (#18690)
* datasource autosave git issue fixed

* Added appropriate comments

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-12-05 20:39:19 +05:30
Abhinav Jha
836af41be1
fix: Auto height breaks for fixed modal's children (#18691)
Fix issue where auto height was throwing an error when a fixed modal widget's children were changing height automatically
2022-12-05 20:24:45 +05:30
Goutham Pratapa
fee9b181fe
chore: fix ingress fieldname in appsmith (#18684) 2022-12-05 17:14:17 +05:30
Arpit Mohan
6734fc27a1
fix: multiselect crashing (#18577) (#18624)
## Description

Hotfix from this commit 058500704e


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-05 12:32:09 +01:00
Nilansh Bansal
ebadab572b
feat: Adding Embedding Apps Functionality in the API (#18566) 2022-12-05 15:49:37 +05:30
Shrikant Sharat Kandula
2198ed4c61
chore: Support using custom port(s) for listening in the start-https.sh script (#18451)
Added `--https-port` and `--http-port`, so you can set a custom port instead of the default 80 and 443. This is useful if you want to test Appsmith when using a non-standard port, fox example, how `appsmith.URL.host` behaves, or how OAuth redirects behave etc.

We also add a shortcut to start this with release endpoint. Just using `release` is now the same thing as using `https://release.app.appsmith.com`. This is useful to people like me who are _very_ good with typos.
2022-12-05 13:34:30 +05:30
Anagh Hegde
f70ad56fae
chore: Remove debugging logs for analytics (#18662) 2022-12-05 11:29:25 +05:30
akash-codemonk
3eab587368
feat: [Context Switching] Maintain datasource collapse state (#17616) 2022-12-05 11:28:17 +05:30
Ankita Kinger
f52a55632d
fix: Updating spec for member roles (#18657)
updated spec for member roles
2022-12-05 10:52:38 +05:30
Arsalan Yaldram
8b06621601
fix: Added support for country code flags on windows devices (#18203)
* fix: add pollyfill and use font family.

* fix: use latest version design system.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-05 10:43:21 +05:30
Arsalan Yaldram
3364bfd1a6
chore: dependentbot vulnerabilities. (#18528)
* fix: dependentbot vulnerabilities.

* chore: remove emoji-mart.

* chore: updated react-syntax-highlighter

* chore: update ts-loader add loader-utils resolution.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-05 10:37:51 +05:30
Appsmith Bot
ab62a1f225 Update top contributors 2022-12-05 06:58:28 +05:30
Sangeeth Sivan
6c498bcbf5
fix: datasource title not editable and ctas disabled on create (#18645)
fix: datasource title not editable on create flow, delete save ctas disabled on rest/graphql form
2022-12-04 20:49:01 +05:30
Ankita Kinger
b7d00d2498
feat: Adding an upgrade page for Access control (#18554)
* updated content for access control upgrade page

* added feature flag and moved content to message constants

* adding feature flag for RBAC

* updated some styles

* added a missing comma

* removed width on trigger details container

* updated some styles
2022-12-04 20:12:35 +05:30
NandanAnantharamu
8c6dccb6b4
Test : DH regression test automation (#18436)
* updated tab test

* updated tests

* Added some more scenarios

* updated valdations for presence of Height property under general

* Added tests for list

* Updated tests
2022-12-03 21:43:10 +05:30
Arsalan Yaldram
b41606e2b7
fix: center align select widgets and RTE widget labels. (#18378)
* fix: center align select and RTE labels.

* feat: added label tooltips to select widgets.

* fix: added center label alignment to datepicker.
2022-12-03 17:28:02 +05:30
Ayangade Adeoluwa
cb82b299b1
fix: datasource switching issue for Google sheets (#18397)
* Fix datasource switching issue for Goole sheets

* Fix failing vercel deployments
2022-12-03 15:25:42 +05:30
Appsmith Bot
f9dc5719fa Update top contributors 2022-12-03 06:58:07 +05:30
Rishabh Rathod
c440343586
chore: perf data tree shrink (#18361)
trimming dataTree object size by removing configs to make evaluation faster.
2022-12-02 18:15:11 +05:30
akash-codemonk
ced3b413c3
chore: comment out flaky assertion (#18640) 2022-12-02 18:14:43 +05:30
Sangeeth Sivan
85db5cc965
fix: update permission driven ctas to handle auto save update changes (#18609) 2022-12-02 18:05:18 +05:30