Commit Graph

777 Commits

Author SHA1 Message Date
arunvjn
28138c18c8
feat: enabled setTimeout/clearTimeout APIs (#17445) 2022-10-17 22:40:17 +05:30
Hetu Nandu
3aff53187c
feat: Maintain Focus and Context Phase 1 (#16317) 2022-10-17 20:46:38 +05:30
Souma Ghosh
99dc583514
feat: Resize Image option in Table Widget v2 (#17482)
* feat: Resize image option in Table Widget

* Change default image size from 64px to 32px

* Add cypress tests

* Move Image Size property control under Style tab

* Review changes

* Fix failing cypress tests

* fix prettier issue
2022-10-14 17:51:54 +05:30
Ayangade Adeoluwa
282f1ff5a6
feat: Adds one way switching to Form Controls (#17194)
* Adds one way switching to Form Controls

* Fix failing jest test

* Retrigger oktotest

* JSOnload1 spec 6th case fix

* Jsonloadspec 1 fix

Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-13 21:28:46 +01:00
Parthvi
c4d6845bd5
test: Add cypress tests for leave workspace flow (#17354)
* Add leave workspace tests

* removing .pause()

* refactor test
2022-10-13 12:14:39 +00:00
Aishwarya-U-R
a255486087
test: Script updates for flaky tests to unblock CI (#17469) 2022-10-13 12:54:09 +05:30
Nidhi
74c3dbbc1a
fix: Modified on page load actions calculation using AST (#17074)
* Changes to on page load logic and consumption for update layout

* Slight clean up, tests and stuff

* - Added evaluationVersion logic based on application configuration
- Added configuration for slim and fat container rts availability
- Added backup logic of string comparison for slim containers
- Added tests for both paths

* Changes to on page load logic and consumption for update layout

* Slight clean up, tests and stuff

* Cleaned up comments all over

* Why isn't there even a setting to disable auto re-formats

* update rts logic to use updated shared AST logic

* Make changes to naming conventions

* Some temp stuff to check if update layout API changes will work out

* Added health check endpoint in RTS

* Added types for AST request

* update: type for save page request object

* update: return type for getEditorConfigs func

- Added applicationId to the type.
- Fetching from the redux store -> applications -> currentApplication -> id

* update: url generation func for update page API

- added applicationId as query param for the call

* Fixed test failures

* Fixed merge from release with on page load failure messages

* Fixed tests failing after merge

* Review comments, more tests, and fix for array index ref directly after .data path

* Test fix

* Addressed review comments

* Updated comment

* Fixed rts temporarily, added handling for data as function name, left with tests

* fix: failing rts server

* Tests for all types of actions and references

* Changes to test

* Modified type to set

* Test fixes

* Trying to make a test pass

* Added app id in cypress test update dsl

* Added app id in cypress test update dsl

* Added app id in cypress test update dsl

* Removed dep tree temp file

* Resolving compile issues after merging from release

* updated tests for applicationId

* corrected a typo

* fixed some more tests

* updated test

* Updated test

* DSL load AppId fix

* appId removal

* AgHelper LocalStorageCache()

* AgHelper LocalStorageCache() - commit 2

* AgHelper LocalStorageCache() - commit 3

* AgHelper LocalStorageCache() - commit 4

* AllWidgets_Reset_spec - Dsl fix

* Json_spec fix

* S3_2 spec fix

* fixes

* LocalStorageCache fixes

* fixes

* fixes

* fix

* OnLoadActions spec fix

* Promises spec fix

* S3_2 spec fix

* 16702 spec update

* OnLoadActions spec trial fix

* RTS fix

Co-authored-by: Nidhi Nair <cataclysm@Nidhis-MacBook-Pro.local>
Co-authored-by: Ayangade Adeoluwa <adeoluayangade@yahoo.com>
Co-authored-by: Ayush Pahwa <ayush@appsmith.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Apple <nandan@thinkify.io>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-11 11:02:44 +05:30
Aman Agarwal
ab106455f2
fix: adding mode for graphql syntax with dynamic bindings (#17229)
fix: added mode for dynamic binding with quote for graphql
2022-10-08 03:17:07 +01:00
Aman Agarwal
78c89894f8
fix: updated settings page design (#16990)
fix: updated settings page design
2022-10-06 16:36:29 +05:30
subratadeypappu
d2de8f7cec
feat: Implement data type handling in MySQL (#16621) (#17017)
* feat: Implement data type handling in MySQL (#16621)

With this implementation we can now achieve the following under prepared statement:
- Ability to distinguish between null object and "null" string
- Ability to distinguish values like {{"098765"}} and {{098765}}. The former is identified as a string and the latter is identified as an integer

* feat: Add unit test cases on data type handling in MySQL (#16621)

* chore: Move MySQL specific types to a separate class (#16621)

* chore: Remove import shortening (#16621)

* Fix testStructure test case to have loose coupling with the order of tables (#16621)

* Fix: Add missing client-side data types in params in a few test cases (#16621)

* Fix query in test case (#16621)

* Fix test cases and add small refactoring (#16621)

* Refactor assertion with a check on Optional (#16621)

* additional cypress test cases for mysql

* updated test case object

* update for failing test cases

* mysql failure point fix

* mysql false spec failure point fix

* fix flacy test cases

* flacky JSON test cases

Co-authored-by: ChandanBalajiBP <chandan@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-10-04 10:45:10 +00:00
Aishwarya-U-R
7596dfc35a
test: Script updates for flaky tests to unblock CI (#17264) 2022-10-03 15:25:11 +05:30
akash-codemonk
a560051d86
feat: fork templates inside an existing app (#17184) 2022-09-30 19:11:04 +05:30
balajisoundar
ed1dccaba7
feat: Table widget select column type (#16337) 2022-09-30 09:33:53 +05:30
Arpit Mohan
c036087379
chore: Import template application to a git branch in application (#17032)
Also fixing the comodification array error when we are removing items from a list while iterating over it.
Fixes #17030

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-29 14:39:19 +05:30
Souma Ghosh
88fe538a70
feat: Autoassigns column datatype in table widget (#16701)
* feat: Autoassigns column datatype in table widget
- Limited to only number, string and boolean datatypes

* Review changes
Adjust jest tests accordingly

* Adds support for recognising Date type columns
Review changes

* Adds jest test for Date field

* Fix warning

* Adjust cypress tests and add helper method to account for code changes

* Fix failing test
2022-09-29 10:56:08 +05:30
f0c1s
7ef0b9669a
feat: Introduce admin settings to left bottom pane (#17060) 2022-09-26 19:38:32 +05:30
akash-codemonk
9715bd3db3
chore: Revert "feat: fork templates inside an existing app (#14514)" (#17041) 2022-09-26 13:44:39 +05:30
akash-codemonk
1b43b16461
feat: fork templates inside an existing app (#14514) 2022-09-22 09:19:18 +05:30
Ayush Pahwa
e3f90db341
feat: grouping in console logs (#16698)
* fix: updated skip functionality

* update: type of logs to add occurence count

* update: reducer function to merge the new logs

* update: added dependance on last log's occurence count

* add: UI to show the occurence badge

* fix: added null check for dependency array

* update: omit occurence from compare fn

* update: changed function call to store logs array directly

* update: moved from saving logs one by one to array

* fix: replaced forEach with reduce

* test: added functions for console log grouping

* feat: updated warning grouping color

* update: moved function to reducer file for jest tests
2022-09-19 06:29:04 +00:00
Rishabh Rathod
9a1fa98416
fix: Autocomplete now works with multiple bindings (#16314)
Fixes #16288
Fixes #16158
Fixes #16188
Fixes #15859
2022-09-19 11:02:06 +05:30
ChandanBalajiBP
2b70914f31
test: mysql datatypes cypress test cases (#16696)
* test: mysql datatypes cypress test cases

* test: cypress added comments with cleaner code

* updates w.r.t review comments

* fix 10th cases failure

* fix for test failing on CI

* fix for test failing on CI another way

* fix: address review comments
2022-09-16 11:51:25 +05:30
balajisoundar
afb9aa93c1
feat: Table widget V2 Inline editing validation for plain text & number column (#15954) 2022-09-13 11:11:59 +05:30
Ayangade Adeoluwa
342c5cc673
fix: Fix Api url path issue (#16628)
* Fix Api url path issue

* Modify test cases
2022-09-13 05:02:59 +00:00
Aishwarya-U-R
bdadb827e3
test: Script updates for flaky tests (#16631)
* CreateNewApp spec flaky fix

* fix

* Moved RepoLimit to commented files

* Inline spec failure fix - case 19

* Table FIlter specs V1/V2 split

* Binding/Table_Property_ToggleJs spec - V1/V2 fix

* Spec name update

* Wait increase

* DS - duplicate error capture fix

* revert

* Recaptcha spec fix

* Jsfun exe flaky fix - unskipped case

* jsfunc exec spec fix

* jsfunex spec fix

* Api bugs spec fix

* Api bugs spec fix

* Chartdata point spec flaky fix

* Theme_multiselect brown type fix

* Jsfunc exe spec fix

* Inline spec fix

* Inline spec fix

* Inline spec fix

* Theme multiselect spec fix

* Promises spec fix

* JSFun Exe spec fix

* Api_all verb methods update

* List1 spec 4th case fix

* Jsfun exe skipping 10th case

* jsunf exe 10th case trial fix

* firestore stub error capture

* jsonload failng spec skip

* JSonload spec fix

* json load spec fix

* Git repo moved back
2022-09-12 09:48:44 +05:30
Parthvi
ee8259d311
test: Fix flaky git tests (#16675)
* fix flaky git tests

* undo skip for git import tests
2022-09-12 08:59:06 +05:30
Sumit Kumar
0cbe81dfde
feat: merge GraphQL plugin to release (#16554)
* merge GraphQL plugin to release
2022-09-09 21:29:47 +05:30
Aishwarya-U-R
bf232dbb7e
test: Script updates for flaky tests (#16558) 2022-09-07 23:55:55 +05:30
Aishwarya-U-R
353e007e78
test: Script updates for flaky tests (#16533)
* Autosave trial fix

* json form field flaky fix

* js fun exe spec flaky fix
2022-09-06 08:59:39 +05:30
Aishwarya-U-R
06cd7542f5
test: Script updates for flaky tests (#16455)
* UUID table load time increase

* Autocomplete js api failiure fix

* mysql crud fix

* MySQL, Postgres CRUD updates

* flaky fix

* flaky fix

* Upgrade Appsmith spec - moved

* MySQL CRUD spec split

* fix

* fix

* fix

* fix

* Postgres CRUD spec split

* Postgres CRUD spec split

* fix

* EE names update

* fix

* fix
2022-09-05 15:24:56 +05:30
Aswath K
8b297e4da1
chore: Property pane design changes (#16112) 2022-09-05 10:22:39 +05:30
Ayush Pahwa
7d621de978
feat: console log implementation in appsmith (#16286)
* feat: capture console from across the app (#15676)

* create: console override file

- Adds methods to override the given console functionality to capture the console statements written by the user

* update: evaluate function to extract console op

- Added logs extraction for both sync and async functions
- Adding them to the return object of the evaluations

* update: timestamp field to log addition method

- Added optional argument to function definition for inputting the timestamp of the log
- This is done to maintain timings of the execution of the log

* update: interface for log objects

* update: post function execution logic

- Added logic to push the logs generated by the evaluation to the logs store

* update: added handling for sending nested fns

- While console logging functions or objects that had functions was causing an error
- Added a check for removing functions and replacing them with name of the functions instead

* chore: added types and comments

* fix: updated evaluation tests

* fix: added check for log in returned obj

* update: added the source data in the trigger logs

- Removed on js execute logs from showing up here since they are already handled. If they are not removed, they will show up on the first page load twice

* add: ellipsis function for log title string

- This is to keep big object contained in the first line only

* update: made logs reset function public

* update: resetting logs before new eval

- Logs object has to be cleared before next eval can happen to make sure there are no roll overs from last evals

* chore: added comments

* add: extracting logs after eval of functions

* add: storing logs to redux after eval

* refactor: updated types

* add: func to store logs w/ severity as arg

* refactor: updating func call for user logs

* chore: fixed elipsis logic

* chore: removed unused type

* chore: updated preview text logic

* add: type for transfer object post eval

* update: aded new userLogs obj to dataTreeEvaluator

* update: passing logs from object to saga

* update: parsing received userlogs

* refactor: used predefined fns

* refactor: moved resetlogs to common func

* chore: updated comments

* feat: update redux store and UI for system + user logs (#15936)

* update: updated types for the redux store

- Added category and data fields in the log object

* update: types of log redux store

* update: calls for the console log store function

* update: icon fetch func for log item UI

* update: syncing UI with the new designs (WIP)

* chore: fixed lint error

* update: filters for logs

* update: icon for clearing log filters

* update: filtering function

- Added checks against category and severity

* update: logitem UI

- updated type of the UI object
- added css based ellipsis
- added toggle for console logs
- added array of json views for objects/arrays
- css tweaks

* update: debugger cta

- Removed copy option
- Updated UI

* update: logic for expanding user logs

- Removed debugger CTA
- Fixed position for the expand/collapse icon
- Added joining char for when the log is expanded

* update: assets for new UI

- updated colors
- Added new icon

* hotfix: ternserver code

* add: search across the text of log

* update: icons for the app

* update: click to expand/collapse of logs

* fix: search keyword update on change within JSObjects

* fix: alignment of log items in both states

* update: jest tests for debugger errors and filter

* fix: drop down options color issue

- the icon used was not the standard one
- We have a lot of duplicates of the same icon

* fix: synced with ADS changes on release

* fix: remove dependency from old icon

* add: cypress selectors for automation testing

* fix: replaced static messages with variables

* fix: updated the dependency map for filter

* fix: height of the filter drop down

* fix: chaining logic for search filter

* fix: syncing the padding values to ADS

* fix: help icon visibility issue

* fix: width of filter dropdown

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>

* add: e2e tests for console statements using IIFE

* test: added test for console logs in jsobjects

* fix: functionality of expanding context menu on msg click

* fix: added try catch and handling for numbers

* hotfix: handling unwanted toasts

* fix: alignment and clickable cursor

* fix: alignment of expanded span in console logs

* add: analytics event on new console log created

* fix: added handling for boolean and undefined

* fix: removed log reset from common func

- Whenever we are creating global DTO, the logs were being reset. This caused logs to reset whenever a promise was encountered in the logs.

* fix: combined JS log saving to widget process

* add: new analytics event on filter changed

* update: added handling for empty value

* update: removed comma between multiple logs

* update: synced test changes with release

* update: removed unused wait timings

* Logs spec script update

* update: ts methods in log spec e2e test

* logs spec update

* update: removed body clicks from test script

* Logs spec update

* update: removed ask from google option

* refactor: ui fixes

* fix: text selection of logs

* fix: updated dropdown width management

* update: made the flushlogs function async

* update: added handling for promises

* update: added test with promises fail and pass

* fix: added sync variant to work for sync objects

* refactor: commented out unused tests

* update: exceptions in the name of log entity

* fix: pagination of logs to handle dynamic data stream

* fix: removed unused async function

* fix: moved logs handling to separate saga

* fix: color for context menu text

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-04 17:28:05 +05:30
Arpit Mohan
763261716b
chore: Fixing lint errors in the Cypress code base (#16504) 2022-09-03 23:57:41 +05:30
Aswath K
db08b16d4e
feat: Grouping & reorganisation of Property Pane (#15768)
* Removes feature flag from Client code

* Updates Cypress tests
2022-09-03 18:20:39 +05:30
Ankita Kinger
e28e89807c
feat: Refactor invite modal for handling RBAC updates (#16405)
* refactored code for invite modal changes for rbac

* code splitted some more files for refactoring invite modal component

* removed unused imports

* created new variable for handlers

* updated an import

* reverted a change

* refactored a section of code

* fixed a cypress test

* fixed a cypress test

* updated imports

* exported some entities
2022-09-02 22:45:08 +05:30
Aishwarya-U-R
4bf0827763
test: Script updates for flaky tests (#16355) 2022-09-02 06:35:45 +05:30
Ayangade Adeoluwa
80fa2c2713
fix: Blocks shortcut action execution when git modal is open (#16248) 2022-09-01 22:55:22 +02:00
arunvjn
fce2352599
fix: fast render form elements in UQI query editors (#16199) 2022-09-01 10:41:57 +05:30
Aishwarya-U-R
f627b1ea8b
test: Script updates for flaky fixes (#16350)
* Table adding more wait time

* theme multiselect trial fix

* Ds form spec flaky fix

* TableV2 filter spec - app crash fix

* theme multiselect flaky fix

* ds form spec + community issues flaky fix

* spinner validatio added

* Theme_multiselect fix

* Json query run flaky fix

* DS add click flaky fix

* ds + locator update

* Skipping upgrade tests until fix

* Arango flaky fix

* Mongo.js flaky fix

* MySql CRud spec time increase

* ReadTableRowColumnData timeout increase
2022-08-29 04:36:17 +05:30
arslanhaiderbuttar
e60375cd02
test: Upgrade appsmith (#16203)
* Added test cases for appsmith upgrade

Added test cases for appsmith upgrade

* deleted extra commands

* add new workflow for upgrade scenarios

* updated the s3 details

* update command.js

* updated the work flows

* Removed the conflicting part with TED

* Update commands.js

* TED run command updated

* removed async calls

* added commands to start the v160

* updated few steps

* added debugging updtream step

* changed the paths

* dynamic port numbers

* dynamic port numbers

* removed the port numbers

* removed debug from the workflows

* increased timeout

* changed the path

* fixed the after all hook

* fixed the stop container
2022-08-28 11:28:01 +05:00
Aishwarya-U-R
3b90baf1d8
test: Script updates for flaky fixes (#16289)
* Auto completre fix

* Toast fixes

* Autocomplete js fix

* datatree mutation spec update

* Datatree -added  running api

* rmeoved unused ref

* Deletion time added

* Community issues spec fix

* AssertImportToast() update

* QueryAbort case fix

* Signature fix

* update

* UUID flaky fix

* Pomises spec + toasts updates

* Toasts updates

* ErrorReporting spec fix

* Scrolling mockdb fix

* Bug tests name change for easy identification

* bug spec file name update

* JSfunc fix

* Community issues table load time increase

* AssertContains() reduced wiat time

* AssertContains() update

* timeout added to mysql crud

* AssertContains revert

* AllInputWidget trial fix

* wait until table load ReadTableRowColumnData()

* fix

* testTimeout added

* ReadTableRowColumnData() revert

* path fix

* WaitUntilTableLoad() revert

* COmmunity issues row select fix

* Faker added

* wait time add for multiselect

* Mulipart fix

* Community issues spec fix

* AllInput spec update

* timeout 1 to 3

* update

* update

* EnterJSContext from JSEditor to PropPane ts

* update

* Removed unwanted comments

* fix

* UUID fix
2022-08-27 18:10:11 +05:30
Aishwarya-U-R
f2c6e1ed61
test: Script updates for flaky fixes (#16143)
* Remove mongo coll dataset

* JSEXe spec flaky trial fix

* AbortActions to ts

* js func exe fix

* Abort spec fix

* Appsmith down flaky fix

* SelectWidget bug 12531 comment

* JSfun exec spec flaky fix

* Scrolling spec fix

* mysql crud fix

* mySql crud fix

* CRUD generate page fix

* jsonload flaky fix

* Automcomplete spec update

* jsOnload-1 spec flaky fix

* http patch

* patch install

* patch path correction

* cypress instal force

* removed

* yarn

* adding dev

* applypatch path corrected

* patch fix

* patch update

* patches

* patch file name update

* Adding blureprint patch back

* Cypress install removed

* Removed .only

* Autocomplete + Abort spec fix

* CI run key press fix

* https proxy update path fix

* JS editor parsing delay handle

* Autocmplete js fix

* Abort Query added

* Removed  "dev": "cypress open"

* js func exec spec fix

* js editor type flaky fix

* GetNClick revert

* Saving JS editor aft removal

* JS specs flaky fixes

* JSfun flaky fix

* Auto complete spec fi

* jSonkoad1 spec fix

* JSOnload spec

* Auto complete JS spec fix

* Removing waiting for toasts

* jsfun fix

* EditJSObj Preetify update

* contains index or colection

* SetQueryTimeout update

* DS toasts handle

* POstgresCRUD toast change

* POstgres CRUD toasts fix

* Bug 15372 spec toast fix + Api timeout update

* Added DeleteDSDirectly()

* Arango spec fix

* JSEditor indent spec - 6 fix

* JSeditor indent spec update 7, 1,2

* removed only

* JSEDitor Indent spec fixes

* removed only

* MySQK CRUD fixes

* BUg 14006 spec fix

* Mongo spec toast fix

* Mongo update

* text wrapping spec flaky fix
2022-08-24 19:53:41 +05:30
Trisha Anand
8f3591615a
feat: RBAC framework (#14823)
Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: Sangeeth Sivan <sangeeth@appsmith.com>
Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com>
2022-08-22 23:27:07 +05:30
Rishabh Rathod
83d30b8d05
fix: autocomplete fixes & enhancement (#15857) 2022-08-22 11:17:24 +05:30
ashit-rath
893fd34cdd
perf: Widget re-rendering refactor (#14485)
* initial commit

* props hoc

* changes

* removed ignores and withWidgetProps

* added extra props to canvasStructure

* widget props changes

* list widget changes

* reintroduced widget props hook and other refactors

* remove warnings

* added deepequal for childWidgets selector

* fix global hotkeys and tabs widget jest test

* fix main container test fix

* fixed view mode width

* fix form widget values

* minor fix

* fix skeleton

* form widget validity fix

* jest test fix

* fixed tests: GlobalHotkeys, Tabs, CanvasSelectectionArena and fixed main container rendering

* minor fix

* minor comments

* reverted commented code

* simplified structure, selective redux state updates and other inconsistencies

* fix junit test cases

* stop form widget from force rendering children

* fix test case

* random commit to re run tests

* update isFormValid prop only if it exists

* detangling circular dependency

* fixing cypress tests

* cleaned up code

* clean up man cnavas props and fix jest cases

* fix rendering order of child widgets for canvas

* fix dropdown reset spec

* adding comments

* cleaning up unwanted code

* fix multiselect widget on deploy

* adressing review comments

* addressing minor review comment changes

* destructuring modal widget child and fix test case

* fix communityIssues cypress spec

* rewrite isVisible logic to match previous behaviour

* merging widget props with component props before checking isVisible

* adressing review comments for modal widget's isVisible

Co-authored-by: rahulramesha <rahul@appsmith.com>
2022-08-19 15:40:36 +05:30
Aishwarya-U-R
ba9e4458a2
Automated test for JSObj OnPageLoad + flaky fixes + fix for timeout runs (#16028) 2022-08-18 12:00:28 +05:30
Pawan Kumar
ea04404de9
fix: Reskinning Input Widgets (#15546)
* update checkbox

* fix margin in checkbox

* fix color bug

* fix border radius

* fixes

* remove unused imports

* bug fixes

* ui fixes

* code review feedback fixes

* css updates for toggle

* fix bg bug in checkbox

* fix disabled checkbox style

* update styles for radio and switch

* update label align

* add hover interaction for switch

* add wds css variables

* add error state

* add error state

* fix css variable

* fix css

* fix checkbox group column height

* move checkbox icons to assets

* update input

* fix input

* fix input

* fix input fix

* fix disalbed icon color

* empty commit to deploy again

* address review feedbacks

* fix font in dropdown

* fix colors

* fix search icon alignment

* fix space in right cross icon

* fix colors and label alignment

* fix margin top in tooltip

* replace red color with css variable

* Json form field spec fix

* fix css variable typo in checkbox

* fix css variable typo in checkbox

* fix label spec

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-18 11:56:07 +05:30
Souma Ghosh
44d1885ae9
fix: Text getting clipped for Italic font in Table Widget V1 (#15549) 2022-08-16 11:12:31 +05:30
Ayangade Adeoluwa
0e36569b06
feat: Abort Query Execution (#15775)
* Snaps response view to certain height and adds abort query execution feature

* make raw string a constant

* Add cypress tests

* Remove theme variable

* move raw strings to constants in messages.ts file

* Fix test case description

* Comment out query abort action execution

* cy fix

* Fix abortion of parallel action execution like onPageLoad

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-08-12 12:49:17 +05:30
Rishabh Rathod
e255593e28
fix: Improve Autocomplete for local vars, JSObject & ButtonGroup Widget
Add Autocomplete support for
- local variables 
- JSObjects
- ButtonGroupWidget
Remove Autocomplete suggestion for
- `eval`
-  undefined global values like `tabs`
2022-08-11 15:29:38 +05:30
Aishwarya-U-R
d0dd080397
test: Script fix for Cypress Timeout - CI runs (#15878) 2022-08-10 21:36:30 +05:30
arunvjn
4e5b21600d
Optimise code editor renders (#15405) 2022-08-04 11:10:44 +05:30
Aishwarya-U-R
8fd3b94f8c
test: Automated tests for Postgres Datatype - UUID Cont., + Flaky fixes (#15582)
* UUID continued

* Edit Obj save

* Added TypeTextIntoField()

* Added paste back to JSEDitor context

* ExecuteActions spec ts

* ApiOnPage load spec ts

* propPane.UpdatePropertyFieldValue update

* fix

* AddDsl method update

* UUID flake fix

* DS docs spec

* GS & Firestore stub specs ts

* faliure fixes

* title fix

* Promises flake fix

* UUID update

* Autocomplete bug file name update

* Restapi flaky fix

* Flaky fix

* UUID fix

* UUID done

* UUID fix

* UUID fix

* Promy fix
2022-08-04 10:18:15 +05:30
arunvjn
7c37f7b35a
Add a new rule to show selectedRow in autocomplete's best match (#15406)
Refactored auto complete sorting logic.
2022-08-03 12:54:38 +05:30
Hetu Nandu
887832d29a
refactor: deprecate commenting and notifications (#15484) 2022-08-03 12:32:49 +05:30
Nidhi
02aa9b29bf
fix: Reset sync function fields on each update (#15442)
* Reset sync function fields on update

* Partial cypress test

* Completed cypress test

* Uncommented every other test :P
2022-08-03 10:11:02 +05:30
Aishwarya-U-R
5369edc245
test: Automated tests for Postgres Datatype - UUID + Flaky fixes (#15535)
* Binary spec updated

* flaky fix

* Removed skip, added only - recaptcha spec

* fix

* Reduced defaultCommandTimeout

* Adding global timeout

* failure fixes

* toForceClick to btn clicks js

* Elastic search flaky fix

* Passing Params - moved to CreateDs()

* Combining similar cases

* Removing unsed variables

* JSON Form widget specs moved

* flaky fix

* Mock db duplicate handling

* UUID added

* UUID spec update

* S3 fix
2022-08-01 17:16:00 +05:30
Aishwarya-U-R
73c0c9eecd
test: Automated tests for JSObjects + Flaky fixes (#15269)
* FOcusElement

* Specs into folders

* Bug14987_spec.js flaky fix

* S3 flaky trial fix

* CreateQuery() added

* Spec rearranged

* Sepcs rearranged

* MySql table load fix

* Added bug id JSOPageLoad

* Postgress idle connections spec fixed

* fixes

* fix

* fix

* Import fix

* Mock DB spec added

* flake fix

* Flake fix

* fix custom_chart_spec and gitSyncedApp_spec tests

* JSOnLoad after Import app scripted

* fix

* mock db name fix

* fix

* tc #58 scripted

* fix

* fixes

* moved spec

* increased wait time

* table filter fix

* Import time fix

* jsONload spec fix

* jsonload spec fix

* failure fixes

* "videoCompression": false

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-29 14:18:25 +05:30
Parthvi
ed90490005
test: fix git cypress tests (#15508)
* fix git tests

* add wait for git status call to complete

* fix git tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-29 08:33:32 +05:30
Parthvi
f60e78c972
test: Fix flaky cypress tests (#15437)
Fix flaky tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-26 08:55:48 +05:30
Favour Ohanekwu
0f92b97226
feat: Triggerpath dependency (#15015)
* Introduce triggerpathdependency

* Code cleanup and refactor

* add jest test for removeLintErrorsFromEntityProperty

* Add triggerfieldDependencyMap jest tests for datatreeEvaluator

* Add cypress tests

* Revamp linting architecture

* Lint when creating first tree

* Prevent modification of unevaltree while linting

* improve linting performance

* Reuse allkeys for all dependencymap creation

* Add jest test for linttree

* Update jest and cypress tests

* Modify linting folder name

* remove redundant commits

* update evaluation jest tests

* Fix failing test

* Update cypress tests

* Code clean up and performance upgrade

* Update cypress tests

* Use unevalTree as global data for non-trigger field

* Improve global data creation time

* Cypress fixes

* Improve creation of global data for linting

* Only generate global data with functions when needed

* remove all unused variables

* Add overriden commit

* remove lint erros before linting

* fix merge conflicts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 21:31:08 +01:00
Favour Ohanekwu
243dc7f477
Improve lint error reporting (#15098)
Core changes in this PR

    Prevents logging of lint warnings (not errors) in the debugger
    Refined message for using 'await' in non-async functions
    Show lint error messages that include line numbers (previously weren't shown)

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-21 18:31:23 +05:30
Nidhi
50172ecd64
fix: Added support for self signed certificate during OAuth2 flows (#14719)
* Added support for self signed certificate during OAuth2 flows, server side changes

* fix: authentication.useSelfSignedCert key added

* Merging from release

* Fixed issue with dependencies, plus bug with using ssl

* Cypress test attempt 1

* Cypress test attempt 2

* Cypress test attempt 3

* Clean up

* Review comments

* Enabled compression again

Co-authored-by: Aman Agarwal <aman@appsmith.com>
2022-07-21 16:10:36 +05:30
Sumit Kumar
fc65216782
fix: fix race condition on datasource creation (#14348)
* fix race condition on datasource creation for non-clustered setup
2022-07-20 23:31:50 +05:30
Ankita Kinger
3933f5f4d1
feat: migrate from org to workspace under phase 3 (#14158)
* migration from organization to workspace on code level

* updated a few more files

* fixed runtime errors

* update org settings URL

* Renamed organizationId in domain objects

* changed field named from organization to workspace

* Reverted AppsmithRole changes

* fixed migrations

* recreating indexes

* migration update

* seed data runs before migration, undo changes

* mock commit

* seedmongo to populate upgraded data, datasource upgrade

* fixed two test cases

* updated migrations

* updated prop name

* Upgraded AclPermission

* comment

* migrated AppsmithRole

* more changes

* final set of changes

* variable name changes

* update cypress variable name

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ApplicationControllerCE.java

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/Datasource.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* reverting encryption handler change

* refactor code to migrate from org to workspace

* migrated a few missed out org to workspace

* updated a few more

* migrated a few missed out org to workspace

* migration changes

* Removed Permission import

* reverted code change

* few more changes

* fixed failing cypress test

* fixed failing cypress test

Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Sidhant Goel <sidhant@hexcod.in>
2022-07-20 17:24:16 +05:30
Preet Sidhu
c03fddf1c9
fix: Improve CodeMirror rendering performance using idleCallback (#13676)
* working editor wrapper

* updated other property controls

* fix tablefilter_spec unit test

* autofocus on editor

* update font styles

* show lint errors

* add syntax highlighting

* fix import issue

* fix input height

* use lazy and suspense

* wip

* update code clean up

* update input style

* fix select widget issue

* fix build issue

* fix import issue and linting css

* update lint error method

* add polyfill for idle callback

* fix undo aggregate helper changes

* rename CodeEditor component

* fix tests add delay before code mirror

* undo name change

* rename lazy editor

* add comments and update aggregate helper

* fix cypress helper

* fix testJsonText command

* update aggregate helper

* add wait to allow time to load

* fix filepicker issue

* fix currency input test

* fix unit tests

* update aggregate helper

* fix table property tests

* fix test

* fix command

* update json text command

* updated command ii

* update iii

* update iv

* add force click

* check for wrapper

* fix for objects

* fix test iv

* fix test v

* fix tests vi

* fix tests vi

* fix variable naming issue

* fix tests vii

* remove wait from wrapper click

* fix tests viii

* fix recheck wrapper availability

* fix updateCodeInput command

* fix undo while loop

* fix ix

* fix each loop

* removed EnableAllCodeEditors

* updated tests

* Upated wait

* updated some more tests

* updated wait time

* updated common method

* updated all related common methods

* update state name and add callback timeout

* updated test

* updated the test

* fix use while loop and update count

* update click func

* fix use get instead of find

* fix on click action command

* remove comments

* fix: update import statements

* add force click to widget command

* update wrapper ui

* fix auto load code editor

* update editor wrapper ui

* fix lineheight adjustment

* refactor editor wrapper

* update style import

* fix ascetic style import

* fix font style

* fix wrapper height

* update color for code block

* fix min height of content wrapper

* remove error linting and editor wrapper

* remove unused variable

* remove unused imports

* fix font color for objects

* update styles for placeholders

* remove console log

* remove react syntax highlighter

* cancel idlecallback on unmount

* Delay input foucs

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-07-20 14:56:12 +05:30
f0c1s
58dac0213c
Regenerate SSH key in connect and import flow (#14383)
As of today, we were supporting only ECDSA keys for GitHub, GitLab, and BitBucket. For Azure, RSA key generation was not available. This PR allows users to generate RSA or ECDSA keys.

As of now we support following key types and version control service providers:

    Github: ECDSA
    Gitlab: RSA, ECDSA
    Bitbucket: RSA, ECDSA
    Azure: RSA

Fixes #14382, #14715, #14570
2022-07-20 12:30:11 +05:30
f0c1s
6eaabc3a7b
fix: reload default page on discard (#14964) 2022-07-20 11:40:06 +05:30
Bhavin K
23c449ac27
fix: error showing in currency input (#14958) 2022-07-20 06:06:33 +00:00
Hetu Nandu
5d568b7a6f
fix: Tooltip for long names in Entity Explorer (#15068) 2022-07-20 06:06:11 +00:00
akash-codemonk
086ac89565
fix: query forms which require evaluation shows loading (#15272) 2022-07-19 12:16:07 +05:30
Aishwarya-U-R
68108d7827
Automated tests for Postgres Datatype - Binary type + Flaky fixes (#15210) 2022-07-16 16:11:17 +05:30
Parthvi
af2e55ef31
test: Add tests for bugs and fix flaky cypress tests (#15115)
* Fix flaky tests 

* fix discardChanges_Spec

* comment the intercept in merge method

* add test for bug#15175

* add test for bug

* fix git tests
2022-07-15 11:36:58 +05:30
balajisoundar
a97ab3d9a2
feat: Table widget v2 with support for non-ASCII characters and improved jest coverage (#11307) 2022-07-14 12:32:35 +05:30
Nidhi
02a5e1d490
fix: Added dropdown to select whether to send credentials in header or body in client credentials flow (#14545)
* Added dropdown to select isAuthorizationHeader in client credentials flow

* Added tests

* Added cypress test

* Oopsie
2022-07-13 14:33:19 +05:30
ChandanBalajiBP
a99176fae9
fix: Outdated design for Rest API Editor (#13812)
* Outdated design for Queries/JS/API Editor

* updated cypress test cases and colors reference

* updated cypress test cases with add and delete datasource

* added indexing for testcases

Co-authored-by: Chandan Balaji <chandanbalaji@Chandans-MacBook-Pro.local>
2022-07-08 20:01:12 +05:30
Ayangade Adeoluwa
57dba485ce
fix: fixes google sheets datasource global search error (#15020)
* fixes google sheets datasource global search error

* Adds cypress test

* Fix cypress test

* Fixes navigating to google sheets queries from global search issue
2022-07-08 18:27:59 +05:30
Parthvi
1f7b923ad9
test: Automate JSObject app in cypress and fix few flaky tests (#14613)
* add tests for promises

* update dsl

* fix deleteBranch_spec

* fix ImportExportForkApplication_spec

* update test

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-08 16:18:20 +05:30
Anagh Hegde
883d9d801e
chore: Refactor git api to include application id as request param instead of the path variable (#14800)
* Refactor git API's to add `/app` to the API path to identify the appId

* Update the url in cypress tests

* Update the path in git spec cypress files

* Update the url for connection spec
2022-07-07 12:35:03 +05:30
Bhavin K
1ca40f9eeb
fix: show the error message for text input widget (#14934)
* fix: show the error message for text input widget

* Update the error message & added releated new test case
2022-07-07 05:37:54 +00:00
Aishwarya-U-R
a5ff06ad7e
test: Script fixes for failing cases due to UQI css changes (#15037)
* flaky fixes

* Eval value pop up hinder fix

* JS delete from EE fix

* ActionContextMenuByEntityName() fix

* Adding Escape()

* Toasts handling
2022-07-06 20:52:24 +05:30
Aishwarya-U-R
10fe3e3acf
Automated tests for Postgres Datatype - JSON type (#14796) 2022-07-06 11:24:00 +05:30
Nidhi
906a7298dc
feat: Simplified Google Sheets queries (#14869)
* Client changes 1

* add DSL functionality

* Temp commit for refactoring changes

* Do I even know what I'm doing here?

* chore: Second GS layout

* Update: Visibility conditional outputs for schemas

- Added the output from conditional outputs for schema children too

* Update: Entity selector visibility control

- Added logic for controlling visibility of sub components via the JS expressions system

* Update: Passing disabled prop to toggle button

* Update: Passing disabled prop to toggle btn

* Update: Styled component for toggle button

- Added disabled styles based on the disabled prop sent to the toggle form view JSON button

* Update: configProperty role in Entity Selector

- Removed dependance of the configProperty of the entity selector children to it's parent component

* Update: type of placeholder key

- Made placeholder key from form config JSON to accept either string or an object
- Earlier only string was accepted
- This is for pagination component

* Update: Added placeholder control for pagination

* Client changes 1

* add DSL functionality

* Do I even know what I'm doing here?

* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design

* fix: updated tooltip component for wrong ui on entity explore

* temp triggers

* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design (#12395)

* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design

* fix: updated tooltip component for wrong ui on entity explore

* fix: updated tooltip ui, where condition placement, sort by ui

* temp form data access logic

* fix: updated sorting type width ui

* fix: updated ui for spacing, width and text issues

* Update: Type for tooltip of UQI forms

- Added option to send an object to the tooltipText object.
- This allows for composite components like pagination to have tooltips for each sub component

* Update: tooltip for pagination component

- Added handling to parse the tooltip for multiple components.
- This allows for composite components like pagination to have tooltips for each sub component

* Update: Type cast for tooltip component

- Made the content passed to tooltip component as a string only

* Update: Fixed tooltip component CSS

* Update: Dropdown option component

- Added a tooltip wrapper to each option
- This is to show on hover text like disabled state

* fix: updated ẇhere clause broken ui for condition

* Add: functions to check and extract expressions

- Loop through the formConfig and find any keys that have a value that is bindable
- Used pre defined regex to check if value is a moustache binding

* Add: Types for evaluated form configs

- Added types for the form configs to be evaluated and their output post eval

* Add: Flow to run the form config

- Run the form config and update the result to the redux state

* Update: Name of the type for formconfigs

- Updated since it was clashing with a component of the same name

* Add: Function to enforce config type checks

- This is done so that the improper configs can be weeded out and the rest of the form can be shown

* Add: Function to update evaluated config

- Added option to update the config if it's values needed evaluation

* Add: Type check for schema sections

* Update: Error handling for invalid control type

- We were throwing an exception till now, changed it to a warning text

* Add: Exposed tooltip for dropdown option disabled state

* Update: switch to json mode functionality

- Added logic to convert data to a string rather than an object when the first switch to JSON mode happens

* Update: Added key to tooltip for dropdown options

* Trigger API modification

* Add: function to fetch default trigger URL

* Update: Made URL optional in dynamic trigger config

* Update: Dynamic trigger API call

- Made the API call for dynamic triggers have URL as optional field
- Added type check to the response of the API call

* Update: resp type for trigger APIs

* Update: Moved code to utils folder

- Moved functions for UQI form eval processing to utils file

* Update: passing original controltype to JS switch

* Update: config for JSON editor mode

- Updated the config to have different options for JSON mode depending on the original control type

* Update: Connected line numbers flag to config

* Revert: CSS changes for tooltip

* Refactor: Removed consle

* Add: type for the config of dynamic values

* Add: Feature to evaluate config for triggers

* Refactor: fix type check errors

* fix: dropdown ui width with text alignment

* Update: fixed selector for dynamic values

* Update: selector call for fetchDynamicValues

* Add table header index prop for columns selector

* migration partial commit

* migration partial commit

* Refactor: removed unused import

* Update: reused function for checking dynamic value

* Update: removed unused import

* Fix format JSON issues

* Retrieve binding paths from entity selector components

* Fixes 6 remaining issues with UQI implementation

* Fix dropdown issues

* Fix dropdown height issues and fixes triggering of APIs when option is deselected

* Migration changes

* Fix QA generated UQI issues

* Fix projection component height and route change logic

* Fix multi select dropdown placeholder text issue and json stringify issue with switching view types

* Reset entity type value when command value changes

* Test changes

* Review comments

* Moved migrations around

* Corrected import statement

* Added JSON schema migration

* Updated schema version

* perf improvements and filter dropdown options feature

* Fix Code mirror component config for toggleComponentToJson input fields.

* Fix prettier issues

* fix prettier issues

* Fix style issues as a result of the merged conflicts

* Fix failing test case

* Fixed a few other flows (#14225)

* Fixed a few other flows

* Review comments

* Fix generate CRUD, fix evaluation of dynamic bindings and fix various styling issues.

* More fixes (#14367)

* Factor in the root formconfig parent key.

* Fix flickering issues, and evaluatedFormConfig issues

* fix: Teeny bugs (#14455)

* Teeny bugs

* Added previous functionality as is

* Improvements in the way we fetch dynamic values

* Fix stringiification issue and cyclic dependency issues

* Resolve projection component values deletion

* Resolve merge conflicts and fix prettier issues

* fix: Tsc issues

* Fix property pane connection navigation

* updating ee locator

* updating inputfield locator

* dropdown locator update

* Merge conflict not properly resolved.

* Fix s3 spec

* Fix Mongo Spec

* Fix some more tests

* fix: prevent cyclic dependency when switching to js mode (#14668)

* add delete events for change from array to string in diff

* add test to assert absence of cyclic dependency error when switching to js in switchgroup widget

* Assert that evaluation is not disabled when no cyclic dependency happens

* Cypress test preparations for google sheets and form controls

* Fixed a few test errors (#14874)

* Add: unit tests for uqi UI updates

- view type tests
- conditional output extraction
- processing conditional output to handle view/enabled state of the component

* Add: completed isValidFormConfig test

* Update: improved tests for update config

- These tests cover the functionality to update a section config after it's components are done evaluating

* Fix failing cypress tests and cyclic dependency issue

* Fixes some more tests

* Fixed migration of row objects (#14896)

* Bumped the version of design system package

* Update: reverted change to EE selector

* Fix deletion pointer

* Update: selector for js on load spec

- Synced with changes related to ADS dropdown

* Fix mongoDBShoppingCart spec

* Remove comments

* Fix: mongo shopping cart test failures

* fix: mongo shopping cart spec

* Dummy push to retrigger vercel

* fix: mongo shopping cart spec

* Update MongoDBShoppingCart_spec.js

* fix: removed unused click away

* dummy commit

* Update: moved helper functions to separate file

* Add: added tests for saga functions

- Worked on testing for
   - extractFetchDynamicValueFormConfigs
   - extractQueueOfValuesToBeFetched

* Add if check for queueOfValuesToBeFetched

* Resolve review comments

* Empty-Commit

Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Ayush Pahwa <ayush@appsmith.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Albin <albin@appsmith.com>
2022-07-04 11:13:27 +05:30
Favour Ohanekwu
11f8684e7f
fix: prevent temporary update of sub-path value in store object (#14847)
* support paths as keys in storevalue

* add cypresstests

* StoreValue added deploy mode verification

* Adding array input [boolean, string, number]

* store number too

* Added bug id to title

* Added dot object array & SelectJSFunctionToExecute

* propPane.UpdateFieldValue() update

* updated UpdatePropertyFieldValue

* JS toasts handling

* JSOnload spec fix

* JsOnload toast appearances fix

* support paths as keys in storevalue

* add cypresstests

* StoreValue added deploy mode verification

* Adding array input [boolean, string, number]

* store number too

* Added bug id to title

* Added dot object array & SelectJSFunctionToExecute

* propPane.UpdateFieldValue() update

* updated UpdatePropertyFieldValue

* JS toasts handling

* JSOnload spec fix

* JsOnload toast appearances fix

* prevent modification of storeValue path in temporary store

* Add cypress tests for case where storeValue key is a path

* remove redundant import of lodash

* Modify cypress tests

* update cypress tests

* Store fix revert

* revert

* Actions revert

* revert redundant change

* removed additional button- from script

* JsOnPage load script fix

* validate toast fixes

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-01 06:26:57 +01:00
Parthvi12
cc3b10c9a6
test: Add visual tests for datasource page (#14811)
* add layout tests for datasource

* fix omnibar_spec

* add tests for postgres and mong

* fix git import test

* fix test

* comment test until issue is fixed

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-01 09:01:02 +05:30
Favour Ohanekwu
41789c71bc
fix: show js function execution errors in debugger (#14555)
* Show js function execution error logs

* remove unused function

* improve check for async functions

* clear errors for deleted jsActions

* fix typescript error

* modify js function execution error logging

* test that execution parse errors are logged in the debugger

* Add test to show that js execution errors are logged in the debugger

* re-order js execution tests

* Add type to jsObj variable

* update cypress tests

* update cypress test
2022-06-30 08:21:20 +01:00
Rishabh Rathod
8bfc3ee87e
fix: store value spec as JsObject bug is resolved (#14788)
* fix: store value spec as JsObject bug is resolved

* fix test

* Use GetNClick

* StoreVal trial fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-29 17:47:14 +05:30
ChandanBalajiBP
be626a132e
Merge pull request #14103 from appsmithorg/Fix/Mismatch-with-design-in-Sample-Datasource-Card
fix: UI inconsistencies in Datasource card and page
2022-06-29 17:32:43 +05:30
Bhavin K
a2dd01806c
fix: remove the duplicate and rename the actions to events in property panel (#14714)
* Fix: Remove the duplicate & rename the "Actions" To "Events"

* rename the "Actions" to "Events" in select & multiselct widget

* Trigger Build

* fix: failed testcase are resolved
2022-06-29 11:54:50 +00:00
Rishabh Rathod
5625784829
fix: reset meta to default value (#14468)
* fix: [WIP] reset meta to default value

* refactor

* fix reset child widget and type in metaReducer

* Fix type and refactor test

* fix multiselect click

* Add jest test for reset widget action

* Add cypress test

* Add comments

* Add more cases as per comment

* remove `only` from test case

* Add default value case of array with values

* MultiSelect spec fix

* fix currencyInput reset

* refactor test code suggested in comments

* fix type

* fix more type

* fix cypress test

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-25 11:00:54 +05:30
Aishwarya-U-R
9774118b8b
test: Automated tests for Postgres Datatype - Boolean & Enum (#14778)
* BooleanEnumDT spec added

* failure point fixes

* Snaps paths updated

* Unskipping cases

* BoolEnum query create fix

* list_regression fix
2022-06-24 13:52:29 +05:30
Aishwarya UR
906cbe1f3f Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-23 21:01:19 +05:30
Aishwarya-U-R
5d75a46df1
test: Automated tests for Bug #14299 + Specs rearranged (#14632)
* Moving tests

* Workspace cases moved all to one folder

* Moving tests

* Bug 14299 scripted

* JSOnload spec failure fix

* Moving spec

* Moving specs

* Moving specs

* Added bug id in title

* Moving specs

* Moving specs

* Moving spec

* Added bug id in title

* Removed tests

* Theme Basic spec - added publish mode validations

* tests re-arranged

* Theme_form widget fix

* endp to endpoint change

* theme Basic spec fix

* AppSetupForRename removed

* Appli rename reverted

* Specs rearranged

* Added interval validation

* Also deleting query

* validation moved places

* Git imports corrected

* git import corrected

* datePicker fix
2022-06-23 20:43:15 +05:30
subratadeypappu
704d19ac4f
Merge pull request #14233 from appsmithorg/fix/14054-describe-table-in-mysql
fix: Show table structure when desc table or describe table command is run stand-alone in MySQL (#14054)
2022-06-23 19:38:20 +06:00
ChandanBalajiBP
abaafab74b Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-22 17:43:51 +05:30
Tolulope Adetula
7ba4f0679a
Merge pull request #13129 from appsmithorg/fix/12161-multiselects-broken-in-modal
fix: Popover in Multi select widget inside modals breaks away from the widget
2022-06-22 09:59:00 +01:00
Vishnu Gp
63205dce27
Merge pull request #14184 from appsmithorg/feat/git-delete-only-removed-resources
Feat: Perform file ops only when the resource is updated
2022-06-22 10:53:45 +05:30
Tolulope Adetula
31f91f6e1c fix: use ESC to close dropdown 2022-06-22 01:11:29 +01:00
Tolulope Adetula
5af2839220 fix: popup issue 2022-06-21 12:22:55 +01:00
ChandanBalajiBP
3b60d16d1f Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-20 13:38:38 +05:30
subrata
4abbd9c0cf Merge branch 'release' into fix/14054-describe-table-in-mysql 2022-06-20 09:06:16 +06:00
Aishwarya UR
673bcea321 Bug 14054 scripted 2022-06-17 17:01:40 +05:30
Aishwarya-U-R
3622bf924e
Automated tests for Postgres Datatype - Datetime (#14607) 2022-06-17 11:42:18 +05:30
Aswath K
478ae29b34
feat: Disable js toggle button if field is not empty (#12754)
* feat: Disable js toggle button if field is not empty and on non-default value

* allows certain values based on control type

* adds handling for more control types

* Change disabled message

* feat: makes option control delete button keyboard accessible

* adds support for theme values

* Adds support for border radius & box shadow controls

* message change and refactor

* minor correction in the message

* Add proper condition for Datepicker control

* fix one cypress test

* updated tests

* add checks for OptionControl

* Updated table binding test

Co-authored-by: apple <nandan@thinkify.io>
2022-06-16 15:17:35 +05:30
Aishwarya-U-R
d7eb5c58fc
Automated tests for Postgres Datatype - Numeric, Character (#14481) 2022-06-16 12:20:02 +05:30
ChandanBalajiBP
24d1ac1018 added test cases with requireed changes 2022-06-16 11:48:44 +05:30
Ankita Kinger
9b7944e7ee
feat: migrate organisation to workspace (#13863)
* migration from organization to workspace on code level

* updated a few more files

* fixed runtime errors

* update org settings URL

* Renamed organizationId in domain objects

* changed field named from organization to workspace

* Reverted AppsmithRole changes

* fixed migrations

* recreating indexes

* migration update

* seed data runs before migration, undo changes

* mock commit

* seedmongo to populate upgraded data, datasource upgrade

* fixed two test cases

* updated migrations

* updated prop name

* Upgraded AclPermission

* comment

* migrated AppsmithRole

* more changes

* final set of changes

* variable name changes

* update cypress variable name

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ApplicationControllerCE.java

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/Datasource.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* reverting encryption handler change

* migrated a few missed out org to workspace

* migrated a few missed out org to workspace

* migration changes

* Removed Permission import

* fixed AppsmithRole

* mongodb version update

* fixed compile error

* fixed compile issue

* fixed some tests

* simplified embedded mongodb config

* updated a cypress test

Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Sidhant Goel <sidhant@hexcod.in>
2022-06-15 21:07:41 +05:30
Favour Ohanekwu
6c45270def
fix: order async functions in settings tab alphabetically (#13731)
* sort js actions alphabetically in settings tab

* add cypress tests

* update cypress tests

* add onPageLoad settings locator

* Update cypress tests

* update cypress tests

* update cypress tests

* update cypress tests

* sort js actions alphabetically in settings tab

* add cypress tests

* update cypress tests

* add onPageLoad settings locator

* Update cypress tests

* update cypress tests

* update cypress tests

* update cypress tests

* fix merge conflict

* JSFunctionnExe spec flow fix

* update cypress tests

* update cypress tests

* add test case for cloning page

* Datatypes - Numeric spec addition

* failure fixes

* JSfun failure fix

* Postgres failure fix

* JSFuncExecutions failure fix

* MySQL failure point fix

* COmmunity issues wait time fix

* Fixing toast mesg validation point

* Reverting all fixes

* Revertion

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-15 12:46:53 +05:30
Pawan Kumar
89bf40e3d7
fix: Toast shows wrong theme name when changing themes (#14488)
* fix typo in toast when changing theme

* fix cypress test

* Added wait time!

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-15 12:21:37 +05:30
Aishwarya-U-R
43cba21013
test: Automated tests for improved CRUD with JSONFrom - Postgres Ds (#14271)
* Postgres CRUD

* MySQL CI run fix

* Added wait time to DeployApp()

* Helpers Enhancements

* ChangeTheme CRUD

* Postgres CRUD

* Postgres CRUD updated

* Postgres CRUD updates

* Postgres CRUD fix

* Postgres CRUD update

* postgres CRUD update

* Postgress CRUD fix

* setting cypress video false

* ExecuteAction spec fixed

* Postgres case #13 fix

* postgres CRUD fix

* Postgres CRUD fixes

* cypress video - true, reattempt - 1

* failure fixes

* Bug 11529 script added

* Bug 11529 scripted + failure fixes

* JSOnLoad_spec failure fix

* OnLoadActions failure fix

* Failure fixes

* ReadTable increased timeout

* JSFunctionExecution_spec failure fix

* Removed duplicate cases

* Mongo failure fixes + applying theme

* Mongo Spec - Added Deletion of DS also

* Deleting initial page

* Deleting DS Validation added

* tc desc updated

* failure point fixes
2022-06-10 19:00:59 +05:30
rahulramesha
c1da8a6866
fix: paste widgets on a new page (#14295)
* paste widget on generate Page

* adding cypress tests
2022-06-09 17:17:47 +05:30
balajisoundar
265ed0dc25
fix: Improve cell overflow check logic when switching between table page (#14095)
* fix: Improve cell overflow check logic when switching between table page.

* Table locators update

* Migration spec - locators update

* Migration spec locators update

* MongoDBShoppingCart spec locators update

* POstgress Spec locator fix

* Adding wait!

* Mongo DBcart spec fix

* EchoApiCMS_spec locator update

* Table locators update

* updated locators

* Added delay

* Hidden column fix trial

* Adding refresh page

* Adding time

* Fix cypress xpaths

Co-authored-by: bhavin <techbhavin@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
2022-06-08 21:59:31 -07:00
RakshaKShetty
221d9c0a7c
test: git delete branch tests (#14047)
* gitdeletebranchtests
2022-06-08 17:14:15 +05:30
Favour Ohanekwu
d5da24e51e
fix: cyclic dependency in renaming js objects (#13914)
* keep localunevaltree update in sync with unevaltree

* undo tree check

* identify .data difference for js objects

* empty line

* unit test

* unit test name change

* comment

Co-authored-by: Anand Srinivasan <anand.a.srinivasan@outlook.com>
2022-06-08 08:47:59 +01:00
Parthvi12
38f14bb5ac
test: Add regenerate SSH key tests (#14325)
* Add regenerate SSH key tests

* fix flaky tests

* fix flaky tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-06-08 13:07:00 +05:30
Aishwarya-U-R
98c06e2817
Automated tests for improved CRUD with JSONFrom - Mongo Ds (#14191) 2022-06-06 11:29:15 +05:30
Aishwarya-U-R
6c1c5581e7
Automated tests for improved CRUD with JSONFrom - MySQL Ds (#14014) 2022-05-31 11:03:59 +05:30
NandanAnantharamu
6359bfcfbe
test: List testcases (#14009) 2022-05-26 13:25:08 +05:30
Ankita Kinger
fa45282b0a
fix: alignment of the image seen on no search results on application page (#13950)
* fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865)

* add debounce to search and remove state var

* increase debounce time

* fix: updated the condition to show expiry key (#13092)

* Add index for git (#13133)

* fix: Fixed compile time errors

* fix: Unable to see apps in home page after git connect fails (#13387)

* Fix Redis installation in Dockerfile (#13428) (#13430)

Conflicts:
	Dockerfile

* fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521)

* prevent execution of onPageLoad actions before sucessful actions fetch

* Perform url update before fetching actions and jscollections

(cherry picked from commit 7261834fe5)

* fix: NPE check when datasource createdAt is null

(cherry picked from commit beafb371b24180dce2e351f1dea6d9d34db2a204)

* fixed image alignment for no search results on applications page

* deleted duplicate file

* reload to Refresh script update

* Adding sleep - script fix

Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
Co-authored-by: Rimil Dey <rimildeyjsr@gmail.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-26 10:05:35 +05:30
Favour Ohanekwu
7bbd109f62
fix: improve jseditor linting performance (#14001) 2022-05-25 18:08:35 +02:00
Aswath K
c8e79eca95
feat: Focus widget name or first property when opening property pane (#13513)
* feat: intial investigation.

* Completed focusing of Property title

* removes unused import

* fix issue with inability to focus Dropdown

* checks if PP opened not because of focusing on input elements in widget

* Adds two level of focus for LocationSearch

* adds multi state to KeyValue component

* Adds multi state to Draggable List as well

* Adds multi state to DatePickerControl

* fix: style issue with draggableList & KeyValue comp

* avoids auto focusing on Panel

* remove commentedout code

* fix: cypress tests

* change ActionConstant name

Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
2022-05-25 15:35:53 +05:30
Rishabh Rathod
cbce8f8b8e
fix: trigger consuming previous evaluated values (#13084)
We are changing how we maintain meta values in our architecture,

Earlier metaHOC component state was used to store meta values that were debounced and pushed in batch to metaReducer and trigger evaluation.
We remove the metaHOC state and directly update values to metaReducer and trigger evaluation separately via a debouched function.
2022-05-25 15:16:14 +05:30
Aishwarya-U-R
d0fed6bfe7
Automation script update to fix Community issues failure (#13968) 2022-05-23 10:50:27 +05:30
arunvjn
9753df54f4
fix: remove transition delay in the switch between explorer and widgets. (#13942) 2022-05-20 10:32:13 +05:30
Favour Ohanekwu
2748ed0e64
fix: prioritize parse errors in debugger callout (#13765)
Prioritize parse errors over lint errors in debugger callout
2022-05-19 11:57:49 +01:00
Ayangade Adeoluwa
f7107a4a0a
Fix response tab overflow issue (#13839)
This commit fixes three things

- It prevents the tab headers from being scrolled up when on the RAW/JSON tabs.
- It prevents the Table component from pushing the API right pane away when its contents are too wide.
- It also prevents the table and JSON component from clipping the data displayed within them by adding margins/paddings between them and the parent container.
2022-05-19 08:32:43 +05:30
Ayangade Adeoluwa
1ee494b9ca
fix: Fix validation check that is blocking input from changing (#13943)
* Fix validation check that is blocking input from changing

* Add testcases for Elastic search datasource

* Adds header value to test case

* Fix validation logic
2022-05-18 17:35:03 +00:00
Aishwarya-U-R
04a8c3b037
Tests for JSObjects-onPageLoad (#13712)
Automated tests to improve coverage for JSObjects-onPageLoad
2022-05-18 16:09:42 +05:30
Bhavin K
94b93a657b
fix: remove cell background from empty rows (#13257) 2022-05-18 04:46:25 +00:00
Parthvi12
32bcd94e54
Add tests for git discard changes (#13866) 2022-05-18 04:45:32 +00:00
ashit-rath
c60f102e45
fix: JSONForm - hidden field value reflects in formData (#13739)
* fix: JSONForm - hidden field value reflects in formData

* shifted update form code from useController to FieldRenderer

* review changes
2022-05-12 17:52:44 +05:30
Favour Ohanekwu
876d1a17e7
fix: prevent lint warnings from blocking execution in js objects (#13700) 2022-05-11 11:20:33 +01:00
NandanAnantharamu
7199a329a9
test: Theme related tests (#12740)
* Removed unwanted waits

* Updated test for fonts

* Updated tests with Font and Theme usecases

* updated tests

* Added new tests and common locators

* Added default/update theme tests

* grouped tests

* Updated Theme tests

* updated multiwidget test

* updated theme tests

* Updated tests

* Reordered tests
2022-05-11 11:43:28 +05:30
Aishwarya-U-R
f5cc98644f
Automated tests to TableFilterSpec for Bug #13334 + failure fixes (#13662) 2022-05-10 10:40:46 +05:30
haojin111
b6d2f971c0
feat: 12594 - added cypress test of form login on admin setting page (#13178)
* added cypress test of form login on admin setting page

* resotre setting after checked

* added a check if signup form is enabled for all users

* minor fix

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-05-06 20:21:08 +05:30
Aishwarya-U-R
e8c9d1da3e
test: Automated tests to improve coverage for JSObjects-onPageLoad + Flaky fixes (#12904)
* Adding theming spec

* Removed theming spec

* Reverted cypress.json changes

* Adding more JSOnPage load validations

* Added Theming - comment spec

* Theming - new cases

* JSOnload fix

* JSOnPage load cases update

* Bind_tabWidget fix

* Name update to CommunityIssues

* Flaky fixes

* Flaky fix

* Reverting postgress index addition

* Failure fixes
2022-05-06 11:10:10 +05:30
Aswath K
ca3f159f66
fix: set max-height for Dropdown component (#13105)
* fix: set max-height for Dropdown component

* changes style for date format dropdown

* Combines MultiSelectControl into DropdonwControl

* fix: max height set via props

* fix: popover double scrollbar issue

* fix: styles for chips

* Delete MultiSelectControl

* fix: error when pressing Enter twice

* add tests for multi select & fix some warnings

* removes unwanted test file

* fix: country filtering issue

* address review comments

* fix dropdown for primary columns dropdown

* fix: issue with position

* Adds scrollIntoView when using arrow key for navigation

* fixes issue with scrollbar

* fix: jest tests

* fix: jest test

* fix: flaky cypress test

* fix: height & align issue in Date format selection

* smoothens the scroll
2022-05-06 10:34:17 +05:30
Favour Ohanekwu
59710de95b
chore: highlight name input field for newly created js objects (#13212) 2022-05-04 10:47:41 +01:00
Pawan Kumar
809a633306
feat: App Theming (#9714)
* fix style bugs

* fix select styles

* test: fix font size issue for cypress tests

* incorporate ashit feedback

* test: addresed review comments for cypress tests

* add analytics events

* height issue in view mode

* incorporate code review feedbacks

* incorporate code review feedbacks

* refactor: addressed review comments; removed border radius and box shadow for text widget; Updated migrations

* feat: Makes shadow and radius controls keyboard accessible (#11547)

* makes shadow and radius controls keyboard accessible

* removes unused imports

* moves options out of render method

* fix: changed the misnomer background property name to the relevant property name

* fix: border radius issue for the map widget

* address qa bugs

* address qa bugs

* fix ux of theming pane when widget is selected

* fix:
* added backgroundColor to the video widget
* restricted pop-over border radius to 0.375rem
* added box shadow for the input group for select widget

* fix: added delete icon in the delete theme modal

* address qa bugs

* change checkbox column size in config

* add js convertible to button color

* remove unused imports

* test: fixed jest tests

* fix primary color typo

* fix: migrations for the theming

* fix:
* Removed background color from MultiTreeSelect and TreeSelect component.
* grouped button's menu button pop over border radius restricting to 0.375rem.

* test: updated Dsl migration UT

* address qa bugs

* address qa bugs

* fix: address qa comments

* address qa bugs

* fix:
* migration issue;
* unit test cases;

* fix rating widget scroll issue

* fix youtube video border radius bug

* fix select widget

* fix select widgets styles

* address qa bugs

* merge conflicts

* makes the reset button keyboard accessible (#12134)

* -resolved merge conflicts

* address qa bugs

* fix: labelTextSize migration fixes

* refactor:
* made changes to the fontSizeUtils function
* fixed the issue related to unit tests

* fix button group widget

* remove unused imports

* fix: fixed the text size migration for the table widget

* refactor: addressed review comments for the table widget theming migration

* fix button group widget

* add init calls for view mode

* json form init theme changes

* fix: added migration for boxShadow, borderRadius and textSizes for table widget

* fix broken fields

* test: fixed unit tests

* wip

* inconsistancy fixes and schemaItem update in updateHook/fieldConfiguration

* feat: init json form migration theming

* json form primaryColor -> accentColor

* update table widget

* update table widget

* object field label styling

* fix: migration related to the JSON form

* fix: fixed labelTextSize migration for JSON form nested widgets

* property control nested stylesheet lookup

* JSONForm label styles form array items

* show label for checkbox field array item

* fix button group widget

* wip

* refactor: addressed table widget review comments

* refactor: addressed ashit review comments;
* added childStylesheet for widgets

* feat: Keyboard navigable Color Picker control (#11797)

* Makes ColorPicker keyboard accessible

* seperate out keyboard and mouse interactions

* fix issue with not focusing back to input

* Adds test for Color picker

* chore: added comment for the boxShadow property

* fix:
* added unit test cases for the widget and property utils
* resolved warning messages

* wip

* theme config update

* fix merge conflicts

* refactor: moved theming migration inside the migrations folder

* fix qa bugs

* fix jest test

* fix: unit test cases

* fix table column creation logic

* refactor: addressed review comments for migrations

* fix: Overriding margin and padding for custom render in the dropdown component (#12875)

* * fix for custom render padding and margin in ADS dropdown

* * fix for removing padding from normal render options

* refactor: moved the boxShadow condition to the variable

* fix qa bugs

* fix: migration QA callouts for audio recorder widget

* refactor: added updated comments for boxShadow migration for table widget

* fix theme binfings for JSONForm fields under Object

* fix table widget theming bug

* fix: addressed code review comments

* fix: unit test cases

* fix: qa migration callouts

* fix table widget theming bug

* fix JSONForm currency input dropdown not submit form

* Added new tests - AppThemingSpec

* fix qa bugs

* fix unit test

* fix JSONForm cellBorderWidth to have default value post migration

* fix unit test

* fix qa bugs

* remove unused imports

* fix qa bugs

* fix JSONForm input height issue

* fix qa bugs

* Updating Theming spec

* * dropdown color fixes (#13249)

* fix caching issue
;

* Fixed Theming tests

* fix tests

* fix tab widget tests

* fix: json form children level migration issue

* fix table widget tests

* Updated test

* updated tests

* updated test

* updated tests

* updated tests

* updated pageload

* fix cypress tests

* remove cypress created files

* fix color picker issues

* Failure fixes

* Fixed some more tests

* fix: cypress test failures

* fix tests

* remove consoles

* fix table tests

* fix qa bugs

* updating snapshots for AppPageLayout_spec as per new UI

* fix rating widget bug

* fix qa bugs

* fix:
* cypress failing tests
* Migration QA callouts
* Removed unused imports

* update constract check algo

* fix color contrast issue

* fix: cypress failure test cases

* update font sizes labels

* fix regression bugs

* fix:
* JSON form labelTextSize issue fix
* Updated comment for the fontSizeUtility function
* migrations issues related to table widget borderRadius and boxShadow

* fix: default labelTextSize issue for the Input and Select families

* fix regression bugs

* fix regression bugs

* PassingParams spec - added wait time

* fix: font family default value issue on JS toggle

* fix js toggle issue in text widget

* fix tests

* fix tests

* fix tests

* fix cypress tests

* fix regression bugs

* fix regression bugs

* fix:
* refactored table widget migration function as per review comments,
* added default value to the widget

* fix: failing unit test cases

* fix theming spec

* fix cypress tests

* test: fixed failed cypress test

* incorporate ashit feedback

* fix cypress tests

* fix: addressed review comments

* comment out table cypress test

* fix merge conflicts

* comment out color picker tests

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aswath K <aswath@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Ashit Rath <ashit@appsmith.com>
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-04 15:15:57 +05:30
balajisoundar
8163becacc
fix: DisplayText in table url column should be processed properly for empty values (#13318)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-04 14:59:42 +05:30
Abhijeet
9fc9f7a774
chore: Commit application files during the connect flow (#12288)
* Commit application files during the connect flow

* Refactor detach remote method name

* updating connectToGitRepo method

* fix git tests

* Update default dsl to remove uncommitted changes for bottomRow and pathlist

* updating git cypress tests

* fixed git bug spec cypress test

* enabled other test case

* with store test

* fixed comment

* closing git sync modal

* updated test logic

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
Co-authored-by: Parthvi12 <80334441+Parthvi12@users.noreply.github.com>
Co-authored-by: haojin111 <haojin828@outlook.com>
2022-05-04 12:27:07 +05:30
Parthvi12
2f4ca6aa98
test: Add tests for git sync app and git bugs (#13394)
* Add tests for gitSync

* add test for git import bug#12749

* modified importAppfromGit method

* add test for bug #13385

* updated tests

* fixed test

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-02 09:59:03 +05:30
Favour Ohanekwu
942547287c
feat: js object v1 run and settings redesign (#11456) 2022-04-28 17:51:02 +01:00
haojin111
7b09976f52
feat: 12457 - added application import success modal (#12739)
* added application import success modal

* updated logic and added cypress test

* fixed cypress test

* added local storage for refresh

* fixed issue - 11721 git import issue

* fixed cypress test with new designd modal

* fixed cypress test failed issue
2022-04-27 12:07:04 +05:30
Ankita Kinger
cd84b63373
added check for disconenct button clicked once (#13272) 2022-04-26 19:51:06 +05:30
Ayangade Adeoluwa
a896467e69
fix: Change response tab name (#12930)
* Change response tab name

* Fix response tab name
2022-04-22 12:10:00 +01:00
Ankita Kinger
9ed26a92b0
chore: update a cypress test (#13036) 2022-04-21 11:44:02 +05:30
arunvjn
b69b1191cf
fix: widgets from other apps shown in omnibar (#12890) 2022-04-15 11:10:56 +05:30
Paul Li
eb37416a2a
feat: Controls for labels in widgets to align the widgets in forms and other places (#10600)
* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Create a new property control for a label position
-- Create a new property control for a label alignment
-- Prototype a label section for Input widget

* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Add a property, labelWidth in the property pane

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Input widget: Implement all the requirements in case its type is Text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adapt the functionalty on other types of the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into DropdownWidget
-- Clean up for the input widget and DRY

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectWidget
-- Eliminate unnecessary component prop, columns

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalties into Tree Select widget
-- Add styles for alignment between lable and input control over the widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectTreeWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Introduce label functionalities into DatePickerWidget2
-- Use width instead of columns prop in InputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RichTextEditorWidget
-- Eliminate compactMode from StyledLabel

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into CheckboxGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement switch group for the correct meaning of right alignment

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RadioGroupWidget
-- Add new properties, alignment and inline for consistency

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adjust cols and rows for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused StyledRadioProps

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete first MVP of enhanced SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete the first MVP of enhanced RadioGroupWidget
-- Eliminate unused StyledSwitch component for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add min-height, align-self rules for LabelContainer

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Use original label property for RadioGroupWidget
-- Add a migration for adding isInline and alignment properties for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Update version to latest one in DSLMigrationsUtils.test.ts

* fix failing jest test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement label functionalities on BaseInputWidget, InputWidgetV2, CurrencyInputWidget, PhoneInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DSLMigrationsUtils

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the label related test case which is failed in Input_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places
-- Fix on #10119: The label text truncates on resizing the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix scroll issue when shrink with MultiSelectWidget and MultiSelectTreeWidget

* fix: Widget Popup test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement width and alginment features on the level of label element
-- Prevent actual inputs from DropdownWidget, MultiSelectWidget, SingleSelectTreeWidget, MultiSelectTreeWidget from overflow when resizing
-- Enable label feature on a RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set label container's default width to 33% when width is not set

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix crash issue when labelWidth is filled by non-numeric value, eliminating passing NaN as its value

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set flex-grow to zero on input types other than TEXT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label features on newly created MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate LabelPositionTypes, directly using enum LabelPosition
-- Add a comment for a constant LABEL_MAX_WIDTH_RATE
-- Directly import React for LabelAlignmentOptionsControl
-- Remove unnecessary constructor for LabelAlignmentOptionsControl
-- Define handleAlign instance method as a higher-order function
-- Only migrate alignment property for RadioGroupWidget
-- Use Object.hasOwnProperty instead of in operator

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Migrate alignment property of RadioGroupWidget in case of currentDSL.version is 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Revert currentDSL.version to 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a Jest test case for RadioGroupWidget's alignment property migration

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Replace all nested ternary operators with if statements

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label feature on new version of SelectWidget
-- Add Cypress tests for widgets' label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor code for BaseInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change CSS selector for step buttons for Numeric BaseInputWidget
-- Directly use migrateRadioGroupAlignmentProperty migration function without using transformDSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on typo about migrateRadioGroupAlignmentProperty

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add data-testid attributes for Cypress selectors

* feat: Deprecate form button widget

-- Assert flex-direction to row in CheckboxGroup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a missing data-testid for SelectWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on failed test cases: CheckboxGroup_spec, DatePicker_2_spec, MultiSelectWidgetV2

* fix: Select popup DSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new property control, NumericInputControl
-- Replace all the label properties with the newly created controls

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new Cypress command, checkLabelWidth and apply to all related test cases
-- Increase width in checkboxgroupDsl.json
-- Rename className for label in MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement the tooltip feature for labels
-- Add missing props for labels in DateField, MultiSelectField, RadioGroupField, SelectField fields for JSONFormWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor property controls, including LabelPositionOptionsControl, LabelAlignmentOptionsControl, NumericInputControl to keep consistency
-- Apply default values into label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract the label related parts from the various widgets as an independent component

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate TypeScript any type from BaseInputComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change labelPosition property type to DROP_DOWN
-- Modify LabelAlignmentOptionsControl to use ButtonTabComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Define getLabelWidth method into BaseWidget
-- Extract the common CSS rules for the widget containers
-- Revert rows and columns for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed test case in DSLMigrationsUtils.test.ts

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on overflow issue on CheckboxGroupWidget
-- Create a distinctive spec file for label feature
-- Eliminate the redundant label specs with the relevant widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Delete unnecessary files, including Select_spec.js, LabelButton.tsx and LabelPositionOptionsControl.tsx
-- Revise wrong comment for checkLabelForWidget Cypress command

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Do not set the label width only if its value is 0
-- Clean up the component for DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Make RadioGroupWidget's layout flexible in all modes

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on Cypress test case for RadioGroupWidget in Widgets_Labels_spec
-- Change Cypress commands, including addAction, addSuccessMessage, enterActionValue to accept parentSelector

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change getLabelWidth method to not have any argument
-- Define some constants for label numbers
-- Extract the common styles for SwitchGroupWidget and RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor some constants

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused width prop from RadioGroupWidget
-- Get labelWidth from getLabelWidth

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate the min-height restriction on a label
-- Eliminate the scroll on the earlier InputWidgetV2 which was not in compact mode

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add one more condition checking if the current input type is text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract common code base for MultiSelectTreeWidget and MultiSelectWidgetV2
-- Apply a few CSS fixes on the scrollbar issue select related widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply some tweaks for earlier widgets with labels so as not to be broken UX

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed Cypress test case in Widget_Popup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add constants, LABEL_DEFAULT_WIDTH_RATE, SELECT_DEFAULT_HEIGHT, LABEL_MARGIN_OLD_SELECT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Increase the widths of CheckboxGroupWidget and SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set the font size to 14px for NumericInputControl

Co-authored-by: ohansFavour <fohanekwu@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-04-14 16:47:25 +08:00
Parthvi12
0766f83cf0
test: Add tests for git bugs and git import (#12751)
* add tests for git bugs and git import

* add dsl file

* added test for git bug and commented git sync test for apps

* updated tests

* removed wait

* updated messages.test.ts

* updated git import tests

* added fix for onboarding_spec
2022-04-14 08:32:57 +05:30
CommanderRoot
a778a98016
chore: replace deprecated String.prototype.substr() (#11928)
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-04-13 12:30:38 +05:30
Aishwarya-U-R
8f4756c1d1
test: Automated tests for AForce Migration scenarios + Improved TableFilter spec script coverage (#12534)
* Aforce spec- DefaultSearchText added

* Bug 12228 scripted

* Remove text added

* Aforce - Client Side Search added

* Aforce - adding new issue from modal

* Aforce spec - add new issue fixed

* Aforce spec - update/Delete issue added

* Aforce - multi widget selection fix

* aforce spec - multi select fix

* Aforce - multi select fix

* Aforce - multi select fix

* Removing Table_Filter_spec from ignore files

* MemberRoles locator fix

* member roles locator update

* Tablefilter spec fix

* Aforce spec type fix

* Aforce - search spec

* TableFilter spec fix

* Chartdatapoint fixed

* desc update

* Aforce - skipping table search again

* Removed duplicate spec

* GetNClick improved

* BindTable_api spec fix

* AForce spec fix

* CHartdatapoint spec fixed

* JSObjToListwidget spec fix

* OnPageLoad spec fix

* updates

* TableFilter.ts added

* TableFilter added more scenarios

* TableFilter added more scenarios

* Table_spec failure fix

* TableFilter spec - scenarios added

* AForce Filter case added

* AForce fix

* Aforce filter fix

* Aforce fix

* SelectFromMultiSelect added fix

* Picking msg from message.ts file

* Aforce spec - Added wait

* Aforce - filter spec fix

* JSONload messages update
2022-04-12 15:31:22 +05:30
Trisha Anand
85ebed6d5e
Merge branch 'master' into release 2022-04-12 14:06:53 +05:30
NandanAnantharamu
db2310bef7
test: Commands file organised (#12533)
* Commands file seggregated

* updated support file

* updated common method

* updated the support files

* Updated imports
2022-04-11 09:00:37 +05:30
Favour Ohanekwu
dcddf4cb86
chore: Add data property in entity explorer as part of "show bindings" (#12590)
* include JSAction data in show-bindings
2022-04-07 21:37:03 +01:00
Bhavin K
d22ae809cb
fix: handle duplicate tab name in tab widget (#12411) 2022-04-07 16:19:12 +00:00
arunvjn
2ac4d917f7 Merge branch 'release' into releasev1.6.17 2022-04-07 16:01:26 +05:30
Aishwarya-U-R
6363e75bda
test: Automation script update to fix JSOnPageLoad pop-up text message (#12673) 2022-04-07 15:55:24 +05:30
arunvjn
c3fdeb884e Merge branch 'release' of github.com:appsmithorg/appsmith into releasev1.6.17 2022-04-07 15:43:29 +05:30
Aishwarya-U-R
cb14819046
JSOnPageLoad pop-up text msg fix (#12671) 2022-04-07 12:08:26 +02:00
arunvjn
1c5e216e6f Merge branch 'release' of github.com:appsmithorg/appsmith into releasev1.6.17 2022-04-07 14:08:48 +05:30
arunvjn
03b46483dc
fix: 404 on apps with names that start with api, login or oauth (#12619) 2022-04-07 07:39:15 +02:00
arunvjn
f18d3b8dc4
fix: update url while switching between git branches (#12586) 2022-04-06 11:46:37 +02:00
Apeksha Bhosale
e7d4bdba6e
fix: removed promisification of confirmation (#12553)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-06 12:52:18 +05:30
arunvjn
1af6ef2be8
fix: 404 on renaming new pages in apps with legacy URLs (#12547) 2022-04-04 13:11:52 +02:00
Parthvi12
6653adc30e
test: add tests for git import flow (#12427)
* adding basic test for git import

* add git import test
2022-04-04 13:27:34 +05:30
Aishwarya-U-R
7a7169e8c3
test: Cypress tests to include Deploy mode verifications + few flaky fixes (#12444) 2022-04-03 18:43:20 +02:00
Aishwarya-U-R
9bbd671b3f
test: Automated few tests for AForce Migration scenarios + Flaky fixes (#12231) 2022-03-31 17:21:08 +05:30
Ayangade Adeoluwa
1cd8dde12c
feat: uses codemirror to display query results (#11312)
* uses codemirror to display query results

* Add finishing touches to codemirror component

Co-authored-by: Adeoluwa Ayangade <adeoluwaayangade@Adeoluwas-MacBook-Pro.local>
2022-03-30 13:12:15 +00:00
Preet Sidhu
c9069bedce
Merge pull request #11673 from appsmithorg/fix-11468_dropdown_performance
fix: 11468 select widget performance on a large data set.
2022-03-30 18:41:59 +05:30
Arpit Mohan
6a3ec51287 Merge branch 'master' into release-300322 2022-03-30 12:33:15 +02:00
arunvjn
23c12f4afc
fix: URL slugs in duplicate, import and export operations. (#12283)
* Persists modal to show info when update is in progress
2022-03-28 18:30:05 +00:00
Preet
d456df8cf6 Merge branch 'release' into fix-11468_dropdown_performance 2022-03-28 12:01:15 +05:30
Preet
28fc96b020 undo common locators lint fix 2022-03-28 12:01:02 +05:30
Aswath K
5330437d1a
feat: Makes jsToggle keyboard accessible (#12048)
* Makes jstoggle keyboard accessible

* fix cypress locator
2022-03-28 11:21:52 +05:30
Parthvi12
794c0f2299
test: add test for git sync bug #10773 (#12267)
* added test for git sync bug and fixed flaky tests

* updating git test
2022-03-28 10:40:07 +05:30
Preet Sidhu
74def3bb98
Merge branch 'release' into fix-11468_dropdown_performance 2022-03-25 16:45:14 +05:30
Preet
4b14f2bf4f fix merge conflicts 2022-03-25 16:44:12 +05:30
Preet
16bea463e7 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-25 16:34:40 +05:30
arunvjn
69c09c03aa
feat: adding slug names in urls (#10957)
* Init commit clean urls

* Changes to builder route

* Refactored URLs

* Remove default params from url builder functions.

* Fixed more urls

* Changed selector name

* Minor url correction

* Type fixes

* Jest fixes

* Fixed routing for old published apps

* Fixed url slug replace

* page-1 -> page1 as default page slug name

* Remove application id from init editor calls

* Use default page slug

* Added comments and placeholder values for slug names

* variable rename

* Removed redirection and added back the old routes

* Prevent page slug name recompute

* Fixed home page load in view mode

* Added null checks

* Fixed jest test

* Fixed jest test

* Update URL slugs when app/page name changes

* Added unit tests and updates types

* Removed unused code

* * Removed duplication fetch page call.
* Fixes #11354
* Fixed sign up flow

* Refactored initializeEditorSaga

* Fixed warnings

* Fixed integrations screen URL bugs

* Cypress fixes

* Fixed slug names in copy/move operations and pages screen

* Minor refactor

* Fixed page highlight bug in published apps

* Added new url factory and middleware to store url params

* Changed store to default export and fix unit tests

* Fixed slugs unit test

* Minor fixes

* Fixes #11379

* Fixed set as home page feature

* Updated types

* app id adjustments for cypress

* Fixed bad merge

* Refactored routes to functional component

* * Fixed EE active entity highlight.
* Remove unused code in editor router.

* jest fix

* Mock history to prevent security errors

* constant rename

* Removed console logs

* Fixed page id regex

* Do not check for /pages in url

* Fixed missing pageId on quick edit/deploy clicks

* Missed files from previous commit

* Fixed warnings

* Fixed jest test

* New api integration

* feat: Add applicationVersion property to Application (#11626)

Added a new property to Application object - applicationVersion. This property can be used to identity when there is a breaking change and can not be solved with migration. FE will use this property to detect such conditions. Another API is added to migrate the applicationVersion to latest version when user migrates the breaking changes.

* Added manual upgrade modal.

* Test fix

* Fixed jest test

* function rename

* Fix deploy error

* Added null check

* Changes to persist URL search params when redirecting

* Added updates tooltip

* More unit test cases

* Fixed git url redirection

* Fix warning

* Fixed evaluation on upgrade

* Fixed warnings

* File rename

* Added cypress for clean urls

* Fixed import/export/fork cypress

* Cypress api server fixes

* Fixed mongo spec

* Fixed replay spec

* Fixed comments spec

* More cypress fixes

* Fixed tooltip in update btn

* Text size changes

* Minor fixes

* Jest test fix

* Fixed type error

* Fixed warnings

* Fixed todo comments

* Moved description to constants file

* Fixed cypress CI run crash

* Fixes git cypress failures

* Import/Export cypress test fixes

* Import export fork cypress fixes

* Explorer test fix

* Switch branch test fix

* Added applicationVersion in export app json

* Calls plugin forms in parallel

* Fixed warnings

* Fixed warning

* Import export CI fixes

* Reverts previous changes

* Fixes import export

* Fixed import export cypress URL verification

* Pass applicationVersion when duplicating application

* Cypress fix

* Dummy commit

Co-authored-by: Nayan <nayan@appsmith.com>
2022-03-25 16:13:26 +05:30
Preet
6902255b72 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-25 16:06:37 +05:30
Aishwarya-U-R
f68bdaa453
test: Skip Git flaky test to unblock CI (#12238)
* Commenting git flaky

* BindApiWIthlistWidget validaton fix

* BindApiWIthlistWidget validaton fix

* SwitchGroup spec fix

* command.js change
2022-03-25 12:04:23 +05:30
Aishwarya-U-R
761e697da8
test: Automated tests improvements for Mongo CRUD cases + few flaky fix (#11985)
* Adding AForceMigration spec

* Merge from release

* Mongo CRUD data load check added

* Added bug id & adding to skip to checkin

* Unskipping MySQL_Spec to test TED

* Api-bugs spec fix

* Adding back MySQL_Spec to ignore

* EE_CopyQuery_RenameDatasource_spec revert to fix

* Skipping Git_sync flaky test

* Removing mySQl from ignore

* Unskipping Mongo cases as Bug12162 fixed

* Empty files moved due to Mocha update
2022-03-25 01:04:28 +05:30
Apeksha Bhosale
d0fdabaccd feat: Settings js editor (#9984)
* POC

* Closing channels

* WIP

* v1

* get working with JS editor

* autocomplete

* added comments

* try removing an import

* different way of import

* dependency map added to body

* triggers can be part of js editor functions hence

* removed unwanted lines

* new flow chnages

* Resolve conflicts

* small css changes for empty state

* Fix prettier

* Fixes

* flow changes part 2

* Mock web worker for testing

* Throw errors during evaluation

* Action execution should be non blocking on the main thread to evaluation of further actions

* WIP

* Fix build issue

* Fix warnings

* Rename

* Refactor and add tests for worker util

* Fix response flow post refactor

* added settings icon for js editor

* WIP

* WIP

* WIP

* Tests for promises

* settings for each function of js object added

* Error handling

* Error handing action validation

* Update test

* Passing callback data in the eval trigger flow

* log triggers to be executed

* WIP

* confirm before execution

* Remove debugging

* Fix backwards compatibility

* Avoid passing trigger meta around

* fix button loading

* handle error callbacks

* fix tests

* tests

* fix console error when checking for async

* Fix async function check

* Fix async function check again

* fix bad commit

* Add some comments

* added clientSideExecution flag for js functions

* css changes for settings icon

* unsued code removed

* on page load PART 1

* onPageLoad rest iof changes

* corrected async badge

* removed duplicate test cases

* added confirm modal for js functions

* removed unused code

* small chnage

* dependency was not getting created

* Fix confirmation modal

* unused code removed

* replaced new confirmsaga

* confirmaton box changes

* Fixing JSEditor Run butn locator

* corrected property

* dependency map was failing

* changed key for confirmation box

Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-24 11:04:36 +01:00
ashit-rath
32fee08c5c
feat: JSON Form widget (#8472)
* initial layout

* updated parser to support nested array

* array field rendering

* changes

* ts fix

* minor revert FormWidget

* modified schema structure

* select and switch fields

* added checkbox field

* added RadioGroupField

* partial DateField and defaults, typing refactoring

* added label and field type change

* minor ts changes

* changes

* modified widget/utils for nested panelConfig, modified schema to object approach

* array/object label support

* hide field configuration when children not present

* added tooltip

* field visibility option

* disabled state

* upgraded tslib, form initial values

* custom field configuration - add/hide/edit

* field configuration - label change

* return input when field configuration reaches max depth

* minor changes

* form - scroll, fixedfooter, enitity defn and other minior changes

* form title

* unregister on unmount

* fixes

* zero state

* fix field padding

* patched updating form values, removed linting warnings

* configured action buttons

* minor fix

* minor change

* property pane - sort fields in field configuration

* refactor include all properties

* checkbox properties

* date properties

* refactor typings and radio group properties

* switch, multselect, select, array, object properties

* minor changes

* default value

* ts fixes

* checkbox field properties implementation

* date field prop implementation

* switch field

* select field and fix deep nested meta properties

* multiselect implementation

* minor change

* input field implementation

* fix position jump on field type change

* initial accordian

* field state property and auto-complete of JSONFormComputeControl

* merge fixes

* renamed FormBuilder to JSONForm

* source data validation minor change

* custom field default value fix

* Editable keys for custom field

* minor fixes

* replaced useFieldArray with custom logic, added widget icon

* array and object accordian with border/background styling

* minor change

* disabled states for array and objects

* default value minor fix

* form level styles

* modified logic for isDisabled for array and object, added disabledWhenInvalid, exposed isValid to fieldState for text input, removed useDisableChildren

* added isValid for all field types

* fixed reset to default values

* debounce form values update

* minor change

* minor change

* fix crash - source data change multi-select to array, fix crash - change of options

* fix positioning

* detect date type in source data

* fix crash - when object is passed to regex input field

* fixed default sourceData path for fields

* accodion keep children mounted on collapse

* jest test for schemaParser

* widget/helper and useRegisterFieldInvalid test

* tests for property config helper and generatePanelPropertyConfig

* fix input field validation not appearing

* fix date field type detection

* rename data -> formData

* handle null/undefined field value change in sourceData

* added null/undefined as valid values for defaultValue text field

* auto detect email field

* set formData default value on initial load

* switch field inline positioning

* field margin fix for row direction

* select full width

* fiex date field default value - out of range

* fix any field type to array

* array default value logic change

* base cypress test changes

* initial json form render cy test

* key sanitization

* fix fieldState update logic

* required design, object/array background color, accordion changes, fix - add new custom field

* minor change

* cypress tests

* fix date formatted value, field state cypress test

* cypress - field properties test and fixes

* rename test file

* fix accessort change to blank value, cypress tests

* fix array field default value for modified accessor

* minor fix

* added animate loading

* fix empty state, add new custom field

* test data fix

* fix warnings

* fix timePrecision visibility

* button styling

* ported input v2

* fix jest tests

* fix cypress tests

* perf changes

* perf improvement

* added comments

* multiselect changes

* input field perf refactor

* array field, object field refactor performance

* checkbox field refactor

* refectored date, radio, select and switch

* fixes

* test fixes

* fixes

* minor fix

* rename field renderer

* remove tracked fieldRenderer field

* cypress test fixes

* cypress changes

* array default value fixes

* arrayfield passedDefaultValue

* auto enabled JS mode for few properties, reverted swith and date property controls

* cypress changes

* added widget sniping mode and fixed object passedDefaultValue

* multiselect v2

* select v2

* fix jest tests

* test fixes

* field limit

* rename field type dropdown texts

* field type changes fixes

* jest fixes

* loading state submit button

* default source data for new widget

* modify limit message

* multiseelct default value changes and cypress fix

* select default value

* keep default value intact on field type change

* TextTable cypress text fix

* review changes

* fixed footer changes

* collapse styles section by default

* fixed footer changes

* form modes

* custom field key rentention

* fixed footer fix in view mode

* non ascii characters

* fix meta merge in dataTreeWidget

* minor fixes

* rename useRegisterFieldInvalid.ts -> useRegisterFieldValidity.ts

* modified dependency injection into evaluated values

* refactored fixedfooter logic

* minor change

* accessor update

* minor change

* fixes

* QA fixes date field, scroll content

* fix phone number field, removed visiblity option from array item

* fix sourceData autocomplete

* reset logic

* fix multiselect reset

* form values hydration on widget drag

* code review changes

* reverted order of merge dataTreeWidget

* fixes

* added button titles, fixed hydration issue

* default value fixes

* upgraded react hook form, modified array-level/field-level default value logic

* fixed select validation

* added icon entity explorer, modified icon align control

* modify accessor validation for mongo db _id

* update email field regex

* review changes

* explicitly handle empty source data validation
2022-03-24 12:43:25 +05:30
Daniel
48685a850d
fix: blank screen in datasource view mode (#12145) 2022-03-23 18:00:38 +05:30
Ayangade Adeoluwa
5f93385f78
feat: Revamp deletion flow (#11774)
* Revamp deletion flow

* remove modal confirmation from cypress tests

* Fix tests, add functionality for other deletion flows

* Fix some more tests

* remove credentials

* fix cypress errors

* Fix more failing cypress tests

* Fix more failing tests

* Fixes failing jest case

* Fix failing tests, Use constant styling for treedropdown component

* Fix failing cypress tests

* Fix failing cypress tests

* Fixes failing Mongo spec test

* Fix datasource card merge conflicts

Co-authored-by: Adeoluwa Ayangade <adeoluwaayangade@Adeoluwas-MacBook-Pro.local>
2022-03-23 05:33:06 +00:00
Preet
9b5b835d82 fix passing props test 2022-03-23 10:04:11 +05:30
Preet
6d33570310 fix cypress tests 2022-03-22 22:22:26 +05:30
Preet
7016f3d439 fix cypress tests 2022-03-21 20:15:17 +05:30
Aishwarya-U-R
47fc1443f2
test: Script fixes for flaky tests + Unskipping few skipped tests + Cypress upgraded (#11724)
* AForceMigration started

* Table_GenralProp Background color failure fix

* Adding assertPageSave()

* Flaky fix

* Flake fix

* S3 - upload case uncomment

* Added click aft clear - Table_AddBtn spec

* Unskipping Promises scripts

* Promises fix

* Table_genral fix

* Separating Table_Color spec

* Failure fixes

* JObjtoInput flaky fix

* .wait to .Sleep

* Failure fix

* HSEditor complete replace fix

* small replace

* Update a user's name flaky fix

* EE_CopyQuery spec fix

* UNSkipping select widget test

* Flaky fixes

* viewportHeight updated

* Page Load spec - fixed & unskipping test

* Mongo cy.al failure fix

* Promises.any fix

* Promises.any fix

* List_Spec fix

* LIst_spec fix

* Promises.any fix

* Replay editor- flaky fix

* S3 flaky fix

* expandCollapse flaky click fix
2022-03-19 21:26:53 +05:30
arunvjn
94d9f233bd
fix: Show newly created datasources on the entity explorer (#11892) 2022-03-18 14:15:38 +05:30
Apeksha Bhosale
79e165af96
feat: Settings js editor (#9984)
* POC

* Closing channels

* WIP

* v1

* get working with JS editor

* autocomplete

* added comments

* try removing an import

* different way of import

* dependency map added to body

* triggers can be part of js editor functions hence

* removed unwanted lines

* new flow chnages

* Resolve conflicts

* small css changes for empty state

* Fix prettier

* Fixes

* flow changes part 2

* Mock web worker for testing

* Throw errors during evaluation

* Action execution should be non blocking on the main thread to evaluation of further actions

* WIP

* Fix build issue

* Fix warnings

* Rename

* Refactor and add tests for worker util

* Fix response flow post refactor

* added settings icon for js editor

* WIP

* WIP

* WIP

* Tests for promises

* settings for each function of js object added

* Error handling

* Error handing action validation

* Update test

* Passing callback data in the eval trigger flow

* log triggers to be executed

* WIP

* confirm before execution

* Remove debugging

* Fix backwards compatibility

* Avoid passing trigger meta around

* fix button loading

* handle error callbacks

* fix tests

* tests

* fix console error when checking for async

* Fix async function check

* Fix async function check again

* fix bad commit

* Add some comments

* added clientSideExecution flag for js functions

* css changes for settings icon

* unsued code removed

* on page load PART 1

* onPageLoad rest iof changes

* corrected async badge

* removed duplicate test cases

* added confirm modal for js functions

* removed unused code

* small chnage

* dependency was not getting created

* Fix confirmation modal

* unused code removed

* replaced new confirmsaga

* confirmaton box changes

* Fixing JSEditor Run butn locator

* corrected property

* dependency map was failing

* changed key for confirmation box

Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-17 17:35:17 +05:30
Arsalan Yaldram
6496f84374
fix: Added Button Container for the firefox drag issue (#11627)
* fix: Added Button Container for the firefox drag issue

* fix: Removed un-necessary styles, added Container in Canvas mode.

* fix: Removed renderMode check from styled function.

* fix: Code refactor and handled Icon Button Component.

* fix: Added extensive comments.

* fix: handled menu button drag issues.

* fix: Fixed some failing tests.

* New Button locator (with drag-container) fix

* NewBtn container locator fix

* btn locator fix

* MongoShopping spec fix

* Mongo, Postgress fixes

* Stat box fix

* Testcase title update

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-13 22:51:04 +05:30
Parthvi12
939e90626f
test: adding tests for smtp using test-event-driver (#11777)
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-03-11 21:18:58 +05:30
albinAppsmith
5423944bbd
fix: Preserve entity explorer state on page refresh (#11064) 2022-03-11 21:17:42 +05:30
Aishwarya-U-R
fb0dc53a83
test: Script fixes for Flaky tests (#11653)
* Table_GeneralProp spec fix

* Flakes fixed

* Increased deployed page ele wait timeout

* readTabledataPublish() fix

* readTabledataPublish() updated

* Table specs flaky fix

* Table & Mongo Flaky fixes

* Mongo & Table spec flake fix

* Mongo flaky fix

* Mongo fix

* Table_Generalprop flaky fix

* Greencolor locator update

* expandCollapseEntity() method improved

* Table_generalProp flaky fix

* Datepick2, AddWidget flaky fix

* FLakyfix

* WidgetSelection_spec flaky fix

* Flaky fixes

* Adding GitSync to ignore files

* Removing GitSync from ignore files

* Added wait aft PublishApp
2022-03-09 12:05:56 +05:30
akash-codemonk
a6946fbcf0
fix: end guided tour on exiting editor (#11084) 2022-03-08 20:25:20 +05:30
Aishwarya-U-R
bd69eb9c3a
test: Automated tests for Bug #10784 + Failure fixes (#11586)
* Scripting Bug # 10784

* Bug 10784 - added script

* Uncommenting - JSObjToInput spec

* Uncommenting - JSObjtoListWidget spec

* SelectEntityByName reverted

* Migration spec locators fix

* Table_GeneralProp spec updated

* Read Table Row/Column locator updated

* Calling WaitAutoSave in JSObj creation

* 19px to 28px to match CI run

* CreateJSObject() - adding back wait time

* Reverting 28px to 19px

* Commenting table specs until CI fixed

* Commenting table spec 9th case

* UNcommenting

* Commenting Table_GeneralProp failure case
2022-03-05 01:01:35 +05:30
Vicky Bansal
43441bfce2
feat: add tooltip to column header text which overflows (#10666)
* feature: add tooltip to column header text which overflows (#10495)

* remove unused import

* feature: add tooltip to column header text which overflows (#10495)

* remove unused styled components

* remove unused import

* feature: add tooltip to column header text which overflows (#10495)

* remove unused styled components

* remove unused import

* Fix cypress command to handle the new changes

* Fix cypress command to handle the new changes

* Fix cypress command to handle the new changes

* Fix: test issues

Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-03-04 00:56:16 -08:00
akash-codemonk
65aee7fd14
feat: Application templates (#10964) 2022-03-03 16:26:53 +05:30
NandanAnantharamu
9b075e502b
test: bugAutomation4136 (#11245)
* bugAutomation4136

* Added tests for bug 5134 / 4136

* updated test data

* Bug7258 automated
2022-03-03 16:24:44 +05:30
Aishwarya-U-R
ef20c1e341
test: Automated tests for Promises & related bugs in Typescript + Flaky fixes (#10378)
* Flaky fixes

* S3 CRUD intercept fix

* S3 CRUD script change revert

* S3 revert!

* .its(store) not present fix

* TS failure fixes

* ChartDataopoint js removed

* JSObject ts flaky fix

* Bugs 9789, 10150 scripted

* Bug 10284 & 9782 scripted

* Updated dsl file names

* Table_Widget case #7 flaky fix

* Bug 10150 scripting improved

* DocumentViewer spec flaky fix

* Input widget locator corrected

* MemberRoles cases script started in TS

* UpdateUserRoleInOrg() fix

* Skip JSObject_To_ListWidgetSpec.ts until #10284

* Add validation

* JSObject_To_ListWidgetSpec.ts timeout increase

* Skipping tests until bug 10284 is fixed

* Increased wait time

* UpdateUserRoleInOrg() updated

* MemberRoles_Spec.ts fixed

* JSObjToInput - updated

* Postgres flaky fix

* Member Roles aka CreateOrg test flaky fix

* JSObToListWidget_Spec.ts - commenting until bugfix

* COmmenting JSobjToInput spec

* Commonlocators added back

* Entity explorer name fix

* Locators fix

* Locator corrected

* Cypress.json removed files from ignoring list

* S3 & Postgress failures fix

* Postgress failure locator fix

* S3 upload script skipping until bug fix

* Params Bug 10784 script started

* Fixing Promises Spec

* Increased wait time!

* MigrationSpec - Image column,Cardformat,Pagestyles

* S3, Postgres, Promise - failures fix

* Canvas renamed

* Bug 11415 - Added Validations

* InputWidgets_navigateTo - flaky fix

* MigrationSpec - import change

* Locators files - Json to Js conversion

* DS plugnis name change

* Locators - Json to JS conversion

* Locators - Json to JS updations

* Select_Widget_Value flaky fix

* Adding timeout for execute calls to finish

* Migration spec - diff syntax+List.js flaky fix

* List & MIgration flaky fix
2022-03-02 16:54:43 +00:00
Rishabh Saxena
acf01995bd
chore: git sync cypress tests (#10006)
* Fix connect test

* check api response

* [wip] test comments across branches (#8704)

* Intercept only connect api

* chore: update switch branches tests (#9005)

* test switch branches from the query params

* test flow wip

* .

* fix merge status update

* change mergeAble to isMergeAble

* wip

* fix: show error popup if pulled from bottom bar

* fix: append branch query to notification links

* fix: disable git connection during onboarding

* fix: typo

* fix: typo

* fix: typo

* fix: z-index bottom bar cout

* fix: pull button minor fix

* fix: reset conflicts when the git sync modal is opened

* fix

* feat: enable search for branch dropdown

* fix

* fix: typo

* added merge conflicting on merge tab

* updated gitsyncsaga for git sync error action

* added generate ssh key on init and updated git changed count message

* removed git sync error action from error processing module(toast and log)

* commented push button on bottom git action bar temperory

* added option to use git global config

* Added latest deploy preview time: didn't appear until the duration was in minutes

* Link open repo button with repo link

* fixed of commented code part

* upated tooltip of push button on bottom quick git sync toolbar

* Update banner styles for error and warning

* updated repo publish url pattern and last deployed view part

* when the user clicks on the push icon the deploy tab should open

* when branch name is too big and user hover on it the tooltip is not displayed

* The dropdown alignment displayed for the git connect should be polished

* update tests

* fix: minor git sync fixes (#9228)

* fixed of Under the merge tab when the user searches for the branch name which is not present the pop up closes all of a sudden

* fix: update merge api, use message from api response

* fix: update field

* added tooltip of long dropdown option and updated merge tab dropdowns

* removed log

* chore: add connection cypress tests

* temp update for running tests locally

* fixed long branch name on branch list popup

* Use _ as the branch name separator, instead of -

* Use large buttons as CTAs

* Remove the % from the progress bar

* Fix alignment for the skeletons on the deploy tab

* Merge CTA moves down when the status is rendered, add offset to prevent that and error branch dropdown on merge tab

* Show progress bar after clicking on Merge CTA as the loading state and generate key button

* after generating the deploy key before clicking on connect close the pop-up and open it again the Remote URL is not visible in the input box

* fixing of conflicting issue

* updated git connection design

* Provide more spacing between the lines

* Learn more does not have a hover state

* Heading Merge Changes should be sentence cased like headings on other tabs

* Button can trigger CTA call when in loading state

* disabled clickable icon on git connect bottom bar

* Git connection tab: on error the window doesn't scroll all the way to the bottom

* updated temp remote url values on action and reducer

* updated ellipsis functions of text

* fix: prune branch flag

* fix: update page level roomId to include branch name

* fix

* fix

* feat: add a separate feature flag for git import

* feat: branch section headers bottom bar branch list

* fixed branch list comments

* fixed merge issue

* fix

* feat: hotkey for commit and push

* remove pull button on git conflict info

* move tempRemoteUrl redux to gitSyncreducer and added messages

* splited git error as individual action

* removed push button from git sync bottom buttons

* feat: section header at the merge dropdown

* added comment of converting ssh to https

* feat: show connected to git badge

* feat: show asterisk when we have uncommitted changes

* fix: upate segment header for dropdown

* t fix: remove redundant success toasts

* removed tempory git repo url from app data

* wrapped tooltip with elipsis text

* fix: rm unused vars

* fix: bottom bar icon updates

* updated dropdown option with ellipsis text

* added new props named "wrappedOption" on dropdown for wrapping ellipsis option

* rename wrappedOption to truncateOption on dropdown component

* updated dropdown option with disabled props of tooltip

* fix: remove remote branches from merge branch dropdown

* reset yarn lock

* reset yarn

* fix: keeping it same as the existing value

* fix: remove branch dropdown border

* fix: show merge success indicator

* feat: init repo limit error modal

* fix: disconnect git wip

* added git user config test

* removed test data

* fix: checkout api

* fix: lint

* chore: pre connection test specs

* added revoking git workflow

* renamed revoke to disconnectGit

* added setting on git sync action over bottom bar

* added analytic on git connection

* added learn more for remote url and init module of temp remote url when select new application

* .

* chore: test learn more ssh url

* Verify the functionality of Read documantation link

* added git connect with onboarding workflow

* Validate the Input Box displayed below Commit to master Text

* updated test module for deploy tab with commit comment and deploy preview

* test of prune branch name

* Validate the error faced when user switches between the branches

* verify the functionality when user click on "+" Icon

* Verify the functionality of serach input box inside the serach dropdown

* Verify the display of the Merge Button

* advanced of disconnect git ui

* added git disconnect modal test case

* updated repo limit error condition

* added learn more link test on git disconnect modal

* for review of repo limit error modal test script.

* fix: issue with intercept

* fixes

* fixes

* add key, misc fixes

* fix

* revert changes

* fix

* fix imports

* Fix import

* Yarn lock update

* fix

* fix imports

* chore: remove timeout for a test run

* Increase timeout for jgit APIs

* chore: try increasing timeout

* try increasing timeout further

* Handle git connect error on the basis of error type

* Add env variable to CI build script

* Fix bad commit for adding env var in workflow

* Refactor

* FAdd env var for local repo path

* fix import

* fix specs

* fix

* fix

* try

* fix

* fix

* fix

* fix

* fix: don't validate error msgs

* fix spec

* improve spec

* chore: rm unused code

* chore: update descriptions

* rm commented out code

* fix

* rm comment

* chore: rm comments

* fix: lint

* chore: update comment

* fix: wait for widget switch transition

* spec updates

* fix

* fix imports

* try waiting for getPagesForViewApp

* fix: rm unused file

* fix: remove spec

* fix: add js collection, comment out repo limit exceeded error since it seems not limited on appsmith instances

* Fix server failure

* chore: correct bootIntercom import and sort lines

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: haojin111 <haojin828@outlook.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Abhijeet <abhijeet@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: f0c1s <anubhav@appsmith.com>
2022-02-25 06:13:16 +00:00
Aishwarya-U-R
67652287f2
test: Automated tests for Table Migration scenarios + Flaky fixes (#11360)
* Migration table script added

* Migration case & inputv2 flaky fix

* Added menu btn validations

* MigrationSpec - Added sorting valiation

* Flaky tests fix

* LIstWidget api.users count fix

* ListWidget api.users count validation fix

* Bind_ApI spec - added waituntil
2022-02-24 08:41:35 +05:30
Ayangade Adeoluwa
ead4d875fa
feat: add confirmation for Datasource deletion operation (#11180)
* add confirmation for Datasource, refactor other components

* fix failing cypress tests

* fix Mongo_spec failing test
2022-02-18 07:58:36 +01:00
Pranav Kanade
b778b83ac4
refactor: admin settings (#9906)
* refactor admin settings feature

* separated save-restart bar to separate component

* created new CE dir to facilitate code split

* created separate ee dir and exporting everything we have in ce file.

* little mod

* minor fix

* splitting settings types config

* using object literals for category types instead of enums

* CE: support use of component for each category

* minor style fix

* authentication page  UI changes implemented

* github signup doc url added back

* removed comments

* routing updates

* made subcategories listing in left pane optional

* added muted saml to auth listing

* added breadcrumbs and enabled button

* created separate component for auth page and auth config

* added callout and disconnect components

* updated breadcrumbs component

* minor updates to common components

* updated warning callout and added icon

* ce: test cases fixed

* updated test file name

* warning banner callout added on auth page

* updated callout banner for form login

* CE: Split config files

* CE: moved the window declaration in EE file as its dependency will be updated in EE

* CE: Splitting ApiConstants and SocialLogin constants

* CE: split login page

* CE: moved getSocialLoginButtonProps func to EE file as it's dependencies will be updated in EE

* added key icon

* CE: created a factory class to share social auths list

* Minor style fix for social btns

* Updated the third party auth styles

* Small fixes to styling

* ce: splitting forms constants

* breadcrumbs implemented for all pages in admin settings

* Settings breadcrumbs separated

* splitted settings breadcrumbs between ce and ee

* renamed default import

* minor style fix

* added login form config.

* updated login/signup pages to use form login disabled config

* removed common functionality outside

* implemented breadcrumb component from scratch without using blueprint

* removed unwanted code

* Small style update

* updated breadcrumb categories file name and breadcrumb icon

* added cypress tests for admin settings auth page

* added comments

* update locator for upgrade button

* added link for intercom on upgrade button

* removed unnecessary file

* minor style fix

* style fix for auth option cards

* split messages constant

* fixed imports for message constants splitting.

* added message constants

* updated unit test cases

* fixed messages import in cypress index

* fixed messages import again, cypress fails to read re-exported objs.

* added OIDC auth method on authentication page

* updated import statements from ee to @appsmith

* removed dead code

* updated read more link UI

* PR comments fixes

* some UI fixes

* used color and fonts from theme

* fixed some imports

* fixed some imports

* removed warning imports

* updated OIDC logo and auth method desc copies

* css changes

* css changes

* css changes

* updated cypress test for breadcrumb

* moved callout component to ads as calloutv2

* UI changes for form fields

* updated css for spacing between form fields

* added sub-text on auth pages

* added active class for breadcrumb item

* added config for disable signup toggle and fixed UI issues of restart banner

* fixed admin settings page bugs

* assigned true as default state for signup

* fixed messages import statements

* updated code for PR comments related suggestions

* reverted file path change in cypress support

* updated cypress test

* updated cypress test

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-02-11 23:38:46 +05:30
balajisoundar
e67474a4f3
fix: Input, Phone and Currency input widgets valid property validations (#10966)
- When the user removes an expression from the validation property of
  input widget, its value becomes `""`. And in boolean validation
  function we treat this empty string as false. so Input widget
  ends up with isValid false and we show an error border around the
  Input. so we are setting a default value true, so when there is
  no expression it evaluates to true.
2022-02-10 17:06:18 +05:30
NoxiousPenguin
abb3aebbba
chore: replaced == and != with === and !=== (#10733) 2022-02-05 11:11:15 +05:30
Bharat Patodi
743d6cb00d
chore: Replace equality and inequality operators with their strict versions (#7585)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2022-02-03 09:42:38 +05:30
albinAppsmith
5cfe12bcea
feat: Entity explorer UI redesign (#9811)
Co-authored-by: arunvjn <arun@appsmith.com>
2022-01-29 12:56:19 +05:30
Rishabh Rathod
b61ceab94b
fix: Add meta to eval cycle and update it when default changes (#10401)
* Rearrange data tree widget factory

* Remove existing handling of default value override

* Altternate way of meta property override

* Fix tests

Co-authored-by: hetunandu <hetu@appsmith.com>
2022-01-28 16:40:05 +05:30
akash-codemonk
94d37f55dd
feat: improved guided tour (#9125) 2022-01-25 19:26:52 +05:30
Tolulope Adetula
70cff3c373
fix: Copy and paste (#10422)
* fix: Copy and paste

* fix: test cases

* fix: onPaste action

* Update index.tsx
2022-01-18 19:54:34 +01:00
balajisoundar
02785b90b2
feat: Input, Phone no., Currency input widget (#10259)
* feat: Input, Phone no., Currency Widget

* cypress tests, jest test, QA and CR callouts

* fix tests

* Cypress and jest test fixes
2022-01-18 13:22:24 +05:30
Arpit Mohan
18276f962b
chore: Removing trailing slash from application API endpoint. (#10316)
- This causes issues in Vercel's deploy preview when creating an app.
2022-01-13 17:49:58 +00:00
Ashok Kumar M
0149085bf8
feat: Reflow and Resize while Dragging and Resizing widgets. (#9054)
* resize n reflow rough cut

* removing warnings

* relatively stable changes

* minor bug fix

* reflow relative collision

* working dp cut

* fix for reflow of widgets closer next to each other

* disabling scroll

* Drag with reflow

* reflow fix

* overlap and retracing fix

* On Drop updates.

* bug when no displacement but resize update.

* temp fix for new widget addition.

* reflow bug fixes

* new widget addition bug.

* stop reflow on leave.

* fix corner case overlap

* update bottom row when reflowed widgets go beyond bottom boundary.

* capture mouse positions on enter

* enable container jumps with faster mouse movements.

* reflow only for snap changes.

* restructured reflow Algorithm

* collision check and bug fixes

* undo redo fix for new widget drop

* resizable fix snapRows fix

* directional stability

* self collision fix

* first round of perf fixes

* update bottom row while resizing and resize-reflowing

* performance fix and overlapping fix

* Remove eslint warning

* remove eslint warning

* eslint warning

* can reflowed Drop Indication Stability

* container jumps and force direction on entering canvas

* fixing scroll on resize jitters.

* reflow when jumping into container.

* reflow ux fixes while leaving container

* resizing fixes.

* fixes for edge move.

* restrict container jumps into reflowed containers.

* container jump direction reflow

* checkbox dimensions fix.

* Excess bottom rows not lost post dragging or resizing widgets.

* fixing the after drop css glitch.

* double first move trigger bug fix.

* stop reflow only if reflowing

* stabilize container exit directions

* using acceleration and speed instead of movement covered to restrict reflow.

* fixing modal drops.

* remove warnings.

* reflow resize styles

* moving acceleration and movement logic to a monitoring effect.

* adding beta flag for reflow.

* fixing jest tests

* Adding analytics to beta flag toggle.

* Adding placeholder for reflow beta screens.

* fixing initial load's screen

* few more crashes.

* force close onboarding for the session.

* fixing bugs in reset canvas.

* Beta flag bug fixes.

* fixing bugs.

* restrict reflow screens during onboarding.

* disabling reflow screens in tests.

* code review comments.

* fixing store based specs.

* fixing cypress failures.

* fixing specs.

* code cleanup

* reverting yarn lock changes

* removing onboarding screens.

* more cleanup and function descriptors

* keeping reflow under the hood.

Co-authored-by: rahulramesha <rahul@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-13 18:51:57 +05:30
Sumit Kumar
18edb18b20
fix: implement getStructure method for S3 plugin (#8919)
* Add `getStructure` implementation for S3 to return a list of accessible buckets.
* Add command templates for S3.
  - List files
  - Read file
  - Create file
  - Delete file
* Remove getDatasourceMetadata implementation as getStructure method can be directly used now.
2022-01-13 11:33:50 +05:30
Aishwarya-U-R
cc426f1455
test: Automated tests for Promises in Typescript + failure fixes (#10288)
* JSObjects scripting

* storeValue Implemented

* Resolve, AsyncAwait script implementation

* Moved ts tests inside already existing folders

* Then & Catch test script implemented

* Promise.race test script implemented + S3 fix

* JSObject_To_ListWidgetSpec.ts failure fix

* S3 flaky test fix

* createOrg flaky fix

* FilePicker_with_fileTypes_spec.js filename fix

* createOrg flaky fix

* createOrg revert

* JSObject_To_ListWidgetSpec.ts added validations

* .then .catch promises script added

* Added script for Promises Maintaining context

* Added WaitUntilEleDisappear()

* JSObj run fix
2022-01-13 05:23:27 +00:00
Parthvi12
687be0f64a
test: removing failure threshold (#10178)
* removing failure threshold

* updating screenshots

* changing failure threshold to 0.1
2022-01-12 10:16:20 +05:30
Aishwarya-U-R
c711e39849
test: Automated tests for JSObjects in Typescript (#10223)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()

* Removing .skip

* Bind_tableApi_spec.js failure fix

* Slash command failure fix

* Bugs # 8595 & 10049 - Implemented

* Updating AGHelper methods to explicit public

* Reverting tsconfig.json

* tsconfig.json reverted

* Adding local tsconfig.json for Cypress tests

* fixture read updating for ts tests

* Updating .yml files to pick up ts files execution

* Including ts files for cypress run

* Running only ts test files

* Inclusion of TS files for cypress run

* Revert cypress.json to run all tests

* Added validation for Bug #10055 & commented

* Flaky fix

* JSObject_To_ListWidgetSpec - Implemented in TS

* Entity_Explorer_JSEditor_spec implemented in TS

* Uncommenting script for Bug 10049, 10055
2022-01-10 09:51:43 +05:30
Paul Li
85d54a7b56
feat: Map Chart widget (#6929)
* FEATURE-6314 : Map Chart Widget

-- Scaffold the widget

* FEATURE-6314 : Map Chart Widget

-- Add a new widget icon
-- Proptotype the property pane for the first time

* FEATURE-6314 : Map Chart Widget

-- Install fusionmaps
-- Draw naive world map for the PoC

* FEATURE-6314 : Map Chart Widget

-- Integrate the limited number of FusionMaps into the widget
-- Bind basic properties and a action into the map

* FEATURE-6314 : Map Chart Widget

-- Comment out the console statements for linting error

* FEATURE-6314 : Map Chart Widget

-- Update dependency versioning

* feat: Map Chart Widget

-- Fix on linting errors, including unused variables, console statement

* Feat: Map Chart Widget

-- Install dependencies from scratch

* fix: increased max chink size allowed in the build config

* Feat: Map Chart Widget

-- Refactor code base according to the changed widget structure
-- Add cleanup for removing event listener
-- Eliminate the unnecessary codes, comments

* Feat: Map Chart Widget

-- Remove unnecessary icon
-- Refactor on constants

* Feat: Map Chart Widget

-- Add a cypress test case for map type changes
-- Add a cypress test case for title change
-- Add a cypress test case for toggling show labels
-- Add a cypress test case for onEntityClick event listener

* feat: Map Chart Widget

-- Scaffold the setup for custom map config

* feat: Map Chart Widget

-- Dynamically import map definition files

* feat: Map Chart Widget

-- Eliminate unnecessary comments

* feat: Fusion Maps Widget

-- Update base dependencies

* partial map chart changes.

* feat: Map Chart Widget

-- Refactor entire code base, removing custom configs
-- Disable prefetching on mapCharts chunk

* feat: Map Chart Widget

-- Comment onEntityClick test case out

* feat: Map Chart Widget

-- Fix on onEntityClick test case

* feat: Map Chart Widget

-- Change the widget icon
-- Rename onEnityClick to onDataPointClick
-- Expose selectedDataPoint
-- Add a new Cypress test case for the toast message on onDataPointClick

* feat: Map Chart Widget

-- Add a new property colorRange
-- Add default values for data and colorRange properties
-- Eliminate unnecessary constant colorRange

* feat: Map Chart Widget

-- update selectedDataPoint meta property unconditionally

* feat: Map Chart Widget

-- Update initial map type config to be consistent with the corresponding property

* feat: Map Chart Widget

-- Add widget icon for entity explorer

* feat: Map Chart Widget

-- Make array elements of data, colorRange properties unique

* feat: Map Chart Widget

-- Prevent re-render when disabling color codes and double-clicking on entities

* feat: Map Chart Widget

-- Declare defaultChartConfigs variable inside component class
-- Replace deprecated substr method with substring

* feat: Map Chart widget

-- Complement validation rules for data property

* feat: Map Chart widget

-- Define rows and cols without using GRID_DENSITY_MIGRATION_V1
-- Change updateDataSet hook by replacing switch statement with object mapping

* feat: Map Chart widget

-- Pull out dataSetMapping from the updateDataSet hook

* feat: Map Chart widget

-- Force click events with regard to onDataPointClick test cases

* feat: Map Chart widget

-- Update fusioncharts and fusionmaps npm packages to the latest version

* feat: Map Chart widget

-- Make contents responsive using CSS styles instead of directly changing width, height attributes of the chart

Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-07 17:57:45 +08:00
Aishwarya-U-R
ac705a49f3
test: Automated tests for RestApi Bug in Typescript (#10137)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()

* Removing .skip

* Bind_tableApi_spec.js failure fix

* Slash command failure fix

* Bugs # 8595 & 10049 - Implemented

* Updating AGHelper methods to explicit public

* Reverting tsconfig.json

* tsconfig.json reverted

* Adding local tsconfig.json for Cypress tests

* fixture read updating for ts tests

* Updating .yml files to pick up ts files execution

* Including ts files for cypress run

* Running only ts test files

* Inclusion of TS files for cypress run

* Revert cypress.json to run all tests

* Added validation for Bug #10055 & commented

* Flaky fix
2022-01-06 20:36:17 +05:30
Aishwarya-U-R
d71a873e16
test: Automated tests for Flakiness fixes (#10040)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()

* Removing .skip

* Bind_tableApi_spec.js failure fix

* Slash command failure fix
2021-12-31 11:58:47 +05:30
Aishwarya-U-R
3a4db6bdfd
test: Automated tests for S3 uploads & Mongo Bugs + Flakiness fixes (#9931)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()
2021-12-29 11:11:30 +05:30
rashmi rai
f6b9abdacf
feat: adding ads component for UQI (#8777) 2021-12-27 17:34:45 +05:30
Parthvi12
b82ea06aa3
test: Adding visual tests for layout validation (#9857)
* Adding visual tests for layout validation

* updating screenshot to match CI's screenshot resolution

* updating screenshot as per CI

* setting failure threshold for the image comparision

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2021-12-24 17:47:22 +05:30
Ayangade Adeoluwa
45a5c38320
feat: Added tests for renaming entities through the entity explorer (#9867)
* Added tests for renaming entities through the entity explorer

* changes made to deletePageFromSideBar function

* adds custom made test cases config

* test cases should be within smoke test suite

* return configuration to run full test suite
2021-12-24 08:16:08 +01:00
Aishwarya-U-R
13f24cbce8
test: Automated tests for Rest Api, S3 Bugs and flakiness fixes (#9695) 2021-12-21 15:07:30 +05:30
NandanAnantharamu
d8e41b4b5c
test: updated org test (#9868) 2021-12-21 13:38:10 +05:30
arunvjn
99a12be018
feat: add option to delete org (#9287)
Co-authored-by: Nayan <nayan@appsmith.com>
2021-12-20 05:58:01 +00:00
balajisoundar
3c1edbeb3a
feat: Admin settings page to tinker with env variables (#9687) 2021-12-16 19:47:16 +05:30
NandanAnantharamu
4fa39d924d
test: TableWidget bugs (#9795)
* Added tests for Table widget bugs

* typo in test corrected

* Updated a flaky test
2021-12-16 14:52:14 +05:30
NandanAnantharamu
990ec76c4b
test: Added test for select Widget (#9600)
* Added test for select Widget

* updated common locators
2021-12-13 11:14:01 +05:30
Aishwarya-U-R
fd0f258699
test: Automated tests for RestApi, S3 Bugs (#9539)
* Supressing console.log

* Bugs 5550, 8684 scripted

* Bugs # 9425, # 4775 + S3 failure fix

* S3 failure fixes

* Postgress Delete Ds correted

* Bug # 9334 - Implemented

* onlyQueryRun reverted

* testSaveDatasource reverted

* Mongo Aggregate case fix

* testSaveDatasource updated to test true & false
2021-12-10 12:53:12 +05:30
balajisoundar
99eb298de7
chore: disable and assert disablility of teletry on CI (#9560) 2021-12-03 23:59:17 +05:30
albinAppsmith
12e277ad1f
fix: Fold/Unfold fix on click of entity (#8961)
* * fold/unfold fix

* * cypress fix

* * Button style fixes

* * test case fix

* * cypress fixes
2021-12-03 11:54:08 +05:30
Aswath K
cc0ed3b89e
fix: long dropdown popup truncates items (#9187)
* set max-height for Dropdown

* Better height calculation

* address review comment

* removed unecessary assertion

Co-authored-by: Apple <nandan@thinkify.io>
2021-12-02 08:28:51 +01:00
Aishwarya-U-R
37339c0cb1
test: RestAPI parallel run & Debug btn crash [Bugs 5550, 6863, 8686] - Script implementation (#9435)
* Bugs 5550, 6863 - Script implemented

* Added wait time in cy.updateCodeInput

* S3 DeleteSource failure fix

* S3 Delete Ds case fix

* Mongo Failure fixes

* Failure fixes

* Bug 8686 - Implemented

* cypress.json updated

* Added wait for proper validation pass

* Updated

* Updated EvaluateCurrentValue

* Update commands.js

* Added AfterEach

* Updated EvaluateCurrentValue()
2021-12-02 10:50:44 +05:30
NandanAnantharamu
425a46f34d
test: updated filter tests (#9448)
* Filter Tests

* Test spec added

* updated import

* added some wait

* updated the dependencies

* Added the dependancy files
2021-11-30 20:56:37 +05:30
rashmi rai
b65258876f
fix: missing number of queries in active datasource (#7694) 2021-11-30 10:11:40 +00:00
Aishwarya-U-R
e5a28b3d9b
test: S3 QueryPane scripting along with possible CRUD flow coverage (#9278)
* S3 QueryPane scritping

* Postgress, S3 - failure fixes

* Postgres, S3 failure fixes

* S3 failure fixes

* Added scrollIntoView for Postgres CRUD failures

* S3 - Suggested&Snipeable widgets implemented

* S3 CRUD - failure fix

* Postgres, S3 CRUD failure fixes

* S3 field inputs corrected

* JQuery empty used to clear fields

* Commenting cases to unblock CI runs

* PgAdmin Spec - commenting failures to unblock CI

* S3, Postgres CRUD failure fixes

* Added Wait for Onboarding spec case failure

* typeValueNValidate - updated

* typeValueNValidate updated

* Reverted typeValueNValidate method trigger change

* Adding wait to typeValueNValidate

* Updated typeValueNValidate with updateCodeInput
2021-11-26 16:17:53 +05:30
Hetu Nandu
8f2935f023
fix: Don't remove bindings when transfering action out of page (#9296) 2021-11-26 14:34:16 +05:30
Pawan Kumar
8395f5e18f
feat: property pane docking (#7361)
* add tailwindcss

* docked property pane

* uncomment a line

* make entity explorer as drawer on unpin

* remove unused imports

* add pin state in  reducer

* add menu icon in header

* fix widget sidebar

* fix widgets sidebar

* style property pane

* update property pane css

* update icons in property pane

* update property pane header styles

* update spacing

* fix few ui issues

* wip: preview mode

* wip:preview mode

* remove unused import

* comments sidebar in app and edit mode

* fix order of import

* use selected state for property pane

* update scrollbar style

* add classes to sidebar and property pane

* make widgets editor fluid

* make widgets editor fluid and refactor logic

* resize the widgets editor if explorer is pinned

* add shortcut for preview mode

* fix link for tabs in edit mode

* zoom in/zoom out for 0.75

* fix chart widget + table widget crashing

* allow zooming of canvas

* fix weird canvas draw issue + update container for handling zoom

* add actions for is panning

* allow panning with grab cursor

* reset panning + zooming when entering preview mode

* add grabbing cursor when grabbing

* only prevent default when space key is pressed

* dont allow zoom in preview mode

* remove unused imports

* fix dont allow zoom in preview mode

* fix ux of panning on space hit

* make fluid as the default app layout

* chart spec

* fix dropdown_on change spec

* fix add widget table and bind spec

* remove draggable property pane spec

* fix container spec

* fix form widget spec

* fix jest test

* fix the function typo

* remove clicking of close button for property pane in cypress tests

* remove property pane actions test

* fix drag and drop test failing

* add cypress selector id to back button in property pane

* fix toggle js spec

* fix merge conflicts from new design system

* editor header

* fix product updates styles + widget card

* remove all unused imports

* fix dynamic layout spec

* fix entity explorer tab rename test failing

* fix table spec

* fix bind tabletextpagination spec

* fix js object spec

* fix entity explorer rename issue

* fix cypress test

* fix cypress command wrong commit

* fix tab spec

* fix property pane copy tests

* add zoom header

* zoom levels

* make property pane sidebar resizable

* add multi select property pane

* fix widget search bug

* update property pane width in state on drag end

* fix viewer header

* fix editor header

* update editor header + remove zooming

* update small style

* dont allow closing of explorer when resizing

* fix jest test

* fix dropdown widget jest test

* preview test case wip

* add entity explorer pinning tests + preview mode tests

* add tooltip in layout control + add padding bottom in property pane view

* incorporate aakash feedbacks

* fix preview mode margin issue

* remove panning code

* fix cypress failing test

* uncomment jest test

* remove redundant code

* fix maincontainer test

* incorporate review feedbacks

* incorporate aakash feedbacks

* review feedbacks

* incorporate review feedbacks

* incorporate qa feedbacks

* fix dynamic layout spec

* updated test based on latest change

* dsl updated

* Updated dsl

* Updated dsl

* resize deselects widget issue.

* fix canvas height issue

* fix typo

* incorporate qa feedbacks

* incorporate qa feedbacks

* incorporate qa feedbacks

* update color for setting control for widget name

* fix onboarding styles conflicts

* Updated tests

* fix application overflow issue

* updated test method

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Apple <nandan@thinkify.io>
2021-11-23 13:31:46 +05:30
Aishwarya-U-R
c52e1d9072
test: Intercept/Real DB for Mongo, MySQL & QueryPane with CRUD flow for Postgres (#9081)
* Intercept/Real DB-Mongo,Postgres-Querypane

* Intercept-Mongo, SQL, Query-Postgres

* Added back welcomePage reference
2021-11-18 14:27:51 +00:00
Aswath K
701207718b
fix: Unable to drag disabled button (#8206) 2021-11-18 15:52:04 +05:30
NandanAnantharamu
07a70debd6
Added wait getUser (#9214) 2021-11-17 21:15:48 +05:30
balajisoundar
7978833011
test: first time user onboarding cypress tests (#9171) 2021-11-17 20:58:23 +05:30
NandanAnantharamu
72cce79a36
test: updated createModal util (#9120)
* updated common method

* Updated login route wait

* updated method
2021-11-17 15:40:57 +05:30
albinAppsmith
06ca32cd96
fix: Edit icon in API editor and toggle transition issue (#9013) 2021-11-17 12:06:18 +05:30
balajisoundar
f0b781ac63
test: Fix super user signup form cypress test (#8947) 2021-11-16 15:53:05 +05:30
Bhavin K
7032ee6b89
fix: Update designs for select widgets according to Figma (#8594)
* updated design as per figma

* updated design, fix cypress test

* item width fix as required

* label functionality in select, tree-select wids

* changes as required

* label, placeholder and default focused item logic changes for select

* updated border color for invalid selected value

* fix for colors file
2021-11-16 09:27:38 +00:00
Hetu Nandu
429337b5b1
fix: clearInterval action creator adds argument in the wrong slot (#9029) 2021-11-16 09:26:47 +00:00
Confidence Okoghenun
014d1f17d6
fix: Disallows entity name to be any extra library name (#8755)
Co-authored-by: sbalaji1192 <balaji@appsmith.com>
2021-11-10 19:29:24 +05:30
NandanAnantharamu
8bc0b0a90d
test: Disable status check for deleteApp step after each test (#9001)
* DeleteApp Status check disabled

* Updated deleteApp status code check to false

* Moved Layout widgets spec to clientside
2021-11-09 17:48:21 +05:30
NandanAnantharamu
8d6e150e00
Added suitable wait (#8946) 2021-11-02 06:34:43 +00:00
balajisoundar
fd0f3d889a
chore: Comment super user cypress test (#8945) 2021-11-01 16:43:54 +05:30
balajisoundar
baf67a8988
chore: Super user signup form cypress tests (#8665) 2021-10-29 14:40:30 +05:30
Aishwarya-U-R
d3f2f8c04f
test: Generate CRUD implementation - Mongo, MySQL, S3 (#8879)
* Generate CRUD implementation - Mongo, MySQL, S3

* Revertion from intercept to route
2021-10-29 07:02:45 +00:00
Rishabh Saxena
44116d3c79
feat: persist embed query param in the URL (#8685) 2021-10-27 17:02:26 +05:30
Apeksha Bhosale
4487fee83e
fix: changed dummy actions object (#8510)
* changed dummy actions object

* Snippets for js objects

* added js objects tag

* fixed tests for new changes

Co-authored-by: arunvjn <arun@appsmith.com>
Co-authored-by: yatinappsmith <yatin@appsmith.com>
2021-10-26 18:23:58 +05:30
balajisoundar
b2c5779234
feat: Introduce a welcome banner and a form to fill in role, useCase for new user (#8312) 2021-10-21 11:06:17 +05:30
akash-codemonk
6347bd9c38
fix: show tooltips for entity names in explorer (#8501) 2021-10-21 10:07:34 +05:30
Rishabh Saxena
31476092cc
chore: refactors for supporting git branches (#7695) 2021-10-18 19:33:44 +05:30
Paul Li
c9c529646f
feat: RTE - option to hide the toolbar (#8271)
-- Add a new widget property, isToolbarHidden
-- Add new Cypress test cases for the newly added property
2021-10-13 18:10:52 +05:30
Arpit Mohan
57bdbdc0f9
test: Fixing some cypress tests that were asserting if the message texts are correct (#8369) 2021-10-11 10:38:08 +05:30
Chiradeep-Banik
7af22b96a7
Remove Square bracket notation when using object properties (#7954)
- Replaced with dot-notations
2021-10-09 02:13:43 +05:30
akash-codemonk
9f2c32b9de
fix: onboarding table widget is blank after adding binding (#8285) 2021-10-08 13:22:08 +05:30
NandanAnantharamu
470fab30f7
test: S3Crud test fix (#8323)
* added route for a validation

* removed calls which are not happening
2021-10-08 08:32:34 +05:30
akash-codemonk
30c859180e
chore: Move action/js debugger tabs related logic to a common component (#8199) 2021-10-07 12:23:58 +05:30
yatinappsmith
f900cf9765
test: JSEditor Tests (#8068)
* Added basic support for JSEditor

* Added copy and delete test cases

* Basic changes for js editor

* Basic tests

* JSEditor Binding tests
2021-10-07 07:59:16 +05:30
Tolulope Adetula
d056c0baaa
feat: menu button as column type (#7039)
* fix: add menubutton

* feat: Make on Menu Item Click

* fix: remove console

* fix: refactor Utils.ts

* fix: add Comments

* fix: refactor utils

* fix: use forEach not Map

* fix: refactor table widget

* fix: add comment to config

* fix: refactor hook

* refactor: property Config

* fix: eslint issues

* fix:Add null check, refactor menuItemComponent

* test: add Cypress test for Menu button In Table widget

* fix: warning error

* fix: conflicts and remove menuStyle

* fix: change property pane arrangement

* fix: QA issues

* fix: Change default text, Change menu button color

* fix: Add background color to menuitems

* fix: bg color

* fix: failing tests
2021-10-06 13:57:05 +01:00
NandanAnantharamu
77d1c7ccfc
test: Updated flaky test (#8198)
* Updated flaky test

* updated test

* updated test

* commenting test
2021-10-05 18:39:07 +05:30
albinAppsmith
31cdfe0fe5
feat: Appsmith design system changes (#8125)
Introducing a much improved design system with new components in the Appsmith Design System.
2021-10-04 21:04:37 +05:30
Pranav Kanade
b261efc511
fix: skip bot comment when user skips comments tour (#7693)
* setup for skipping the bot comments if user skips the comments tour

* Using the onboarding status api

* removed comments

* fixed typos

* added test cases

* small fixes

* updated the tests

* minor update to a test case
2021-10-01 21:55:55 +05:30
Tolulope Adetula
1e0e42db7a
fix: set button color and remove button style for button, IconButton, Menubutton (#7166)
* fix: set button color and remove button style for button, IconButton, Menubutton

* fix: test

* fix: make the FormButtonWidget to have properties of ButtonWidget

* Adds Migration for FormButtonWidget

* fix: Broken FilePickerWidget

* Remove cypress tests for buttonStyle and add tests for buttonColor

* Change button variant labels

* set default value for buttonColor

* fix: migration for CUSTOM ButtonStyleType

* change make public toggle slider locator to be more specific

Co-authored-by: Aswath K <aswath.sana@gmail.com>
Co-authored-by: sbalaji1192 <sbalaji1192@gmail.com>
2021-09-23 20:44:24 +05:30
NandanAnantharamu
8e6ba37d00
test: fix/Updated common method (#7734)
* Updated common method

* updated dsl
2021-09-23 16:44:01 +05:30
rahulramesha
6cefc6dbea
feat: Undo/Redo (#6654)
* Scaffolding for undo-redo

* undo redo working Poc commit

* memory performance improvements by diffing

* dont run update on undo/redo"

* merging widget postion update and canvas bottom row update into one dsl update.

* fix tabs widget

* Visible updates per undo redo action (#6838)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* resize atomic operation

* fix switch control state issue

* disallow undo/redo for snipping and comment mode

* disallow undo/redo for snipping and comment mode

* fix color picker issue in undo/redo

* add test for replayDSL

* option control fix, adding logs

* minor position change undo redo updates

* add test cases for replayHelpers

* property Upade visual change

* remove unused code

* global hot key jest test for undo redo

* Fixing batch updates on property change..

* add tests for toggle control in property pane

* unwanted utils.

* add tests for text control

* add tests for deletion

* add tests for dropping a new widget

* adding jest test for replayUtils

* add move widget tests

* add tests for color picker control

* add analytics for undo/redo

* add analytics for undo/redo

* tab addition atomic

* cypress tests for propertyPane, toasts and radiowidget optionControl

* replayDSL end of redo stack fix

* property update changes

* menu option control debounce input

* color picker empty undo fix

* fix cypress tests

* widget add/remove atomic

* revert alternative approach to handle atomic operations

* update replayDSL test

* add some comments

* addressing review comments

* flash color for property pane controls

* Fixing adding of tabs widget as well.

* code review comments.

* merging widget postion update and canvas bottom row update into one dsl update.

* fix ordering of tabs property control

* meta property update canvas min height.

* fixing failed specs.

* Fixing entity explorer update on deleting tab from entity explorer.

* address review comments and minor property update changes

* fixing failing tests

* merge conflicts

* changes to cater widget api.

* fix suggested widget table issue

* draggable list for undo redo

* fix widget name focus

* excluding canvas updates.

* fixing codeEditor update on propertySection collapse

* fixed failing test case

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-09-21 13:25:56 +05:30
rahulramesha
0b37812b56
feat: resizable modal (#7312)
* dip

* resizable modal full working commit

* resizable modal minor fixes

* code restructuring

* fix canvas small size bugs and add migration to remove modal type

* moving resize modal to modal sagas

* layoutResize and last column width

* fix warning

* setResizible if resizing

* fix incorrect import

* fixing cypress tests

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2021-09-20 22:36:13 +05:30
Tolulope Adetula
15b26f823e
feat: Tree Select widget (#6271)
* feat: Tree Select

* feat: styling multiselect

* fix: selected values

* fix: remove console statement

* fix: popup position

* fix: selection types

* fix: Form validation using TreeSelect

* feat: Add Label to TreeSelect

* fix: styling

* fix: Dropdown search

* fix: Add Entity Definitions

* fix: Entity Definition

* Feat: Add clear icon

* fix: validation

* fix: options validation

* fix: Styling issues

* fix: build error

* Fix: Separate Tree Select widget

* fix: issues and add validation

* fix: Options Validation

* fix: issues with build

* fix: yarn

* fix: changes

* fix

* Fix: select component

* fix: PR issues

* fix: merge conflicts

* fix: issues

* fix: all issues

* test: added test

* fix: failing test
2021-09-17 02:08:35 -07:00
NandanAnantharamu
1db152bd5c
updated test and common method (#7446) 2021-09-15 14:07:58 +05:30
Rishabh Rathod
1911cf53c8
chore: remove debugger (#7438)
Remove `debugger`
2021-09-14 13:46:23 +00:00
arslanhaiderbuttar
603e282529
test: Select UI test cases (#6328)
* Select/MultiSelect widget UI test cases

* Select/MultiSelect Test Cases

Dropdown-AlertModal
Dropdown-FromModal
Dropdown-Call-Api
Dropdown-Call-Query
Toggle JS - Dropdown-Call-Query
Toggle JS - Dropdown-CallAnApi Validation
Verify Search box for selecting drop-down options
Verify Dropdown default value
Dropdown Icon Visibility
Explore Widget related documents
Dropdown Close
On Option Change Action
Copy paste dropdown
Dropdown-Delete
Toggle JS - Dropdown-Unckeck Visible field
Toggle JS - Dropdown-ckeck Visible field

* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget

* Added go to edit page from published page

* Removed the multiselect test cases from dropdown

* Select ui test cases fixes

* Select UI test fixes
2021-09-07 13:41:36 +00:00
arslanhaiderbuttar
c5503ee9e8
List widget UI test cases (#5535)
* List Widget UI Test Cases

List Widget UI Test Cases:

Change the List Widget Name
Add or Modify items
Change the Background Color
Change the Item Background Color
Enable Disable Visible
Enable Disable Visible - JS
Adding Query/API
Copy Widget
Delete Widget
Change the list and item background color using JS Button

* Update List_spec.js
2021-09-07 12:48:38 +00:00
arunvjn
277cb7fcca
fix: Ghseets scroll bug(#6634) 2021-09-01 14:41:51 +05:30
yatinappsmith
b8d9e68106
test: Added stub tests for MySQL, MsSQL, ArangoDB and Redshift (#6868)
* Added stub testcases for MySQL, MsSQL, ArangoDB and Redshift

* Removed intercept for saveDatasource
2021-08-27 17:24:03 +05:30
arslanhaiderbuttar
c90d844b63
test: Form widget UI test (#6884)
* Form widget test cases

* Form widget Test Cases

- Form widget fixes

* Form widget Test Cases

Defult Form text,  Reset and Close button Validation
Add Multiple widgets in Form
Form_Widget Minimize and maximize General Validation
Rename Form widget from Entity Explorer
Toggle JS - Form-Unckeck Visible field Validationpassed
Toggle JS - Form-Check Visible field Validationpassed
Copy Paste Validation
Form Delete Validation

* Form_test_cases_Fix

* Form test cases fix
2021-08-26 20:24:37 +05:00
Vicky Bansal
2f45db2008
Input widget: New data type supported - Phone number with ISD codes (#5256) 2021-08-26 16:22:45 +05:30
NandanAnantharamu
530735e13f
test: CypressNewVersion (#6116)
* Upgrade Cypress Version

* Upgrade to 7.6

* update moment library with Dayjs

* updated a test

* Added tests for copy to clipboard

* Added a missing dsl
2021-08-25 19:31:04 +05:30
yatinappsmith
aa869f21ab
test: Added Support for MySQL (#6795)
* Added Support for MySQL

* Update setup-test.sh

fixed sql file

* Update setup-test.sh

Fixed path
2021-08-24 14:16:52 +05:30
arslanhaiderbuttar
01e5d8d839
Table UI test cases (#5910)
* TableUITestCases

Commit

* Table-widget-testcases

On Search Text Change Action
Default array data
On Row Selected Action
Explore Widget related documents Verification
On Page Change Action
Default search text
Default selected row
Delete Table Widget
Changing Column data type to "Image"
Changing Column data type to "URL"
Table Widget Functionality To Verify Row Height Functionality
Drage and Drop Table widget and verify default data
Table Widget Functionality To Filter The Data using 'Empty
Table Widget Functionality To Filter The Data using 'Not Empty'

* Discarded changes in cypress.json

Discarded changes in cypress.json

* Updated the test cases

* Undo changes to Cypress.json

Undo changes to Cypress.json

* Added new dsl json file

* Merge branch 'release' into SelectUITestCases

* table test cases fix

Co-authored-by: arslan <>
2021-08-21 12:34:23 +05:00
Rishabh Rathod
652950d239
Add Gsheets support for generate CRUD page (#6301)
* Add s3 support for generate CRUD
- Dropdown enhancement to open options on initial load
- Hide column selection option for s3

* Refactor the prop name

* Dropdown enchancement & Fix small issues

* Add fetch all sheets query

* Fix issues related to dropdown

* Add hooks to fetch sheets and spreadsheets

* Resolve warnings

* complete gheets basic support

* Add UI changes for Gsheet column names
- Fix Page Scroll issue

* Add debounce to avoid to many API calls

* Add request object formation via plugin config

* Resolve comments & remove executingDatasourceQuery

* Send sheetName in the tableName key.

* Add loader and Column name UI Fix

* Add Column Headers Label

* Fix logic to show comma separator btn column names
- Make "Column Header Fetched" text Bold

* Add tooltip info for searchable column

* Add value prop to TextInput
- Fix Table header Index Invalid Input issue

* Hotfix validator logic
2021-08-20 15:25:59 +05:30
Rishabh Rathod
12e7ee0c94
Add s3 support for generate CRUD (#6264)
* Add s3 support for generate CRUD
- Dropdown enhancement to open options on initial load
- Hide column selection option for s3

* Refactor the prop name

* Add useS3BucketList hook WIP

* Dropdown enchancement & Fix small issues

* Add fetch all sheets query

* Add Query to get all S3 buckets

* Fix dropdown open issue

* Remove defaultIsOpen prop from dropdown

* Resolve comments
- Remove debugger
- mockSheetUrl -> getSheetUrl

* Add S3 cypress test

* Fix cypress test yml config

* Fix generate page cypress test
2021-08-20 12:27:01 +05:30
Favour Ohanekwu
11385092ca
Hotfix/trailing white spaces in mysql datasource configuration (#6227)
* trimmed white spaces in datasource configuration

* Added cypress tests for MySQLdatasource

* fixed trailing whitespaces bug in mysql datasource configuration

* Fix overflowing text in toasts on safari (#6200)

* [Feature] Generate template page from datasource  (#5513)

- Add Generate CRUD page feature
- Modify the Datasource card UI in the `INTEGRATION.ACTIVE` tab to directly delete and edit.
- Add `renderOption` , `errorMsg`, `isLoading` props in Dropdown component.
If `renderOption` prop is not defined, it will show default option UI.
- Add getDatasourcesStructure [new entity Selector]
( This will provide all fetched structure of datasources)

> Commit Messages ⬇️

* Show disabled GenPage Button for unsupported DS

* Add Icon in Select Table and Column dropdown

* Add Error message when datasource config has error

* Fix the continous loading state issue

* Add Not supported datasource in select Table

* Add ignoreCache when fetching DS struct

* Go to generate page if initiator=generate-page

* Fix connect new datasource button disabled

* Modify error message for invalid datasource struct

* Add snowflake to supported plugin for template

* Fix Show More option width

* Fix incorrect error msg for valid dS config

* Generate page UI improvements

* Refactor navigation

* Fix Datasource Card UX

* Remove semi-colon from Icon loader

* Refactor contants

* Add executeDatasourceQuery & fetchPluginForm API
- WIP google sheet form UI and functionality
- Implemented fetch all spreadsheet with mock data

* disable S3 and google sheet for generate page

* Update yarn.lock

* Resolve review comments
- Add Messages to `constants/messages`
- Add default value for `fetchActionsForPage` 2nd param
- Add comment
- Remove `onFinishCallback` from `handleFetchedPage`

* move string literal to constants/messages

* Remove hardcoded pluginId implementation

* Refactor getGenerateCRUDEnabledPluginMap selector

* Fix CreateAppInFirstListedOrg test command

* Add getIsGeneratePageInitiator helper func

* Fix Entity explorer Edit option test

* Fix CreateAppForOrg test command
- Add click on build from scratch in generatePage

* Fix deleteDatasource command test
- Click on Datasource Name to Edit, Datasource Card handles the click

* Fix DynamicLayout spec test issue

* Fix pageLoadSpec test

* Disable google plugin & Refactor
- Add useDatasourceOptions hook

* Add datasourceCardMenu in DatasourceEditor.json

* Fix issues
- Add Icon hover clickable control
- Auth API click handler

* Fix Createpage test command

* Add cypress test for generate page flow

* Fix cypress test

* Add Analytics

* Add comments in CloseEditor

* Rename initiator to isGeneratePageMode

* Disable S3 for generate CRUD page

* Fix generate page from existing datasource issue

* Enhance test to verify if data is fetched properly

* Wait for get Actions before execute actions

* Change the cypress route for excute api

Co-authored-by: Pranav Kanade <pranav@appsmith.com>

* Fix xss redirectURL (#6229)

* Update msg

* Revert "Update msg"

This reverts commit 0ac70ea7e9.

* Fix JS error message showing callstack in firefox (#6234)

* Adding expiry of 30 days to session cookies (#6224)

Fixes #5872

Adding an expiry of 30 days to the cookie to ensure that browsers don't delete the cookie when the browser session is closed.

* Removing release-drafter github action (#6248)

* Add Skip tour button in welcome onboarding (#6158)

This allows users to skip the welcome tour, there is an End tour button already present but wasn't easily accessible.

* Fix - #6221 new nav analytics improvements (#6223)

* fixed redirection on connect data click. and updated analytics

* Added generic analytics for all datasource cards

* Add missed new nav analytics for connections (#6233)

* Log event when property pane connected entity is clicked

- Also update screen to source

* Add missed analytic event when user navigates to entity from property pane connection

- Also add entity type info to event
- Refactor to make this happen by moving useGetEntityInfo hook to debugger hooks

* [Fix] Small UI improvements to suggested widgets section (#6190)

* added slight transition to suggested widgets. Adjusted the height of arrows in relationship.

* minor fixes to back btn style in suggested widgets panel

* fixed the size of collapsible icon

* removed a comment

* Fix NPE when Segment key not available correctly (#6244)

* Using local Postgres database instead of remote (#6241)

* Using local Postgres database instead of remote

* Added createdb and usedb at the top

* FEATURE-5852 : make the iframe widget message property accessible (#5897)

-- Add a new meta property for receiving the message from an iframe. Now the user can simply refer to {{iframe.message}} to access the data they receive in an API or widget.

* Disable tern in view mode (#6203)

* Fixed ExecutionParams (#6284)

* Fix test by mocking the response (#6273)

* added cypress tests for users mock datasource

* Fix: Mark comment threads as viewed when they are resolved (#6251)

* -log widget type in analytics service when new thread created
-set viewed=true for resolved threads

* fixed typo

* fix the test case when there is not widget type

* Add analytics event for mock-data creation (#6136)

* Add analytics event for mockdata creation

* Use the correct name for the mockdatasource

* Added FE analytics for mock datasource

* Changes per review

* Remove the method call

* Fix indentation issue

Co-authored-by: Pranav Kanade <pranav@appsmith.com>

* Missing validations (#6281)

* Fix validations for certain scenarios which were missed earlier

* Minor comments feature fixes (#6245)

* Fix comment card click: set visible thread (#6166)

* Fixing bug where the comment feature flag was disabled for all users

* [Fix] Refresh sidebar comments list when a thread is unresolved (#6326)

* fix stop Rich text Editor from crashing on Modal (#6077)

* changed RTE removal mechanism

* modified changes to remove just before initializing

* tinyMCE patch for firefox

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Sentry typeError fix, with checks (#6256)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Supporting all ASCII characters in table widget (#6041)

* Updated labels Mock data to Sample data (#6330)

* [perf] propertyControl re-rendering (#5941)

* prevent unnecessry re-renders on property control keyPress

* Changes to memoize with useSelector

* propertyControl re-rendering initial commit

* Optimized and Generalized PropertyControl

* Updating Property Dependencies

* removing useCallback and replacing WidgetEnhancementHelpers with selector

* nested property path changes

* reverting name Change

* tests fixes and adding dependencies for validation structure

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Snowflake get structure error resolved for columns query (#6316)

* Table name reference copied from templates body to avoid misconfiguration in action body

* more conditions for run check (#6255)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Fix comment card click at the view mode (#6332)

* Fix unnecessary renders of ActionCreator, EntityName, CodeEditor and ActionEntityContextMenu (#6242)

* Fix action creator unnecessary render issue
- Optimize the selectors and hooks to return new values only when something has changed.

* Fix ActionEntityContextMenu re-renders issue

* Prevent rerenders of EntityName component

* Fix CodeEditor re-renders

* Use createSelector instead of memoization.

* Cleanup

* - Remove whyDidYouRender

Co-authored-by: Satish Gandham <satish@appsmith.com>

* Multiselect Widget (#5228)

We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.

* Added instance Id in analytics datapoint (#6252)

* Enable Autocomplete for Static Objects (#6302)

* Remove type from COLORS constant

* Remove type from InputTypes in InputWidget

* Remove type from ReduxActionTypes

* Remove type from ReduxErrorActionTypes

* Remove type from SocialLoginTypes

* Fix widget actions issues

* Remove OPEN_SUB_PANE commented redux action

* updated cypress tests to account for testing trailing spaces in db name and host address

* removed unparsed token

* Commenting test (#6354)

* Add list buckets API to S3 (#6334)

* Add list buckets action method to S3

* Added TC for list bucket method

* FIX #6324 : reset recaptcha token on click and handled button loading explicitly (#6337)

 reset re-captcha token on click and handled button loading explicitly such that the user know that the api call has not finished

* Added null check to verify empty layout in generate CRUD page flow (#6359)

* Fix authentication issue while creating mockdata (#6294)

* Re set password to avoid double encryption while creating suffix datasource

* Add test to query on mockdata source

* Check the Authentication type before setting the password

* updated cypress tests for mock datasource

* fixed cypress failing datasources tests

* Fix: Update debugger placeholder text for non-mac (#6142)

* Added logic to show form data requests in debugger (#6350)

* Added logic to show form data requests in debugger

* Tests and comments

* Tests

* Tern server performance fix and Best match fix (#6338)

* Uncomment Gen CRUD page Test (#6371)

* Reorganised test steps to utilise retry action (#6208)

* updated spec with assertion values (#6323)

* updated spec with assert

* updated test

* updated test

* updated dsl

* Improvement: Add limit on password length in user signup (#6312)

* -add max password validation in FE and password validation in BE for signup

* -added unit test for password length limit

* - set max password length to 48
- add password length check in reset password

* -removed password limit check from login

* Fix binding query for the nested data responses (#6372)

* Fix binding query for the nested data responses

* Fix formatting issues and add comments

* Updated comments

* remove code duplications

* Fix: Keep inspect entity in sync with the widget selection in the entity explorer

* docs: Updates event archive

* Navigation Dropdown feedback Changes (#6119)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Feature: Add API to set and get concurrent app editors (#6292)

* -add an API in RTS to store and retrieve currently online users of an application

* -handled the case when edit app event received before user is authenticated

* -updated authentication API in rts

* close modal on cancel btn click (#6383)

The cancel button in the modal will now by default have the close action configured.

* Button and chart fixes (#6373)

* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget

* changed border radius of multiselect widget to 0px (#6349)

* open link inside text component in a new tab (#6205)

* Fix loading test data for Cypress tests in CodeBuild

* Change dropdown widget to select widget in Github labels for automation to work properly (#6386)

* Updating k8s README to point to docs.appsmith.com

* iFrame - When the source url is removed message should be displayed in iframe similar to other widgets (#6295)

* FIX-5414 : iFrame - When the source url is removed message is be displayed within the component

* BUG : Iframe widget: wrong placeholder `Title` (#6053)

Rectified the wrong placeholder in the iframe widget title property.

* Use feature flag api to enable/disable comments (#6322)

* Check if comments are enabled for comment intro modal (#6395)

* Fix ts error release (#6396)

* updated common method (#6397)

* Fix #5740 - Api actions are treated as queries (#6381)

* updated active datasources pane carry proper cta to create new action

* properly creating action names in either api/query context

* added a new separate new api/query btn component

* moved empty datasources warning to messages

* fix: wrap overflow option in multiselect such that all option checkboxes are available(#6403)

* Fix #6160 Updated Text binding for row and removed variable evaluation - Default table data (#6360)

* Icon Button Widget (#5723)

Introducing the **Floating action button / Icon button**. Now you can use this to show small actions as icons. We have added a bunch of styling customisation to this as well. You can bind an onClick action to this and easily trigger an even. The component also automatically resizes within the widget as you scale it while maintaining the right aspect ratio.

* [Fix] Mark resolved threads as read in real time, refresh list when thread resolved status is updated (#6407)

* fix: Font size fixed for consistency between select and multi-select widget (#6400)

* Skip btn comment onboarding (#6331)

* [Fix] Reset comment mode hotkey (#6401)

* Welcome tour GIF and Close button fixes (#6309)

* * Chaged New Query GIF
* Added close button for welcome tour final page

* Changed Run GIF

* Sticky sidebar z-index change

* Added testcases

* Replaced hardcoded colors and text with constants

* Fix: Set a default option in select widget while adding from suggested widgets (#6236)

* Fix jest test for comments by overriding isCommentMode selector (#6027)

* Fix download with URL issue  (#6179)

* Bump tar from 6.0.5 to 6.1.6 in /app/client (#6392)

Bumps [tar](https://github.com/npm/node-tar) from 6.0.5 to 6.1.6.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v6.0.5...v6.1.6)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update CRUD template For S3 page (#6426)

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>

* Cypress tests for commenting feature (#5505)

* Minor fixes for comments on the modal widget (#6368)

* Update permission check for determining a user with dev access for comments intro (#6431)

* Prevent Entire Editor Header from re rendering (#6415)

* Seperate save indicator without rerendering entire Editor Header

* stop unnecessary update to Saved message every second

* moving raw strings to messages

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* [Fix] Focus the comment thread when opened after dismissing (#6437)

* Dont fetch feature flags if not logged in (#6444)

* Update README.md

Fixed a spelling mistake

* Fix: Parse api body to be shown as an object in debugger if possible (#6249)

* Fix: List Widget issues (#6226)

* fix binding

* fix multiple binding not working issue

* use box shadow inset + fix gap issue

* fix container z index issue

* fix resize ux issue

* update container height

* allow selecting list widget only when the property pane is not visible

* fix resize handle overflow issue

* fix dot issue in current item structure + fix resize issue for template

* fix select widget not workign inside list widget issue

* remove unused keys

* fix jest test

* fix derived.js test

* add undefiend check

* add currentIndex for autocomplete

* revert white color to transparent for list container

* fix pagination wrong calculation

* remove beta tag

* fix issue with cypress test failing

* fix issue with dropdown widget

* fix the boolean value issue

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>

* [Bugfix] Empty object creation in published pages for application object fixed

* Omnibar redesign (#6288)

Omni bar would now have the categories navigation and documentation.

* [skip_changelog] Form login disabled after user uses OAuth login method (#6425)

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* changed default image to old value loading from cloudinary (#6467)

* Feature: Show a list of realtime app editors (#6286)

* Added support for showing realtime app editors

* emitting an event only when socket is connected

* added a tooltip to show username/email

* using proper selector

* using theme

* created the separate component for listing editors

* created a separate hook for app collab events

* moved collab user type to /entities

* moved user visible strings to message constants

* Revert "moved user visible strings to message constants"

This reverts commit 04ac18a188b0117dd364ad764a4e0103bfd28ef6.

* made provision to reset the concurrent editors list

* Enable auto-start after VM restart (#6428)

* BUG-6029 : Property pane for iFrame widget does not appear on clicking on widget (#6260)

-- Add a overlaid div for iframe

* Added fix for cmd + enter not running google sheets actions (#6446)

* Fix-Catch invalid google recaptcha v3 key error (#6034)

* Handle invalid google recaptcha v3 key

* changed default divider color to light grey (#6335)

* fixed issue where the resize cursor did not appear on the left hand side of the widget (#6380)

* Add null check for the nested data structure (#6479)

* Add null check for the nested data structure

* Add unit test for the null nested data

* Adding a max size of approximately 1 MB of data fetched using appsmith (#6491)

* WIP Restrict fetch size

* Adding a cut off of approximately 1 MB of data fetched in postgres plugin

* Code cleanup

* Minor cleanup

* [Fix] Minor comments feature fixes (#6490)

* Fix skip btn

* update sorting for mentions list

* Show server logs when create cypress user fails

* [Fix test spec]Create a new org for the comments test so existing user roles don't exist (#6477)

* Revert "Supporting all ASCII characters in table widget (#6041)" (#6429)

This reverts commit 3ae1bd6d95.

* Updated flaky test (#6486)

* Updated flaky test

* updated another test

* Store MongoDB creds in separate file from install.sh (#6499)

* Store MongoDB creds in separate file from install.sh

* Move MongoDB credentials to docker.env

* Add Analytics to Generate CRUD template feat (#6503)

* Add Analytics to Generate CRUD template feat

* Add analytics event on datasource click

* Send pluginName instead of plugin obj in analytics

* Fix: Adding checks before we check for disallowCopy (#6214)

* Fix: Adding checks to before we check for disallowCopy

* Adding checks for undo logic when a child delete is undone but the parent is already deleted.

* restore widgets if they have their parent available.

* reported bugs.

* undo only when parent exists.

* Hotfix Table Widget crashes when there is a cyclical dependency (#6505)

* FIX #5254 : dropdown height fixed and made scrollable (#6170)

* will widget pane if user moves away from canvas (#6516)

* Fix: intercom triggers are not working properly (#6512)

* initializing the intercom as soon as the help components are mounted.

* removed log

* Fix: Undo-Delete of Containers fix (#6510)

* Encrypt attributes (#6508)

* encrypt attributes

* updated references to DOM targets for accessing the Mock User datasource

* Fix/omnibar landing bug (#6513)

* hide certificate string using dots on UI (#6533)

* replace actual certificate string with '*' like it is done for hiding password on the UI.

* Updated Template

* fixed failing cypress tests

Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: Pranav Kanade <pranav@appsmith.com>
Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Paul Li <82799722+wmdev0808@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Nayan <83352306+nayan-rafiq@users.noreply.github.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: rahulramesha <71900764+rahulramesha@users.noreply.github.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com>
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
Co-authored-by: Yash Vibhandik <vibhandikyash@gmail.com>
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Confidence Okoghenun <cokoghenun@gmail.com>
Co-authored-by: arslanhaiderbuttar <83570904+arslanhaiderbuttar@users.noreply.github.com>
Co-authored-by: haojin111 <63215848+haojin111@users.noreply.github.com>
Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: abhishek nayak <nayak.abhishek@gmail.com>
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com>
Co-authored-by: Nipun Agarwal <31271538+nipun1999@users.noreply.github.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Sumit Kumar <sumit@appsmith.com>
2021-08-13 09:42:29 +01:00
arslanhaiderbuttar
273b2d902f
Update Button_spec.js (#6474)
* Update Button_spec.js

Button widget issue has been fixed.

* Change the method to write text in property pane
2021-08-12 22:37:30 +05:00
Ashok Kumar M
f19ebbafe9
[Feature] Widget grouping - Allow Drag and Drop of multiple widgets. (#5389)
* dip

* dip

* scroll

* fixes

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* solve for canvas glitches

* dip

* dip

* dip

* adjust scroll speed

* dip

* dip(code clean up)

* dip

* dip

* ---dip

* dip

* dip

* dip

* middle ware for dropping multiple widgets.

* adding scroll to drag for canvas selection.

* fixing drag disabled and modal widget(detach from layout) drops

* firefox and safari fixes

* rebase conflicts.

* fixing broken specs.

* fixing specs and adding jest tests.

* show border and disable resize when multiple widgets are selected.

* selection box grab cursor

* merge conflicts.

* code clean up

* fixing specs.

* fixed a bug and failed specs.

* fixing rerenders.

* code clean up

* code review comments

* always have the drag point inside the widget.

* fetching snap spaces instead of calculating.

* remove widget_move action

* fixing bugs with add widget parent height updation.

* fixing specs.

* List widget conflict fixes.

* fixing canvas drop persistence.

* Adding click to drag for modals and fixing few issues.
2021-08-12 11:15:38 +05:30
NandanAnantharamu
11c70353d9
Updated flaky test (#6486)
* Updated flaky test

* updated another test
2021-08-10 13:29:05 +05:30
Rishabh Saxena
ea5603920e
Cypress tests for commenting feature (#5505) 2021-08-06 14:47:02 +05:30
NandanAnantharamu
9a4e1aed64
updated common method (#6397) 2021-08-05 15:40:52 +05:30
arslanhaiderbuttar
159ad60dc6
Button and chart fixes (#6373)
* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget
2021-08-04 12:50:40 +00:00
Tolulope Adetula
24b78d1e2b
Multiselect Widget (#5228)
We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.
2021-08-03 12:08:01 +05:30