Commit Graph

1485 Commits

Author SHA1 Message Date
Saroj
a8e305db92
ci: Fix to download the docker image from current run in case run id is not provided (#23903)
## Description
- Fix to download the docker image from current run in case run id is
not provided
#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- Workflow runs
2023-05-31 12:55:26 +05:30
Saroj
d595eabf8a
ci: Allow to use existing docker image from a previous run if provided (#23901)
## Description
- Allow to use existing docker image from a previous run if provided

#### Type of change
- Workflow file changes

## Testing
- Workflow run
2023-05-31 12:37:40 +05:30
Satish Gandham
40af2195df
ci: Update perf-test.yml (#23781) 2023-05-26 21:26:30 +05:30
Aishwarya-U-R
088b629438
test: Cypress | Handling confirmation dialogs (#23703)
## Description
- This PR handles the proper click of No & Yes in the confirmation
modals during a query/js object run
- Also updated the ci-test-limited.yml for Installing dependencies from
right path
- GitImport - 5th case - flakyfix

#### PR fixes following issue(s)
- Unskips the JsOnload3 spec
- JSFunctionExecution_spec.ts - flaky fix

#### Type of change
- Script update

## Testing
>
#### How Has This Been Tested?
- [X] Cypress run

## Checklist:

#### QA activity:
- [X] Added `Test Plan Approved` label aftee test changes were reviewed
2023-05-25 07:12:51 +05:30
Saroj
1dc13270c6
ci: Download the failed specs from artifact instead of cache (#23600)
## Description
- Updated the workflows to save and download the correct dependencies
cache

#### Type of change
- Workflow changes

#### How Has This Been Tested?
- CI run
2023-05-24 18:28:01 +05:30
Nikhil Nandagopal
936e5151b4 Updated Label Config 2023-05-24 13:22:20 +05:30
albinAppsmith
80c0bfa845
fix: Added DS pod as reviewer for all PR that changes client (#23635)
## Description

Added workflow to add DS pod team members as default reviewers.


#### Type of change
- New feature (non-breaking change which adds functionality)

## Testing

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-05-23 15:04:16 +05:30
Goutham Pratapa
23b8ae41ac
ci: fix github-release workflow (#23612) 2023-05-22 22:11:10 +05:30
Satish Gandham
236ee1e171 ci: Untar the client build in github release workflow (#23610)
Co-authored-by: Satish Gandham <hello@satishgandham.com>
2023-05-22 21:26:28 +05:30
Valera Melnikov
9f607d250d
chore: move local dependency to packages (#23395)
## Description
1. Move everything related to client from app folder to client folder
(`.yarn`, `yarn.lock`, package.json, .gitignore)
2. Move `ast` and `rst` to client packages
3. Fix running scripts in packages
4. Add running unit tests in packages in CI

TODO: It is necessary to consider enabling the `nmHoistingLimits:
workspaces` option, since now all packages are hoisted to the root,
there may be issues with dependencies in workspaces. Also, there is a
possibility of implicit use of packages.

https://yarnpkg.com/configuration/yarnrc#nmHoistingLimits

#### PR fixes following issue(s)
Fixes #23333

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing

#### How Has This Been Tested?
- [x] Manual
- [x] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-05-22 15:55:46 +03:00
Nikhil Nandagopal
49791cf8ab Updated Label Config 2023-05-22 17:32:15 +05:30
Satish Gandham
52759e31b1
ci: Add yarn install step to github-release-workflow (#23593)
Co-authored-by: Satish Gandham <hello@satishgandham.com>
2023-05-22 15:52:32 +05:30
Nikhil Nandagopal
52e4210d5f Updated Label Config 2023-05-22 14:45:22 +05:30
Nikhil Nandagopal
61b4e7e675 Updated Label Config 2023-05-22 14:45:10 +05:30
Nikhil Nandagopal
9aaa9344e7 Updated Label Config 2023-05-22 14:44:42 +05:30
Nikhil Nandagopal
b35b173119 Updated Label Config 2023-05-22 14:44:26 +05:30
Nikhil Nandagopal
fbfa34ecc4 Updated Label Config 2023-05-22 14:43:39 +05:30
Nikhil Nandagopal
0eb5a7f6b4 Updated Label Config 2023-05-22 14:43:31 +05:30
Aishwarya-U-R
6b05ee30e5
ci: Reducing jobs count in ci-test-limited.yml (#23580)
## Description
- This PR reduces the jobs used count to minimal in ci-limited-tests.yml
for safer side
- Folks using it can add/remove jobs further as needed in their PR along
with updating limites-tests.txt present in cypress folder for running
limited Cypress tests


#### QA activity:
- [x] Added `Test Plan Approved` label after reviewing all changes
2023-05-22 11:33:12 +05:30
Aishwarya-U-R
3af14828e6
Revert "ci: Fix for cypress rerun cache issue" (#23560)
Reverts appsmithorg/appsmith#23553
2023-05-20 00:13:31 +05:30
albinAppsmith
629999f124
feat: [epic] appsmith design system version 2 deduplication (#22030)
## Description

### Fixes
- [x] https://github.com/appsmithorg/appsmith/issues/19383
- [x] https://github.com/appsmithorg/appsmith/issues/19384
- [x] https://github.com/appsmithorg/appsmith/issues/19385
- [x] https://github.com/appsmithorg/appsmith/issues/19386
- [x] https://github.com/appsmithorg/appsmith/issues/19387
- [x] https://github.com/appsmithorg/appsmith/issues/19388
- [x] https://github.com/appsmithorg/appsmith/issues/19389
- [x] https://github.com/appsmithorg/appsmith/issues/19390
- [x] https://github.com/appsmithorg/appsmith/issues/19391
- [x] https://github.com/appsmithorg/appsmith/issues/19392
- [x] https://github.com/appsmithorg/appsmith/issues/19393
- [x] https://github.com/appsmithorg/appsmith/issues/19394
- [x] https://github.com/appsmithorg/appsmith/issues/19395
- [x] https://github.com/appsmithorg/appsmith/issues/19396
- [x] https://github.com/appsmithorg/appsmith/issues/19397
- [x] https://github.com/appsmithorg/appsmith/issues/19398
- [x] https://github.com/appsmithorg/appsmith/issues/19399
- [x] https://github.com/appsmithorg/appsmith/issues/19400
- [x] https://github.com/appsmithorg/appsmith/issues/19401
- [x] https://github.com/appsmithorg/appsmith/issues/19402
- [x] https://github.com/appsmithorg/appsmith/issues/19403
- [x] https://github.com/appsmithorg/appsmith/issues/19404
- [x] https://github.com/appsmithorg/appsmith/issues/19405
- [x] https://github.com/appsmithorg/appsmith/issues/19406
- [x] https://github.com/appsmithorg/appsmith/issues/19407
- [x] https://github.com/appsmithorg/appsmith/issues/19408
- [x] https://github.com/appsmithorg/appsmith/issues/19409

Fixes # (issue)
> if no issue exists, please create an issue and ask the maintainers
about this first


Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video


## Type of change

> Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update


## How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Provide
instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.
> Delete anything that is not important

- Manual
- Jest
- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Tanvi Bhakta <tanvi@appsmith.com>
Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Rohit Agarwal <rohit_agarwal@live.in>
Co-authored-by: Nilesh Sarupriya <nilesh@appsmith.com>
Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
Co-authored-by: Vijetha-Kaja <vijetha@appsmith.com>
Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com>
Co-authored-by: Apple <nandan@thinkify.io>
Co-authored-by: Saroj <43822041+sarojsarab@users.noreply.github.com>
Co-authored-by: Sangeeth Sivan <74818788+berzerkeer@users.noreply.github.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: rahulramesha <rahul@appsmith.com>
Co-authored-by: Aswath K <aswath.sana@gmail.com>
Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com>
Co-authored-by: Vijetha-Kaja <119562824+Vijetha-Kaja@users.noreply.github.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-05-20 00:07:06 +05:30
Aishwarya-U-R
c8615a853d
ci: Update ci-test.yml-for ADS run (#23557)
## Description

- This PR adds changes for ADS run via oktotest with Cy10 on increased
jobs

#### Type of change
- yml file update
2023-05-19 21:43:09 +05:30
Saroj
79e7dac1c5
ci: Fix for cypress rerun cache issue (#23553)
## Description
- Download the combined failed spec from artifact instead of cache in
ci-test.yml

#### Type of change
- ci-test.yml
#### How Has This Been Tested?
- Workflow run

## Checklist:
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-05-19 21:32:49 +05:30
Aishwarya-U-R
8ad7f80321
Revert "Update ci-test.yml-for ADS run" (#23534)
Reverts appsmithorg/appsmith#23529
2023-05-19 17:23:41 +05:30
Aishwarya-U-R
1904cc4f79
Update ci-test.yml-for ADS run (#23529)
## Description
- This PR adds changes for ADS run via oktotest with Cy10 on increased
jobs

#### Type of change
- yml file update
2023-05-19 14:44:55 +05:30
Aishwarya-U-R
c91670f7d1
Revert "Update ci-test.yml-for ADS run" (#23508)
Reverts appsmithorg/appsmith#23507
2023-05-19 07:56:07 +05:30
Aishwarya-U-R
294a0149b3
Update ci-test.yml-for ADS run (#23507)
> Pull Request Template
>
> Use this template to quickly create a well written pull request.
Delete all quotes before creating the pull request.
>
## Description
> Add a TL;DR when description is extra long (helps content team)
>
> Please include a summary of the changes and which issue has been
fixed. Please also include relevant motivation
> and context. List any dependencies that are required for this change
>
> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
>
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-05-19 06:23:50 +05:30
Saroj
aa8196b1cd
ci: Added step to build docker image separately for ci-test-limited (#23410)
## Description
- Added step to build docker image separately for ci-test-limited.yml
#### Type of change
- workflow file changes
#### How Has This Been Tested?
- Manual
2023-05-16 18:48:03 +05:30
Nikhil Nandagopal
86d42952e1 Updated Label Config 2023-05-15 18:36:32 +05:30
Sangeeth Sivan
bc5a23e8cd
feat: ci changes & cypress tests with cypress tags (#22989)
## Description

This includes

> Building a new image for airgapped instances
> Running ci-tests on airgapped image
> Running cypress tests selectively ignoring non supported features for
airgap like Templates, Custom JS lib and also alternating test
behaviours for some tests like tests using mock db, since it doesn't
work on airgap we have to create a ds. So this selective testing was
done using cypress-tags
> Having a new client build for airgapped images which bundles all the
assets.
> And changes in the workflow files to account for all the above. 

With airgap, we can ignore certain tests and also need to account for
tests using mock datasources and such by creating new datasources
instead of mock datasources. Since those are blocked. So to perform a
selective testing we are using a plugin called `cypress-tags` and to
perform conditional testing when required we use the `AIRGAPPED` cypress
env. This PR introduces both and also modified the codebase to support
this new way of running cypress.

Since we can't trigger `/ok-to-test` on this because ci-test needs the
CYPRESS_EXCLUDE_TAGS and slash command doesn't dispatch from current
branch,

I manually triggered the `TBP` workflow to run ci-test on this branch. 
And the new `TBP airgap` workflow to run ci-test on airgapped docker
image on this branch.

Here is the link to the run 
https://github.com/appsmithorg/appsmith/actions/runs/4882041416

Fixes #22007 
Fixes #22814 


## Type of change

> Please delete options that are not relevant.

- New feature (non-breaking change which adds functionality)
- Chore (housekeeping or task changes that don't impact user perception)


## How Has This Been Tested?

- Manual
- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-05-12 00:15:06 +05:30
Saroj
e1c8012074
ci: Fix for dependency installation time (#23239)
## Description
- Added --immutable to yarn install

#### Type of change
- Workflow files

#### How Has This Been Tested?
- Manual
2023-05-11 22:26:52 +05:30
Saroj
b34bd212e0
ci: Fix for build-client-serve.yml (#23236)
## Description
- Added dependency for ci-limited-test 

#### Type of change
- Workflow changes

#### How Has This Been Tested?
- Manual
2023-05-11 20:20:23 +05:30
Saroj
f53379ef96
ci: Workflow to build client and server builds without running tests (#23234)
## Description
- Added workflow to build client and server without running tests
#### Type of change
- Added workflow file
#### How Has This Been Tested?
- Manual
2023-05-11 19:51:43 +05:30
Goutham Pratapa
3bfaf5a070
fix: vercel deploy previews (#23221) 2023-05-11 15:50:50 +05:30
Goutham Pratapa
e8783eb672
Fix vercel builds (#23219) 2023-05-11 15:28:05 +05:30
Ivan Akulov
0700eda0be
ci: correct the artifact download paths (#23209) 2023-05-11 12:52:43 +05:30
Satish Gandham
e8f76a9db1
ci: Fix an incorrect artifact download path (#23208)
Co-authored-by: Satish Gandham <hello@satishgandham.com>
2023-05-11 12:49:56 +05:30
Satish Gandham
83538ad74d
feat: Bundle optimization and first load improvements (#21667)
Co-authored-by: Ivan Akulov <mail@iamakulov.com>
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Ivan Akulov <iamakulov@outlook.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2023-05-11 10:56:03 +05:30
ramsaptami
69b1a60082
chore: cleaned up formatting for the template (#22670)
## Description

Cleaned up template heading and section styles on PR template

- Chore (housekeeping or task changes that don't impact user perception)

---------

Co-authored-by: Hetu Nandu <hetu@appsmith.com>
2023-05-05 20:38:21 +05:30
Shrikant Sharat Kandula
3c8c940caf
ci: Remove unused java setup step (#22978)
We're setting up Java, but aren't using it in this workflow. This PR
removes it.
2023-05-04 11:52:57 +05:30
Shrikant Sharat Kandula
1504254d84
ci: Fix issue title injections in workflow 2023-05-02 11:02:43 +05:30
Arun
693aa75e79
fix: Security Vulnerability in GitHub Workflows (#22888)
"github.event.issue.title" is potentially untrusted. avoid using it
directly in inline scripts. instead, pass it through an environment
variable. see
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions
for more details.
2023-05-02 10:59:34 +05:30
yatinappsmith
af6b2b0150
ci: Increased clientbuild runner (#22722)
## Description

Increased clientbuild runner


## Type of change



- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- Manual

### Test Plan
None

### Issues raised during DP testing
None


## Checklist:
### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-25 17:18:23 +05:30
Saroj
b5850ba78a
ci: Added step to check the PR approval status (#22671)
## Description
- Added step to check the PR approval status
- Used another plugin for merge

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-24 17:51:25 +05:30
Saroj
a0ab7fa990
ci: Added UPDATE_LABLES and update the rename variables with more meaningful name (#22585)
## Description
- Added UPDATE_LABLES and update the rename variables with more
meaningful name

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github Actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-20 13:19:59 +05:30
Saroj
fc01e65df8
ci: Add env to print logs from auto-merge in ci-merge-check (#22581)
## Description
- Added logging for auto merge in ci-merge-check

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-20 12:38:30 +05:30
Saroj
4459ba3cef
ci: Updated requirements for auto merge in ci-merge-check (#22567)
## Description
- Updated requirements for auto merge in ci-merge-check

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-20 11:15:04 +05:30
Saroj
2729bbff28
ci: Fix for ci-merge-check.yml issues (#22564)
## Description
-  Fix for ci-merge-check.yml issues

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-19 17:40:09 +05:30
Saroj
2794ec695c
ci: Fix for "Test Plan Approved" check in ci-merge-check (#22547)
## Description
- Consider the latest one if there are more than one 'Test plan
approved' output in the api

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github Actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-19 14:48:55 +05:30
Saroj
10b51c15f0
ci: Fix ci-test-result in ci-merge-check (#22540)
## Description
- Fixing ci-test-result in ci-merge-check
- Added Authorisation header in the curl requests to support this in EE

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github Actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-19 12:32:34 +05:30
Saroj
5620d0ab09
ci: Fix ci-merge-check issue (#22528)
## Description
- Fix ci-merge-check issue

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Guthub actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-19 09:51:30 +05:30
Saroj
43febea649
ci: Added logic to handle few more cases in ci-merge-check (#22519)
## Description
- Added logic to handle few more cases in ci-merge-check

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github Actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 18:23:22 +05:30
Saroj
e8a986516c
ci: Fix syntax error in ci-merge-check (#22518)
## Description
- Fix syntax error in ci-merge-check

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 17:12:31 +05:30
Saroj
27d5b76d1f
ci: Modified the logic to pick the last comment for ci-merge-check (#22517)
## Description
- Modified the logic to pick the last comment for ci-merge-check

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 17:04:12 +05:30
Saroj
ddccd8d24b
ci: Fix to fetch the sha id from client_payload instead of event.pull_request (#22513)
## Description
- Fix to fetch the sha id from client_payload instead of
event.pull_request in ci-merge-check

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 16:44:11 +05:30
Saroj
b19e974d8e
ci: Fix for ci-merge-check workflow (#22511)
## Description
- Fix for ci-merge-check workflow

## Type of change
- ci-merge-check.yml


## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 16:14:12 +05:30
Saroj
0edcc07048
ci: Fix for ci-merge-check (#22452)
## Description
- Fixing ci-merge-check.yml

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 15:42:53 +05:30
Shrikant Sharat Kandula
7a0e54ae5f
chore: Delete unused close-label.yml 2023-04-18 07:43:58 +05:30
Goutham Pratapa
f32623420e
ci: uncomment debug statements and clear dps when merged (#22463)
Succesful run:
https://github.com/appsmithorg/appsmith/actions/runs/4718116171/jobs/8367371248
2023-04-17 15:45:52 +05:30
Nikhil Nandagopal
55e45e8250 Updated Label Config 2023-04-17 14:53:09 +05:30
Goutham Pratapa
6bbcbc1b2c
ci: add workflows to cleanup merged deploy-previews (#20627)
[20765](https://github.com/appsmithorg/appsmith/issues/20765)
2023-04-17 11:39:33 +05:30
Goutham Pratapa
9b37810c7b
ci: add recreate option for dps (#22091)
fixes: [248](https://github.com/appsmithorg/cloud-deployment/issues/248)


https://github.com/appsmithorg/appsmith-ci/pull/14#issuecomment-1504569726
This doesnt delete the existing stacks 


https://github.com/appsmithorg/appsmith-ci/pull/14#issuecomment-1504842238
this deletes the stack, database in mongo and therefore creating a
complete new stack
2023-04-14 16:27:17 +05:30
Nikhil Nandagopal
14710d297b Updated Label Config 2023-04-13 19:59:10 +05:30
Nikhil Nandagopal
07e6f15336 Updated Label Config 2023-04-12 16:52:16 +05:30
Nikhil Nandagopal
634d0a9d79 Updated Label Config 2023-04-12 14:19:00 +05:30
Aishwarya-U-R
f88c1b1077
ci: Update the text in Git comment flaky tests app link (#22307)
## Description

- This PR updates the text message that gets commented after a PR run

## Type of change

- Yml file update

## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
2023-04-12 11:07:55 +05:30
Nikhil Nandagopal
a23bd70e29 Updated Label Config 2023-04-11 10:37:06 +05:30
Nikhil Nandagopal
2206d0a513 Updated Label Config 2023-04-11 10:36:56 +05:30
Nikhil Nandagopal
b0581da992 Updated Label Config 2023-04-10 21:38:40 +05:30
Nikhil Nandagopal
318d862709 Updated Label Config 2023-04-10 18:55:04 +05:30
Aishwarya-U-R
5f1e4d1ba8
test: Cypress - flaky fix + Git comment improve (#22169)
## Description

- This fixes the Firestore spec that fails sometimes in CI due to all
runs accessing the same cloud collection for validation.
- This PR also adds comments to PR - if all cypress cases passed, right
now there is no comment

## Type of change

- Script update

## How Has This Been Tested?

- Cypress CI runs


## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all Cypress test
2023-04-10 17:41:14 +05:30
Shrikant Sharat Kandula
64edd25a8b
ci: Use vars for DOCKER_HUB_ORGANIZATION (#22177)
GitHub's Variables, unlike Secrets, don't get masked in the output, and
are ideal for non-secret... _variables_. I'm switching on such secret
here, and depending on our experience with this, we'll look to moving
more.

Of course, goes without saying, do NOT use these variables for secrets.
When in doubt, use Secrets.

[Learn more about
Variables](https://docs.github.com/en/actions/learn-github-actions/variables).
2023-04-10 14:23:12 +05:30
Nikhil Nandagopal
0eb8ff5ce1 Updated Label Config 2023-04-07 13:36:44 +05:30
Goutham Pratapa
f56596af62
fix:skipping jest-tests in client workflow (#21675)
Fixes: [22072](https://github.com/appsmithorg/appsmith/issues/22072)
Running as part of individual builds:


https://github.com/appsmithorg/appsmith/actions/runs/4605026111/jobs/8136569091
2023-04-07 12:41:36 +05:30
Nikhil Nandagopal
14e78fb550 Updated Label Config 2023-04-07 00:15:24 +05:30
Shrikant Sharat Kandula
0b7bedf1fc
ci: Fix close-labeler to work on correct repo for issues 2023-04-05 19:08:39 +05:30
Saroj
292c32407b
ci: Added 'Workflow run' and 'Commit' for the failed spec comments (#22128)
## Description
- Added 'Workflow run' and 'Commit' for the failed spec comments

## Type of change
- YML Changes

## How Has This Been Tested?
- CI run

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-04-05 14:45:59 +05:30
Shrikant Sharat Kandula
1836a44577
ci: Remove license in ci-test.yml (#21938)
The License key is unused in this repo. Setting it here is misleading,
and can cause confusions at best, or missed accidental License failures
at worst.

This PR removes the License key occurrences from `ci-test.yml`.

Note: Please review/approve only. Don't merge. This will likely cause a
conflict, so I'd like to be available when this is merged so I can
resolve the conflict. Thanks!
2023-04-05 09:38:44 +05:30
Shrikant Sharat Kandula
164a724969
ci: Add inhouse close-labeler workflow 2023-04-05 07:14:08 +05:30
Aishwarya-U-R
85f3ebc1f3
ci: Starting ElasticSearch DB container for running test scripts in CI runs (#22102)
## Description

- This PR includes ElasticSearch as separate docker container inside CI
that can be used for running ElasticSearch datasource test cases in CI

## Type of change

- Yaml file update


## Checklist:
### QA activity:
- [ ] Added Test Plan Approved label after reviewing all changes
2023-04-05 01:36:57 +05:30
Aishwarya-U-R
83ea3c04cf
test: Cypress - Automated tests for Firestore datasource (#22057)
## Description

- This PR includes tests for Firestore ds - with querying & usage of
various fields in the query page

## Type of change

- New script

## How Has This Been Tested?

- Cypress CI runs

## Checklist:

### QA activity:
- [ ] Added Test Plan Approved label after reviewing all changes
2023-04-04 21:26:57 +05:30
Nikhil Nandagopal
78a210e12e Updated Label Config 2023-04-04 13:23:50 +05:30
Nikhil Nandagopal
3b86afb4d1 Updated Label Config 2023-04-04 13:23:17 +05:30
Nikhil Nandagopal
d885b479c7 Updated Label Config 2023-04-04 11:44:31 +05:30
Aishwarya-U-R
ceefaa00bc
Test: Adding Smoke & Sanity suites into the CI pipeline (#22029)
## Description

- This PR introduces smoke & sanity tests into the CI pipeline, to
capture the failures early.

## Type of change

- CI Improvements


## How Has This Been Tested?

- Cypress runs on local PR workflows

## Checklist:

### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes

---------

Co-authored-by: Saroj <saroj@appsmith.com>
2023-04-04 10:39:40 +05:30
Aishwarya UR
a5f0689a24 Adding FIRESTORE_PRIVATE_KEY to git 2023-04-04 03:12:46 +05:30
Aishwarya-U-R
dffbf3d97c
ci: Adding Identified Flaky tests app link into Git comments section in a PR (#21966)
## Description

- This PR adds the Flaky list application link into the git comments
section on completion of the run, so the PR owners have easy access to
it.


## Type of change

- Yml file update

## Checklist:

### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
2023-03-31 16:55:51 +05:30
Nikhil Nandagopal
ea704bcf08 Updated Label Config 2023-03-31 08:25:58 +05:30
Saroj
a5aabe7bbc
ci: Upload an empty failed-spec-ci file if all the specs are passed (#21914)
## Description
-  Upload an empty failed-spec-ci file if all the specs are  passed

## Type of change
- YML file changes

## How Has This Been Tested?
- github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-03-30 20:14:22 +05:30
Saroj
ee3bccdae2
ci: Resetting the failed_spec_ci in case of success in ci-test.yml (#21853)
## Description
- Resetting the failed_spec_ci in case of success in ci-test.yml

## Type of change
- yml file changes

## How Has This Been Tested?
- Workflow run

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-03-29 13:30:30 +05:30
Aishwarya-U-R
eaede7960e
ci: Starting Arango DB container for running Arango test scripts in CI runs (#21841)
## Description

- This PR includes Arango as separate docker container inside CI that
can be used for running Arango datasource test cases in CI

## Type of change

- Yml file update


## Checklist:
- [X] Added Test Plan Approved label after reviewing all changes
2023-03-29 00:01:53 +05:30
Nikhil Nandagopal
18b82667a2 Updated Label Config 2023-03-28 17:56:58 +05:30
Nikhil Nandagopal
670480e8c4 Updated Label Config 2023-03-28 15:35:00 +05:30
Nikhil Nandagopal
9a0a3219e2 Updated Label Config 2023-03-28 15:34:05 +05:30
Saroj
f3211dd2f5
ci: Added dub points for failed-spec comment (#21810)
## Description
- Added dub points for failed-spec comment

## Type of change
- YML File changes


## How Has This Been Tested?
- Manual

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-03-28 09:51:55 +05:30
Aishwarya-U-R
413d430025
test: Cypress - Segment calls intercepted (#21726)
## Description

- This PR adds the host for segment calls as localhost as opposed to
sending it to Segment itself
- Diverting segment calls to Localhost for Cypress CI runs &
intercepting the response
- Updated to Analytics spec to validate the enableTelemtry false state
- Bug 21191, validation included
- Welcome screen - not toggling off the Usage Details anymore

## Type of change

- Yml file update
- Script updates


## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
2023-03-24 21:36:48 +05:30
Saroj
608658818f
ci: Added condition to fetch the specs failed in after hook in ci-test.yml (#21713)
## Description
- Added condition to fetch the specs failed in after hook in ci-test.yml

## Type of change
- YML file changes
- 
## How Has This Been Tested?
- Manual

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-03-23 13:11:02 +05:30
Saroj
f17df15953
ci: Fix for combined-failed-spec-ci cache not found issue (#21706)
## Description
- Fix for combined-failed-spec-ci cache not found issue

## Type of change
- YML file changes

## How Has This Been Tested?
- Manual

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-03-23 10:51:41 +05:30
Saroj
bc79466a99
ci: Updated the workflow files to use actions/cache@v3 (#21669)
## Description
- Updated the workflow files to use actions/cache@v3 

## Type of change
- yml file changes

## How Has This Been Tested?
- Manual

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-03-22 16:17:13 +05:30
Saroj
a872435320
ci: Reverting the use of combined-failed-spec-ci artifact instead of cache (#21663)
## Description
- Reverting the use of combined-failed-spec-ci artifact instead of cache

## Type of change
- yml file changes

## How Has This Been Tested?
- Manual

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-03-22 09:44:41 +05:30