Commit Graph

39 Commits

Author SHA1 Message Date
Valera Melnikov
f25eb88754
chore: separation of client build steps (#24506)
## Description
Separation to different steps of running lint, prettier, and jest unit
tests

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-06-16 09:03:56 +03:00
Saroj
1dc13270c6
ci: Download the failed specs from artifact instead of cache (#23600)
## Description
- Updated the workflows to save and download the correct dependencies
cache

#### Type of change
- Workflow changes

#### How Has This Been Tested?
- CI run
2023-05-24 18:28:01 +05:30
Valera Melnikov
9f607d250d
chore: move local dependency to packages (#23395)
## Description
1. Move everything related to client from app folder to client folder
(`.yarn`, `yarn.lock`, package.json, .gitignore)
2. Move `ast` and `rst` to client packages
3. Fix running scripts in packages
4. Add running unit tests in packages in CI

TODO: It is necessary to consider enabling the `nmHoistingLimits:
workspaces` option, since now all packages are hoisted to the root,
there may be issues with dependencies in workspaces. Also, there is a
possibility of implicit use of packages.

https://yarnpkg.com/configuration/yarnrc#nmHoistingLimits

#### PR fixes following issue(s)
Fixes #23333

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing

#### How Has This Been Tested?
- [x] Manual
- [x] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-05-22 15:55:46 +03:00
Satish Gandham
83538ad74d
feat: Bundle optimization and first load improvements (#21667)
Co-authored-by: Ivan Akulov <mail@iamakulov.com>
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Ivan Akulov <iamakulov@outlook.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2023-05-11 10:56:03 +05:30
yatinappsmith
af6b2b0150
ci: Increased clientbuild runner (#22722)
## Description

Increased clientbuild runner


## Type of change



- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- Manual

### Test Plan
None

### Issues raised during DP testing
None


## Checklist:
### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-25 17:18:23 +05:30
Goutham Pratapa
f56596af62
fix:skipping jest-tests in client workflow (#21675)
Fixes: [22072](https://github.com/appsmithorg/appsmith/issues/22072)
Running as part of individual builds:


https://github.com/appsmithorg/appsmith/actions/runs/4605026111/jobs/8136569091
2023-04-07 12:41:36 +05:30
Satish Gandham
b2828dfe93
ci: Add lint check to the build step (#21442)
Add a step to verify lint rules in client build workflow.

---------

Co-authored-by: Satish Gandham <hello@satishgandham.com>
2023-03-20 22:50:44 +05:30
Goutham Pratapa
891df1dc33
ci: build lite version of deploy preview (#21078)
**Case-1:**

**`/build-deploy-preview skip-tests=true`**

**Client-jest skipped**
![Screenshot 2023-03-01 at 3 40 04
PM](https://user-images.githubusercontent.com/15846947/222109174-74749203-eafa-4694-ac5f-f5713942d07b.png)
**Server Build taking less time**
![Screenshot 2023-03-01 at 3 40 46
PM](https://user-images.githubusercontent.com/15846947/222109336-6771357f-6acf-4e5f-a428-ae73d057bf44.png)

**Case-2:**

**`/build-deploy-preview `**
![Screenshot 2023-03-02 at 11 54 37
AM](https://user-images.githubusercontent.com/15846947/222649676-f78f9f58-d918-4c74-961a-a5405481ab4c.png)


**Case-3**

**`/build-deploy-preview  env=release`**

![Screenshot 2023-03-07 at 8 05 38
PM](https://user-images.githubusercontent.com/15846947/223453763-35a0f5b5-b941-4349-80bc-a024deed5a08.png)

**github-action**
![Screenshot 2023-03-07 at 8 05 58
PM](https://user-images.githubusercontent.com/15846947/223453797-fad9b60e-f363-44b2-a7a0-2a954f1a4dac.png)

**final-dp:**

![Screenshot 2023-03-07 at 8 06 46
PM](https://user-images.githubusercontent.com/15846947/223454037-5725d6e5-18ff-4e9f-bd8d-3b181887ec75.png)
2023-03-08 15:07:30 +05:30
Shrikant Sharat Kandula
84e0ae80c8
ci: Use release Segment Key (#21225)
Effectively reverts changes from
https://github.com/appsmithorg/appsmith/pull/20669, since we depend on
this for usage tracking.
2023-03-07 14:50:14 +05:30
Shrikant Sharat Kandula
fb8870765a
ci: Remove Segment key unless on master branch (#20669) 2023-02-16 14:49:55 +05:30
Goutham Pratapa
568544b5a3
ci: fix artifact names across the ci (#20586)
Fix: artifact names across CI
2023-02-13 14:45:02 +05:30
Goutham Pratapa
d452b2452c
ci: Migrate runners from buildjet to github (#19066)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-12-20 16:32:22 +05:30
Hetu Nandu
c5c8734dc1
chore: Update github actions to remove deprecation warnings (#18619) 2022-12-19 13:04:43 +05:30
Arpit Mohan
970deb92c7 ci: Reverting change for Github large runners 2022-12-15 21:03:18 +05:30
Arpit Mohan
4ed4de8d9c
ci: Moving the runners to use Github large runners instead of Buildjet (#18984) 2022-12-15 20:29:21 +05:30
Satish Gandham
f560fcc4f8
ci: Fix a typo in client-build workflow (#17983)
Fix a typo in client-build workflow
2022-11-01 12:51:18 +05:30
Satish Gandham
58fcb72606
ci: Remove PR from create run meta query (#17981)
* Rearrange client build steps

* Remove PR from the run meta insert query

* Add repo to the query

Co-authored-by: Satish Gandham <hello@satishgandham.com>
2022-10-31 13:13:07 +05:30
Satish Gandham
ecd87464b0
ci: Rearrange client build steps (#17979)
Rearrange client build steps

Co-authored-by: Satish Gandham <hello@satishgandham.com>
2022-10-31 12:44:40 +05:30
Satish Gandham
349d5c8283
ci: Read environment variables right. (#17948)
* Fix typos

* Read the env variables right

Co-authored-by: Satish Gandham <hello@satishgandham.com>
2022-10-28 19:35:59 +05:30
Satish Gandham
6ad782c242
ci: Add S3 credentials to environment and create run meta record at the time of checkout (#17917)
* - Add S3 credentials to environment
- Change the workflow name
- Create performance run meta data record at the begining.

* Fix a typo

* Fix a typo

* Store DB credentials as plain values instead of JSON

* Fix SQL insert query

* Add missing secrets

* Continue even if the meta creation fails

* Fix SQL insert command

* Rename workflow

Co-authored-by: Satish Gandham <hello@satishgandham.com>
2022-10-28 16:32:38 +05:30
Arpit Mohan
98c18862c2
ci: Fixing the caches for server,client and rts build (#16757)
The problem was being caused by reusable modules taking the same job id
2022-09-14 20:28:40 +05:30
Arpit Mohan
7580eb9990
ci: Fixing the RTS build workflow (#16748)
## Description

The problem with the RTS workflow after the induction of AST parsing was that while copying the `node_modules`, Ubuntu doesn't follow the symlink and copy the content. It simply copies the symlink as is. This causes issues for RTS service to start.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- Personal repository

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-09-14 14:24:20 +05:30
Arpit Mohan
697bdecaa5
ci: Modularizing the Github actions workflow for maintainability (#16505) 2022-09-09 01:08:55 +05:30
Arpit Mohan
037efacbf3
fix: Display community edition along with version (#16341)
## Description

This PR adds the string `Community` along with the Appsmith version. This will help users identify the type of instance that they are running.

## Type of change

- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

Manually

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-08-27 15:10:03 +05:30
Arpit Mohan
48738091e5
chore: Removing jest test coverage because of node version mismatch (#14230) 2022-06-01 17:43:03 +05:30
Arsalan Yaldram
8d55d6f51d
chore: update node version to 16.14.0 (#14127) 2022-05-26 23:39:59 +05:30
Arsalan Yaldram
b28eb3fed8
chore: Update node version to 16.15.0 LTS (#14094) 2022-05-26 16:05:02 +05:30
Arpit Mohan
6dcc00a9f4
ci: Moving the runs-on parameter in some Github workflows to use Buildjet (#12399) 2022-03-30 20:39:34 +05:30
Abhinav Jha
91ead4f864
fix: Use existing yarn.lock as-is in CI (#11497)
* Update github workflows to use the lockfile in the codebase and not update it

* Fix jobs array formatting
2022-03-21 11:43:42 +05:30
Arpit Mohan
02bf061479 Revert "Adding paths-ignore to the client build workflows to ignore manual test changes"
This reverts commit 008d83cc0b.
2021-10-01 11:52:49 +05:30
Arpit Mohan
008d83cc0b Adding paths-ignore to the client build workflows to ignore manual test changes 2021-10-01 11:40:43 +05:30
Hetu Nandu
74a292ffda
Add better code coverage comments (#4140) 2021-04-26 16:21:52 +05:30
Hetu Nandu
d1a13a28bc
Remove coverage drop failure checks (#4048) 2021-04-19 14:51:04 +05:30
Nidhi
fccf43d7f0
Enable ok to test for contributors (#3737) 2021-03-30 15:04:08 +05:30
Hetu Nandu
9a4c317f20
Store value improvements (#3663) 2021-03-24 10:39:47 +05:30
Hetu Nandu
2dd1791810
Refactor and add unit tests to API interceptors (#3647) 2021-03-22 14:52:24 +05:30
hetunandu
6b5c46e117 Only do jest coverage when it is a pull request 2021-03-21 11:34:08 +05:30
Hetu Nandu
f1cb2a35b7
Add jest coverage diff reporting action (#3651) 2021-03-20 19:28:10 +05:30
Hetu Nandu
52c7f5331a
Trigger client integration only on approved PRs (#3632)
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
2021-03-19 14:21:14 +05:30