Commit Graph

832 Commits

Author SHA1 Message Date
Favour Ohanekwu
b703ceb69f
fix: remove duplicate query params in evaluated value (#10101)
Remove duplicate query parameters in evaluated value
2022-01-04 10:27:38 +01:00
Yash Vibhandik
a6a462cf68
feat: #4141 added truncate support into text widget (#9820)
* feat: #4141 added truncate support into text widget

* fix: updated truncate show logic, cypress added

* fix: updated ellipsis position

Co-authored-by: bhavin <techbhavin@gmail.com>
2022-01-04 11:51:02 +05:30
Vicky Bansal
c9ec218b79
fix: change recaptcha key and type and add suggestion for recaptchaToken (#9464)
* Change recaptcha key and type and add suggestion for recaptchatoken

* Add recaptchaToken property as target for auto completion cypress tests

* Added cypress test to validate recaptcha v2 can be selected in button widget property pane

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2022-01-02 08:27:39 -08:00
Aishwarya-U-R
d71a873e16
test: Automated tests for Flakiness fixes (#10040)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()

* Removing .skip

* Bind_tableApi_spec.js failure fix

* Slash command failure fix
2021-12-31 11:58:47 +05:30
Keyur Paralkar
40ba88ce57
fix: added selectedOptionValue for index change in changeSelectedOption func Dropdown widget (#10047)
* fix: added selectedOptionValue for index change in changeSelectedOption func Dropdown widget

* test: added cypress test for select reset issue
2021-12-31 11:00:17 +05:30
balajisoundar
467f9ee1c2
fix: Allow empty value in multiple widgets options property (#10012)
- Checkbox group widget
- MultiSelecttree widget
- Multiselect widget
- dropdown widget
- radio group widget
- single select tree
- switch group widget
2021-12-30 14:57:44 +05:30
Vicky Bansal
f05c92603e
fix: Improper formatting for Input Widget for DataType currency (#9050)
* Fix currency number formating and add unit tests

* Fix Input currency type cypress test

* Fix currency number formating and add unit tests

* Fix Input currency type cypress test

* Add comments for utilities formatCurrencyNumber and limitDecimalValue

* Fix currency number formating and add unit tests

* Fix Input currency type cypress test

* Fix Input currency type cypress test

* Add comments for utilities formatCurrencyNumber and limitDecimalValue

* Fix upstep and downstep button action for formated currency input

* remove crendentials from cypress.json

* Fix input currency test flakiness

* Fix cypress test for currency input type

Fix formatCurrencyNumber function and added more unit tests

* Fix cypress test for currency input

Handle group separator and decimal separator when formatting and deformatting input for currency type

* remove console.log

* Handle formatting changes for default text

* Format input widget value for currency to handle default text

* remove unused import

* Add unit tests for getGroupSeparator and getDecimalSeparator functions

* add function to get user locale

* use preventDefault in input increment/decrement button click

* Use getLocale function, use String function

* use Number function for type conversion

* fix number to string type

* Handle 0 value for numbers

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-30 00:40:01 -08:00
Vicky Bansal
2d645b7e8d
fix: disable submit button when date is out of bounds (#9552)
* disable submit button when date is out of bounds

* Remove comment from derived.js function as comments are not allowed for parsing

* Fix table client side search cypress test

* validate date again min/max irrespective of isRequired property
2021-12-30 00:38:40 -08:00
Tolulope Adetula
54bb8bffe0
fix: rich text editor cursor fix (#9889)
* fix: rich text editor cursur fix

* fix: failing tests

* fix: debounce callback

* fix: Throw away any pending invokation

* fix: use SetTimeout for deboucing

* fix: markdown issues

* fix: onTextChange on page load

* fix: failing test
2021-12-30 00:01:45 -08:00
Bhavin K
323fa52455
feat: add progressbar widget (#9574) 2021-12-29 17:31:19 +05:30
Bhavin K
e995865b28
fix: updated columns names (#9715) 2021-12-29 17:12:07 +05:30
Yash Vibhandik
29687f9f12
feat: 8761 added optionAlignment property (#9696) 2021-12-29 07:22:10 +00:00
Aishwarya-U-R
3a4db6bdfd
test: Automated tests for S3 uploads & Mongo Bugs + Flakiness fixes (#9931)
* Bugs  #9069, #9201, #6975, #9922 - Scripted

* Mongo DS update from Cloud to Localhost

* Updating command.js

* Ignoring Mongo until Localhost is fixed

* S3 fixes

* S3 fix

* Mongo Cloud to Localhost transition

* Bug #6375 scripted

* Failure fix

* S3 fix + testSaveDs method flow update

* Refresh datasource structure script fix

* Entity explorer datasource structure script fix

* testSaveDs method flow update fixes

* testSaveDs method flow update fixes - set 2

* S3, Mongo Skipping cases fix

* Custom Chart failure fix

* Button-Call-Query Validation case script fix

* Confirm run action failure fix

* Confirm run action script fix

* Dropdown-Call-Query Validation script fix

* S3 - Delete icon issue fix

* S3 - Delete icon locator updated

* actionContextMenuByEntityName method call update

* Table widget add new menu button column - rgb fix

* Commenting BG color verify - to override flakiness

* Mongo skipping script fix

* Commenting Cypress.runner.stop()
2021-12-29 11:11:30 +05:30
Favour Ohanekwu
c96c0d4f3b
feat: Show evaluated value in embeddedDatasource url (#9198)
Show evaluated value in embeddedDatasource url
2021-12-28 13:14:32 +01:00
Aswath K
56590ef253
feat: Add keyboard navigation for dropdown (#9561)
* Add keydown handler for DropdownContainer

* Add keyboard focus state

* fix: esc resets changed selection

* Add tests

* fix: Merge induced type issue with multi-select option

* fix: broken locator from #8777
2021-12-28 16:43:56 +05:30
balajisoundar
8c6bae6f71
fix: allow updating computed values of table widget in view mode (#9817)
* fix: allow updating computed values of table widget in view mode
* cypress tests
2021-12-28 12:45:28 +05:30
imgbot[bot]
15ace470a5
chore: [ImgBot] Optimize images (#10019)
*Total -- 226.72kb -> 167.93kb (25.93%)

/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/EmptyApp.snap.png -- 20.32kb -> 13.87kb (31.78%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/apppage.snap.png -- 57.58kb -> 41.70kb (27.59%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/quickPageWizard.snap.png -- 59.08kb -> 42.85kb (27.47%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/loginpage.snap.png -- 35.57kb -> 26.33kb (25.96%)
/app/client/cypress/snapshots/Smoke_TestSuite/ClientSideTests/LayoutValidation/AppPageLayout.spec.js/emptyAppBuilder.snap.png -- 44.30kb -> 33.38kb (24.67%)
/app/client/src/assets/icons/widget/camera.svg -- 0.28kb -> 0.27kb (1.41%)
/app/client/src/widgets/CameraWidget/icon.svg -- 0.31kb -> 0.30kb (1.27%)
/app/client/src/assets/icons/widget/camera/exit-fullscreen.svg -- 0.51kb -> 0.50kb (1.15%)
/app/client/src/assets/icons/widget/camera/fullscreen.svg -- 0.36kb -> 0.36kb (1.08%)
/app/client/src/assets/icons/widget/camera/camera-muted.svg -- 0.69kb -> 0.69kb (0.84%)
/app/client/src/widgets/SwitchGroupWidget/icon.svg -- 1.60kb -> 1.59kb (0.61%)
/app/client/src/assets/icons/widget/camera/camera.svg -- 0.69kb -> 0.69kb (0.56%)
/app/client/src/assets/icons/widget/camera/microphone-muted.svg -- 1.63kb -> 1.63kb (0.42%)
/app/client/src/assets/icons/form/help-outline.svg -- 0.89kb -> 0.89kb (0.33%)
/app/client/src/assets/icons/widget/camera/microphone.svg -- 1.46kb -> 1.45kb (0.27%)
/app/client/src/assets/icons/widget/camera/camera-offline.svg -- 1.44kb -> 1.44kb (0.2%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-12-27 18:02:30 +05:30
rashmi rai
f6b9abdacf
feat: adding ads component for UQI (#8777) 2021-12-27 17:34:45 +05:30
Aman Agarwal
4d73536ea8
fix: Correcting the execution of query with the latest values when run shortcut is pressed (#9363)
* fix(run-hot-key): added update init action with debounced on change function

* fix(run-hot-key): Adding new action for updating store for isSaving query true

* fix(run-hot-key): updating the action name to preparing_update_action

* fix(run-hot-key): added descriptive comments

* fix(run-hot-key): updated the action name and moved condition to action file

* fix(run-hot-key): updated the action to entity started at global app

* fix(run-hot-key): added entity saving status to show loader

* fix(run-hot-key): fixed cypress test to type in the query rather using set method of code editor
2021-12-24 19:29:02 +05:30
Parthvi12
b82ea06aa3
test: Adding visual tests for layout validation (#9857)
* Adding visual tests for layout validation

* updating screenshot to match CI's screenshot resolution

* updating screenshot as per CI

* setting failure threshold for the image comparision

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2021-12-24 17:47:22 +05:30
Paul Li
3d0be06ea1
fix: table filter popup is overlaid on modal (#8540)
* fix: Table widget's filter pop-up does not collapse on opening a modal

-- Dispatch an action for closing the table filter pane when a modal is opened

* fix: Table widget's filter pop-up does not collapse on opening a modal

-- Add the Cypress test case

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-24 18:02:40 +08:00
Ayangade Adeoluwa
45a5c38320
feat: Added tests for renaming entities through the entity explorer (#9867)
* Added tests for renaming entities through the entity explorer

* changes made to deletePageFromSideBar function

* adds custom made test cases config

* test cases should be within smoke test suite

* return configuration to run full test suite
2021-12-24 08:16:08 +01:00
Parthvi12
6cb4590f4f
Added testcases for statbox (#9684) 2021-12-24 09:17:43 +05:30
Bhavin K
244b089771
fix: added support for timePrecision (#9423) 2021-12-23 14:17:08 +00:00
balajisoundar
8d3e3fd88b
fix: remove allowed filetype restriction in filepickerwidget (#9921) 2021-12-23 18:46:57 +05:30
Anand Srinivasan
3a4658c8f5
fix: unexpected return error (#9432)
* assign undefined for empty scripts during evaluation

* add unit tests

* handle anonymous_function when undefined

* update unit tests

* remove unwanted assignments in evaluation scripts

* update unit tests

* Update app/client/src/workers/evaluate.test.ts

* fix lint cypress tests

* remove semicolon

* fix API_bugs_spec

* undo anonymous function change

* Update app/client/src/workers/evaluate.ts

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* add comment

* return back when JS is empty

* Update app/client/src/workers/evaluate.ts

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-21 20:00:19 +05:30
Keyur Paralkar
848bc13bc3
fix: corrected Index cond. for conditional formatting in table widget (#9735)
* fix: corrected Index cond. for conditional formatting in table widget

* test: added integration test for checking condtional formating post sorting

* refactor: enhanced the originalIndex condition with nullish coalescing op
2021-12-21 15:25:12 +05:30
Aishwarya-U-R
13f24cbce8
test: Automated tests for Rest Api, S3 Bugs and flakiness fixes (#9695) 2021-12-21 15:07:30 +05:30
NandanAnantharamu
d8e41b4b5c
test: updated org test (#9868) 2021-12-21 13:38:10 +05:30
Parthvi12
293ddc3ea1
adding test cases for undo/redo (#9742) 2021-12-21 10:44:58 +05:30
Arpit Mohan
96677ef673
fix: Updating log4j to 2.17.0 to prevent JNDI lookups (#9863)
Also making minor edit to not show "Application name updated" toast message. This is a counter-productive toast that is distracting the user
2021-12-20 16:01:08 +05:30
arunvjn
99a12be018
feat: add option to delete org (#9287)
Co-authored-by: Nayan <nayan@appsmith.com>
2021-12-20 05:58:01 +00:00
balajisoundar
3c1edbeb3a
feat: Admin settings page to tinker with env variables (#9687) 2021-12-16 19:47:16 +05:30
Ayangade Adeoluwa
7af727651d
fix: Assigns query Params in Datasource and Api query editor (#9184)
* adds option to assign query params in datasource and see those params in apieditor

* fix flaky cypress tests

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:38 +05:30
NandanAnantharamu
4fa39d924d
test: TableWidget bugs (#9795)
* Added tests for Table widget bugs

* typo in test corrected

* Updated a flaky test
2021-12-16 14:52:14 +05:30
Tolulope Adetula
7e3529f60b
fix: selected option value from select widget (#9796)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

* fix: selectedOptionValue

* revert : test case

* fix: tests

* fix: add test cases

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 08:36:26 +01:00
Keyur Paralkar
3a1c2b0799
fix: removed -1 and 2d array population error in the selectedRowIndices (#9606)
* fix: removed -1 and 2d array population error in the selectedRowIndices

* test: init integration test for bug fix

* test: completed the integration tests for bug fixes

* test: added unit test for edge case in propertyUtils

* refactor: removed unused import

* feat: added selectedRowIndices as an option in the autocomplete

* fix: fixed table widget test cases
2021-12-15 17:44:50 +05:30
Aman Agarwal
d05b2d5b56
fix: Correcting the run button loading state on cancel in API pane (#9094)
* fix(run-button-loading): the run button loading state changed on cancel

* fix(run-button-loading): added test case for run button loading status
2021-12-14 12:37:42 +00:00
Aswath K
a2902b5235
fix: table color picker issue (#9681)
* fix: deleting color in color picker causes default color to set automatically

* Set default color property for newly added columns

* Add cypress tests

* fix issue for Label color

* fix: test issue
2021-12-14 07:55:05 +00:00
Rishabh Rathod
4838b7e73e
Revert "fix: Select widget Value (#9444)" (#9744)
This reverts commit af08547529.
2021-12-14 11:19:54 +05:30
NandanAnantharamu
990ec76c4b
test: Added test for select Widget (#9600)
* Added test for select Widget

* updated common locators
2021-12-13 11:14:01 +05:30
Aishwarya-U-R
fd0f258699
test: Automated tests for RestApi, S3 Bugs (#9539)
* Supressing console.log

* Bugs 5550, 8684 scripted

* Bugs # 9425, # 4775 + S3 failure fix

* S3 failure fixes

* Postgress Delete Ds correted

* Bug # 9334 - Implemented

* onlyQueryRun reverted

* testSaveDatasource reverted

* Mongo Aggregate case fix

* testSaveDatasource updated to test true & false
2021-12-10 12:53:12 +05:30
Paul Li
54579a4e6c
feat: Switch Group widget (#7590)
* Feat: Switch Group Widget

-- The first MVP of the widget

* feat: Switch Group Widget

-- Follow the same config and implementation as the other group widgets

* feat: Switch Group Widget

-- Elaborate the help text for defaultSelectedValues

* feat: Switch Group Widget

-- Add a widget icon

* feat: Switch Group Widget

-- Remove unnecessary property control at ItemsControl.tsx
-- Refactor some code snippets for higher code quality
-- Add basic cypress test cases

* fix: icon for the widget optimised & replaced

* feat: Switch Group Widget

-- Add a unit test for defaultSelectedValuesValidation

* feat: Switch Group Widget

-- Make the validation type for defaultSelectedValues property to ValidationTypes.ARRAY
-- Remove original validation function and its unit test

* feat: Switch Group Widget

-- Fix on typo
-- Fix on formatting issue
-- Change the help text for isRequired property

* feat: Switch Group Widget

-- Revert help text for isRequired property to the original one

* feat: Switch Group Widget

-- Set strict property to true on defaultSelectedValues

* feat: Switch group widget

-- Refactor utility function, getCamelCaseString
-- Add the corresponding test case

* feat: Switch group widget

-- Implement options property as a plain JS field
-- Reimplement update logic for selectedValues when options changes
-- Add a new utility function for checking equality of object arrays
-- Add a unit test for the above function
-- Rewrite the corresponding Cypress test cases

* feat: Switch Group Widget

-- Remove isArrayEqual utility function and directly use functions from lodash

* feat: Swtich Group Widget

-- Make selectedValues as a derived property

* feat: Switch Group Widget

-- Replace the widget icon

* feat: Switch Group Widget

-- Rewrite a test case for onSelectionChange property

* feat: Switch Group Widget

-- Remove redundant calls for openPropertyPane

* feat: Switch Group Widget

-- Remove closePropertyPane call from afterEach hook

* feat: Switch Group Widget

-- Change the selector for every switch element in onSelectionChange test case

* feat: Switch Group Widget

-- Fix on failed Cypress test case, adding closePropertyPane command to onSelectionChange

* feat: Switch Group Widget

-- Remove template literal from a selector

* feat: Switch Group Widget

-- Make click on onSelectionChange test case forced

* feat: Switch Group Widget

-- Fix on crash issue when editing on Options property

* feat: Switch Group Widget

-- Add the widget icon to show in entity explorer

* feat: Switch Group Widget

-- Fix on blue color on mouse down
-- Add a new property for alignment

Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2021-12-09 20:02:47 +08:00
Tolulope Adetula
4829820e86
fix: add enableClientSideSearch (#9505)
* fix: add enableClientSideSearch

* fix: add test

* fix: refactor function

* fix: filter issue

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-08 22:35:27 -08:00
Aswath K
177df5cc68
fix: table icon selector js mode toggle issue (#9396)
* fix: ARRAY validation with allowedValues

* Adds TABLE_PROPERTY validation

* Add test

* fix: Table icon JS mode toggle issue

* remove unused variable

* Make use of constant for icon

* Adds comment

* better validation

* fix: failed cypress test

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 11:45:59 +05:30
Tolulope Adetula
af08547529
fix: Select widget Value (#9444)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-08 11:14:53 -08:00
Vicky Bansal
3ac913a12c
feat: Row selection in Table widget using Primary Column (#8156) 2021-12-08 19:36:14 +05:30
Bhavin K
4889098888
fix: added placement support in button, button group, and menu widget (#9354) 2021-12-08 13:11:13 +00:00
balajisoundar
ef488f1f7a
fix: Empty column name check before computing dynamicBindingPathList in Table widget (#9466) 2021-12-08 11:24:31 +05:30
arunvjn
f62247b468
feat: Action undo redo (#9045) 2021-12-07 09:45:18 +00:00