Commit Graph

387 Commits

Author SHA1 Message Date
Nikhil Nandagopal
d9bc97cf39 Merge branch 'release' into fix/filepicker 2021-02-04 19:25:33 +05:30
Nikhil Nandagopal
6f779b215c added a text property for the file as well 2021-02-04 16:45:00 +05:30
Rishabh Saxena
c72833b53b
Add an option to set reset the input widget's value on submit (#2837) 2021-02-04 11:21:16 +05:30
Nikhil Nandagopal
8c5213b6fd
Merge pull request #2851 from appsmithorg/fix/docs-link
Fix/docs link
2021-02-03 21:31:33 +05:30
Nikhil Nandagopal
486a9da8dd updated all doc links 2021-02-03 20:45:16 +05:30
Vicky Bansal
42289173b1
Fix: Date widget crash due to invalid date in date picker (#2845)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-03 17:00:19 +05:30
Nikhil Nandagopal
f2045b5435 added file name to file picker and fixed a crash 2021-02-03 14:46:44 +05:30
Vicky Bansal
11f5687b38
Date picker validation fixed (#2789)
* Date picker validation fixed

* Added date value check to remove unncessary validations

Commented defaultDate validation test as invalid date cannot be saved in date control

* Fixed date selection on user change

Fixed min and max date parsing for date picker control default date

* Added validation for min and max date in validations to handle validations when field is converted to JS
2021-02-02 20:12:49 +05:30
Rishabh Saxena
b8bcac8544
add support for an onSubmit action for the input widget (#2749) 2021-01-28 16:45:14 +05:30
Vicky Bansal
5406cbee9e
Fix: Update map initial location after creating a new marker (#2736) 2021-01-27 12:25:43 +05:30
Vicky Bansal
e34a98833c
Trigger onPageSizeChange action when table page size changes (#2737) 2021-01-27 11:10:53 +05:30
vicky-primathon
63e286a469
Show row cursor as pointer when onRowSelected property is set in table widget (#2604) 2021-01-22 15:42:34 +05:30
vicky-primathon
c9cee45f51
Fix - Wrap contents of the table cell tooltip (#2629) 2021-01-22 15:19:02 +05:30
vicky-primathon
a9e0b5b678
Fix - selectedRow autocomplete suggestions when no row is selected (#2603) 2021-01-22 15:15:14 +05:30
vicky-primathon
154a4d30c9
Persist column sizes on resize in app viewer for the duration of the session (#2578) 2021-01-22 15:08:48 +05:30
Rishabh Saxena
8e459a0c6b
validate map center and markers (#2488) 2021-01-19 12:59:15 +05:30
Hetu Nandu
94cae231c1
Make sure Table selected row is not set to undefined on mount (#2518) 2021-01-12 11:45:08 +05:30
Piyush Mishra
148497a1bc
Refactor datasources and actions for stronger type checking (#2167) 2021-01-12 09:47:28 +05:30
Piyush Mishra
1521f7445c
Fix eslint warnings (#2510) 2021-01-12 06:52:31 +05:30
Hetu Nandu
4387200262
Sub tree evaluation (#1841)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Piyush Mishra <piyush@codeitout.com>
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Akash N <akash@codemonk.in>
2021-01-04 15:46:08 +05:30
Rishabh Saxena
611186c4b2
set min pageSize for table widget (#2362) 2020-12-30 18:32:46 +05:30
Piyush Mishra
806a139ddb
Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
Rishabh Saxena
fb7ae53002
set the first tab as selected when the selected tab is not found (#2231) 2020-12-23 16:59:34 +05:30
vicky-primathon
6b6e302ee1
Fix Table data validation issues (#2297) 2020-12-23 09:47:13 +05:30
vicky-primathon
bf5693f907
Reset table selected row when table data changes (#2307) 2020-12-23 09:28:23 +05:30
vicky-primathon
567f3a16fb
Fixed accessing length property of undefined selectedRowIndices (#2293)
* Fixed accessing length property of undefined selectedRowIndices

* Added getting selectedRowIndices when multiRowSelection is true
2020-12-22 08:27:57 +05:30
Piyush Mishra
9f0cc2f4bb
Wrap Query Table in ErrorBoundary (#2274) 2020-12-21 11:44:50 +05:30
vicky-primathon
a6f602c33e
Fixed conversation of Unix timestamp in milliseconds (#2251) 2020-12-18 12:52:49 +05:30
Pawan Kumar
ffc6c91150
Fix: Input Widget Regex validation not working as expected (#2165)
* add check for custom regex when input is number

* add test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-15 10:34:30 +05:30
vicky-primathon
b917f71678
Added undefined check on selectedRowIndices property before checking its length (#2163) 2020-12-14 11:49:39 +05:30
Piyush Mishra
2b4e25b04a
default to empty array on usage (#2074) 2020-12-10 11:25:12 +05:30
Pawan Kumar
91127ed719
Fix: FilePicker widget was not setting loading state to true on calling action (#1985)
* set loading state on calling action in file picker

* add test cases for file picker loading state

* add tests cases

* add isLoading state in state instead meta

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-03 11:02:50 +05:30
Hetu Nandu
6a7403d88e
Store tabs name data as array instead of string (#1676) 2020-12-02 18:23:51 +05:30
Piyush Mishra
400fd8007f
Make sure google is available before loading components that rely on it (#1934) 2020-11-30 12:53:05 +05:30
Pawan Kumar
9997f2cb9f
Feature: Min and Max date inputs to restrict range in Datepicker Widget (#1865)
* add daterange property control

* fix typescript errors

* update daterangepicker control

* remove daterangepicker control

* add toasts for invalid dates + add test cases

* update test cases

* update test cases

* update test cases + change validation type name + few refactor

* merge release + update toast usage in datepicker control

* update test cases

* update form dsl for test cases

* update test cases

* update setDate command in test cases

* update test cases

* update test case dsl for datepicker widget

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-27 14:18:38 +05:30
Pawan Kumar
7a7fb4547f
Fix: isRequired validation of checkbox widget (#1884)
* fix checkbox required issue

* add test case

* update error styling for checkbox

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-26 16:51:23 +05:30
Nikhil Nandagopal
c77c43cfee
Merge pull request #1892 from appsmithorg/fix/tabs-selectedTab
Fix selectedTab binding issue
2020-11-24 19:06:10 +05:30
Abhinav Jha
bddc79aee8 Fix selectedTab binding issue 2020-11-24 18:20:08 +05:30
Piyush Mishra
03f97c0323
Fix: Maps widget crash on wrong initial location datatype (#1854) 2020-11-24 14:13:45 +05:30
vicky-primathon
3b85cc8222
Added defaultSelectedRow property in table widget so that users can configure default selected row(s) (#1684)
* Added defaultSelectedRow property in table widget so that users can configure default selected rows

* Cypress test cases added to test default row selection in table widget

* Fix defualtSelectedRow property's evaluation type

* Fix default select row type

* Set default selected row when resetting user selected rows

* Use defaultSelectedRow when no user selected row in table
2020-11-20 13:13:39 +05:30
Hetu Nandu
37c2246e22
[Enhancement] Update DSL structures to allow for nested dynamic paths (#1625)
Implements #1575
2020-11-12 16:53:32 +05:30
Hetu Nandu
3a84af82ed
Fix critical issues (#1686)
Fixes #1683
Fix for dropdowns with option not being an object crashes dropdown and stops eval
Fixes #1656 #1657
Fix issue where updateWidgetProperty would get called without a widgetId
2020-11-11 17:02:14 +05:30
Hetu Nandu
a52c5df987 Fix form widget eval loops for arrays 2020-11-10 13:23:18 +05:30
vicky-primathon
fd12e907af
Map not resetting to location selected fix. Location map to search location. (#1619) 2020-11-06 20:39:35 +05:30
vicky-primathon
54a6ca0850
Fix/table widget pagination changes (#1298) 2020-11-06 16:45:47 +05:30
Abhinav Jha
e14f23c31d
Handle null regex parts in input widget regex function (#1569) 2020-11-04 19:49:46 +05:30
Abhinav Jha
1747390183
Fix: All canvas widgets should have no container styling applied (#1564) 2020-11-04 18:58:21 +05:30
Abhinav Jha
120c2da507
Fix: Tabs Widget (#1532)
* Fix issue where placing widgets into the first tab of a tabs widget was disallowed.

* Concatenate using spread instead of produce

* Remove widget blueprint from widget props

* Deal with nested blueprint
2020-11-03 18:32:50 +05:30
vicky-primathon
1c4adf84a1
Fix/multi select dropdown (#1295)
* Cypress test locator fix

* Multi select dropdown values initialization fixed

* Reverted test case selector change

* Using lodash isEqual since values can be object
2020-11-03 10:49:27 +05:30
satbir121
540f2637b5
Adding zoom on image widget. (#1356)
* Adding zoom on image widget.

* Changing zoom level to step.

* Fixed typescript issue.

* Added zoom-in/out on Click.

* Removing bad code.
2020-10-29 16:44:39 +05:30
vicky-primathon
aa9bc58a90
Fix/map crash (#1301)
* Adding default map center to fix map crash issue

* API key removed
2020-10-26 15:31:01 +05:30
Hetu Nandu
a16372fed1
Fix Dropdown widget selection (#1340) 2020-10-22 01:15:02 +05:30
Hetu Nandu
655b160922
Web worker evaluation (#706)
- Adds Web workers and does evaluations in off the main thread
- Removes any need to store functions in the data tree and only keeps them around while evaluating
- Maintains a stored data tree in the redux state
- Evaluates based on editor events instead of state changes
2020-10-21 09:55:32 +05:30
Shrikant Sharat Kandula
920b38da90
Resolve conflict with master (#1246)
* added code to not identify anonymous users

* minor fix

* added alias for users so that segment works with mixpanel

* removed alias since we enabled identity merge for mixpanel

* added fix to not send anonymous user

* Add first_login event for analytics (#1184)

* Don't send full object to analytics (#1186)

* added binary raw data to be set for files picked (#1211)

* added binary raw data to be set for files picked

* spread options before modifying to maintain immutability

* Add isFromInvite field to create_USER event (#1223)

* Adding dummy commit to trigger build

* added extra information to execute action call (#1244)

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2020-10-19 16:36:44 +05:30
Abhinav Jha
76ae0103bf
Upgrade npm packages (#1079)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-10-12 18:36:05 +05:30
satbir121
8bf80fe507
Google Recaptcha integration for button and form button widgets. (#1118)
* Adding base code for google re-captcha.

* Removing recaptcha as well

* Adding recaptchaToken on Button.

* Fixing updateMetaProperty errors.

* Handling recaptcha generation failed case.

* Adding a message for recaptcha token gen fail

* Rename setRecaptchaToken

* Adding loading state for recaptcha button

* Adding googleRecaptchaKey as a Btn prop

* Adding the bound functions in widgets

* Removing unused vars.

* Handling google recaptcha key error.

* Adding proper messages for
2020-10-12 18:31:19 +05:30
Hetu Nandu
9ac935c424
Fix release cleanup issues (#1132) 2020-10-11 19:02:02 +05:30
dodococo
17028a3f86
Input Widget: Parse regexp before regex validation (#884)
Fixes #697
2020-10-07 12:03:53 +05:30
Hetu Nandu
bf2b4efbfd
Fix for action execution (#1023) 2020-10-06 22:17:16 +05:30
Hetu Nandu
8b75e1c8f4
Local meta state in widgets (#851) 2020-10-06 14:31:51 +05:30
Ajay Kumar
9fce3912ea
Fix image widget not showing default image when image property is invalid (#882)
Fixes: #760
2020-10-06 12:06:57 +05:30
Hetu Nandu
858db968f6
Fix issue with radio widget crashing (#922)
* fix types

* Options Validaor checks for empty values

Fixes: #662

Co-authored-by: Sanchit Jain <171220040@nitdelhi.ac.in>
2020-10-05 12:57:44 +05:30
MartinT
58b759bd6a
fix: input widget number validation #768 (#917) 2020-10-05 12:36:24 +05:30
Nicholas
052bd2a5e3
Fix triggering of onChange when value is the same (#892)
Fixes: #710
2020-10-03 15:22:59 +05:30
satbir121
53c616b747
Video URL and Auto Play labels changed. Removed onStart. (#793)
* Removing onStart

* Changing auto play and url label
2020-09-29 15:30:55 +05:30
satbir121
15f84203c7
Video widget (#684)
* Working version of video player.

* Adding default video url

* Reducing the default widget of video widget

* Fixed tests

* Adding video icon.

* Removing commented code.

* Adding playState, onPause, onStart, onEnd.

* Adding onPlay event.

* Fixing onPlay

* Adding isVisible field.

* Changing video icon.

* Fixing Popover table video.

* Adding an error message for no url.
2020-09-26 18:29:33 +05:30
Satbir Singh
d444b2e169 Adding onClick property for image widget. 2020-09-18 15:42:57 +05:30
Abhinav Jha
0b87c7431b
Fix issue where tabs are lost when the user enters an invalid tabs value (#569) 2020-09-18 10:52:54 +05:30
Abhinav Jha
436f190555
Feature: Widgets: Cut-Copy-Paste-Delete shortcuts, undo-delete facility (#500) 2020-09-16 15:58:01 +05:30
Nikhil Nandagopal
4995706679
Fix chart data evaluation (#548)
* changed chart data to behave as an array <str, str> and not use json stringify to update
added a generic logic to flag all objects with internal bindings as dynamic
moved unescape to only handle at the time of eval and removed new lines before eval

* added a migration for older charts that have their data as strings

* flagged column actions as an action trigger to avoid evaluating it

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-09-15 22:24:15 +05:30
Hetu Nandu
f09b717b38
Retry dynamic import and lazy promises (#543) 2020-09-15 12:29:58 +05:30
Nikhil Nandagopal
c0fcdef4b6 Merge branch 'master' into release 2020-09-11 17:08:15 +05:30
vicky-primathon
2cb7c7be97
Reset selected rows when table data is modified (#536) 2020-09-11 17:07:33 +05:30
vicky-primathon
e343f9deaa
Table Widget: Date column type: user defined input and display format (#409) 2020-09-11 16:10:15 +05:30
Nikhil Nandagopal
02c3c199ac deprecated selectedOptionValueArr 2020-09-10 12:51:44 +05:30
Hetu Nandu
96643507ec
Merge branch 'master' into release 2020-09-09 12:55:21 +05:30
vicky-primathon
fb34609c89
selectedRowIndexes changed to selectedRowIndices (#516)
Data type of selectedRowIndices changed to array of numbers
2020-09-09 12:42:15 +05:30
vicky-primathon
da9274de10 Feature: Table Widget - multi row selection (#507) 2020-09-09 11:16:06 +05:30
vicky-primathon
f7931701d8
Feature: Table Widget - multi row selection (#507) 2020-09-08 18:34:51 +05:30
Nikhil Nandagopal
0b22fc67b3
Updated sentry sdk (#461)
Integrated react router for better performance reporting
Added Sentry Profiler for editor, appviewer and widgets

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-08-28 22:53:07 +05:30
vicky-primathon
8a0805d77f
Fix: Table widget actions header scrollbar padding (#353)
* Table header scrollbar padding removed. 
* Table row font size changed based on compact mode.
2020-08-28 15:25:20 +05:30
vicky-primathon
a8e6b268ab
Setting table widget filteredTableData after reset. (#425) 2020-08-26 11:11:18 +05:30
satbir121
bccef563c4
Alignment of icon button is to right (#372) 2020-08-24 11:12:19 +05:30
Hetu Nandu
a2b1d3442f
Table widget selected row initial value fix (#401)
* Set initial value as empty object

* log debug
2020-08-21 22:13:02 +05:30
vicky-primathon
17af152148
Table Widget: Filter updates (#355)
- Show symbol signifying selected filters in table widget
- Show callout to prompt users to change column data types for accurate filter operations
2020-08-20 15:00:19 +05:30
vicky-primathon
222ba74996
Table widget initializing selectedRow value to show up in autocomplete (#359) 2020-08-20 12:09:16 +05:30
vicky-primathon
714d107a71
Table column sorting changes (#360)
- Sort icon correction
- Allow users to remove sorting
2020-08-20 12:08:16 +05:30
Hetu Nandu
590afa7a30
Fix query response state (#348) 2020-08-19 10:07:20 +05:30
vicky-primathon
33cd1ac1d9
Fix-table filtered data calculations (#342)
* Update table widget's filtered data calculations to avoid recursive dataTree evaluations

* Stringify removed from Table component as data is already checked inside TableWidget

* Vertical scrollbar removed from Table Widget. Stop column sorting by stopping event propagation when clicking column menu icon.

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2020-08-18 17:00:26 +05:30
Hetu Nandu
bb369e6bdf
Fix overflowing multi select widget (#320)
Co-authored-by: Akash N <akash@codemonk.in>
2020-08-18 13:11:53 +05:30
akash-codemonk
664d55053d
Add email validation for email input (#276)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-08-17 19:53:57 +05:30
Abhinav Jha
28e3831862
Fix: Jump issue of APIPane fields (#330) 2020-08-17 15:13:25 +05:30
vicky-primathon
cf91361637
Fix: table compact mode to persist and saved from canvas editor (#316)
* Table widget compact mode to persist after reload

* Table widget compact mode to be saved from canvas editor
2020-08-17 13:03:37 +05:30
vicky-primathon
b7815006a1
Fix: selection of correct table row data after sort, search and filter (#315)
* Table fix sort, search and filter methods to set correct selectedRow after these methods are applied

* Filtering table data with the latest filters, to correctly select the row

* Setting initial filteredTableData value

* Updating filteredTableData when tableData is updated
2020-08-17 13:01:17 +05:30
vicky-primathon
02a2d8e0a3
Fix-table widget compact mode row height (#285)
* Table column header made sticky. Scrollbar background changed to be in consistent with the background for table body scroll and table header scroll

* Row height changed for short compact mode

* New "Tall" row size
2020-08-13 22:11:08 +05:30
Abhinav Jha
2cb5e4442b
Tab Widget Fixes (#293)
* Issue: Tabs widget's child canvas widget's minHeight is not updating

* Fix: Warning removed for unused onTabChange event handler by removing event handler from props passed to ScrollableCanvasWrapper

* Removed tab container not working as droppable component if added again with same name fixed

* Selecting first tab as default tab when no tab is selected in tabs widget. Used getNextEntityName funciton to generate new tab name
2020-08-13 13:38:16 +05:30
vicky-primathon
e1676beba2
Table filters to be accessible in publish mode (#273)
Filters are only available on the client. This results in filters being available in published mode.
2020-08-13 13:26:10 +05:30
vicky-primathon
c0527a4816
Reset page number when searching in table widget (#274) 2020-08-12 10:52:19 +05:30
vicky-primathon
76bc382a2d
Table Widget UI Filters (#61)
New Table Widget Feature
- Filter columns
- Misc table widget bug fixes
2020-08-10 16:46:13 +05:30
vicky-primathon
6a53e1e0ed
Added compact modes to table widget UI (#222)
New Feature: Table Widget compact rows
Users can now use different sizes for rows in the table widget
2020-08-10 15:31:36 +05:30