Commit Graph

1754 Commits

Author SHA1 Message Date
Arpit Mohan
e96cbd30cd
ci: Adding fetch-depth 0 to chromatic Github workflow (#29371)
Full git history is required by the chromatic plugin to work properly &
publish the site. Hence adding `fetch-depth: 0` back into the Chromatic
workflow



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated GitHub Actions workflows to fetch the full Git history for
more accurate CI/CD operations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-06 14:07:28 +05:30
Aishwarya-U-R
7f4bbf848c
ci: Run server/client tests parallel to cypress in TestBuildPush (#29320)
## Description
- This PR makes changes to run the Client & Server unit tests in
parallel to Cypress for TBP workflow
- Removes invalid input restore-keys, adding cache-hit
- Remove save cache from /workflows/client-unit-tests.yml
- Making ci-test, client-unit-tests, server-unit-tests mandatory for
ci-test-result

#### Type of change
- Yml file update (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- TBP workflow run

## Checklist:
#### QA activity:
- [ ] Added `Test Plan Approved` label after workflow run & tests were
identified to run parallel to cypress


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Updated GitHub Actions workflows to use the latest version of
`actions/checkout`.
- Improved CI/CD pipeline by adding conditional job definitions for
server and client unit tests.
- Enhanced workflow logic to differentiate between pull request and
branch push triggers for more accurate code checkouts.
- Streamlined caching strategy by removing `restore-keys` configuration
for better dependency management during builds.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-06 13:13:04 +05:30
Shrikant Sharat Kandula
b41cbe86b8
ci: Disable extra logging during tests 2023-12-06 06:00:46 +05:30
Shrikant Sharat Kandula
1965fec54b
ci: Disable pipefail in version calculation for client-build 2023-12-05 20:32:14 +05:30
Shrikant Sharat Kandula
c03bfc1c64
ci: Add xtrace to client-build's version calc step 2023-12-05 20:12:56 +05:30
Shrikant Sharat Kandula
6a2d529d95
ci: Remove RTS' computation of snapshot version (#29333)
RTS is already getting the version from `info.json`.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Streamlined the build process by removing unnecessary versioning
steps.
- **Refactor**
  - Simplified the Docker image tagging process during builds.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-05 19:46:41 +05:30
Shrikant Sharat Kandula
160871bd31
ci: Fix version calculation in workflows (#29331)
This code is duplicated from generate_info_json.sh script, but that's
temporary. We'll be moving towards not having the version computation in
the workflows at all, and all components getting version information
from `info.json` alone. Essentially treating `info.json` as the source
of truth for this.
2023-12-05 18:50:50 +05:30
Trisha Anand
c1a7afe688
fix: Fixing client-build yaml file for yaml syntax error (#29315)
> Pull Request Template
>
> Use this template to quickly create a well written pull request.
Delete all quotes before creating the pull request.
>
## Description
> Add a TL;DR when description is extra long (helps content team)
>
> Please include a summary of the changes and which issue has been
fixed. Please also include relevant motivation
> and context. List any dependencies that are required for this change
>
> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
>
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Adjusted indentation in the build workflow for improved readability
and consistency.

- **Documentation**
  - No alterations to exported entities' declarations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2023-12-05 15:01:29 +05:30
Arpit Mohan
2650ea161d
ci: Updating actions/checkout to v4 and defaulting to fetch-depth 1 instead of 0 (#29281)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated GitHub Actions workflows to use `actions/checkout@v4` for
improved performance and reliability.
- Removed `fetch-depth` parameter to simplify checkout steps across
various workflows.
  - Standardized quote usage for consistency in workflow files.

- **Documentation**
- Adjusted formatting and descriptions in workflow files for better
clarity and readability.

- **Refactor**
- Aligned multiple workflow files to follow a consistent structure and
naming convention.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

fetch-depth 0 causes the Github workflow to checkout the entire Git
history. This is not required. We only need to check out the head of the
commit. By default, actions/checkout has fetch-depth=1, hence removing
it from the workflow completely for simplicity.
2023-12-05 13:44:43 +05:30
Arpit Mohan
8c132c780f
ci: Cleaning up CI workflows from warnings and unnecessary logs (#29280)
## Summary by CodeRabbit

- **Chores**
- Updated `umani/changed-files` action to v4.1.0 across various workflow
files.
- Updated `peter-evans/create-or-update-comment` action to v3 in
multiple workflow files.
  - Minor adjustments to workflow syntax for consistency and accuracy.

- **Documentation**
  - Corrected URLs in Slack notification messages to ensure accuracy.

- **Refactor**
- Removed redundant job configurations and steps related to caching and
storing run results.
- Streamlined environment variable usage by sourcing values from
secrets.

- **Style**
- Standardized quote usage in workflow files for file matching patterns.

- **Bug Fixes**
- Fixed URLs in echo statements within `test-build-docker-image.yml` to
point to the correct "cypress-dashboard" path segment.
- Updated `slack_color` and `slack_icon` values to better reflect
success and failure states in notifications.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-03 14:53:15 +05:30
Arpit Mohan
58c62e0bbc
ci: Removing set-output in CI workflows as it's a deprecated command. (#29279)
Using GITHUB_OUTPUT to save environment variables instead. This is to
remove lots of warnings in the CI run and make it easier to read the
summary.
2023-12-03 12:46:56 +05:30
Arpit Mohan
08f625e754
ci: Modifying the CI workflows for ok-to-test to leverage Cypress tags (#28944)
## Description
If the user types `ok-to-test tags=Git`, Cypress should only run the
specs marked with the Git tag

Related to #28943

#### Type of change
- New feature (non-breaking change which adds functionality)

## Testing

#### How Has This Been Tested?
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress

#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-12-01 23:13:15 +05:30
Goutham Pratapa
32b56423e1
revert gh runner to selfhosted runner (#29224) 2023-11-30 10:18:10 +05:30
Shrikant Sharat Kandula
a958a3823f
ci: Revert RTS build to default runner again 2023-11-28 14:12:45 +05:30
Goutham Pratapa
21e1117dba
Move rts build to selfhosted github actions (#29126) 2023-11-27 12:25:30 +05:30
Goutham Pratapa
e5429a8327
Update rts-build-selfhost.yml 2023-11-27 12:16:56 +05:30
Goutham Pratapa
b2af42a293
Update rts-build-selfhost.yml (#29125) 2023-11-27 12:15:17 +05:30
Goutham Pratapa
1317da164e
Update rts-build-selfhost.yml 2023-11-27 12:10:04 +05:30
Goutham Pratapa
8c6a781f64
Update rts-build-selfhost.yml (#29124) 2023-11-27 12:08:33 +05:30
Goutham Pratapa
d1bd880261
Update rts-build-selfhost.yml (#29122) 2023-11-27 11:54:47 +05:30
Goutham Pratapa
9d5f393ea5
Update rts-build-selfhost.yml 2023-11-27 11:52:41 +05:30
Goutham Pratapa
b0b8ef4667
Create rts-build-selfhost.yml (#29120) 2023-11-27 11:48:37 +05:30
Shrikant Sharat Kandula
1920d4c24c
ci: Revert RTS build to use GitHub runner 2023-11-27 09:17:44 +05:30
Shrikant Sharat Kandula
38ffbedb3a
ci: Don't overwrite RTS version, if using info.json 2023-11-26 13:21:11 +05:30
Goutham Pratapa
52a954acea
move rts build from github to self-host runners (#29099) 2023-11-24 16:56:24 +05:30
Nikhil Nandagopal
e3509a9578 Updated Label Config 2023-11-24 16:51:16 +05:30
yatinappsmith
59023009d7
ci: Add retry for JUnit failures in the CI workflow (#29048)
## Checklist:
#### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [X] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-11-23 16:44:57 +05:30
Nikhil Nandagopal
7cb3bca580 Updated Label Config 2023-11-23 15:53:35 +05:30
Nikhil Nandagopal
5964c8ee1c Updated Label Config 2023-11-23 10:56:19 +05:30
Nikhil Nandagopal
72ac81facf Updated Label Config 2023-11-23 10:55:54 +05:30
Nikhil Nandagopal
9ca73f1f18 Updated Label Config 2023-11-23 10:53:23 +05:30
Nikhil Nandagopal
ef630d68fa Updated Label Config 2023-11-23 10:53:02 +05:30
Aishwarya-U-R
84314baaf3
ci: Remove all extra slash commands yml (#29016)
## Description
- This PR removes extra slash ymls

#### Type of change
- Yml file update fix (non-breaking change which fixes an issue)

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-11-22 15:29:59 +05:30
Goutham Pratapa
dba56223f1
feat: skip-tests for rts (#29014) 2023-11-21 19:57:50 +05:30
Saroj
41cd80411f
ci: Skip flaky tests on demand (#28984)
## Description
- Skip flaky tests on demand

#### Type of change
- Dime defenders changes to accommodate the flaky spec skip on demand
- Workflow changes to control the skip flaky functionality
2023-11-21 19:08:28 +05:30
Goutham Pratapa
13134975e8
Update rts-build-self-host.yml (#28992) 2023-11-21 12:31:32 +05:30
Goutham Pratapa
5241a24eb9
test: self-hosted github runner (#28976)
Self-hosted runners:


![image](https://github.com/pratapaprasanna/appsmith/assets/15846947/5e10d428-8d4e-4d4a-819d-2b687596e8fd)
2023-11-21 12:21:01 +05:30
Abhijeet
67d7e773b9
chore: Add LaunchDarkly configs in CI run to mock feature flags (#28761)
Note: We have to create `LAUNCHDARKLY_BUSINESS_FLAGS_SERVER_KEY` secret
before merging this PR.
2023-11-16 13:00:56 +05:30
Nikhil Nandagopal
093a32770a Updated Label Config 2023-11-14 17:02:58 +05:30
Nikhil Nandagopal
70ed5519a7 Updated Label Config 2023-11-10 16:44:12 +05:30
Nikhil Nandagopal
9f72b64de2 Updated Label Config 2023-11-10 16:21:26 +05:30
Nikhil Nandagopal
b894a9a5a4 Updated Label Config 2023-11-10 16:20:41 +05:30
Nikhil Nandagopal
22045ef2b8 Updated Label Config 2023-11-10 14:37:53 +05:30
Nikhil Nandagopal
6e388d27cc Updated Label Config 2023-11-10 11:23:31 +05:30
Nikhil Nandagopal
b2bf3fa976 Updated Label Config 2023-11-10 11:23:10 +05:30
Nikhil Nandagopal
696ef3b219 Updated Label Config 2023-11-10 11:22:45 +05:30
Nikhil Nandagopal
2f86f60e13 Updated Label Config 2023-11-10 11:22:31 +05:30
Nikhil Nandagopal
3a504c2a3d Updated Label Config 2023-11-10 11:21:45 +05:30
Nikhil Nandagopal
66471ab270 Updated Label Config 2023-11-10 11:21:28 +05:30
Nikhil Nandagopal
ec2013ad47 Updated Label Config 2023-11-10 11:21:11 +05:30