Commit Graph

19467 Commits

Author SHA1 Message Date
Trisha Anand
eb72ece5e8
fix: Attempting fix of tenant deserialization error with forcing a serialUID to override the runtime value (#38836)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/test sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12947096482>
> Commit: 177e408c87c4a09920d599210c6f126955cd13e2
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12947096482&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 24 Jan 2025 10:15:44 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated serialization version control for the Tenant class to ensure
proper object deserialization in multi-pod deployments.
- Modified tenant retrieval method in the tenant service implementation
to potentially improve caching mechanism.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-24 16:16:37 +05:30
Rahul Barwal
be2133eda8
chore: remove deprecated feature flag for custom loading state in TableWidget (#38826) 2025-01-24 15:25:09 +05:30
Alex
efceb1e390
feat: editable dismissible tab component (#38788)
## Description
Addition of a template component that combines editable entity name and
dismissible tab.

Fixes #37649  

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12925482595>
> Commit: 23c8fbe877a2390ec95877ae8f761d7c590b23c7
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12925482595&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.Sanity
> Spec: 
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/OtherUIFeatures/GlobalSearch_spec.js</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.
> <hr>Thu, 23 Jan 2025 11:42:24 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced `DismissibleTab` component with interactive close and click
functionality.
- Added `EditableEntityName` component for editing entity names with
validation.
- Created `EditableDismissibleTab` component combining dismissible and
editable behaviors.
- Added new Storybook stories for `DismissibleTab`,
`EditableDismissibleTab`, and `EditableEntityName` components.

- **Improvements**
- Enhanced design system with new styled components for better
interactivity and appearance.

- **Refactoring**
	- Reorganized hook and component imports.
- Updated export statements in various files to improve module
accessibility.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-23 12:21:05 +00:00
Ashit Rath
72251cba2e
chore: Accept app mode param in fetch environment action (#38786)
## Description
Adds mode as a a param to the fetchingEnvironmentConfigs action to
handle the environment resolution on page load. The extended code is in
EE where this change is leveraged.

EE PR https://github.com/appsmithorg/appsmith-ee/pull/5977

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12926385771>
> Commit: 980841c6ae8a3d34f9ea23e0373d9e41813343c3
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12926385771&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 23 Jan 2025 10:53:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced environment configuration fetching with optional application
mode parameter
	- Improved workspace ID setting to include application mode context

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-23 16:58:44 +05:30
Vemparala Surya Vamsi
9c632b5a68
chore: merge updateActionData with an evaluation (#38793)
Whenever we have debounced updateActionData and an evalTree we will
merge that to a single evaluation. Seeing a 10-20% reduction in LCP, for
a configured customer app we are seeing the LCP reduce from 20-23
seconds to about 15-20 seconds.


## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12908010770>
> Commit: fc26db67fec9390b10e217706059278b7d4bb6a0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12908010770&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 22 Jan 2025 13:35:05 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
	- Enhanced test coverage for evaluation and action update processes.
- Added new test scenarios for evaluation loop and action data handling.
- Introduced a new test suite for `DataTreeEvaluator` focusing on
`actionsToUpdate`.

- **Refactor**
	- Improved evaluation saga logic with debounce mechanism.
	- Modularized action data update handling.
	- Refined evaluation tree update process.

- **Performance**
	- Optimized evaluation process to reduce unnecessary updates.
	- Introduced more efficient action data consolidation.
	- Enhanced handling of action data during evaluations.

- **New Features**
	- Added support for consolidated action data in evaluation processes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Diljit VJ <diljit@appsmith.com>
2025-01-23 15:17:47 +05:30
Rahul Barwal
0af11b9128
fix: when value of array is empty, no need for data type recalculation (#38794)
## Description
<ins>Problem</ins>
When we have a `select/multi-select` field type and the source data
gives empty array to the `JSONFormWidget`, the widget tries to gauge the
sub type for value inside the array, and since it is empty it got
`undefined`

This led to re-evaluation of property config for the field. 

<ins>Solution</ins>
- Added a check to prevent unnecessary recalculation of sub data types
when arrays are empty in `checkIfArrayAndSubDataTypeChanged`.

- Changed parameter type from `any` to `unknown` in `dataTypeFor` and
`subDataTypeFor` functions for improved type safety.

- Added and refactored unit tests.

This refactor enhances type safety and optimizes performance in the
schema parsing logic.

Fixes #37246  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.JSONForm"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12905055896>
> Commit: cad7015881c16a9af273b84dcf44cc33e32fb7d9
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12905055896&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JSONForm`
> Spec:
> <hr>Wed, 22 Jan 2025 09:50:23 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
	- Enhanced test suite for determining field types.
- Added comprehensive test cases covering primitive values, email
formats, date formats, array types, object types, and edge cases.

- **Refactor**
- Updated type annotations in schema parser functions to improve type
safety.
	- Changed parameter types from `any` to `unknown`.
	- Added clarifying comment for handling empty arrays in type checking.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-23 15:14:49 +05:30
Hetu Nandu
78718229da
chore: Remove style from editor and setting config (#38756) 2025-01-23 13:29:03 +05:30
Manish Kumar
928a00e9b1
chore: Removed setting of published theme while application import (#38806)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #38767 

> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Git, @tag.ImportExport"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12912937730>
> Commit: 0e9f7c2b12a4dc384ceedce1492170cd965fa13a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12912937730&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git, @tag.ImportExport`
> Spec:
> <hr>Wed, 22 Jan 2025 18:43:17 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Theme Management**
	- Simplified theme import and publishing logic
	- Removed handling of published mode themes during import process
	- Updated theme management to handle scenarios with null theme IDs

- **Bug Fixes**
	- Improved null handling for application and theme-related lists
- Ensured proper initialization of page and theme lists to prevent
potential exceptions

- **Testing**
	- Updated test assertions to reflect new theme management approach
- Adjusted expectations for published mode theme ID during application
imports

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-23 10:37:37 +05:30
sneha122
b14669e986
fix: ds structure issue fixed for zendesk integration (#38795)
## Description
This PR fixes the issue where for Saas integrations like zendesk, we do
not have a structure to be displayed, in that case we should show
appropriate error message.


Fixes #38736 
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12907027118>
> Commit: 5a9ef72ef41275bcd6303e311313758f0c24789d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12907027118&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 22 Jan 2025 12:24:10 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
	- Deprecated the previous method for retrieving datasource context.
- Updated the datasource context retrieval process to include plugin
information.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2025-01-22 19:51:23 +05:30
Rudraprasad Das
704e4735ad
chore: git api - adding new apis (#38681)
## Description
- Introduces new api contracts for git
- Adds feature flag `release_git_api_contracts_enabled`


Fixes https://github.com/appsmithorg/appsmith/issues/38500

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12810595516>
> Commit: 8f05bbfb0b9259c3ee40464099416b75688a4bd1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12810595516&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Thu, 16 Jan 2025 15:05:20 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
    - Introduced a new feature flag `release_git_api_contracts_enabled`
    - Added support for enhanced Git API contract handling

- **Improvements**
    - Updated type definitions for Git-related operations
    - Refined request and response handling for Git artifacts
    - Improved type safety for Git references and branches

- **Changes**
- Modified several Git-related request and saga functions to support new
API contracts
    - Updated artifact type enum values to use lowercase representations
    - Introduced new interfaces for Git references and branches

- **Technical Updates**
    - Added conditional logic for feature flag-based request processing
    - Restructured type definitions across multiple Git-related modules
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-21 11:19:18 +01:00
Rahul Barwal
16e121ce73
fix: Update ChartWidget fontFamily handling to respect system default (#38784) 2025-01-21 15:34:08 +05:30
Ankita Kinger
c223c5070d
chore: Refactoring usage of editorType to ideType to remove code duplication (#38778)
## Description

Refactoring usage of `editorType` to `ideType` to remove code
duplication

Fixes [#38286](https://github.com/appsmithorg/appsmith/issues/38286)
[#39289](https://github.com/appsmithorg/appsmith/issues/38289)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12878729200>
> Commit: dfe8f5c6d14c7d5aa4c377ad67516e01c26e2e5b
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12878729200&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 21 Jan 2025 06:50:04 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced a new IDE type context to replace the previous editor type
system
	- Enhanced type safety for IDE-related operations

- **Improvements**
	- Refactored editor type handling across multiple components
	- Updated utility functions to work with new IDE type
	- Simplified permission and context management

- **Code Quality**
	- Removed deprecated editor type hooks and constants
	- Standardized IDE type determination across the application
	- Improved import and module organization

- **Performance**
	- Streamlined type checking and context retrieval mechanisms

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-21 15:24:06 +05:30
devin-ai-integration[bot]
8e9db85eee
fix: Chart widget respects theme font (#38777)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
2025-01-21 12:14:36 +05:30
devin-ai-integration[bot]
d8de0f4c11
fix: Update button property text (#38758)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
2025-01-21 10:39:30 +05:30
albinAppsmith
2ca5993b18
fix: Stopped calling usage pulse in air-gapped instance (#38749)
## Description

This PR added fix for not triggering usage pulse for air gapped
instances


Fixes https://github.com/appsmithorg/cloud-services/issues/1883


## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12867501950>
> Commit: 2300d200cf4213edfc734c1a8b89b4ad797cdb64
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12867501950&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 20 Jan 2025 12:38:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Enhanced user activity tracking by introducing airgapped environment
detection, preventing unnecessary tracking in restricted network
settings.
- **Tests**
- Added a new test suite to verify the behavior of the user activity
tracking method in airgapped conditions, ensuring correct functionality
based on the airgapped status.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-20 23:23:26 +05:30
Valera Melnikov
0b830a58b4
chore: Increase max-old-space-size to 8192 (#38768)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2025-01-20 13:51:36 +05:30
Aman Agarwal
7a7ceed359
fix: edit datasource for External saas plugins (#38672) 2025-01-20 13:04:16 +05:30
Rahul Barwal
185fefcc26
refactor: remove deprecated table widget tests (#38733) 2025-01-20 10:23:06 +05:30
Sagar Khalasi
2a2e37a256
test: Api curl remaining cases (#38753)
## Description
New test cases

Fixes #
https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38478

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12850322339>
> Commit: 308c60ebadc1832fc407b2b6b8c0c7345a52b1c5
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12850322339&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Sun, 19 Jan 2025 09:01:49 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
- Added comprehensive Cypress end-to-end tests for API panel
functionality
	- Validated run button state with empty fields
	- Verified error handling for invalid URL inputs
	- Confirmed keyboard navigation for running API tests
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-19 21:00:51 +05:30
Sagar Khalasi
db75a6c0a5
fix: console log update and fix modal issue (#38692)
## Description
Fix the issue for modal and remove unwanted logs.


Fixes #
https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38729

## Automation

/ok-to-test tags="@tag.JS"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12843319044>
> Commit: 8cd4512993023ed476ed3a159893518c64acb2e1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12843319044&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JS`
> Spec:
> <hr>Sat, 18 Jan 2025 18:43:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Tests**
- Improved test reliability by adding page reload and modal visibility
checks in end-to-end testing.
- Increased timeout for sidebar visibility checks to accommodate varying
load times.
- Removed unnecessary console log statements to clean up test output
across various test cases.
- Verified download functionality with various scenarios, ensuring
appropriate error messages are displayed.
- Streamlined tests for local storage operations by removing debug
output.
- Cleaned up test output for show alert functions by removing debug log
statements.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-19 09:25:04 +05:30
NandanAnantharamu
fd7219706f
test: adding test for page functionality (#38538)
/ok-to-test tags="@tag.Sanity"



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12745705423>
> Commit: 88c823df3032a7fdf492e3a086d8be9daf03b062
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12745705423&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 13 Jan 2025 11:37:45 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
	- Added comprehensive end-to-end tests for page actions functionality.
- Introduced new test coverage for page management operations like
renaming, cloning, hiding, and setting home pages.

- **Tests**
- Created Cypress tests to verify page actions under different
scenarios.
- Updated test specifications to focus on partial import/export
functionality.

- **Improvements**
	- Enhanced modal opening methods with dynamic entity name support.
	- Added home icon locator for improved test reliability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>
2025-01-18 20:26:42 +05:30
Ashit Rath
86bddaaa43
fix: JSObject diff error when actions are missing (#38572)
## Description
This PR fixes 2 issues
<em>Issue 1<em> - No function available in the dropdown of a valid JS
Module in JS Module editor
Due to some reason the actions property in the JSObject is missing
instead of being `[]`, due to this when the check is done for getting
the diff `const preExisted = jsAction.actions.find((js) => js.name ===
action.name);` the `.find` is on an `undefined` value. The actual reason
of the `actions` to be missing is yet to be discovered but this is added
to add guard against such failures.

<em>Issue 2<em> - When a function is removed from a JSModule, a silent
error is thrown by the splice
`TypeError: Cannot delete property '0' of [object Array]`
The reason for this is that the jsObject are directly being mutated for
an object where the `writable` property is `false`.
Upon verifying the code block removed from line 145-155 has no use since
it just updates the jsActions object which neither is used by subsequent
code of the function nor the caller of this function.
Also splicing directly on redux selector data mutates the redux store
directly which is a bad practice.
So technically it's a piece of code that is unused, thus removing it
fixes the problem



Fixes https://github.com/appsmithorg/appsmith/issues/38683

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12802464049>
> Commit: 316f0aecfe19b1d1db80baf21fa16312ae5f883f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12802464049&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 16 Jan 2025 11:54:27 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved error handling in JS collection updates by ensuring proper
array initialization
- Enhanced action comparison logic to handle undefined action arrays
more gracefully

- **Refactor**
- Simplified action comparison and deletion process in JS collection
utilities

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-18 09:48:04 +05:30
Nikhil Nandagopal
19002c383a Updated Label Config 2025-01-17 16:56:43 +05:30
Hetu Nandu
5aeee41104
chore: Make Split screen feature GA (#38731) 2025-01-17 16:42:40 +05:30
devin-ai-integration[bot]
24a7fa5926
feat: update autocomplete sorting (#38690)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: rahul.kochar@appsmith.com <rahul.kochar@appsmith.com>
Co-authored-by: Hetu Nandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2025-01-17 16:30:52 +05:30
Valera Melnikov
41a5110c85
chore: disable sourcemaps for non-prod builds and cleanup craco configs (#38706)
## Description
- reduce --max-old-space-size to 7168 for build. [Test for EE
here](https://github.com/appsmithorg/appsmith-ee/pull/5932).
- disable sourcemaps for non-prod build
- cleanup craco configs

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12825105662>
> Commit: 80b63a627b312f486f0d0baccf8a7d98b810471d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12825105662&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.All
> Spec: 
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/Binding/Api_withPageload_Input_spec.js</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.
> <hr>Fri, 17 Jan 2025 09:34:32 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Configuration Updates**
	- Reduced memory allocation for the build process.
	- Updated Webpack configuration with Brotli compression.
	- Modified WebSocket settings for the development server.
	- Streamlined build configuration by removing unnecessary sections.

- **Performance Optimization**
	- Adjusted build memory limits.
	- Improved compression algorithm for build artifacts.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-17 12:35:34 +03:00
Rahul Barwal
3e259b89f6
test: fixes failing recaptcha test bey updating key. (#38684) 2025-01-17 13:30:22 +05:30
devin-ai-integration[bot]
36cc21a4e3
feat: expose --appsmith-theme-fontFamily (#38700)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: nikhil@appsmith.com <nikhil@appsmith.com>
2025-01-17 13:27:31 +05:30
Arpit Mohan
42b8a564fe
ci: Pinning the server build runs to Ubuntu 22.04 because of Flapdoodle errors (#38723)
## Description
Flapdoodle, our Mongo embedded testing library throws errors when
running Junit tests on Ubuntu 24.04. This is because of a mismatch of
openssl version from Ubuntu 22.04 to Ubuntu 24.04. Hence pinning our CI
for server builds to Ubuntu 22.04 for now. Will issue a holistic fix
with Flapdoodle upgrade later.

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated GitHub Actions workflow configurations for server build and
integration tests
- Migrated workflow environments from `ubuntu-latest-8-cores` to
`ubuntu-22.04-8core`
	- Refined workflow logic for test execution and artifact management

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-17 11:43:37 +05:30
Hetu Nandu
1963a9a27d
chore: Move action redesign to GA (#38659) 2025-01-16 22:26:34 +05:30
Alex
5a98f55024
fix: suppress error toast for update notifications (#38709)
## Description
Prevents error toasts for errors designed to show update notification
toasts.

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12811573044>
> Commit: 444b42858eece8b8454283480e5b72d96aee4290
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12811573044&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 16 Jan 2025 15:41:29 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
	- Updated error handling mechanism for bad request errors
	- Refined version mismatch error processing

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-16 18:58:02 +03:00
Sagar Khalasi
56f968fb07
fix: Flaky test case fix (#38703)
## Description
Code improvement


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12808540560>
> Commit: a5bfdaf3c397f05bd73d66a0fe57a84b92a36944
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12808540560&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Settings`
> Spec:
> <hr>Thu, 16 Jan 2025 12:33:05 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated test cases for admin settings to improve interaction
reliability
	- Modified save button interaction and element visibility checks
- Updated test expectations for instance name changes in Enterprise
Edition

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-16 20:24:47 +05:30
devin-ai-integration[bot]
b3e5e431b2
feat: disabledWhenInvalid in ButtonGroupWidget (#38656)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
2025-01-16 17:23:35 +05:30
Hetu Nandu
4e7a2a013d
fix: Workflow query conversion (#38688) 2025-01-16 17:06:06 +05:30
Aparna Ramachandran
19a603af4e
CI: Changing cron timing - Update test-build-docker-image.yml (#38701)
Changed TBP to run at different times, and added a new one

## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2025-01-16 17:04:29 +05:30
Sagar Khalasi
eb8e0e398f
ci: Fix for ssh port 22 issue (#38697)
## Description
Workflow failure :
https://github.com/appsmithorg/appsmith/actions/runs/12804875642/job/35705873169


Fixes #
https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38698

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/12807366996>
> Commit: cc4baab222b9f0667cb9addb98ef3549b2650ecf
> Workflow: `PR Automation test suite`
> Tags: `@tag.Settings`
> Spec: ``
> <hr>Thu, 16 Jan 2025 10:54:57 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated GitHub Actions workflows to disable SSH socket service during
Docker container execution
- Ensures SSH service is stopped and prevented from automatically
restarting during CI tests

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-16 16:41:17 +05:30
Hetu Nandu
2b8ba77fec
fix: AI query not showing any bottom tabs (#38687) 2025-01-16 07:35:32 +00:00
Sagar Khalasi
71ff3ee2a7
chore: Improve code (#38622)
## Description
Minor improvement.


Fixes #
https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38320

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12745102566>
> Commit: 6fd0683846fddb03650527c09300b10d9bc29b41
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12745102566&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Settings`
> Spec:
> <hr>Mon, 13 Jan 2025 10:43:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
	- Enhanced Cypress end-to-end tests for Admin settings page
	- Added improved loading state and document readiness assertions
- Increased test robustness by ensuring stable application state before
interactions

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-15 22:43:18 +05:30
Aman Agarwal
b496e4ab21
fix: copy changes to the description and content of modal (#38637) 2025-01-15 16:17:27 +05:30
Hetu Nandu
446eb2b602
chore: Update mixpanel masking classname (#38661) 2025-01-15 16:03:07 +05:30
Hetu Nandu
329c797a60
chore: Fix theme CE change only in EE (#38657) 2025-01-15 09:20:09 +00:00
Sagar Khalasi
0106489346
ci: return true if command fails (#38662)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!WARNING]
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12783144157>
> Commit: 0a2d9705b729c8429e7c79cc52bef0d78a51f390
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12783144157&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.Settings
> Spec: 
> It seems like **no tests ran** 😔. We are not able to recognize it,
please check <a
href="https://github.com/appsmithorg/appsmith/actions/runs/12783144157"
target="_blank">workflow here</a>.
> <hr>Wed, 15 Jan 2025 07:01:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Documentation**
- Updated description for PR number input parameter in GitHub Actions
workflow configuration

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-15 12:31:41 +05:30
Sagar Khalasi
df5ef9be98
ci: Do not fail on image remove (#38660)
## Description
Fix : https://theappsmith.slack.com/archives/CGBPVEJ5C/p1736920490455829


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated Docker image build workflow to improve error handling when
removing Docker images.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-15 12:16:43 +05:30
Hetu Nandu
a23bcbf955
fix: Separate Plugin Entity from Action (#38582) 2025-01-15 11:29:32 +05:30
Rudraprasad Das
d7e30e7dc5
chore: fixes mergeviaremote_spec flakiness (#38635)
## Description
Fixes flakiness for merge via remote spec

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12765495211>
> Commit: 7f83e90fe136425136e3f497ba825449dec72ea4
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12765495211&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Tue, 14 Jan 2025 11:18:09 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Tests**
	- Updated Git synchronization test suite for merging changes
	- Modified test file to streamline page creation and merging process
	- Added new test path for Anvil Widgets tests
	- Removed commented test file path and related comment
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-14 13:56:46 +01:00
Hetu Nandu
357664f809
chore: Move IDE Sidebar into ADS (#38641) 2025-01-14 12:10:22 +00:00
Hetu Nandu
d5551aab2e
fix: [ADS] Entity Tree node overflow (#38651) 2025-01-14 17:03:31 +05:30
Hetu Nandu
e1b3b0df00
Revert "feat: Added focus ring for focus visible (#37700)" (#38650) 2025-01-14 16:44:52 +05:30
Rudraprasad Das
3ad06e215e
chore: git mod - minor fixes (#38634)
## Description
- Adds `isInitialized` state for git components
- Adds message to autocommit progressbar
- Adds proper loading state for merge dropdown

Fixes https://github.com/appsmithorg/appsmith/issues/38593
Fixes https://github.com/appsmithorg/appsmith/issues/38594

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12753560383>
> Commit: bd7a5814bd094717bc6bffb746418c3bbe682d55
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12753560383&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Mon, 13 Jan 2025 19:21:01 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
	- Added initialization tracking for Git-related components.
	- Enhanced Git editor initialization state management.
- Introduced new selectors for retrieving Git artifact initialization
states.

- **Bug Fixes**
	- Improved conditional rendering for Git quick actions.
	- Updated merge status tracking and display logic.

- **Refactor**
	- Introduced new hooks for Git artifact initialization.
	- Updated state management for Git-related UI components.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-14 11:58:10 +01:00
Ankita Kinger
d187854e40
chore: Replacing the entity group list component on state inspector and data side pane with new ADS component (#38621)
## Description

Replacing the entity group list component on state inspector and data
side pane with new ADS component

Fixes [#38290](https://github.com/appsmithorg/appsmith/issues/38290)

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12763738469>
> Commit: a4b717244604617d39fb1869d039899dd024c687
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12763738469&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Tue, 14 Jan 2025 09:50:48 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
  - Enhanced list item styling with configurable height.
  - Added support for dynamic item count in entity groups.
  - Improved icon rendering with customizable dimensions.
  - Introduced a new constant for default group list size.

- **Improvements**
  - Simplified rendering of grouped items in various components.
  - Refined type safety for boolean assignments.
  - Updated state management for entity groups.
  - Enhanced control over item visibility in modals and lists.

- **Technical Updates**
  - Introduced new data attributes for enhanced component interactions.
  - Modernized component rendering logic.
- Replaced custom styled list with a dedicated `EntityGroupsList`
component for better maintainability.
- Expanded story examples for the `ListItem` component to showcase
various configurations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-01-14 15:27:08 +05:30