## Description
We are implementing this to control Dependabot alerts and prevent
flagging of the TinyMCE library, which we are maintaining at version
6.8.3.
* Additionally, we have reverted the change that checks for TinyMCE
version updates in the pre-commit hook. Managing this within the
Dependabot configuration file is a better approach.
Fixes #`Issue Number`
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._
## Automation
/ok-to-test tags="@tag.Sanity"
### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢🟢🟢 All cypress tests have passed! 🎉🎉🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/14770091908>
> Commit: bc960270a70184b00bfee7789dd3ae3d0c2cf7b5
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14770091908&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 01 May 2025 05:43:58 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Added automated dependency update configuration to streamline npm
package management, with specific rules for update frequency, labeling,
and commit message formatting.
- **Refactor**
- Simplified pre-commit checks by removing restrictions related to
TinyMCE version changes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description
* In addition, added a check on the pre-commit hook to prevent anyone
from updating TinyMCE from 6. 8. 3 again.
Fixes #`Issue Number`
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._
## Automation
/ok-to-test tags="@tag.TextEditor"
### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢🟢🟢 All cypress tests have passed! 🎉🎉🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/14735650279>
> Commit: 2fb46c6675b18e735dca766083dd78469722ebb5
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14735650279&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.TextEditor`
> Spec:
> <hr>Tue, 29 Apr 2025 16:12:43 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Updated selectors for rich text editor elements to use the `title`
attribute instead of `aria-label`, improving compatibility with recent
changes.
- **Chores**
- Added a pre-commit check to prevent changes to the TinyMCE dependency
version in `package.json`.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description
This PR fixes failure in the CI build workflow. The workflow was failing
in `Put release build in cache` job. The workflow was failing because
while installing git lfs, there was a conflict with the newly added pre
push hook. git lfs also contains its pre push hooks which was
conflicting with our hooks. In this PR, I have configured the workflow
for git lfs pre push hooks to override appsmith pre push commit since
appsmith git hooks are not required during workflows.
Fixes #`Issue Number`
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._
## Automation
/ok-to-test tags=""
### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!CAUTION]
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Introduced a pre-push hook to ensure integrity by preventing
inadvertent pushes of certain files to the repository.
- **Improvements**
- Updated GitHub Actions workflow to enhance management of large files,
ensuring the latest configurations are applied before builds.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description
This change will remove applying spotless when compiling code and
instead will apply spotless in the precommit hook.
This will lead to faster build times and DX improvement as developer
need not to manually run spotless anymore.
Fixes https://github.com/appsmithorg/appsmith/issues/35056
## Automation
/test sanity
### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢🟢🟢 All cypress tests have passed! 🎉🎉🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10040567648>
> Commit: 587204979ba0cb9991a599969351aa48e69900c5
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10040567648&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 22 Jul 2024 12:41:36 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
## Summary by CodeRabbit
- **New Features**
- Improved the formatting application process for server files,
providing clearer feedback on success or failure.
- **Bug Fixes**
- Adjusted the build process to ensure a more streamlined execution of
plugin goals.
- **Chores**
- Enhanced messaging and readability in scripts for better user
experience.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description
This PR checks for file changes when pushing in CE repo and passes if
the changes are present only in CE folder. To override the check,
developers can use --no-verify check when pushing the changes. This PR
is an extension of https://github.com/appsmithorg/appsmith/pull/32791
Fixes #`Issue Number`
_or_
Fixes `Issue URL`
> [!WARNING]
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._
## Automation
/ok-to-test tags=""
### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!CAUTION]
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Chores**
- Implemented a pre-push Git hook to check for specific file changes and
provide feedback before pushing to a remote repository.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description
1. Optimise `lint-staged` scripts so that they are not executed twice.
For some patterns, I removed the `prettier` checks since they are
executed by`eslint` checks as well.
2. Add caching for all scripts.
3. Optimisation of the `git secrets`, now we check only staged files.
Earlier we checked all the files that `git ls-files` returns. [Here more
about this.](https://github.com/awslabs/git-secrets#options-for-scan).
## Description
Fixes for running checks on pre-commit for BE and FE separately
#### Type of change
- Bug fix (non-breaking change which fixes an issue)
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
## Description
1. Update husky, prettier and lint-staged then move them to
devDependencies
2. Configure husky and lint-staged
3. Impriove rules for the lint commands
4. Fix errors of eslint and prettier.
5. Remove redundant files
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
