fix: Min width in certain ADS Button usage (#37624)
## Description 1. Remove height override in Workspace add button 2. Remove min width in Debugger trigger button Fixes #37623 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11953373643> > Commit: 9acd2b982c393841d472bb91576f997cd8a8df3a > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11953373643&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Thu, 21 Nov 2024 13:18:43 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced new styled components for enhanced workspace layout: `WorkspaceDropDown`, `WorkspaceSection`, and `ApplicationContainer`. - Added functionality for creating and managing workspaces, including a new button in the `LeftPaneSection`. - Enhanced application display logic based on Anvil feature status. - **Bug Fixes** - Improved error handling and state management for workspace and application fetching. - **Style** - Updated `DebuggerTrigger` to use a new styled button for improved design consistency. - Customized button appearance in the debugger with a new styled component. - **Documentation** - Enhanced overall component structure for better readability and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
This commit is contained in:
parent
0dac601979
commit
fd24aabbb3
|
|
@ -253,9 +253,6 @@ const LeftPaneDataSection = styled.div<{ isBannerVisible?: boolean }>`
|
||||||
height: calc(100vh - ${(props) => 48 + (props.isBannerVisible ? 48 : 0)}px);
|
height: calc(100vh - ${(props) => 48 + (props.isBannerVisible ? 48 : 0)}px);
|
||||||
display: flex;
|
display: flex;
|
||||||
flex-direction: column;
|
flex-direction: column;
|
||||||
button {
|
|
||||||
height: 34px !important;
|
|
||||||
}
|
|
||||||
`;
|
`;
|
||||||
|
|
||||||
// Tags for some reason take all available space.
|
// Tags for some reason take all available space.
|
||||||
|
|
|
||||||
|
|
@ -3,8 +3,9 @@ import { useDispatch, useSelector } from "react-redux";
|
||||||
import DebuggerTabs from "./DebuggerTabs";
|
import DebuggerTabs from "./DebuggerTabs";
|
||||||
import { setErrorCount } from "actions/debuggerActions";
|
import { setErrorCount } from "actions/debuggerActions";
|
||||||
import { getMessageCount, showDebuggerFlag } from "selectors/debuggerSelectors";
|
import { getMessageCount, showDebuggerFlag } from "selectors/debuggerSelectors";
|
||||||
import { Button, Tooltip } from "@appsmith/ads";
|
import { Tooltip } from "@appsmith/ads";
|
||||||
import useDebuggerTriggerClick from "./hooks/useDebuggerTriggerClick";
|
import useDebuggerTriggerClick from "./hooks/useDebuggerTriggerClick";
|
||||||
|
import * as Styled from "./styles";
|
||||||
|
|
||||||
function Debugger() {
|
function Debugger() {
|
||||||
// Debugger render flag
|
// Debugger render flag
|
||||||
|
|
@ -33,7 +34,7 @@ export function DebuggerTrigger() {
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Tooltip content={tooltipContent}>
|
<Tooltip content={tooltipContent}>
|
||||||
<Button
|
<Styled.DebuggerTriggerButton
|
||||||
className="t--debugger-count"
|
className="t--debugger-count"
|
||||||
kind={messageCounters.errors > 0 ? "error" : "tertiary"}
|
kind={messageCounters.errors > 0 ? "error" : "tertiary"}
|
||||||
onClick={onClick}
|
onClick={onClick}
|
||||||
|
|
@ -43,7 +44,7 @@ export function DebuggerTrigger() {
|
||||||
}
|
}
|
||||||
>
|
>
|
||||||
{messageCounters.errors > 99 ? "99+" : messageCounters.errors}
|
{messageCounters.errors > 99 ? "99+" : messageCounters.errors}
|
||||||
</Button>
|
</Styled.DebuggerTriggerButton>
|
||||||
</Tooltip>
|
</Tooltip>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -0,0 +1,10 @@
|
||||||
|
import { Button } from "@appsmith/ads";
|
||||||
|
import styled from "styled-components";
|
||||||
|
|
||||||
|
export const DebuggerTriggerButton = styled(Button)`
|
||||||
|
/* Override the min-width of the button for debugger trigger only */
|
||||||
|
|
||||||
|
.ads-v2-button__content {
|
||||||
|
min-width: unset;
|
||||||
|
}
|
||||||
|
`;
|
||||||
|
|
@ -65,11 +65,6 @@ const MainConfiguration = styled.div`
|
||||||
|
|
||||||
.api-info-row {
|
.api-info-row {
|
||||||
padding-top: var(--ads-v2-spaces-5);
|
padding-top: var(--ads-v2-spaces-5);
|
||||||
|
|
||||||
.ads-v2-select > .rc-select-selector {
|
|
||||||
min-width: 110px;
|
|
||||||
width: 110px;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
.form-row-header {
|
.form-row-header {
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue
Block a user