Merge branch 'release' of https://github.com/appsmithorg/appsmith into feat/reactive-actions-run-behaviour

This commit is contained in:
Ankita Kinger 2025-04-30 11:17:05 +05:30
commit fd159671af
5 changed files with 29 additions and 8 deletions

View File

@ -2,9 +2,21 @@
is_server_change=$(git diff --cached --name-only | grep -c "app/server") is_server_change=$(git diff --cached --name-only | grep -c "app/server")
is_client_change=$(git diff --cached --name-only | grep -c "app/client") is_client_change=$(git diff --cached --name-only | grep -c "app/client")
is_package_json_change=$(git diff --cached --name-only | grep -c "app/client/package.json")
is_merge_commit=$(git rev-parse -q --verify MERGE_HEAD) is_merge_commit=$(git rev-parse -q --verify MERGE_HEAD)
# Function to check TinyMCE version changes
check_tinymce_version() {
# Check if TinyMCE version is being changed
if git diff --cached app/client/package.json | grep -q '^-.*"tinymce": "6\.8\.3"' &&
git diff --cached app/client/package.json | grep -q '^+.*"tinymce": "[^"]*"'; then
echo "❌ Error: Attempting to change TinyMCE version. This is not allowed as per team decision."
echo "Please keep TinyMCE at version 6.8.3"
exit 1
fi
}
# Function to apply Spotless and only commit staged files # Function to apply Spotless and only commit staged files
apply_spotless_and_commit_staged_files() { apply_spotless_and_commit_staged_files() {
staged_server_files=$(git diff --cached --name-only | grep "app/server" | sed 's|app/server/||') staged_server_files=$(git diff --cached --name-only | grep "app/server" | sed 's|app/server/||')
@ -21,6 +33,11 @@ apply_spotless_and_commit_staged_files() {
if [ "$is_merge_commit" ]; then if [ "$is_merge_commit" ]; then
echo "Skipping server and client checks for merge commit" echo "Skipping server and client checks for merge commit"
else else
if [ "$is_package_json_change" -ge 1 ]; then
echo "Checking package.json changes..."
check_tinymce_version
fi
if [ "$is_server_change" -ge 1 ]; then if [ "$is_server_change" -ge 1 ]; then
echo "Applying Spotless to server files..." echo "Applying Spotless to server files..."
pushd app/server >/dev/null pushd app/server >/dev/null

View File

@ -43,6 +43,7 @@ describe(
propPane.EnterJSContext("Table data", JSON.stringify(testData)); propPane.EnterJSContext("Table data", JSON.stringify(testData));
propPane.TogglePropertyState("Server side pagination", "On");
propPane.TogglePropertyState("Infinite scroll", "On"); propPane.TogglePropertyState("Infinite scroll", "On");
}); });

View File

@ -48,6 +48,7 @@ describe(
it("1. should enable infinite scroll and verify records are loaded automatically when scrolling", () => { it("1. should enable infinite scroll and verify records are loaded automatically when scrolling", () => {
// Enable infinite scroll in the property pane // Enable infinite scroll in the property pane
propPane.TogglePropertyState("Server side pagination", "On");
propPane.TogglePropertyState("Infinite scroll", "On"); propPane.TogglePropertyState("Infinite scroll", "On");
// Wait for network call to complete // Wait for network call to complete

View File

@ -315,11 +315,11 @@ export class CommonLocators {
_fileUploadAddMore = ".uppy-DashboardContent-addMore"; _fileUploadAddMore = ".uppy-DashboardContent-addMore";
_buttonText = ".bp3-button-text"; _buttonText = ".bp3-button-text";
_richText_TitleBlock = "[aria-label='Block Paragraph']"; _richText_TitleBlock = "[aria-label='Block Paragraph']";
_richText_Heading = "[aria-label='Heading 1']"; _richText_Heading = "[title='Heading 1']";
_richText_Label_Text = ".tox-tbtn__select-label"; _richText_Label_Text = ".tox-tbtn__select-label";
_richText_Text_Color = (color: string) => _richText_Text_Color = (color: string) =>
`[aria-label="Text color ${color}"] .tox-split-button__chevron`; `[aria-label="Text color ${color}"] .tox-split-button__chevron`;
_richText_color = (value: string) => `[aria-label="${value}"]`; _richText_color = (value: string) => `[title="${value}"]`;
_richText_line = "#tinymce p span"; _richText_line = "#tinymce p span";
_treeSelectedContent = ".rc-tree-select-selection-item-content"; _treeSelectedContent = ".rc-tree-select-selection-item-content";
_switcherIcon = ".switcher-icon"; _switcherIcon = ".switcher-icon";

View File

@ -200,8 +200,10 @@ export default [
updateCellEditabilityOnInfiniteScrollChange, updateCellEditabilityOnInfiniteScrollChange,
updateSearchSortFilterOnInfiniteScrollChange, updateSearchSortFilterOnInfiniteScrollChange,
]), ]),
dependencies: ["primaryColumns"], dependencies: ["primaryColumns", "serverSidePaginationEnabled"],
hidden: () => !Widget.getFeatureFlag(INFINITE_SCROLL_ENABLED), hidden: (props: TableWidgetProps) =>
!Widget.getFeatureFlag(INFINITE_SCROLL_ENABLED) ||
!props.serverSidePaginationEnabled,
}, },
{ {
helpText: createMessage(TABLE_WIDGET_TOTAL_RECORD_TOOLTIP), helpText: createMessage(TABLE_WIDGET_TOTAL_RECORD_TOOLTIP),