From fc9d7486fa2c678bd041fd3b290c5db1435a1175 Mon Sep 17 00:00:00 2001 From: Dhruvik Neharia Date: Fri, 30 Dec 2022 16:11:46 +0530 Subject: [PATCH] fix: remove 'display: block' from span inside text widget (#19308) ## Description This PR prevents `span` HTML tags inside the text widget from breaking lines. More context here - https://theappsmith.slack.com/archives/C02JV8G1MP0/p1672230336770849 Fixes #19285 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual - ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --- app/client/src/widgets/TextWidget/component/index.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/app/client/src/widgets/TextWidget/component/index.tsx b/app/client/src/widgets/TextWidget/component/index.tsx index a79f111d1c..5e3a4a65aa 100644 --- a/app/client/src/widgets/TextWidget/component/index.tsx +++ b/app/client/src/widgets/TextWidget/component/index.tsx @@ -144,7 +144,6 @@ export const StyledText = styled(Text)<{ width: 100%; line-height: 1.2; white-space: pre-wrap; - display: block; text-align: ${(props) => props.textAlign.toLowerCase()}; } `;