Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix Modal widget overlay to cover top bar (#266)

Browse Source
This commit is contained in:
Hetu Nandu 2020-08-12 20:18:49 +05:30 committed by GitHub
parent 10f462b229
commit fbbe32c8f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
app/client/cypress/support/commands.js
View File

@ -629,22 +629,22 @@ Cypress.Commands.add("DeleteAPI", apiname => {
);
});
Cypress.Commands.add("CreateModal", () => {
cy.get(modalWidgetPage.selectModal).click();
cy.get(modalWidgetPage.createModalButton).click({ force: true });
cy.get(modalWidgetPage.controlModalType)
.find(".bp3-button")
.click({ force: true })
.get("ul.bp3-menu")
.children()
.contains("Alert Modal")
.click();
cy.get(modalWidgetPage.controlModalType)
.find(".bp3-button > .bp3-button-text")
.should("have.text", "Alert Modal");
cy.get(commonlocators.editPropCrossButton).click();
cy.reload();
});
// Cypress.Commands.add("CreateModal", () => {
// cy.get(modalWidgetPage.selectModal).click();
// cy.get(modalWidgetPage.createModalButton).click({ force: true });
// cy.get(modalWidgetPage.controlModalType)
// .find(".bp3-button")
// .click({ force: true })
// .get("ul.bp3-menu")
// .children()
// .contains("Alert Modal")
// .click();
// cy.get(modalWidgetPage.controlModalType)
// .find(".bp3-button > .bp3-button-text")
// .should("have.text", "Alert Modal");
// cy.get(commonlocators.editPropCrossButton).click();
// cy.reload();
// });
Cypress.Commands.add("createModal", (modalType, ModalName) => {
cy.get(widgetsPage.buttonOnClick)
@ -686,6 +686,7 @@ Cypress.Commands.add("createModal", (modalType, ModalName) => {
.contains("Center")
.click();
cy.assertPageSave();
cy.get(".bp3-overlay-backdrop").click({ force: true });
});
Cypress.Commands.add("CheckWidgetProperties", checkboxCss => {

2
app/client/src/components/designSystems/blueprint/ModalComponent.tsx
View File

@ -15,7 +15,7 @@ const Container = styled.div<{
z-index: ${props => props.zIndex || 2 - 1};
}
position: fixed;
top: ${props => props.theme.headerHeight};
top: 0;
right: 0;
bottom: 0;
height: 100vh;