Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: fix MsSQL JDBC URL format error (#25094)

Browse Source
This commit is contained in:
Sumit Kumar 2023-07-11 17:44:33 +05:30 committed by GitHub
parent 3cedd9251f
commit fb5600a54d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java vendored
View File

@ -541,14 +541,6 @@ public class MssqlPlugin extends BasePlugin {
.append(";"); .append(";");
} }
if (StringUtils.hasLength(authentication.getUsername())) {
urlBuilder.append("user=").append(authentication.getUsername()).append(";");
}
if (StringUtils.hasLength(authentication.getPassword())) {
urlBuilder.append("password=").append(authentication.getPassword()).append(";");
}
addSslOptionsToUrlBuilder(datasourceConfiguration, urlBuilder); addSslOptionsToUrlBuilder(datasourceConfiguration, urlBuilder);
hikariConfig.setJdbcUrl(urlBuilder.toString()); hikariConfig.setJdbcUrl(urlBuilder.toString());

2
app/server/appsmith-plugins/mssqlPlugin/src/test/java/com/external/plugins/MssqlTestDBContainerManager.java vendored
View File

@ -28,7 +28,7 @@ public class MssqlTestDBContainerManager {
.asCompatibleSubstituteFor("mcr.microsoft.com/mssql/server:2017-latest")) .asCompatibleSubstituteFor("mcr.microsoft.com/mssql/server:2017-latest"))
.acceptLicense() .acceptLicense()
.withExposedPorts(1433) .withExposedPorts(1433)
.withPassword("Mssql123"); .withPassword("Mssql12;3");
} }
static DatasourceConfiguration createDatasourceConfiguration(MSSQLServerContainer container) { static DatasourceConfiguration createDatasourceConfiguration(MSSQLServerContainer container) {