Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: Bindings on API and Query panes are not tracked via ENTITY_BINDING_SUCCESS (#22150)

Browse Source 
## Description
Bindings on API and Query panes are not tracked via
ENTITY_BINDING_SUCCESS

Fixes #22125 

## Type of change
- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?
- Manual

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [x] Added Test Plan Approved label after reveiwing all Cypress test
This commit is contained in:
Druthi Polisetty 2023-04-14 14:44:53 +05:30 committed by GitHub
parent 7c009218ef
commit f7eefec296
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
app/client/src/actions/evaluationActions.ts
View File

@ -33,12 +33,13 @@ export const LINT_REDUX_ACTIONS = {
[ReduxActionTypes.META_UPDATE_DEBOUNCED_EVAL]: true,
};
export const LOG_REDUX_ACTIONS = [
ReduxActionTypes.UPDATE_LAYOUT,
ReduxActionTypes.UPDATE_WIDGET_PROPERTY,
ReduxActionTypes.UPDATE_WIDGET_NAME_SUCCESS,
ReduxActionTypes.CREATE_ACTION_SUCCESS,
];
export const LOG_REDUX_ACTIONS = {
[ReduxActionTypes.UPDATE_LAYOUT]: true,
[ReduxActionTypes.UPDATE_WIDGET_PROPERTY]: true,
[ReduxActionTypes.UPDATE_WIDGET_NAME_SUCCESS]: true,
[ReduxActionTypes.CREATE_ACTION_SUCCESS]: true,
[ReduxActionTypes.UPDATE_ACTION_PROPERTY]: true,
};
export const EVALUATE_REDUX_ACTIONS = [
...FIRST_EVAL_REDUX_ACTIONS,
@ -129,7 +130,19 @@ export function shouldLint(action: ReduxAction<unknown>) {
}
export function shouldLog(action: ReduxAction<unknown>) {
return LOG_REDUX_ACTIONS.includes(action.type);
if (
action.type === ReduxActionTypes.BATCH_UPDATES_SUCCESS &&
Array.isArray(action.payload)
) {
const batchedActionTypes = action.payload.map(
(batchedAction) => batchedAction.type,
);
return batchedActionTypes.some(
(actionType) => LOG_REDUX_ACTIONS[actionType],
);
}
return LOG_REDUX_ACTIONS[action.type];
}
export const setEvaluatedTree = (