Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

ci: Fixing the page actions spec (#40328)

Browse Source 
## Description

Fixing the page actions spec that was failing after
[#40322](https://github.com/appsmithorg/appsmith/pull/40322) merge

Fixes #

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/14587020719>
> Commit: d46229ad5cef61fdfa1eaee3adc38d38faac2b3a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14587020719&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`
> Spec:
> <hr>Tue, 22 Apr 2025 05:28:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated test assertions to check the "data-subtle" attribute instead
of "data-disabled" when verifying the UI state of hidden pages.
  - Added a tag to the test suite for improved categorization.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Ankita Kinger 2025-04-22 11:35:14 +05:30 committed by GitHub
parent 5ace9ba414
commit f7e8aada2e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts
View File

@ -15,7 +15,7 @@ import {
import PageList from "../../../../support/Pages/PageList"; import PageList from "../../../../support/Pages/PageList";
import { EntityItems } from "../../../../support/Pages/AssertHelper"; import { EntityItems } from "../../../../support/Pages/AssertHelper";
describe("Check Page Actions Menu", {}, function () { describe("Check Page Actions Menu", { tags: ["@tag.IDE"] }, function () {
it("1. Verify Page Actions when a page is selected", function () { it("1. Verify Page Actions when a page is selected", function () {
homePage.RenameApplication("PageActions"); homePage.RenameApplication("PageActions");
PageList.AddNewPage("New blank page"); PageList.AddNewPage("New blank page");
@ -32,7 +32,7 @@ describe("Check Page Actions Menu", {}, function () {
PageList.ShowList(); PageList.ShowList();
agHelper.AssertAttribute( agHelper.AssertAttribute(
locators._entityTestId("NewPage Copy"), locators._entityTestId("NewPage Copy"),
"data-disabled", "data-subtle",
"true", "true",
); );
PageList.DeletePage("NewPage Copy"); PageList.DeletePage("NewPage Copy");
@ -93,7 +93,7 @@ describe("Check Page Actions Menu", {}, function () {
PageList.ShowList(); PageList.ShowList();
agHelper.AssertAttribute( agHelper.AssertAttribute(
locators._entityTestId("Page2 Copy"), locators._entityTestId("Page2 Copy"),
"data-disabled", "data-subtle",
"true", "true",
); );
PageList.DeletePage("Page2 Copy"); PageList.DeletePage("Page2 Copy");
@ -115,7 +115,7 @@ describe("Check Page Actions Menu", {}, function () {
PageList.ShowList(); PageList.ShowList();
agHelper.AssertAttribute( agHelper.AssertAttribute(
locators._entityTestId("HomePage Copy"), locators._entityTestId("HomePage Copy"),
"data-disabled", "data-subtle",
"true", "true",
); );
PageList.DeletePage("HomePage Copy"); PageList.DeletePage("HomePage Copy");