From f5e696a4f4eaca98e0f26fde4ac9a67a929e7cde Mon Sep 17 00:00:00 2001
From: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Date: Wed, 6 Jan 2021 09:38:18 +0530
Subject: [PATCH] Hide other header elements while showing the deploy button

---
 .../Smoke_TestSuite/Onboarding/Onboarding_spec.js   | 13 ++++++++++++-
 app/client/src/constants/OnboardingConstants.tsx    | 11 ++++++++++-
 app/client/src/pages/Editor/EditorHeader.tsx        |  4 ++--
 app/client/src/sagas/OnboardingSagas.ts             |  5 ++++-
 4 files changed, 28 insertions(+), 5 deletions(-)

diff --git a/app/client/cypress/integration/Smoke_TestSuite/Onboarding/Onboarding_spec.js b/app/client/cypress/integration/Smoke_TestSuite/Onboarding/Onboarding_spec.js
index 30e87049b7..7fdb5af7a7 100644
--- a/app/client/cypress/integration/Smoke_TestSuite/Onboarding/Onboarding_spec.js
+++ b/app/client/cypress/integration/Smoke_TestSuite/Onboarding/Onboarding_spec.js
@@ -56,7 +56,18 @@ describe("Onboarding", function() {
     cy.openPropertyPane("tablewidget");
     cy.closePropertyPane();
 
-    cy.PublishtheApp();
+    cy.get(".t--application-feedback-btn").should("not.be.visible");
+
+    // Publish
+    cy.window().then((window) => {
+      cy.stub(window, "open").callsFake((url) => {
+        window.location.href = Cypress.config().baseUrl + url.substring(1);
+        window.location.target = "_self";
+      });
+    });
+    cy.get(homePage.publishButton).click();
+    cy.wait("@publishApp");
+
     cy.get(".t--continue-on-my-own").click();
   });
 });
diff --git a/app/client/src/constants/OnboardingConstants.tsx b/app/client/src/constants/OnboardingConstants.tsx
index 74d898a8c1..82daf732a0 100644
--- a/app/client/src/constants/OnboardingConstants.tsx
+++ b/app/client/src/constants/OnboardingConstants.tsx
@@ -1,4 +1,3 @@
-import { setCurrentStep } from "actions/onboardingActions";
 import { ReduxAction, ReduxActionTypes } from "./ReduxActionConstants";
 import { EventName } from "../utils/AnalyticsUtil";
 
@@ -11,6 +10,7 @@ export enum OnboardingStep {
   ADD_WIDGET = 4,
   SUCCESSFUL_BINDING = 5,
   DEPLOY = 6,
+  FINISH = 7,
 }
 
 export type OnboardingTooltip = {
@@ -140,4 +140,13 @@ export const OnboardingConfig: Record<OnboardingStep, OnboardingStepConfig> = {
     },
     eventName: "ONBOARDING_DEPLOY",
   },
+  // Final step
+  [OnboardingStep.FINISH]: {
+    setup: () => {
+      return [];
+    },
+    tooltip: {
+      title: "",
+    },
+  },
 };
diff --git a/app/client/src/pages/Editor/EditorHeader.tsx b/app/client/src/pages/Editor/EditorHeader.tsx
index 1cd2e8348e..a410df8992 100644
--- a/app/client/src/pages/Editor/EditorHeader.tsx
+++ b/app/client/src/pages/Editor/EditorHeader.tsx
@@ -215,7 +215,7 @@ export const EditorHeader = (props: EditorHeaderProps) => {
           />
         </Link>
       </HeaderSection>
-      <Boxed step={OnboardingStep.DEPLOY}>
+      <Boxed step={OnboardingStep.FINISH}>
         <HeaderSection flex-direction={"row"}>
           {currentApplication ? (
             <EditableTextWrapper
@@ -244,7 +244,7 @@ export const EditorHeader = (props: EditorHeaderProps) => {
         </HeaderSection>
       </Boxed>
       <HeaderSection>
-        <Boxed step={OnboardingStep.DEPLOY}>
+        <Boxed step={OnboardingStep.FINISH}>
           <SaveStatusContainer className={"t--save-status-container"}>
             {saveStatusIcon}
           </SaveStatusContainer>
diff --git a/app/client/src/sagas/OnboardingSagas.ts b/app/client/src/sagas/OnboardingSagas.ts
index fe5396a5b3..3aae3689ce 100644
--- a/app/client/src/sagas/OnboardingSagas.ts
+++ b/app/client/src/sagas/OnboardingSagas.ts
@@ -118,7 +118,8 @@ function* listenForSuccessfullBinding() {
         const widgetProperties = dataTree[selectedWidget.widgetName];
         const dynamicBindingPathList =
           dataTree[selectedWidget.widgetName].dynamicBindingPathList;
-        const hasBinding = !!dynamicBindingPathList.length;
+        const hasBinding =
+          dynamicBindingPathList && !!dynamicBindingPathList.length;
 
         if (hasBinding) {
           yield put(showTooltip(OnboardingStep.NONE));
@@ -265,6 +266,8 @@ function* listenForDeploySaga() {
 
     yield take(ReduxActionTypes.PUBLISH_APPLICATION_SUCCESS);
     yield put(showTooltip(OnboardingStep.NONE));
+
+    yield put(setCurrentStep(OnboardingStep.FINISH));
     yield put({
       type: ReduxActionTypes.SHOW_ONBOARDING_COMPLETION_DIALOG,
       payload: true,