Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Hide other header elements while showing the deploy button

Browse Source
This commit is contained in:
akash-codemonk 2021-01-06 09:38:18 +05:30 committed by GitHub
parent de5003a98e
commit f5e696a4f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 28 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/client/cypress/integration/Smoke_TestSuite/Onboarding/Onboarding_spec.js
View File

@ -56,7 +56,18 @@ describe("Onboarding", function() {
cy.openPropertyPane("tablewidget");
cy.closePropertyPane();
cy.PublishtheApp();
cy.get(".t--application-feedback-btn").should("not.be.visible");
// Publish
cy.window().then((window) => {
cy.stub(window, "open").callsFake((url) => {
window.location.href = Cypress.config().baseUrl + url.substring(1);
window.location.target = "_self";
});
});
cy.get(homePage.publishButton).click();
cy.wait("@publishApp");
cy.get(".t--continue-on-my-own").click();
});
});

11
app/client/src/constants/OnboardingConstants.tsx
View File

@ -1,4 +1,3 @@
import { setCurrentStep } from "actions/onboardingActions";
import { ReduxAction, ReduxActionTypes } from "./ReduxActionConstants";
import { EventName } from "../utils/AnalyticsUtil";
@ -11,6 +10,7 @@ export enum OnboardingStep {
ADD_WIDGET = 4,
SUCCESSFUL_BINDING = 5,
DEPLOY = 6,
FINISH = 7,
}
export type OnboardingTooltip = {
@ -140,4 +140,13 @@ export const OnboardingConfig: Record<OnboardingStep, OnboardingStepConfig> = {
},
eventName: "ONBOARDING_DEPLOY",
},
// Final step
[OnboardingStep.FINISH]: {
setup: () => {
return [];
},
tooltip: {
title: "",
},
},
};

4
app/client/src/pages/Editor/EditorHeader.tsx
View File

@ -215,7 +215,7 @@ export const EditorHeader = (props: EditorHeaderProps) => {
/>
</Link>
</HeaderSection>
<Boxed step={OnboardingStep.DEPLOY}>
<Boxed step={OnboardingStep.FINISH}>
<HeaderSection flex-direction={"row"}>
{currentApplication ? (
<EditableTextWrapper
@ -244,7 +244,7 @@ export const EditorHeader = (props: EditorHeaderProps) => {
</HeaderSection>
</Boxed>
<HeaderSection>
<Boxed step={OnboardingStep.DEPLOY}>
<Boxed step={OnboardingStep.FINISH}>
<SaveStatusContainer className={"t--save-status-container"}>
{saveStatusIcon}
</SaveStatusContainer>

5
app/client/src/sagas/OnboardingSagas.ts
View File

@ -118,7 +118,8 @@ function* listenForSuccessfullBinding() {
const widgetProperties = dataTree[selectedWidget.widgetName];
const dynamicBindingPathList =
dataTree[selectedWidget.widgetName].dynamicBindingPathList;
const hasBinding = !!dynamicBindingPathList.length;
const hasBinding =
dynamicBindingPathList && !!dynamicBindingPathList.length;
if (hasBinding) {
yield put(showTooltip(OnboardingStep.NONE));
@ -265,6 +266,8 @@ function* listenForDeploySaga() {
yield take(ReduxActionTypes.PUBLISH_APPLICATION_SUCCESS);
yield put(showTooltip(OnboardingStep.NONE));
yield put(setCurrentStep(OnboardingStep.FINISH));
yield put({
type: ReduxActionTypes.SHOW_ONBOARDING_COMPLETION_DIALOG,
payload: true,