From f379f16bdd880788852c9799a48ca86d0ff7a430 Mon Sep 17 00:00:00 2001 From: Jacques Ikot Date: Mon, 30 Jun 2025 09:15:02 +0100 Subject: [PATCH] feat: exclude app.appsmith.com from recent domains tracking (#41059) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Adds filtering to exclude domains starting with "app." from the recent domains tracking functionality. ## Changes - Updated `isValidAppsmithDomain()` function to exclude domains that start with "app." - This prevents domains like `app.appsmith.com` from being tracked and stored in recent domains ## Automation /ok-to-test tags="@tag.Sanity" ### :mag: Cypress test results > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: b7f9bfa93b84592c5d2526410270799f5c44a9cd > Cypress dashboard. > Tags: `@tag.Sanity` > Spec: >
Mon, 30 Jun 2025 07:53:35 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No ## Summary by CodeRabbit * **Bug Fixes** * Improved domain validation to exclude domains starting with "app." from being recognized as valid Appsmith domains. --- app/client/src/utils/multiOrgDomains.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/app/client/src/utils/multiOrgDomains.ts b/app/client/src/utils/multiOrgDomains.ts index 82e271370d..05b671df60 100644 --- a/app/client/src/utils/multiOrgDomains.ts +++ b/app/client/src/utils/multiOrgDomains.ts @@ -16,6 +16,7 @@ function isValidAppsmithDomain(domain: string): boolean { domain.endsWith(".appsmith.com") && !domain.startsWith("login.") && !domain.startsWith("release.") && + !domain.startsWith("app.") && !domain.startsWith("dev.") ); }