Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #13570 from appsmithorg/feat/analytics-events-for-authentication-methods

Browse Source 
Chore: Functional breakdown for authentication analytics feature
This commit is contained in:
Vishnu Gp 2022-05-05 20:14:48 +05:30 committed by GitHub
commit f23077285b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/EnvManagerCEImpl.java
View File

@ -329,14 +329,7 @@ public class EnvManagerCEImpl implements EnvManagerCE {
Map<String, String> properties = new HashMap<>(){{ Map<String, String> properties = new HashMap<>(){{
put("provider", authEnv); put("provider", authEnv);
}}; }};
// Authentication configuration added properties = setAnalyticsEventAction(properties, changes.get(authEnv), originalVariables.get(authEnv), authEnv);
if (!changes.get(authEnv).isEmpty() && originalVariables.get(authEnv).isEmpty()) {
properties.put("action", "Added");
}
// Authentication configuration removed
else if (changes.get(authEnv).isEmpty() && !originalVariables.get(authEnv).isEmpty()) {
properties.put("action", "Removed");
}
if(properties.containsKey("action")){ if(properties.containsKey("action")){
analyticsEvents.add(properties); analyticsEvents.add(properties);
} }
@ -346,6 +339,27 @@ public class EnvManagerCEImpl implements EnvManagerCE {
return analyticsEvents; return analyticsEvents;
} }
/**
* Sets the correct action to analytics event properties template(s) according to the env variable changes
* @param properties
* @param newVariable Updated env variable value
* @param originalVariable Already existing env variable value
* @param authEnv Env variable name
* @return
*/
public Map<String, String> setAnalyticsEventAction(Map<String, String> properties, String newVariable, String originalVariable, String authEnv){
// Authentication configuration added
if (!newVariable.isEmpty() && originalVariable.isEmpty()) {
properties.put("action", "Added");
}
// Authentication configuration removed
else if (newVariable.isEmpty() && !originalVariable.isEmpty()) {
properties.put("action", "Removed");
}
return properties;
}
/** /**
* Adds or removes admin user policy from users. * Adds or removes admin user policy from users.
* If an email is removed from admin emails, it'll remove the policy from that user. * If an email is removed from admin emails, it'll remove the policy from that user.