Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: remove bindingPathList properties on jstoggle off.

Browse Source
This commit is contained in:
Arsalan 2022-03-25 15:25:01 +05:30
parent 4fb492ee60
commit f0de3c6457
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/client/src/sagas/WidgetOperationSagas.tsx
View File

@ -331,6 +331,7 @@ function* setWidgetDynamicPropertySaga(
const propertyValue = _.get(widget, propertyPath);
let dynamicPropertyPathList = getWidgetDynamicPropertyPathList(widget);
let dynamicBindingPathList = getEntityDynamicBindingPathList(widget);
if (isDynamic) {
const keyExists =
dynamicPropertyPathList.findIndex((path) => path.key === propertyPath) >
@ -345,6 +346,9 @@ function* setWidgetDynamicPropertySaga(
dynamicPropertyPathList = _.reject(dynamicPropertyPathList, {
key: propertyPath,
});
dynamicBindingPathList = _.reject(dynamicBindingPathList, {
key: propertyPath,
});
const { parsed } = yield call(
validateProperty,
propertyPath,
@ -354,7 +358,7 @@ function* setWidgetDynamicPropertySaga(
widget = set(widget, propertyPath, parsed);
}
widget.dynamicPropertyPathList = dynamicPropertyPathList;
widget.dynamicBindingPathList = dynamicBindingPathList;
const stateWidgets = yield select(getWidgets);
const widgets = { ...stateWidgets, [widgetId]: widget };

3
app/client/src/utils/helpers.tsx
View File

@ -642,6 +642,9 @@ export const captureInvalidDynamicBindingPath = (
* Checks if dynamicBindingPathList contains a property path that doesn't have a binding
*/
if (!isDynamicValue(pathValue)) {
alert(
`INVALID_DynamicPathBinding_CLIENT_ERROR: Invalid dynamic path binding list: ${currentDSL.widgetName}.${dBindingPath.key}`,
);
Sentry.captureException(
new Error(
`INVALID_DynamicPathBinding_CLIENT_ERROR: Invalid dynamic path binding list: ${currentDSL.widgetName}.${dBindingPath.key}`,