Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: refactor new page crud repo methods (#38169)

Browse Source 
## Description
As part of transaction support in PG, we are moving from using the jpa
methods for database operations. This PR is refactoring the code to use
custom repository class for NewPageRepository from the default
CrudRepository.

## Automation

/ok-to-test tags="@tag.ImportExport"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/12329409662>
> Commit: d8ff386a0c54ae00c4abc51ec6012e4c220bcba6
> Workflow: `PR Automation test suite`
> Tags: `@tag.ImportExport`
> Spec: ``
> <hr>Sat, 14 Dec 2024 11:17:37 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced methods to retrieve pages by application ID and count
non-deleted pages.
  
- **Bug Fixes**
- Removed outdated methods from the `NewPageRepositoryCE` interface to
streamline functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Anagh Hegde 2024-12-16 15:47:59 +05:30 committed by GitHub
parent e2916b205a
commit f08dd29300
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/CustomNewPageRepositoryCE.java
View File

@ -42,4 +42,8 @@ public interface CustomNewPageRepositoryCE extends AppsmithRepository<NewPage> {
Flux<NewPage> findAllByApplicationIdsWithoutPermission(List<String> applicationIds, List<String> includeFields);
Mono<Integer> updateDependencyMap(String pageId, Map<String, List<String>> dependencyMap);
Flux<NewPage> findByApplicationId(String applicationId);
Mono<Long> countByDeletedAtNull();
}

12
app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/CustomNewPageRepositoryCEImpl.java
View File

@ -261,4 +261,16 @@ public class CustomNewPageRepositoryCEImpl extends BaseAppsmithRepositoryImpl<Ne
update.set(NewPage.Fields.unpublishedPage_dependencyMap, dependencyMap);
return queryBuilder().criteria(q).updateFirst(update);
}
@Override
public Flux<NewPage> findByApplicationId(String applicationId) {
final BridgeQuery<NewPage> q = Bridge.equal(NewPage.Fields.applicationId, applicationId);
return queryBuilder().criteria(q).all();
}
@Override
public Mono<Long> countByDeletedAtNull() {
final BridgeQuery<NewPage> q = Bridge.notExists(NewPage.Fields.deletedAt);
return queryBuilder().criteria(q).count();
}
}

5
app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/NewPageRepositoryCE.java
View File

@ -5,15 +5,10 @@ import com.appsmith.server.projections.IdPoliciesOnly;
import com.appsmith.server.repositories.BaseRepository;
import com.appsmith.server.repositories.CustomNewPageRepository;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
import java.util.List;
public interface NewPageRepositoryCE extends BaseRepository<NewPage, String>, CustomNewPageRepository {
Flux<NewPage> findByApplicationId(String applicationId);
Mono<Long> countByDeletedAtNull();
Flux<IdPoliciesOnly> findIdsAndPolicyMapByApplicationIdIn(List<String> applicationIds);
}