From eec7b74c3506e852fdb887058f500acf23f84c83 Mon Sep 17 00:00:00 2001
From: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
Date: Wed, 28 Aug 2024 11:40:24 +0530
Subject: [PATCH] test: common code change for Workflow tests (#35886)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

/ok-to-test tags="@tag.All"



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10589609542>
> Commit: 27a55649d9f3cb398053fd68bfcecbbc96f6a694
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10589609542&attempt=3"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 28 Aug 2024 05:53:34 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced user interface functionality by ensuring the application
waits for the button spinner to disappear before proceeding with
visibility assertions and onboarding.

- **Improvements**
- Improved user experience by reducing potential inconsistencies or
errors during the onboarding process.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: NandanAnantharamu <nandan@normalyze.ai>
---
 app/client/cypress/support/Pages/HomePage.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/client/cypress/support/Pages/HomePage.ts b/app/client/cypress/support/Pages/HomePage.ts
index 0d7569aa63..b482db49d5 100644
--- a/app/client/cypress/support/Pages/HomePage.ts
+++ b/app/client/cypress/support/Pages/HomePage.ts
@@ -306,6 +306,7 @@ export class HomePage {
     this.agHelper.GetNClick(this._newButtonCreateApplication, 0, true);
     this.AssertApplicationCreated();
     if (skipSignposting) {
+      this.agHelper.WaitUntilEleDisappear(this.locator._btnSpinner);
       AppSidebar.assertVisible();
       this.agHelper.AssertElementVisibility(PageLeftPane.locators.selector);
       this.onboarding.skipSignposting();