From ede0df21bc272836415ea26fa90a445e8fb34fd6 Mon Sep 17 00:00:00 2001 From: Trisha Anand Date: Fri, 16 Jul 2021 20:24:18 +0530 Subject: [PATCH] Adding timeout on execution of postgres and ms sql actions (#5922) --- .../src/main/java/com/external/plugins/MssqlPlugin.java | 4 +++- .../src/main/java/com/external/plugins/PostgresPlugin.java | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java b/app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java index 6bb760376f..84942cf581 100644 --- a/app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java +++ b/app/server/appsmith-plugins/mssqlPlugin/src/main/java/com/external/plugins/MssqlPlugin.java @@ -14,8 +14,8 @@ import com.appsmith.external.models.DBAuth; import com.appsmith.external.models.DatasourceConfiguration; import com.appsmith.external.models.DatasourceTestResult; import com.appsmith.external.models.Endpoint; -import com.appsmith.external.models.PsParameterDTO; import com.appsmith.external.models.Property; +import com.appsmith.external.models.PsParameterDTO; import com.appsmith.external.models.RequestParamDTO; import com.appsmith.external.models.SSLDetails; import com.appsmith.external.plugins.BasePlugin; @@ -45,6 +45,7 @@ import java.sql.Statement; import java.sql.Time; import java.sql.Timestamp; import java.sql.Types; +import java.time.Duration; import java.time.LocalDateTime; import java.time.OffsetDateTime; import java.time.format.DateTimeFormatter; @@ -333,6 +334,7 @@ public class MssqlPlugin extends BasePlugin { result.setRequest(request); return result; }) + .timeout(Duration.ofMillis(actionConfiguration.getTimeoutInMillisecond())) .subscribeOn(scheduler); } diff --git a/app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java b/app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java index eb8ce46a95..2c999d4cf2 100644 --- a/app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java +++ b/app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java @@ -49,6 +49,7 @@ import java.sql.Statement; import java.sql.Time; import java.sql.Timestamp; import java.sql.Types; +import java.time.Duration; import java.time.LocalDateTime; import java.time.OffsetDateTime; import java.time.format.DateTimeFormatter; @@ -452,6 +453,7 @@ public class PostgresPlugin extends BasePlugin { result.setRequest(request); return result; }) + .timeout(Duration.ofMillis(actionConfiguration.getTimeoutInMillisecond())) .subscribeOn(scheduler); }