diff --git a/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js b/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js index 263c16e894..f08798d041 100644 --- a/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js +++ b/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js @@ -120,6 +120,7 @@ describe("Entity explorer tests related to query and datasource", function() { .click({ force: true }); cy.contains(".t--datasource-name", datasourceName).click(); cy.get(".t--delete-datasource").click(); + cy.get("[data-cy=t--confirm-modal-btn]").click(); cy.wait("@deleteDatasource").should( "have.nested.property", "response.body.responseMeta.status", diff --git a/app/client/cypress/integration/Smoke_TestSuite/ServerSideTests/ExplorerTests/Entity_Explorer_CopyQuery_RenameDatasource_spec.js b/app/client/cypress/integration/Smoke_TestSuite/ServerSideTests/ExplorerTests/Entity_Explorer_CopyQuery_RenameDatasource_spec.js index 1cbe239508..ac5a6e9b3d 100644 --- a/app/client/cypress/integration/Smoke_TestSuite/ServerSideTests/ExplorerTests/Entity_Explorer_CopyQuery_RenameDatasource_spec.js +++ b/app/client/cypress/integration/Smoke_TestSuite/ServerSideTests/ExplorerTests/Entity_Explorer_CopyQuery_RenameDatasource_spec.js @@ -94,6 +94,7 @@ describe("Entity explorer tests related to copy query", function() { cy.wait(2000); cy.hoverAndClick(); cy.get(apiwidget.delete).click({ force: true }); + cy.get("[data-cy=t--confirm-modal-btn]").click(); //This is check to make sure if a datasource is active 409 cy.wait("@deleteDatasource").should( "have.nested.property", diff --git a/app/client/cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js b/app/client/cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js index 599ed9c69f..e87565b250 100644 --- a/app/client/cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js +++ b/app/client/cypress/integration/Smoke_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.js @@ -196,6 +196,7 @@ describe("Create a query with a mongo datasource, run, save and then delete the cy.NavigateToActiveTab(); cy.contains(".t--datasource-name", datasourceName).click(); cy.get(".t--delete-datasource").click(); + cy.get("[data-cy=t--confirm-modal-btn]").click(); cy.wait("@deleteDatasource").should( "have.nested.property", "response.body.responseMeta.status", @@ -288,6 +289,7 @@ describe("Create a query with a mongo datasource, run, save and then delete the cy.NavigateToActiveTab(); cy.contains(".t--datasource-name", datasourceName).click(); cy.get(".t--delete-datasource").click(); + cy.get("[data-cy=t--confirm-modal-btn]").click(); // cy.wait("@deleteDatasource").should( // "have.nested.property", // "response.body.responseMeta.status", diff --git a/app/client/cypress/support/commands.js b/app/client/cypress/support/commands.js index e36b59efd5..d4405b5139 100644 --- a/app/client/cypress/support/commands.js +++ b/app/client/cypress/support/commands.js @@ -2186,6 +2186,7 @@ Cypress.Commands.add("testSaveDeleteDatasource", () => { .click(); // delete datasource cy.get(".t--delete-datasource").click(); + cy.get("[data-cy=t--confirm-modal-btn]").click(); cy.wait("@deleteDatasource").should( "have.nested.property", "response.body.responseMeta.status", @@ -2504,6 +2505,7 @@ Cypress.Commands.add("deleteDatasource", (datasourceName) => { .click({ force: true }); cy.contains(".t--datasource-name", datasourceName).click(); cy.get(".t--delete-datasource").click(); + cy.get("[data-cy=t--confirm-modal-btn]").click(); cy.wait("@deleteDatasource").should( "have.nested.property", "response.body.responseMeta.status", @@ -2581,6 +2583,7 @@ Cypress.Commands.add("deleteJSObject", () => { Cypress.Commands.add("deleteDataSource", () => { cy.hoverAndClick(); cy.get(apiwidget.delete).click({ force: true }); + cy.get("[data-cy=t--confirm-modal-btn]").click(); cy.wait("@deleteDatasource").should( "have.nested.property", "response.body.responseMeta.status", diff --git a/app/client/src/actions/pluginActionActions.ts b/app/client/src/actions/pluginActionActions.ts index 5744efb6dc..fc3adebcc6 100644 --- a/app/client/src/actions/pluginActionActions.ts +++ b/app/client/src/actions/pluginActionActions.ts @@ -89,22 +89,22 @@ export const runAction = (id: string, paginationField?: PaginationField) => { }; }; -export const showRunActionConfirmModal = (show: boolean) => { +export const showActionConfirmationModal = (show: boolean) => { return { - type: ReduxActionTypes.SHOW_RUN_ACTION_CONFIRM_MODAL, + type: ReduxActionTypes.SHOW_ACTION_MODAL, payload: show, }; }; -export const cancelRunActionConfirmModal = () => { +export const cancelActionConfirmationModal = () => { return { - type: ReduxActionTypes.CANCEL_RUN_ACTION_CONFIRM_MODAL, + type: ReduxActionTypes.CANCEL_ACTION_MODAL, }; }; -export const acceptRunActionConfirmModal = () => { +export const acceptActionConfirmationModal = () => { return { - type: ReduxActionTypes.ACCEPT_RUN_ACTION_CONFIRM_MODAL, + type: ReduxActionTypes.CONFIRM_ACTION_MODAL, }; }; diff --git a/app/client/src/constants/ReduxActionConstants.tsx b/app/client/src/constants/ReduxActionConstants.tsx index ec9f438666..34b2429448 100644 --- a/app/client/src/constants/ReduxActionConstants.tsx +++ b/app/client/src/constants/ReduxActionConstants.tsx @@ -260,9 +260,9 @@ export const ReduxActionTypes = { DELETE_ACTION_INIT: "DELETE_ACTION_INIT", SET_DATASOURCE_EDITOR_MODE: "SET_DATASOURCE_EDITOR_MODE", DELETE_ACTION_SUCCESS: "DELETE_ACTION_SUCCESS", - SHOW_RUN_ACTION_CONFIRM_MODAL: "SHOW_RUN_ACTION_CONFIRM_MODAL", - CANCEL_RUN_ACTION_CONFIRM_MODAL: "CANCEL_RUN_ACTION_CONFIRM_MODAL", - ACCEPT_RUN_ACTION_CONFIRM_MODAL: "ACCEPT_RUN_ACTION_CONFIRM_MODAL", + SHOW_ACTION_MODAL: "SHOW_ACTION_MODAL", + CANCEL_ACTION_MODAL: "CANCEL_ACTION_MODAL", + CONFIRM_ACTION_MODAL: "CONFIRM_ACTION_MODAL", CREATE_QUERY_INIT: "CREATE_QUERY_INIT", ONBOARDING_CREATE_APPLICATION: "ONBOARDING_CREATE_APPLICATION", FETCH_DATASOURCES_INIT: "FETCH_DATASOURCES_INIT", @@ -295,6 +295,7 @@ export const ReduxActionTypes = { HISTORY_PUSH: "HISTORY_PUSH", DELETE_DATASOURCE_INIT: "DELETE_DATASOURCE_INIT", DELETE_DATASOURCE_SUCCESS: "DELETE_DATASOURCE_SUCCESS", + DELETE_DATASOURCE_CANCELLED: "DELETE_DATASOURCE_CANCELLED", STORE_AS_DATASOURCE_INIT: "STORE_AS_DATASOURCE_INIT", STORE_AS_DATASOURCE_UPDATE: "STORE_AS_DATASOURCE_UPDATE", STORE_AS_DATASOURCE_COMPLETE: "STORE_AS_DATASOURCE_COMPLETE", diff --git a/app/client/src/pages/AppViewer/AppViewerPageContainer.tsx b/app/client/src/pages/AppViewer/AppViewerPageContainer.tsx index 333cc1c2d1..487b642b9d 100644 --- a/app/client/src/pages/AppViewer/AppViewerPageContainer.tsx +++ b/app/client/src/pages/AppViewer/AppViewerPageContainer.tsx @@ -14,7 +14,7 @@ import { getCurrentApplicationId, getCurrentPageName, } from "selectors/editorSelectors"; -import ConfirmRunModal from "pages/Editor/ConfirmRunModal"; +import RequestConfirmationModal from "pages/Editor/RequestConfirmationModal"; import { getCurrentApplication } from "selectors/applicationSelectors"; import { isPermitted, @@ -110,7 +110,7 @@ class AppViewerPageContainer extends Component { pageId={this.props.match.params.pageId} pageName={this.props.currentPageName} /> - + ); } diff --git a/app/client/src/pages/Editor/APIEditor/ApiRightPane.tsx b/app/client/src/pages/Editor/APIEditor/ApiRightPane.tsx index 4a03d2ef0f..0392b5fc62 100644 --- a/app/client/src/pages/Editor/APIEditor/ApiRightPane.tsx +++ b/app/client/src/pages/Editor/APIEditor/ApiRightPane.tsx @@ -128,7 +128,8 @@ const SelectedDatasourceInfoContainer = styled.div` align-items: center; padding: 2px 8px; background-color: ${Colors.LIGHT_GREEN_CYAN}; - margin-right: 5px; + margin-right: 2px; + margin-left: 3px; text-transform: uppercase; & p { font-style: normal; @@ -141,6 +142,7 @@ const SelectedDatasourceInfoContainer = styled.div` letter-spacing: 0.4px; text-transform: uppercase; color: ${Colors.GREEN}; + white-space: nowrap; } `; diff --git a/app/client/src/pages/Editor/ConfirmRunModal.tsx b/app/client/src/pages/Editor/RequestConfirmationModal.tsx similarity index 81% rename from app/client/src/pages/Editor/ConfirmRunModal.tsx rename to app/client/src/pages/Editor/RequestConfirmationModal.tsx index b370b25855..9748853ac4 100644 --- a/app/client/src/pages/Editor/ConfirmRunModal.tsx +++ b/app/client/src/pages/Editor/RequestConfirmationModal.tsx @@ -3,9 +3,9 @@ import { connect } from "react-redux"; import { AppState } from "reducers"; import { Keys } from "@blueprintjs/core"; import { - showRunActionConfirmModal, - cancelRunActionConfirmModal, - acceptRunActionConfirmModal, + showActionConfirmationModal, + cancelActionConfirmationModal, + acceptActionConfirmationModal, } from "actions/pluginActionActions"; import DialogComponent from "components/ads/DialogComponent"; import styled from "styled-components"; @@ -33,7 +33,7 @@ const ModalFooter = styled.div` } `; -class ConfirmRunModal extends React.Component { +class RequestConfirmationModal extends React.Component { addEventListener = () => { document.addEventListener("keydown", this.onKeyUp); }; @@ -50,14 +50,14 @@ class ConfirmRunModal extends React.Component { onConfirm = () => { const { dispatch } = this.props; - dispatch(acceptRunActionConfirmModal()); + dispatch(acceptActionConfirmationModal()); this.handleClose(); }; handleClose = () => { const { dispatch } = this.props; - dispatch(showRunActionConfirmModal(false)); - dispatch(cancelRunActionConfirmModal()); + dispatch(showActionConfirmationModal(false)); + dispatch(cancelActionConfirmationModal()); }; componentDidUpdate() { @@ -85,8 +85,9 @@ class ConfirmRunModal extends React.Component {