feat: remove release_paid_features_tagging feature flag (#41123)
## Summary This PR removes the `release_paid_features_tagging` feature flag and enables premium tagging for paid datasource features by default. ## Changes Made ### Files Modified - `app/client/src/ce/entities/FeatureFlag.ts` - Removed feature flag definition - `app/client/src/pages/Editor/DataSidePane/DataSidePane.tsx` - Removed feature flag usage ### Detailed Changes 1. **Removed feature flag definition**: - Removed `release_paid_features_tagging` from `FEATURE_FLAG` object - Removed corresponding default value from `DEFAULT_FEATURE_FLAG_VALUE` 2. **Updated DataSidePane component**: - Removed `useFeatureFlag(FEATURE_FLAG.release_paid_features_tagging)` hook - Removed conditional check `if (!isPaidFeaturesTaggingEnabled) return false;` - Updated `shouldShowPremiumTag` function to always evaluate premium tag logic - Cleaned up dependency array in useMemo ## Impact - Premium tags for paid datasource features will now be **always visible** when applicable - Removes the feature flag gating mechanism that was previously controlling this behavior - Simplifies the codebase by removing conditional logic around premium tagging ## Automation /ok-to-test tags="@tag.Sanity, @tag.IDE, @tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/16435603085> > Commit: 2db1a7337cb167f87f10de1a8e9a7513303427a5 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=16435603085&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity, @tag.IDE, @tag.Datasource` > Spec: > <hr>Tue, 22 Jul 2025 06:41:49 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Removed the feature flag for paid features tagging and all related logic from the application. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
parent
11a5a963d2
commit
e8ce322877
|
|
@ -64,7 +64,6 @@ export const FEATURE_FLAG = {
|
||||||
"release_jsobjects_onpageunloadactions_enabled",
|
"release_jsobjects_onpageunloadactions_enabled",
|
||||||
configure_block_event_tracking_for_anonymous_users:
|
configure_block_event_tracking_for_anonymous_users:
|
||||||
"configure_block_event_tracking_for_anonymous_users",
|
"configure_block_event_tracking_for_anonymous_users",
|
||||||
release_paid_features_tagging: "release_paid_features_tagging",
|
|
||||||
} as const;
|
} as const;
|
||||||
|
|
||||||
export type FeatureFlag = keyof typeof FEATURE_FLAG;
|
export type FeatureFlag = keyof typeof FEATURE_FLAG;
|
||||||
|
|
@ -117,7 +116,6 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = {
|
||||||
license_ai_agent_instance_enabled: false,
|
license_ai_agent_instance_enabled: false,
|
||||||
release_jsobjects_onpageunloadactions_enabled: false,
|
release_jsobjects_onpageunloadactions_enabled: false,
|
||||||
configure_block_event_tracking_for_anonymous_users: false,
|
configure_block_event_tracking_for_anonymous_users: false,
|
||||||
release_paid_features_tagging: false,
|
|
||||||
};
|
};
|
||||||
|
|
||||||
export const AB_TESTING_EVENT_KEYS = {
|
export const AB_TESTING_EVENT_KEYS = {
|
||||||
|
|
|
||||||
|
|
@ -83,9 +83,6 @@ export const DataSidePane = (props: DataSidePaneProps) => {
|
||||||
);
|
);
|
||||||
|
|
||||||
const isFeatureEnabled = useFeatureFlag(FEATURE_FLAG.license_gac_enabled);
|
const isFeatureEnabled = useFeatureFlag(FEATURE_FLAG.license_gac_enabled);
|
||||||
const isPaidFeaturesTaggingEnabled = useFeatureFlag(
|
|
||||||
FEATURE_FLAG.release_paid_features_tagging,
|
|
||||||
);
|
|
||||||
|
|
||||||
const canCreateDatasource = getHasCreateDatasourcePermission(
|
const canCreateDatasource = getHasCreateDatasourcePermission(
|
||||||
isFeatureEnabled,
|
isFeatureEnabled,
|
||||||
|
|
@ -113,8 +110,6 @@ export const DataSidePane = (props: DataSidePaneProps) => {
|
||||||
|
|
||||||
const shouldShowPremiumTag = useCallback(
|
const shouldShowPremiumTag = useCallback(
|
||||||
(datasource: Datasource) => {
|
(datasource: Datasource) => {
|
||||||
if (!isPaidFeaturesTaggingEnabled) return false;
|
|
||||||
|
|
||||||
const plugin = plugins.find((p) => p.id === datasource.pluginId);
|
const plugin = plugins.find((p) => p.id === datasource.pluginId);
|
||||||
|
|
||||||
if (!plugin) return false;
|
if (!plugin) return false;
|
||||||
|
|
@ -128,7 +123,7 @@ export const DataSidePane = (props: DataSidePaneProps) => {
|
||||||
|
|
||||||
return false;
|
return false;
|
||||||
},
|
},
|
||||||
[plugins, isIntegrationsEnabledForPaid, isPaidFeaturesTaggingEnabled],
|
[plugins, isIntegrationsEnabledForPaid],
|
||||||
);
|
);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue
Block a user