From e805fca60bb4e4f734cbe1fb03466d114b9f9c5c Mon Sep 17 00:00:00 2001 From: Rudraprasad Das Date: Wed, 9 Apr 2025 12:14:51 +0200 Subject: [PATCH] chore: fixes issue with disabled branch button (#40163) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description - Users with "developer" access to an app were finding the branch switch button disabled - The issue is occurring due to a bug in the autocommit flow. This PR fixes it Fixes https://github.com/appsmithorg/appsmith/issues/40162 ## Automation /ok-to-test tags="@tag.Git" ### :mag: Cypress test results > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: 5803065bc71df9f9c36aa7a14fdac9ed94e7d0f5 > Cypress dashboard. > Tags: `@tag.Git` > Spec: >
Tue, 08 Apr 2025 16:13:18 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No ## Summary by CodeRabbit - **Refactor** - Improved the autocommit process by enhancing the success-handling logic with additional context details. This change refines how commit actions are processed, ensuring more precise state updates during the commit workflow while preserving the existing functional flow. These modifications help significantly streamline internal operations without affecting the overall seamless user experience. --- app/client/src/git/sagas/triggerAutocommitSaga.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/client/src/git/sagas/triggerAutocommitSaga.ts b/app/client/src/git/sagas/triggerAutocommitSaga.ts index a2f00ea1de..72f88d66ac 100644 --- a/app/client/src/git/sagas/triggerAutocommitSaga.ts +++ b/app/client/src/git/sagas/triggerAutocommitSaga.ts @@ -1,4 +1,3 @@ -import { triggerAutocommitSuccessAction } from "actions/gitSyncActions"; import { AutocommitStatusState } from "git/constants/enums"; import fetchAutocommitProgressRequest from "git/requests/fetchAutocommitProgressRequest"; import type { @@ -151,6 +150,6 @@ export default function* triggerAutocommitSaga( yield take(gitArtifactActions.pollAutocommitProgressStop.type); yield cancel(pollTask); } else { - yield put(triggerAutocommitSuccessAction()); + yield put(gitArtifactActions.triggerAutocommitSuccess({ artifactDef })); } }