From e74664c32e981e1d235d2fe475c26a841bb761ac Mon Sep 17 00:00:00 2001 From: Subhrashis Das Date: Wed, 26 Feb 2025 13:36:32 +0530 Subject: [PATCH] fix: Add default RTS port in CE (#39444) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### :mag: Cypress test results > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: > Commit: 0c3ee991f26237589d2119a0048045552690c3c2 > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` > Spec: `` >
Wed, 26 Feb 2025 07:33:40 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No ## Summary by CodeRabbit - **Chores** - Updated the application’s default real-time service port configuration. The system now directly uses a default value of 8091 when no explicit port is provided, ensuring consistent connectivity behavior and reducing potential configuration ambiguities. Users relying on default settings will benefit from improved reliability. --- .../java/com/appsmith/server/helpers/ce/RTSCallerCEImpl.java | 5 ----- .../src/main/resources/application-ce.properties | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/RTSCallerCEImpl.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/RTSCallerCEImpl.java index 812d54be31..1e0210f06b 100644 --- a/app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/RTSCallerCEImpl.java +++ b/app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/ce/RTSCallerCEImpl.java @@ -22,7 +22,6 @@ import java.util.Map; import static com.appsmith.server.filters.MDCFilter.INTERNAL_REQUEST_ID_HEADER; import static com.appsmith.server.filters.MDCFilter.REQUEST_ID_HEADER; -import static org.apache.commons.lang3.StringUtils.isEmpty; @Component public class RTSCallerCEImpl implements RTSCallerCE { @@ -42,10 +41,6 @@ public class RTSCallerCEImpl implements RTSCallerCE { @PostConstruct private void makeWebClient() { - if (isEmpty(rtsPort)) { - rtsPort = "8091"; - } - final ConnectionProvider connectionProvider = ConnectionProvider.builder("rts-provider") .maxConnections(100) .maxIdleTime(Duration.ofSeconds(30)) diff --git a/app/server/appsmith-server/src/main/resources/application-ce.properties b/app/server/appsmith-server/src/main/resources/application-ce.properties index 712eed456c..829965bfbd 100644 --- a/app/server/appsmith-server/src/main/resources/application-ce.properties +++ b/app/server/appsmith-server/src/main/resources/application-ce.properties @@ -100,7 +100,7 @@ appsmith.plugin.response.size.max=${APPSMITH_PLUGIN_MAX_RESPONSE_SIZE_MB:5} appsmith.admin.envfile=${APPSMITH_ENVFILE_PATH:/appsmith-stacks/configuration/docker.env} # RTS port -appsmith.rts.port=${APPSMITH_RTS_PORT:} +appsmith.rts.port=${APPSMITH_RTS_PORT:8091} appsmith.internal.password=${APPSMITH_INTERNAL_PASSWORD:}