From e6b85465a6c01573a5c8c4cd550db0d3f54cc6ff Mon Sep 17 00:00:00 2001 From: Nikhil Nandagopal Date: Mon, 4 Nov 2019 19:47:48 +0530 Subject: [PATCH] added shallow equal --- app/client/package.json | 1 + app/client/src/widgets/BaseWidget.tsx | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/client/package.json b/app/client/package.json index 6e211dec35..9c675df972 100644 --- a/app/client/package.json +++ b/app/client/package.json @@ -67,6 +67,7 @@ "redux-form": "^8.2.6", "redux-saga": "^1.0.0", "reselect": "^4.0.0", + "shallowequal": "^1.1.0", "styled-components": "^4.1.3", "ts-loader": "^6.0.4", "typescript": "^3.6.3" diff --git a/app/client/src/widgets/BaseWidget.tsx b/app/client/src/widgets/BaseWidget.tsx index 28cb1b8ac7..23ca52bdb3 100644 --- a/app/client/src/widgets/BaseWidget.tsx +++ b/app/client/src/widgets/BaseWidget.tsx @@ -16,6 +16,7 @@ import DraggableComponent from "../components/editorComponents/DraggableComponen import ResizableComponent from "../components/editorComponents/ResizableComponent"; import { ActionPayload } from "../constants/ActionConstants"; import { WidgetFunctionsContext } from "../pages/Editor/WidgetsEditor"; +import shallowequal from "shallowequal"; abstract class BaseWidget< T extends WidgetProps, @@ -120,7 +121,8 @@ abstract class BaseWidget< shouldComponentUpdate(nextProps: WidgetProps, nextState: WidgetState) { const isNotEqual = - !_.isEqual(this.props, nextProps) || !_.isEqual(this.state, nextState); + !shallowequal(nextProps, this.props) || + !shallowequal(nextState, this.state); return isNotEqual; }