From dfc0983ed47dded7216208a32b5e7ea536e9075e Mon Sep 17 00:00:00 2001
From: balajisoundar <balaji@appsmith.com>
Date: Thu, 9 Mar 2023 10:18:23 +0530
Subject: [PATCH] chore: [lazy canvas rendering] check whether observer exist
 before disconnecting while cleaning up (#21171)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes #20558

Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video


## Type of change

> Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update


## How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Provide
instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.
> Delete anything that is not important

- Manual
- Jest
- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---
 app/client/src/widgets/withLazyRender.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/client/src/widgets/withLazyRender.tsx b/app/client/src/widgets/withLazyRender.tsx
index a1e099cee6..3fb04a2513 100644
--- a/app/client/src/widgets/withLazyRender.tsx
+++ b/app/client/src/widgets/withLazyRender.tsx
@@ -55,7 +55,7 @@ export function withLazyRender(Widget: typeof BaseWidget) {
 
       return () => {
         (window as any).cancelIdleCallback(idleCallbackId);
-        observer.disconnect();
+        observer && observer.disconnect();
       };
     }, []);