From df6dce26e9cebcd3e48297070bad2a4e998c3220 Mon Sep 17 00:00:00 2001
From: Shrikant Sharat Kandula <shrikant@appsmith.com>
Date: Wed, 7 Feb 2024 15:43:26 +0530
Subject: [PATCH] chore: remove BaseDomain on WorkspacePlugin (#30958)

The `WorkspacePlugin` is not a top-level entity. Yet, it extends
`BaseDomain`. It gets all the fields from `BaseDomain`, but since it
doesn't have a collection of its own, nothing is ever used.

This is fine today, with the `@Document` annotation, but with Postgres,
with `@Entity` annotation, querydsl is getting confused and is creating
a `QWorkspacePlugin` class, which is producing a compile error in
`QWorkspace.plugins` field.

This PR removes this unneeded inheritance.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
	- Updated the structure of the Workspace Plugin to enhance performance.
- **Bug Fixes**
- Ensured all plugins, including previously inaccessible ones, are now
correctly retrievable.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 .../main/java/com/appsmith/server/domains/WorkspacePlugin.java | 3 +--
 .../com/appsmith/server/plugins/base/PluginServiceCEImpl.java  | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/domains/WorkspacePlugin.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/domains/WorkspacePlugin.java
index 1ed5e33738..2b8f82ccf3 100644
--- a/app/server/appsmith-server/src/main/java/com/appsmith/server/domains/WorkspacePlugin.java
+++ b/app/server/appsmith-server/src/main/java/com/appsmith/server/domains/WorkspacePlugin.java
@@ -1,6 +1,5 @@
 package com.appsmith.server.domains;
 
-import com.appsmith.external.models.BaseDomain;
 import com.appsmith.server.dtos.WorkspacePluginStatus;
 import lombok.AllArgsConstructor;
 import lombok.EqualsAndHashCode;
@@ -15,7 +14,7 @@ import lombok.ToString;
 @NoArgsConstructor
 @AllArgsConstructor
 @EqualsAndHashCode(callSuper = false)
-public class WorkspacePlugin extends BaseDomain {
+public class WorkspacePlugin {
 
     String pluginId;
 
diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/plugins/base/PluginServiceCEImpl.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/plugins/base/PluginServiceCEImpl.java
index e9bc03e801..eb11aea0e1 100644
--- a/app/server/appsmith-server/src/main/java/com/appsmith/server/plugins/base/PluginServiceCEImpl.java
+++ b/app/server/appsmith-server/src/main/java/com/appsmith/server/plugins/base/PluginServiceCEImpl.java
@@ -134,7 +134,6 @@ public class PluginServiceCEImpl extends BaseService<PluginRepository, Plugin, S
                     }
 
                     List<String> pluginIds = org.getPlugins().stream()
-                            .filter(plugin -> !plugin.isDeleted())
                             .map(WorkspacePlugin::getPluginId)
                             .collect(Collectors.toList());
                     Query query = new Query();