chore: Remove archiveById in BaseService
This is used in two/three services only, so isn't being reused a lot by being in `BaseService`.
This commit is contained in:
parent
07ea23daf1
commit
deb39ac3b5
|
|
@ -70,6 +70,8 @@ public interface ActionCollectionServiceCE extends CrudService<ActionCollection,
|
|||
|
||||
Flux<ActionCollection> findByPageIdsForExport(List<String> pageIds, AclPermission permission);
|
||||
|
||||
Mono<ActionCollection> archiveById(String id);
|
||||
|
||||
Mono<ActionCollection> findByBranchNameAndDefaultCollectionId(
|
||||
String branchName, String defaultCollectionId, AclPermission permission);
|
||||
|
||||
|
|
|
|||
|
|
@ -81,11 +81,6 @@ public abstract class BaseService<
|
|||
analyticsService.sendCreateEvent(savedResource, getAnalyticsProperties(savedResource)));
|
||||
}
|
||||
|
||||
@Override
|
||||
public Mono<T> archiveById(ID id) {
|
||||
return Mono.error(new AppsmithException(AppsmithError.UNSUPPORTED_OPERATION));
|
||||
}
|
||||
|
||||
/**
|
||||
* This function runs the validation checks on the object and returns a Mono.error if any of the constraints
|
||||
* have been violated. If all checks pass, a Mono of the object is returned back to the caller
|
||||
|
|
|
|||
|
|
@ -22,8 +22,6 @@ public interface CrudService<T extends BaseDomain, ID> {
|
|||
return this.getById(id);
|
||||
}
|
||||
|
||||
Mono<T> archiveById(ID id);
|
||||
|
||||
Map<String, Object> getAnalyticsProperties(T savedResource);
|
||||
|
||||
Flux<T> filterByEntityFieldsWithoutPublicAccess(
|
||||
|
|
|
|||
|
|
@ -15,6 +15,8 @@ public interface ThemeServiceCE extends CrudService<Theme, String> {
|
|||
|
||||
Flux<Theme> getSystemThemes();
|
||||
|
||||
Mono<Theme> archiveById(String themeId);
|
||||
|
||||
Mono<Theme> getSystemTheme(String themeName);
|
||||
|
||||
Mono<Theme> updateTheme(String applicationId, String branchName, Theme resource);
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user