From dcf425af7e1ce6e05b45360117cbe47d5a07dd43 Mon Sep 17 00:00:00 2001 From: Shrikant Sharat Kandula Date: Fri, 30 Apr 2021 16:37:33 +0530 Subject: [PATCH] Fix RTS build and push workflow (#4246) * Update build.sh * Fix invalid build-arg argument to docker build --- .github/workflows/build-rts.yml | 6 +++--- app/rts/build.sh | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-rts.yml b/.github/workflows/build-rts.yml index 6b7804e27a..a273c50c63 100644 --- a/.github/workflows/build-rts.yml +++ b/.github/workflows/build-rts.yml @@ -64,7 +64,7 @@ jobs: - name: Push release image to Docker Hub if: success() && github.ref == 'refs/heads/release' run: | - docker build --build-arg -t ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-rts:${{steps.vars.outputs.tag}} . + docker build -t ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-rts:${{steps.vars.outputs.tag}} . echo ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin #docker push ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-rts:${{steps.vars.outputs.tag}} @@ -72,8 +72,8 @@ jobs: - name: Push master image to Docker Hub with commit tag if: success() && github.ref == 'refs/heads/master' run: | - docker build --build-arg -t ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-rts:${GITHUB_SHA} . - docker build --build-arg -t ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-rts:nightly . + docker build -t ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-rts:${GITHUB_SHA} . + docker build -t ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-rts:nightly . echo ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin #docker push ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-rts:${GITHUB_SHA} #docker push ${{ secrets.DOCKER_HUB_ORGANIZATION }}/appsmith-rts:nightly diff --git a/app/rts/build.sh b/app/rts/build.sh index b39f22ffcd..e39103bca0 100755 --- a/app/rts/build.sh +++ b/app/rts/build.sh @@ -3,4 +3,5 @@ set -o errexit cd "$(dirname "$0")" +yarn install --frozen-lockfile npx tsc