Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

ci: Add server failed tests as PR comment (#30888)

Browse Source 
And, don't show duplicates. Not sure why we're seeing duplicates though.
This commit is contained in:
Shrikant Sharat Kandula 2024-02-06 16:07:43 +05:30 committed by GitHub
parent 1afd321e13
commit dbe138778a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
.github/workflows/server-build.yml vendored
View File

@ -183,11 +183,16 @@ jobs:
args+=("-DtestResultFile=$PWD/failed-server-tests.txt") args+=("-DtestResultFile=$PWD/failed-server-tests.txt")
if ! mvn test "${args[@]}"; then if ! mvn test "${args[@]}"; then
if [[ -s failed-server-tests.txt ]]; then if [[ -s failed-server-tests.txt ]]; then
{ content="$(
echo "## Failed tests" echo "## Failed server tests"
echo echo
sed 's/^/- /' 'failed-server-tests.txt' sed 's/^/- /' 'failed-server-tests.txt'
} >> "$GITHUB_STEP_SUMMARY" )"
echo "$content" >> "$GITHUB_STEP_SUMMARY"
# Add a comment to the PR with the list of failed tests.
curl --header "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
--data "$(jq -n --arg body "$content" '$ARGS.named')" \
"https://api.github.com/repos/$GITHUB_REPOSITORY/issues/${{ inputs.pr }}/comments"
fi fi
exit 1 exit 1
fi fi

6
app/server/appsmith-server/src/test/java/com/appsmith/server/TestResultLoggerExtension.java
View File

@ -6,8 +6,8 @@ import org.junit.jupiter.api.extension.TestWatcher;
import java.io.FileWriter; import java.io.FileWriter;
import java.io.IOException; import java.io.IOException;
import java.util.ArrayList; import java.util.Collection;
import java.util.List; import java.util.TreeSet;
/** /**
* The TestWatcher interface is used to react to the execution of tests. * The TestWatcher interface is used to react to the execution of tests.
@ -20,7 +20,7 @@ import java.util.List;
*/ */
public class TestResultLoggerExtension implements TestWatcher, AfterAllCallback { public class TestResultLoggerExtension implements TestWatcher, AfterAllCallback {
private final List<String> failedTests = new ArrayList<>(); private final Collection<String> failedTests = new TreeSet<>();
/** /**
* This method is called after all the tests are run. It writes the failed tests to a file. * This method is called after all the tests are run. It writes the failed tests to a file.