Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: Button variant validation (#7699)

Browse Source 
* fix: Button variant validation

* fix: MenuVariant validation

* Add default value to buttonVariant

* Adds default value to MenuVariant
This commit is contained in:
Aswath K 2021-09-27 12:00:04 +05:30 committed by GitHub
parent 60131403b2
commit d9fa049578
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/client/src/widgets/ButtonWidget/widget/index.tsx
View File

@ -12,6 +12,7 @@ import {
ButtonBorderRadius, ButtonBorderRadius,
ButtonBorderRadiusTypes, ButtonBorderRadiusTypes,
ButtonVariant, ButtonVariant,
ButtonVariantTypes,
} from "components/constants"; } from "components/constants";
class ButtonWidget extends BaseWidget<ButtonWidgetProps, ButtonWidgetState> { class ButtonWidget extends BaseWidget<ButtonWidgetProps, ButtonWidgetState> {
@ -147,12 +148,13 @@ class ButtonWidget extends BaseWidget<ButtonWidgetProps, ButtonWidgetState> {
}, },
], ],
isJSConvertible: true, isJSConvertible: true,
isBindProperty: false, isBindProperty: true,
isTriggerProperty: false, isTriggerProperty: false,
validation: { validation: {
type: ValidationTypes.TEXT, type: ValidationTypes.TEXT,
params: { params: {
allowedVAlues: ["SOLID", "OUTLINE", "GHOST"], default: ButtonVariantTypes.SOLID,
allowedValues: ["SOLID", "OUTLINE", "GHOST"],
}, },
}, },
}, },

6
app/client/src/widgets/MenuButtonWidget/widget/index.tsx
View File

@ -9,6 +9,7 @@ import {
ButtonBorderRadius, ButtonBorderRadius,
ButtonBoxShadow, ButtonBoxShadow,
ButtonVariant, ButtonVariant,
ButtonVariantTypes,
} from "components/constants"; } from "components/constants";
import { IconName } from "@blueprintjs/icons"; import { IconName } from "@blueprintjs/icons";
export interface MenuButtonWidgetProps extends WidgetProps { export interface MenuButtonWidgetProps extends WidgetProps {
@ -245,12 +246,13 @@ class MenuButtonWidget extends BaseWidget<MenuButtonWidgetProps, WidgetState> {
}, },
], ],
isJSConvertible: true, isJSConvertible: true,
isBindProperty: false, isBindProperty: true,
isTriggerProperty: false, isTriggerProperty: false,
validation: { validation: {
type: ValidationTypes.TEXT, type: ValidationTypes.TEXT,
params: { params: {
allowedVAlues: ["SOLID", "OUTLINE", "GHOST"], default: ButtonVariantTypes.SOLID,
allowedValues: ["SOLID", "OUTLINE", "GHOST"],
}, },
}, },
}, },