fix: IDE texts and alignements bugs (#28783)
## Description This PR fixes, 1. ‘Drag and drop a widget’ not required to show when settings pane is open. 2. Overlap of the libraries popover is seen over the left pane 3. Data Pane : Change the text workplace to workspace. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/28782 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
This commit is contained in:
parent
74b3ec6db2
commit
d7a061935f
|
|
@ -2206,7 +2206,7 @@ export const EMPTY_TABLE_SVG_ALT_TEXT = () => "Empty table image";
|
|||
|
||||
export const DATA_PANE_TITLE = () => "Datasources in your Workspace";
|
||||
export const DATASOURCE_LIST_BLANK_TITLE = () =>
|
||||
"No datasources exist in your workplace.";
|
||||
"No datasources exist in your workspace.";
|
||||
export const DATASOURCE_BLANK_STATE_MESSAGE = () =>
|
||||
"You need a datasource connection to write your first query";
|
||||
|
||||
|
|
|
|||
|
|
@ -49,6 +49,8 @@ import DragLayerComponent from "./DragLayerComponent";
|
|||
import StarterBuildingBlocks from "./starterBuildingBlocks";
|
||||
import { useFeatureFlag } from "utils/hooks/useFeatureFlag";
|
||||
import { FEATURE_FLAG } from "@appsmith/entities/FeatureFlag";
|
||||
import useCurrentAppState from "pages/Editor/IDE/hooks";
|
||||
import { AppState as IDEAppState } from "entities/IDE/constants";
|
||||
|
||||
export type DropTargetComponentProps = PropsWithChildren<{
|
||||
snapColumnSpace: number;
|
||||
|
|
@ -75,6 +77,7 @@ const StyledDropTarget = styled.div`
|
|||
function Onboarding() {
|
||||
const [isUsersFirstApp, setIsUsersFirstApp] = useState(false);
|
||||
const isMobileCanvas = useSelector(getIsMobileCanvasLayout);
|
||||
const appState = useCurrentAppState();
|
||||
const user = useSelector(getCurrentUser);
|
||||
const showStarterTemplatesInsteadofBlankCanvas = useFeatureFlag(
|
||||
FEATURE_FLAG.ab_show_templates_instead_of_blank_canvas_enabled,
|
||||
|
|
@ -100,13 +103,15 @@ function Onboarding() {
|
|||
})();
|
||||
}, [user, currentApplicationId]);
|
||||
|
||||
return shouldShowStarterTemplates ? (
|
||||
<StarterBuildingBlocks />
|
||||
) : (
|
||||
<h2 className="absolute top-0 left-0 right-0 flex items-end h-108 justify-center text-2xl font-bold text-gray-300">
|
||||
Drag and drop a widget here
|
||||
</h2>
|
||||
);
|
||||
if (shouldShowStarterTemplates && appState === IDEAppState.PAGES)
|
||||
return <StarterBuildingBlocks />;
|
||||
else if (!shouldShowStarterTemplates && appState === IDEAppState.PAGES)
|
||||
return (
|
||||
<h2 className="absolute top-0 left-0 right-0 flex items-end h-108 justify-center text-2xl font-bold text-gray-300">
|
||||
Drag and drop a widget here
|
||||
</h2>
|
||||
);
|
||||
else return null;
|
||||
}
|
||||
|
||||
/*
|
||||
|
|
|
|||
|
|
@ -26,7 +26,13 @@ const AddLibraryPopover = () => {
|
|||
startIcon="add-line"
|
||||
/>
|
||||
</PopoverTrigger>
|
||||
<PopoverContent align="start" className="z-[25]" side="left" size="md">
|
||||
<PopoverContent
|
||||
align="start"
|
||||
className="z-[25]"
|
||||
side="left"
|
||||
sideOffset={16}
|
||||
size="md"
|
||||
>
|
||||
<PopoverHeader className="sticky top-0" isClosable>
|
||||
{createMessage(customJSLibraryMessages.ADD_JS_LIBRARY)}
|
||||
</PopoverHeader>
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user