Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: Fix the issue for the reverse PR comment (#36308)

Browse Source 
## Description
Fix the issue as flag value was interchange.


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.ImportExport"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10846876122>
> Commit: aa17588ae04bf60d668512b262e9e742814d3ffc
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10846876122&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.ImportExport`
> Spec:
> <hr>Fri, 13 Sep 2024 10:01:50 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Adjusted the logic for adding comments on pull requests based on CI
test results, improving clarity of feedback.
- Enhanced conditions for commenting on new CI failures and successful
jobs to provide more accurate notifications.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Sagar Khalasi 2024-09-13 15:56:02 +05:30 committed by GitHub
parent eb0311aa8e
commit d6a1500fa8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.github/workflows/build-client-server-count.yml vendored
View File

@ -292,7 +292,7 @@ jobs:
fi fi
- name: Add a comment on the PR with new CI failures - name: Add a comment on the PR with new CI failures
if: env.ci_test_failed == 'true' && needs.file-check.outputs.pr != '0' if: env.ci_test_failed != 'true' && needs.file-check.outputs.pr != '0'
uses: peter-evans/create-or-update-comment@v3 uses: peter-evans/create-or-update-comment@v3
with: with:
issue-number: ${{fromJson(needs.file-check.outputs.pr)}} issue-number: ${{fromJson(needs.file-check.outputs.pr)}}
@ -306,7 +306,7 @@ jobs:
``` ```
- name: Add a comment on the PR when ci-test-limited is successful - name: Add a comment on the PR when ci-test-limited is successful
if: env.ci_test_failed != 'true' && needs.file-check.outputs.pr != '0' if: env.ci_test_failed == 'true' && needs.file-check.outputs.pr != '0'
uses: peter-evans/create-or-update-comment@v3 uses: peter-evans/create-or-update-comment@v3
with: with:
issue-number: ${{fromJson(needs.file-check.outputs.pr)}} issue-number: ${{fromJson(needs.file-check.outputs.pr)}}
@ -451,7 +451,7 @@ jobs:
fi fi
- name: Add a comment on the PR with new CI failures - name: Add a comment on the PR with new CI failures
if: env.ci_test_failed == 'true' && needs.file-check.outputs.pr != '0' if: env.ci_test_failed != 'true' && needs.file-check.outputs.pr != '0'
uses: peter-evans/create-or-update-comment@v3 uses: peter-evans/create-or-update-comment@v3
with: with:
issue-number: ${{fromJson(needs.file-check.outputs.pr)}} issue-number: ${{fromJson(needs.file-check.outputs.pr)}}
@ -465,7 +465,7 @@ jobs:
``` ```
- name: Add a comment on the PR when ci-test-limited-existing-docker-image is success - name: Add a comment on the PR when ci-test-limited-existing-docker-image is success
if: env.ci_test_failed != 'true' && needs.file-check.outputs.pr != '0' if: env.ci_test_failed == 'true' && needs.file-check.outputs.pr != '0'
uses: peter-evans/create-or-update-comment@v3 uses: peter-evans/create-or-update-comment@v3
with: with:
issue-number: ${{fromJson(needs.file-check.outputs.pr)}} issue-number: ${{fromJson(needs.file-check.outputs.pr)}}