From d5ee82db85ff4fbf1601c343682e91c110a7db90 Mon Sep 17 00:00:00 2001 From: Nidhi Date: Thu, 13 Mar 2025 10:26:07 +0530 Subject: [PATCH] chore: Missed adding argument for cookie init (#39704) ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### :mag: Cypress test results > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --- .../configurations/ce/CustomCookieWebSessionIdResolverCE.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/configurations/ce/CustomCookieWebSessionIdResolverCE.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/configurations/ce/CustomCookieWebSessionIdResolverCE.java index 481a94d50b..181661507a 100644 --- a/app/server/appsmith-server/src/main/java/com/appsmith/server/configurations/ce/CustomCookieWebSessionIdResolverCE.java +++ b/app/server/appsmith-server/src/main/java/com/appsmith/server/configurations/ce/CustomCookieWebSessionIdResolverCE.java @@ -27,11 +27,11 @@ public class CustomCookieWebSessionIdResolverCE extends CookieWebSessionIdResolv @Override public void setSessionId(ServerWebExchange exchange, String id) { - addCookieInitializers(); + addCookieInitializers(exchange); super.setSessionId(exchange, id); } - protected void addCookieInitializers() { + protected void addCookieInitializers(ServerWebExchange exchange) { // Add the appropriate SameSite attribute based on the exchange attribute addCookieInitializer((builder) -> builder.sameSite(LAX).secure(true)); }